From ec51d21818183d174f275d093ad5232dbdd7bed3 Mon Sep 17 00:00:00 2001 From: "Walter A. Boring IV" Date: Wed, 2 Sep 2015 02:20:32 +0000 Subject: [PATCH] DotHill driver fix create_cloned_volume parent id This patch changes how the Dothill driver finds the parent volume id during create_cloned_volume time. The proper place to get it is from the source volume dict/object being passed in. Change-Id: I7623b31d850701fe7c85eff59085197a2cd73352 Closes-Bug: 1491207 --- cinder/volume/drivers/dothill/dothill_common.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cinder/volume/drivers/dothill/dothill_common.py b/cinder/volume/drivers/dothill/dothill_common.py index 96b098e70..6325f1f6f 100644 --- a/cinder/volume/drivers/dothill/dothill_common.py +++ b/cinder/volume/drivers/dothill/dothill_common.py @@ -210,13 +210,13 @@ class DotHillCommon(object): self._assert_enough_space_for_copy(volume['size']) self._assert_source_detached(src_vref) LOG.debug("Cloning Volume %(source_id)s to (%(dest_id)s)", - {'source_id': volume['source_volid'], + {'source_id': src_vref['id'], 'dest_id': volume['id'], }) if src_vref['name_id']: orig_name = self._get_vol_name(src_vref['name_id']) else: - orig_name = self._get_vol_name(volume['source_volid']) + orig_name = self._get_vol_name(src_vref['id']) dest_name = self._get_vol_name(volume['id']) self.client_login() @@ -225,7 +225,7 @@ class DotHillCommon(object): self.backend_name, self.backend_type) except exception.DotHillRequestError as ex: LOG.exception(_LE("Cloning of volume %s failed."), - volume['source_volid']) + src_vref['id']) raise exception.Invalid(ex) finally: self.client_logout() -- 2.45.2