From e7651e2ada2b15bb57596e1190e1f936e6360459 Mon Sep 17 00:00:00 2001 From: Ihar Hrachyshka Date: Tue, 22 Apr 2014 15:26:44 +0200 Subject: [PATCH] Use list copy for events in nova notifier There is no need to call range() and len() and .pop() for such a simple task as list copy. Change-Id: I4d25e0887ba0a7a5c7f49d195e90a7d2818caac2 --- neutron/notifiers/nova.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/neutron/notifiers/nova.py b/neutron/notifiers/nova.py index 1237a16b7..482bdce52 100644 --- a/neutron/notifiers/nova.py +++ b/neutron/notifiers/nova.py @@ -211,13 +211,12 @@ class Notifier(object): port._notify_event = None def send_events(self): - batched_events = [] - for event in range(len(self.pending_events)): - batched_events.append(self.pending_events.pop()) - - if not batched_events: + if not self.pending_events: return + batched_events = self.pending_events + self.pending_events = [] + LOG.debug(_("Sending events: %s"), batched_events) try: response = self.nclient.server_external_events.create( -- 2.45.2