From e3492286ca247c2f910d073044dd2b9c5387d150 Mon Sep 17 00:00:00 2001 From: Angus Lees Date: Mon, 22 Dec 2014 14:52:42 +1100 Subject: [PATCH] ml2: remove superfluous %s in LOG.debug() format ml2.db.get_dynamic_segment() includes this line: LOG.debug("No dynamic segment %s found for " "Network:%(network_id)s, " "Physical network:%(physnet)s, " "segmentation_id:%(segmentation_id)s", {'network_id': network_id, 'physnet': physical_network, 'segmentation_id': segmentation_id}) Note the superfluous %s in the format string. At run-time, %s prints the args hash again and doesn't cause an error, but this is clearly unintended. Since there doesn't seem to be any value that was meant to be used instead, this change simply removes the %s. Change-Id: I414c7b4497f59927d8b6ec5f057dca19aa4ef122 Closes-Bug: #1404782 --- neutron/plugins/ml2/db.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/neutron/plugins/ml2/db.py b/neutron/plugins/ml2/db.py index f3cfe0f5a..1cf2b18e4 100644 --- a/neutron/plugins/ml2/db.py +++ b/neutron/plugins/ml2/db.py @@ -103,7 +103,7 @@ def get_dynamic_segment(session, network_id, physical_network=None, if record: return _make_segment_dict(record) else: - LOG.debug("No dynamic segment %s found for " + LOG.debug("No dynamic segment found for " "Network:%(network_id)s, " "Physical network:%(physnet)s, " "segmentation_id:%(segmentation_id)s", -- 2.45.2