From cf4c885c20fb46672a758a6ec94e61346fa317cc Mon Sep 17 00:00:00 2001 From: John Griffith Date: Tue, 12 May 2015 15:48:03 -0600 Subject: [PATCH] Fix overwrite of params in SF image cache update In the update cache volume routine of the SolidFire driver we're unintentionally re-initializing the params variable when assigning volID as opposed to just appending another key to it. This patch fixes that. Change-Id: I213776ee6aef6e5dee2807c19b7eea05af23d6c0 Closes-Bug: #1454425 --- cinder/volume/drivers/solidfire.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cinder/volume/drivers/solidfire.py b/cinder/volume/drivers/solidfire.py index 9f6e2fd15..3accf8866 100644 --- a/cinder/volume/drivers/solidfire.py +++ b/cinder/volume/drivers/solidfire.py @@ -608,7 +608,7 @@ class SolidFireDriver(san.SanISCSIDriver): else: # Bummer, it's been updated, delete it params = {'accountID': sfaccount['accountID']} - params = {'volumeID': sf_vol['volumeID']} + params['volumeID'] = sf_vol['volumeID'] data = self._issue_api_request('DeleteVolume', params) if 'result' not in data: msg = _("Failed to delete SolidFire Image-Volume: %s") % data -- 2.45.2