From c660173edcc137c53bad6194183188bcac3552a1 Mon Sep 17 00:00:00 2001 From: Ihar Hrachyshka Date: Sun, 2 Aug 2015 22:40:40 +0200 Subject: [PATCH] Cleaned up some TODO comments for feature/qos that do not apply anymore 1. Removed comment to add tests for invalid input for attach/detach methods for QosPolicy. Those tests are already implemented in the test class, so the TODO became obsolete. 2. Removed TODO to use a constant for rule 'type' field. There is no 'type' field in rules anymore, so it does not apply any more. Change-Id: I205cbc2d9a2eeee1a0a9fb5794efc063de6f326d Partially-Implements: blueprint quantum-qos-api --- neutron/tests/tempest/services/network/json/network_client.py | 1 - neutron/tests/unit/objects/qos/test_policy.py | 1 - 2 files changed, 2 deletions(-) diff --git a/neutron/tests/tempest/services/network/json/network_client.py b/neutron/tests/tempest/services/network/json/network_client.py index c01c83c70..daf563f21 100644 --- a/neutron/tests/tempest/services/network/json/network_client.py +++ b/neutron/tests/tempest/services/network/json/network_client.py @@ -656,7 +656,6 @@ class NetworkClientJSON(service_client.ServiceClient): def create_bandwidth_limit_rule(self, policy_id, max_kbps, max_burst_kbps): uri = '%s/qos/policies/%s/bandwidth_limit_rules' % ( self.uri_prefix, policy_id) - #TODO(QoS): 'bandwidth_limit' should not be a magic string. post_data = self.serialize( {'bandwidth_limit_rule': { 'max_kbps': max_kbps, diff --git a/neutron/tests/unit/objects/qos/test_policy.py b/neutron/tests/unit/objects/qos/test_policy.py index 20807c904..3eede4f5f 100644 --- a/neutron/tests/unit/objects/qos/test_policy.py +++ b/neutron/tests/unit/objects/qos/test_policy.py @@ -124,7 +124,6 @@ class QosPolicyDbObjectTestCase(test_base.BaseDbObjectTestCase, 'device_id': 'fake_device', 'device_owner': 'fake_owner'}) - #TODO(QoS): give a thought on checking detach/attach for invalid values. def test_attach_network_get_network_policy(self): obj = self._create_test_policy() -- 2.45.2