From af5d4b323597e3654b4e41af5ee19f5fe395ae35 Mon Sep 17 00:00:00 2001 From: Monty Taylor Date: Mon, 11 Feb 2013 13:57:27 -0600 Subject: [PATCH] Use nose and openstack nose plugin. It's a little silly since we're working on removing nose for testr, but it turns out that the old test run wrapper was in use here, which was causing all sorts of havoc. Change-Id: Ib6e31547ec4921f91b6253a1798cb04ca6930c87 --- cinder/testing/__init__.py | 0 cinder/testing/fake/__init__.py | 1 - cinder/testing/runner.py | 371 -------------------------------- cinder/tests/__init__.py | 3 + cinder/tests/test_test.py | 2 + run_tests.sh | 17 +- tox.ini | 28 +-- 7 files changed, 18 insertions(+), 404 deletions(-) delete mode 100644 cinder/testing/__init__.py delete mode 100644 cinder/testing/fake/__init__.py delete mode 100755 cinder/testing/runner.py diff --git a/cinder/testing/__init__.py b/cinder/testing/__init__.py deleted file mode 100644 index e69de29bb..000000000 diff --git a/cinder/testing/fake/__init__.py b/cinder/testing/fake/__init__.py deleted file mode 100644 index 5cdad4717..000000000 --- a/cinder/testing/fake/__init__.py +++ /dev/null @@ -1 +0,0 @@ -import rabbit diff --git a/cinder/testing/runner.py b/cinder/testing/runner.py deleted file mode 100755 index c6658d951..000000000 --- a/cinder/testing/runner.py +++ /dev/null @@ -1,371 +0,0 @@ -#!/usr/bin/env python -# vim: tabstop=4 shiftwidth=4 softtabstop=4 - -# Copyright 2010 United States Government as represented by the -# Administrator of the National Aeronautics and Space Administration. -# All Rights Reserved. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -# Colorizer Code is borrowed from Twisted: -# Copyright (c) 2001-2010 Twisted Matrix Laboratories. -# -# Permission is hereby granted, free of charge, to any person obtaining -# a copy of this software and associated documentation files (the -# "Software"), to deal in the Software without restriction, including -# without limitation the rights to use, copy, modify, merge, publish, -# distribute, sublicense, and/or sell copies of the Software, and to -# permit persons to whom the Software is furnished to do so, subject to -# the following conditions: -# -# The above copyright notice and this permission notice shall be -# included in all copies or substantial portions of the Software. -# -# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, -# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF -# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND -# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE -# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION -# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION -# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. -"""Unittest runner for Cinder. - -To run all tests - python cinder/testing/runner.py - -To run a single test module: - python cinder/testing/runner.py test_compute - - or - - python cinder/testing/runner.py api.test_wsgi - -To run a single test: - python cinder/testing/runner.py - test_compute:ComputeTestCase.test_run_terminate - -""" - -import gettext -import heapq -import os -import sys -import time -import unittest - -import eventlet -from nose import config -from nose import core -from nose import result - -gettext.install('cinder', unicode=1) -reldir = os.path.join(os.path.dirname(__file__), '..', '..') -absdir = os.path.abspath(reldir) -sys.path.insert(0, absdir) - -from cinder.openstack.common import log as logging - - -class _AnsiColorizer(object): - """ - A colorizer is an object that loosely wraps around a stream, allowing - callers to write text to the stream in a particular color. - - Colorizer classes must implement C{supported()} and C{write(text, color)}. - """ - _colors = dict(black=30, red=31, green=32, yellow=33, - blue=34, magenta=35, cyan=36, white=37) - - def __init__(self, stream): - self.stream = stream - - def supported(cls, stream=sys.stdout): - """ - A class method that returns True if the current platform supports - coloring terminal output using this method. Returns False otherwise. - """ - if not stream.isatty(): - return False # auto color only on TTYs - try: - import curses - except ImportError: - return False - else: - try: - try: - return curses.tigetnum("colors") > 2 - except curses.error: - curses.setupterm() - return curses.tigetnum("colors") > 2 - except Exception: - raise - # guess false in case of error - return False - supported = classmethod(supported) - - def write(self, text, color): - """ - Write the given text to the stream in the given color. - - @param text: Text to be written to the stream. - - @param color: A string label for a color. e.g. 'red', 'white'. - """ - color = self._colors[color] - self.stream.write('\x1b[%s;1m%s\x1b[0m' % (color, text)) - - -class _Win32Colorizer(object): - """ - See _AnsiColorizer docstring. - """ - def __init__(self, stream): - import win32console as win - red, green, blue, bold = (win.FOREGROUND_RED, - win.FOREGROUND_GREEN, - win.FOREGROUND_BLUE, - win.FOREGROUND_INTENSITY) - self.stream = stream - self.screenBuffer = win.GetStdHandle(win.STD_OUT_HANDLE) - self._colors = { - 'normal': red | green | blue, - 'red': red | bold, - 'green': green | bold, - 'blue': blue | bold, - 'yellow': red | green | bold, - 'magenta': red | blue | bold, - 'cyan': green | blue | bold, - 'white': red | green | blue | bold} - - def supported(cls, stream=sys.stdout): - try: - import win32console - screenBuffer = win32console.GetStdHandle( - win32console.STD_OUT_HANDLE) - except ImportError: - return False - import pywintypes - try: - screenBuffer.SetConsoleTextAttribute( - win32console.FOREGROUND_RED | - win32console.FOREGROUND_GREEN | - win32console.FOREGROUND_BLUE) - except pywintypes.error: - return False - else: - return True - supported = classmethod(supported) - - def write(self, text, color): - color = self._colors[color] - self.screenBuffer.SetConsoleTextAttribute(color) - self.stream.write(text) - self.screenBuffer.SetConsoleTextAttribute(self._colors['normal']) - - -class _NullColorizer(object): - """ - See _AnsiColorizer docstring. - """ - def __init__(self, stream): - self.stream = stream - - def supported(cls, stream=sys.stdout): - return True - supported = classmethod(supported) - - def write(self, text, color): - self.stream.write(text) - - -def get_elapsed_time_color(elapsed_time): - if elapsed_time > 1.0: - return 'red' - elif elapsed_time > 0.25: - return 'yellow' - else: - return 'green' - - -class CinderTestResult(result.TextTestResult): - def __init__(self, *args, **kw): - self.show_elapsed = kw.pop('show_elapsed') - result.TextTestResult.__init__(self, *args, **kw) - self.num_slow_tests = 5 - self.slow_tests = [] # this is a fixed-sized heap - self._last_case = None - self.colorizer = None - # NOTE(vish): reset stdout for the terminal check - stdout = sys.stdout - sys.stdout = sys.__stdout__ - for colorizer in [_Win32Colorizer, _AnsiColorizer, _NullColorizer]: - if colorizer.supported(): - self.colorizer = colorizer(self.stream) - break - sys.stdout = stdout - - # NOTE(lorinh): Initialize start_time in case a sqlalchemy-migrate - # error results in it failing to be initialized later. Otherwise, - # _handleElapsedTime will fail, causing the wrong error message to - # be outputted. - self.start_time = time.time() - - def getDescription(self, test): - return str(test) - - def _handleElapsedTime(self, test): - self.elapsed_time = time.time() - self.start_time - item = (self.elapsed_time, test) - # Record only the n-slowest tests using heap - if len(self.slow_tests) >= self.num_slow_tests: - heapq.heappushpop(self.slow_tests, item) - else: - heapq.heappush(self.slow_tests, item) - - def _writeElapsedTime(self, test): - color = get_elapsed_time_color(self.elapsed_time) - self.colorizer.write(" %.2f" % self.elapsed_time, color) - - def _writeResult(self, test, long_result, color, short_result, success): - if self.showAll: - self.colorizer.write(long_result, color) - if self.show_elapsed and success: - self._writeElapsedTime(test) - self.stream.writeln() - elif self.dots: - self.stream.write(short_result) - self.stream.flush() - - # NOTE(vish): copied from unittest with edit to add color - def addSuccess(self, test): - unittest.TestResult.addSuccess(self, test) - self._handleElapsedTime(test) - self._writeResult(test, 'OK', 'green', '.', True) - - # NOTE(vish): copied from unittest with edit to add color - def addFailure(self, test, err): - unittest.TestResult.addFailure(self, test, err) - self._handleElapsedTime(test) - self._writeResult(test, 'FAIL', 'red', 'F', False) - - # NOTE(vish): copied from nose with edit to add color - def addError(self, test, err): - """Overrides normal addError to add support for - errorClasses. If the exception is a registered class, the - error will be added to the list for that class, not errors. - """ - self._handleElapsedTime(test) - stream = getattr(self, 'stream', None) - ec, ev, tb = err - try: - exc_info = self._exc_info_to_string(err, test) - except TypeError: - # 2.3 compat - exc_info = self._exc_info_to_string(err) - for cls, (storage, label, isfail) in self.errorClasses.items(): - if result.isclass(ec) and issubclass(ec, cls): - if isfail: - test.passed = False - storage.append((test, exc_info)) - # Might get patched into a streamless result - if stream is not None: - if self.showAll: - message = [label] - detail = result._exception_detail(err[1]) - if detail: - message.append(detail) - stream.writeln(": ".join(message)) - elif self.dots: - stream.write(label[:1]) - return - self.errors.append((test, exc_info)) - test.passed = False - if stream is not None: - self._writeResult(test, 'ERROR', 'red', 'E', False) - - def startTest(self, test): - unittest.TestResult.startTest(self, test) - self.start_time = time.time() - current_case = test.test.__class__.__name__ - - if self.showAll: - if current_case != self._last_case: - self.stream.writeln(current_case) - self._last_case = current_case - - self.stream.write( - ' %s' % str(test.test._testMethodName).ljust(60)) - self.stream.flush() - - -class CinderTestRunner(core.TextTestRunner): - def __init__(self, *args, **kwargs): - self.show_elapsed = kwargs.pop('show_elapsed') - core.TextTestRunner.__init__(self, *args, **kwargs) - - def _makeResult(self): - return CinderTestResult(self.stream, - self.descriptions, - self.verbosity, - self.config, - show_elapsed=self.show_elapsed) - - def _writeSlowTests(self, result_): - # Pare out 'fast' tests - slow_tests = [item for item in result_.slow_tests - if get_elapsed_time_color(item[0]) != 'green'] - if slow_tests: - slow_total_time = sum(item[0] for item in slow_tests) - self.stream.writeln("Slowest %i tests took %.2f secs:" - % (len(slow_tests), slow_total_time)) - for elapsed_time, test in sorted(slow_tests, reverse=True): - time_str = "%.2f" % elapsed_time - self.stream.writeln(" %s %s" % (time_str.ljust(10), test)) - - def run(self, test): - result_ = core.TextTestRunner.run(self, test) - if self.show_elapsed: - self._writeSlowTests(result_) - return result_ - - -def run(): - # This is a fix to allow the --hide-elapsed flag while accepting - # arbitrary nosetest flags as well - argv = [x for x in sys.argv if x != '--hide-elapsed'] - hide_elapsed = argv != sys.argv - logging.setup("cinder") - - # If any argument looks like a test name but doesn't have "cinder.tests" in - # front of it, automatically add that so we don't have to type as much - for i, arg in enumerate(argv): - if arg.startswith('test_'): - argv[i] = 'cinder.tests.%s' % arg - - testdir = os.path.abspath(os.path.join("cinder", "tests")) - c = config.Config(stream=sys.stdout, - env=os.environ, - verbosity=3, - workingDir=testdir, - plugins=core.DefaultPluginManager()) - - runner = CinderTestRunner(stream=c.stream, - verbosity=c.verbosity, - config=c, - show_elapsed=not hide_elapsed) - sys.exit(not core.run(config=c, testRunner=runner, argv=argv)) - - -if __name__ == '__main__': - eventlet.monkey_patch() - run() diff --git a/cinder/tests/__init__.py b/cinder/tests/__init__.py index 3b95e052e..5027886ad 100644 --- a/cinder/tests/__init__.py +++ b/cinder/tests/__init__.py @@ -30,6 +30,9 @@ .. moduleauthor:: Andy Smith """ +import eventlet +eventlet.monkey_patch() + # See http://code.google.com/p/python-nose/issues/detail?id=373 # The code below enables nosetests to work with i18n _() blocks import __builtin__ diff --git a/cinder/tests/test_test.py b/cinder/tests/test_test.py index be17f3916..fe62d9abd 100644 --- a/cinder/tests/test_test.py +++ b/cinder/tests/test_test.py @@ -30,6 +30,8 @@ class IsolationTestCase(test.TestCase): """ def test_service_isolation(self): + import os + print os.path.abspath(".") self.start_service('volume') def test_rpc_consumer_isolation(self): diff --git a/run_tests.sh b/run_tests.sh index 74b5f96d5..4f1155890 100755 --- a/run_tests.sh +++ b/run_tests.sh @@ -66,6 +66,10 @@ recreate_db=1 patch_migrate=1 update=0 +export NOSE_WITH_OPENSTACK=true +export NOSE_OPENSTACK_COLOR=true +export NOSE_OPENSTACK_SHOW_ELAPSED=true + for arg in "$@"; do process_option $arg done @@ -86,17 +90,8 @@ function run_tests { # Cleanup *pyc ${wrapper} find . -type f -name "*.pyc" -delete # Just run the test suites in current environment - ${wrapper} $NOSETESTS 2> run_tests.log - # If we get some short import error right away, print the error log directly + ${wrapper} $NOSETESTS RESULT=$? - if [ "$RESULT" -ne "0" ]; - then - ERRSIZE=`wc -l run_tests.log | awk '{print \$1}'` - if [ "$ERRSIZE" -lt "40" ]; - then - cat run_tests.log - fi - fi return $RESULT } @@ -124,7 +119,7 @@ function run_pep8 { } -NOSETESTS="python cinder/testing/runner.py $noseopts $noseargs" +NOSETESTS="nosetests $noseopts $noseargs" if [ $never_venv -eq 0 ] then diff --git a/tox.ini b/tox.ini index 105e300e6..7d1de9d72 100644 --- a/tox.ini +++ b/tox.ini @@ -8,9 +8,14 @@ setenv = VIRTUAL_ENV={envdir} NOSE_OPENSTACK_RED=0.05 NOSE_OPENSTACK_YELLOW=0.025 NOSE_OPENSTACK_SHOW_ELAPSED=1 + NOSE_OPENSTACK_STDOUT=1 + LANG=en_US.UTF-8 + LANGUAGE=en_US:en + LC_ALL=C + deps = -r{toxinidir}/tools/pip-requires -r{toxinidir}/tools/test-requires -commands = /bin/bash run_tests.sh -N -P {posargs} +commands = nosetests {posargs} [testenv:pep8] commands = @@ -23,26 +28,7 @@ commands = commands = {posargs} [testenv:cover] -commands = /bin/bash run_tests.sh -N -P --coverage-xml - -[tox:jenkins] -downloadcache = ~/cache/pip - -[testenv:jenkins26] -basepython = python2.6 -setenv = NOSE_WITH_XUNIT=1 - -[testenv:jenkins27] -basepython = python2.7 -setenv = NOSE_WITH_XUNIT=1 - -[testenv:jenkinscover] -setenv = NOSE_WITH_XUNIT=1 -commands = /bin/bash run_tests.sh -N --coverage-xml - -[testenv:jenkinsvenv] -setenv = NOSE_WITH_XUNIT=1 -commands = {posargs} +setenv = NOSE_WITH_COVERAGE=1 [testenv:pyflakes] deps = pyflakes -- 2.45.2