From a1a908e815f27f630bc7a7a5dfc06031cfc2bf3b Mon Sep 17 00:00:00 2001 From: Angus Lees Date: Wed, 17 Dec 2014 15:44:12 +1100 Subject: [PATCH] Cisco: unsupported format character in log format CiscoCfgAgent.hosting_devices_removed() contains an error in the format string used to log errors: LOG.error(_LE("Invalid payload format for received RPC message " "`hosting_devices_removed`. Error is %{error}s. " "Payload is %(payload)s"), {'error': e, 'payload': payload}) "%{error}s" should be "%(error)s" The existing version raises "ValueError: unsupported format character '{' (0x7b)" when invoked. (found via pylint) Change-Id: Ic5e9db2a19aa7652cbbd1ee04d7e02914e8d0093 Closes-Bug: #1403304 --- neutron/plugins/cisco/cfg_agent/cfg_agent.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/neutron/plugins/cisco/cfg_agent/cfg_agent.py b/neutron/plugins/cisco/cfg_agent/cfg_agent.py index dfc094aca..636fb5c81 100644 --- a/neutron/plugins/cisco/cfg_agent/cfg_agent.py +++ b/neutron/plugins/cisco/cfg_agent/cfg_agent.py @@ -228,7 +228,7 @@ class CiscoCfgAgent(manager.Manager): self.process_services(removed_devices_info=payload) except KeyError as e: LOG.error(_LE("Invalid payload format for received RPC message " - "`hosting_devices_removed`. Error is %{error}s. " + "`hosting_devices_removed`. Error is %(error)s. " "Payload is %(payload)s"), {'error': e, 'payload': payload}) -- 2.45.2