From a18f711e81d237fdcb6a04008ae9a48d1d19e3b0 Mon Sep 17 00:00:00 2001
From: Steve Baker <sbaker@redhat.com>
Date: Fri, 16 Aug 2013 11:37:27 +1200
Subject: [PATCH] Move _deferred_server_statuses to nova_utils

Refactoring as part of blueprint native-nova-instance.

Change-Id: I91234905a2647ed03fd105b0fe5964ce2319248b
---
 heat/engine/resources/instance.py   | 15 ++-------------
 heat/engine/resources/nova_utils.py | 12 ++++++++++++
 2 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/heat/engine/resources/instance.py b/heat/engine/resources/instance.py
index 8e861e7e..6946a60d 100644
--- a/heat/engine/resources/instance.py
+++ b/heat/engine/resources/instance.py
@@ -138,17 +138,6 @@ class Instance(resource.Resource):
     update_allowed_keys = ('Metadata', 'Properties')
     update_allowed_properties = ('InstanceType',)
 
-    _deferred_server_statuses = ['BUILD',
-                                 'HARD_REBOOT',
-                                 'PASSWORD',
-                                 'REBOOT',
-                                 'RESCUE',
-                                 'RESIZE',
-                                 'REVERT_RESIZE',
-                                 'SHUTOFF',
-                                 'SUSPENDED',
-                                 'VERIFY_RESIZE']
-
     def __init__(self, name, json_snippet, stack):
         super(Instance, self).__init__(name, json_snippet, stack)
         self.ipaddress = None
@@ -316,7 +305,7 @@ class Instance(resource.Resource):
 
             # Some clouds append extra (STATUS) strings to the status
             short_server_status = server.status.split('(')[0]
-            if short_server_status in self._deferred_server_statuses:
+            if short_server_status in nova_utils.deferred_server_statuses:
                 return False
             elif server.status == 'ACTIVE':
                 self._set_ipaddress(server.networks)
@@ -485,7 +474,7 @@ class Instance(resource.Resource):
                 server.get()
                 logger.debug("%s check_suspend_complete status = %s" %
                              (self.name, server.status))
-                if server.status in list(self._deferred_server_statuses +
+                if server.status in list(nova_utils.deferred_server_statuses +
                                          ['ACTIVE']):
                     return server.status == 'SUSPENDED'
                 else:
diff --git a/heat/engine/resources/nova_utils.py b/heat/engine/resources/nova_utils.py
index a2a69752..05969ebb 100644
--- a/heat/engine/resources/nova_utils.py
+++ b/heat/engine/resources/nova_utils.py
@@ -33,6 +33,18 @@ from heat.openstack.common import uuidutils
 logger = logging.getLogger(__name__)
 
 
+deferred_server_statuses = ['BUILD',
+                            'HARD_REBOOT',
+                            'PASSWORD',
+                            'REBOOT',
+                            'RESCUE',
+                            'RESIZE',
+                            'REVERT_RESIZE',
+                            'SHUTOFF',
+                            'SUSPENDED',
+                            'VERIFY_RESIZE']
+
+
 def get_image_id(nova_client, image_identifier):
     '''
     Return an id for the specified image name or identifier.
-- 
2.45.2