From 9b6297dc01e101c38bf3102bd9993deeb9b8badf Mon Sep 17 00:00:00 2001 From: Gary Kotton Date: Wed, 19 Dec 2012 06:57:36 +0000 Subject: [PATCH] Fix pep8 issues Change-Id: I62674220028274619a9b180542eea716f2660917 --- quantum/plugins/cisco/models/network_multi_blade_v2.py | 4 ++-- quantum/plugins/cisco/models/virt_phy_sw_v2.py | 10 +++++----- quantum/tests/unit/test_attributes.py | 2 +- quantum/tests/unit/test_debug_commands.py | 2 +- quantum/tests/unit/test_linux_ip_lib.py | 4 ++-- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/quantum/plugins/cisco/models/network_multi_blade_v2.py b/quantum/plugins/cisco/models/network_multi_blade_v2.py index 6a50121c0..1f55bfdcd 100644 --- a/quantum/plugins/cisco/models/network_multi_blade_v2.py +++ b/quantum/plugins/cisco/models/network_multi_blade_v2.py @@ -180,8 +180,8 @@ class NetworkMultiBladeV2(quantum_plugin_base_v2.QuantumPluginBaseV2): base_plugin_ref = kwargs[const.BASE_PLUGIN_REF] n = kwargs[const.NETWORK] tenant_id = n['tenant_id'] - args = [tenant_id, id, {const.CONTEXT:context}, - {const.BASE_PLUGIN_REF:base_plugin_ref}] + args = [tenant_id, id, {const.CONTEXT: context}, + {const.BASE_PLUGIN_REF: base_plugin_ref}] # TODO (Sumit): Might first need to check here if there are active # ports output = [] diff --git a/quantum/plugins/cisco/models/virt_phy_sw_v2.py b/quantum/plugins/cisco/models/virt_phy_sw_v2.py index 1d6622e5e..d77527f26 100644 --- a/quantum/plugins/cisco/models/virt_phy_sw_v2.py +++ b/quantum/plugins/cisco/models/virt_phy_sw_v2.py @@ -200,7 +200,7 @@ class VirtualPhysicalSwitchModelV2(quantum_plugin_base_v2.QuantumPluginBaseV2): vlanids = self._get_all_segmentation_ids() args = [ovs_output[0]['tenant_id'], ovs_output[0]['name'], ovs_output[0]['id'], vlan_name, vlan_id, - {'vlan_ids':vlanids}] + {'vlan_ids': vlanids}] nexus_output = self._invoke_plugin_per_device(const.NEXUS_PLUGIN, self._func_name(), args) @@ -227,7 +227,7 @@ class VirtualPhysicalSwitchModelV2(quantum_plugin_base_v2.QuantumPluginBaseV2): vlan_name = conf.VLAN_NAME_PREFIX + str(vlan_id) args = [ovs_network['tenant_id'], ovs_network['name'], ovs_network['id'], vlan_name, vlan_id, - {'vlan_ids':vlanids}] + {'vlan_ids': vlanids}] nexus_output = self._invoke_plugin_per_device( const.NEXUS_PLUGIN, "create_network", args) return ovs_output @@ -271,9 +271,9 @@ class VirtualPhysicalSwitchModelV2(quantum_plugin_base_v2.QuantumPluginBaseV2): ovs_output = self._invoke_plugin_per_device(const.VSWITCH_PLUGIN, self._func_name(), args) - args = [tenant_id, id, {const.VLANID:vlan_id}, - {const.CONTEXT:context}, - {const.BASE_PLUGIN_REF:base_plugin_ref}] + args = [tenant_id, id, {const.VLANID: vlan_id}, + {const.CONTEXT: context}, + {const.BASE_PLUGIN_REF: base_plugin_ref}] if self._validate_vlan_id(vlan_id): self._invoke_plugin_per_device(const.NEXUS_PLUGIN, self._func_name(), args) diff --git a/quantum/tests/unit/test_attributes.py b/quantum/tests/unit/test_attributes.py index 447cbf647..8b470b900 100644 --- a/quantum/tests/unit/test_attributes.py +++ b/quantum/tests/unit/test_attributes.py @@ -421,7 +421,7 @@ class TestConvertToInt(unittest2.TestCase): [], attributes.convert_none_to_empty_list(None)) def test_convert_none_to_empty_list_value(self): - values = ['1', 3, [], [1], {}, {'a':3}] + values = ['1', 3, [], [1], {}, {'a': 3}] for value in values: self.assertEqual( value, attributes.convert_none_to_empty_list(value)) diff --git a/quantum/tests/unit/test_debug_commands.py b/quantum/tests/unit/test_debug_commands.py index 1a8fe9295..292766235 100644 --- a/quantum/tests/unit/test_debug_commands.py +++ b/quantum/tests/unit/test_debug_commands.py @@ -77,7 +77,7 @@ class TestDebugCommands(unittest.TestCase): 'mac_address': 'aa:bb:cc:dd:ee:ffa', 'network_id': 'fake_net', 'fixed_ips': - [{'subnet_id': 'fake_subnet', 'ip_address':'10.0.0.3'}] + [{'subnet_id': 'fake_subnet', 'ip_address': '10.0.0.3'}] }} fake_ports = {'ports': [fake_port['port']]} self.fake_ports = fake_ports diff --git a/quantum/tests/unit/test_linux_ip_lib.py b/quantum/tests/unit/test_linux_ip_lib.py index b3ed926e4..23e37be7e 100644 --- a/quantum/tests/unit/test_linux_ip_lib.py +++ b/quantum/tests/unit/test_linux_ip_lib.py @@ -536,10 +536,10 @@ class TestIpRouteCommand(TestIPCmdBase): def test_get_gateway(self): test_cases = [{'sample': GATEWAY_SAMPLE1, - 'expected': {'gateway':'10.35.19.254', + 'expected': {'gateway': '10.35.19.254', 'metric': 100}}, {'sample': GATEWAY_SAMPLE2, - 'expected': {'gateway':'10.35.19.254', + 'expected': {'gateway': '10.35.19.254', 'metric': 100}}, {'sample': GATEWAY_SAMPLE3, 'expected': None}, -- 2.45.2