From 9627e6db42a5dbf0db5aebfc363cf5d1156a2f06 Mon Sep 17 00:00:00 2001 From: john-griffith Date: Thu, 14 Feb 2013 12:00:47 -0700 Subject: [PATCH] Add an ID to temporary volume snapshot object The create_cloned_volum method creates a temp snapshot and when it's done it uses the standard snapshot_delete method in the LVM driver. A change was added that logs a statement using the object[id], but we weren't actually setting this on our temp object so we would get a trace fo key DNE. This change adds an id key to our temp object. Fixes bug: 1125457 Change-Id: I4d886f2738a3c394a3a3a6373045669cf6bf8aaf --- cinder/volume/drivers/lvm.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cinder/volume/drivers/lvm.py b/cinder/volume/drivers/lvm.py index 51df63546..44d244fc8 100644 --- a/cinder/volume/drivers/lvm.py +++ b/cinder/volume/drivers/lvm.py @@ -252,10 +252,12 @@ class LVMVolumeDriver(driver.VolumeDriver): """Creates a clone of the specified volume.""" LOG.info(_('Creating clone of volume: %s') % src_vref['id']) volume_name = FLAGS.volume_name_template % src_vref['id'] + temp_id = 'tmp-snap-%s' % src_vref['id'] temp_snapshot = {'volume_name': volume_name, 'size': src_vref['size'], 'volume_size': src_vref['size'], - 'name': 'clone-snap-%s' % src_vref['id']} + 'name': 'clone-snap-%s' % src_vref['id'], + 'id': temp_id} self.create_snapshot(temp_snapshot) self._create_volume(volume['name'], self._sizestr(volume['size'])) try: -- 2.45.2