From 93f40ca8928109956f3ecebbe8077414c5b52a29 Mon Sep 17 00:00:00 2001 From: Farzad FARID Date: Mon, 22 Jun 2015 14:32:58 +0200 Subject: [PATCH] Fix use of $::apt::params::backports and $::apt::params::xfacts. --- manifests/backports.pp | 12 ++++++------ manifests/ppa.pp | 6 ++++-- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/manifests/backports.pp b/manifests/backports.pp index 3cac0b5..f4c5faa 100644 --- a/manifests/backports.pp +++ b/manifests/backports.pp @@ -4,7 +4,7 @@ class apt::backports ( $repos = undef, $key = undef, $pin = 200, -){ +) inherits apt::params { if $location { validate_string($location) $_location = $location @@ -29,18 +29,18 @@ class apt::backports ( } } - if ($::apt::xfacts['lsbdistid'] == 'debian' or $::apt::xfacts['lsbdistid'] == 'ubuntu') { + if ($::apt::params::xfacts['lsbdistid'] == 'debian' or $::apt::params::xfacts['lsbdistid'] == 'ubuntu') { unless $location { - $_location = $::apt::backports['location'] + $_location = $::apt::params::backports['location'] } unless $release { - $_release = "${::apt::xfacts['lsbdistcodename']}-backports" + $_release = "${::apt::params::xfacts['lsbdistcodename']}-backports" } unless $repos { - $_repos = $::apt::backports['repos'] + $_repos = $::apt::params::backports['repos'] } unless $key { - $_key = $::apt::backports['key'] + $_key = $::apt::params::backports['key'] } } else { unless $location and $release and $repos and $key { diff --git a/manifests/ppa.pp b/manifests/ppa.pp index f3e2bfd..cf98fdd 100644 --- a/manifests/ppa.pp +++ b/manifests/ppa.pp @@ -2,15 +2,17 @@ define apt::ppa( $ensure = 'present', $options = $::apt::ppa_options, - $release = $::apt::xfacts['lsbdistcodename'], + $release = $::apt::params::xfacts['lsbdistcodename'], $package_name = $::apt::ppa_package, $package_manage = false, ) { + include 'apt::params' + unless $release { fail('lsbdistcodename fact not available: release parameter required') } - if $::apt::xfacts['lsbdistid'] == 'Debian' { + if $::apt::params::xfacts['lsbdistid'] == 'Debian' { fail('apt::ppa is not currently supported on Debian.') } -- 2.45.2