From 930f4b393af312b39b56ee00a5f5282010f4156b Mon Sep 17 00:00:00 2001 From: John Griffith Date: Thu, 31 Oct 2013 10:14:57 -0600 Subject: [PATCH] Remove lvm-thin pool_size config option The pool_size config option when using thin LVM is never actually checked/honored. It's also unlikely that users will want to do something other than use the entire VG for their thin pool. Rather than have the unused option going forward let's remove it from the config and just go with the default behavior of utilizing the entire Cinder VG. For folks that would like to only use a portion of the VG for some reason, they can do an lvcreate pool on their own (just like we have them do for the VG itself) and get the same flexibility that way. This is done simply by: lvcreate -T -L ${size} ${vg-name}/${vg_name}-pool DocImpact Change-Id: I3ef2cde433b8dd775b1873a0d6df165dd1945d8c --- cinder/volume/drivers/lvm.py | 4 ---- etc/cinder/cinder.conf.sample | 4 ---- 2 files changed, 8 deletions(-) diff --git a/cinder/volume/drivers/lvm.py b/cinder/volume/drivers/lvm.py index bb3b71dd4..e1cb9fe0e 100644 --- a/cinder/volume/drivers/lvm.py +++ b/cinder/volume/drivers/lvm.py @@ -44,10 +44,6 @@ volume_opts = [ cfg.StrOpt('volume_group', default='cinder-volumes', help='Name for the VG that will contain exported volumes'), - cfg.StrOpt('pool_size', - default=None, - help='Size of thin provisioning pool ' - '(None uses entire cinder VG)'), cfg.IntOpt('lvm_mirrors', default=0, help='If set, create lvms with multiple mirrors. Note that ' diff --git a/etc/cinder/cinder.conf.sample b/etc/cinder/cinder.conf.sample index 8ab46e8e0..c501bf784 100644 --- a/etc/cinder/cinder.conf.sample +++ b/etc/cinder/cinder.conf.sample @@ -1241,10 +1241,6 @@ # value) #volume_group=cinder-volumes -# Size of thin provisioning pool (None uses entire cinder VG) -# (string value) -#pool_size= - # If set, create lvms with multiple mirrors. Note that this # requires lvm_mirrors + 2 pvs with available space (integer # value) -- 2.45.2