From 90e833a3cbbe4835de82e3d83196cbe4545818c1 Mon Sep 17 00:00:00 2001 From: Miguel Angel Ajo Date: Tue, 24 Mar 2015 13:10:37 +0000 Subject: [PATCH] Enable Process Monitor by default. Process monitor is enabled by default by this patch, with a default 60 second monitoring interval, this interval was calculated early in the development process to scale to 1000s of processes with light load. We believe it's important to have it enabled to get user feedback as we release kilo. Process monitor is sucessfully enabled and backported to Red Hat D/S distributions from icehouse to juno without any issue. Specific process monitor functional tests provide coverage, also keepalived checks that it can be properly respawned. We should follow up with dhcp and l3 agent functional testing for killing and checking their processes correctly respawned. Normal process start/stop is already validated by other functional tests and tempest. DocImpact Change-Id: I85fe31bee30714148168a293eea29fa0a37f9701 Implements: blueprint agent-child-processes-status --- etc/neutron.conf | 2 +- neutron/agent/common/config.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/etc/neutron.conf b/etc/neutron.conf index c68af4e66..e25d8e253 100644 --- a/etc/neutron.conf +++ b/etc/neutron.conf @@ -652,7 +652,7 @@ lock_path = $state_path/lock # use_helper_for_ns_read = True # The interval to check external processes for failure in seconds (0=disabled) -# check_child_processes_interval = 0 +# check_child_processes_interval = 60 # Action to take when an external process spawned by an agent dies # Values: diff --git a/neutron/agent/common/config.py b/neutron/agent/common/config.py index 3f533fa3a..429f2c479 100644 --- a/neutron/agent/common/config.py +++ b/neutron/agent/common/config.py @@ -67,7 +67,7 @@ PROCESS_MONITOR_OPTS = [ cfg.StrOpt('check_child_processes_action', default='respawn', choices=['respawn', 'exit'], help=_('Action to be executed when a child process dies')), - cfg.IntOpt('check_child_processes_interval', default=0, + cfg.IntOpt('check_child_processes_interval', default=60, help=_('Interval between checks of child process liveness ' '(seconds), use 0 to disable')), ] -- 2.45.2