From 82e0c388929245a69559261a8aec4ac37edcc567 Mon Sep 17 00:00:00 2001 From: david22swan Date: Wed, 26 Apr 2023 17:50:58 +0100 Subject: [PATCH] (CONT-773) Rubocop Manual Fix 6 - RSpec/RepeatedExampleGroupDescription --- .rubocop_todo.yml | 13 ------------- spec/acceptance/apt_spec.rb | 4 ++-- spec/classes/apt_spec.rb | 4 ++-- 3 files changed, 4 insertions(+), 17 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 8b672ac..da3cce5 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -42,13 +42,6 @@ RSpec/DescribeClass: RSpec/ExampleLength: Max: 15 -# Offense count: 3 -RSpec/LeakyConstantDeclaration: - Exclude: - - 'spec/defines/key_compat_spec.rb' - - 'spec/defines/source_compat_spec.rb' - - 'spec/defines/source_spec.rb' - # Offense count: 3 # Configuration parameters: AllowSubject. RSpec/MultipleMemoizedHelpers: @@ -88,12 +81,6 @@ RSpec/NoExpectationExample: - 'spec/acceptance/apt_key_provider_spec.rb' - 'spec/acceptance/apt_spec.rb' -# Offense count: 4 -RSpec/RepeatedExampleGroupDescription: - Exclude: - - 'spec/acceptance/apt_spec.rb' - - 'spec/classes/apt_spec.rb' - # Offense count: 3 RSpec/StubbedMock: Exclude: diff --git a/spec/acceptance/apt_spec.rb b/spec/acceptance/apt_spec.rb index d726c34..802858e 100644 --- a/spec/acceptance/apt_spec.rb +++ b/spec/acceptance/apt_spec.rb @@ -32,7 +32,7 @@ everything_everything_pp = <<-MANIFEST MANIFEST describe 'apt class' do - context 'with reset' do + context 'with test start reset' do it 'fixes the sources.list' do run_shell('cp /etc/apt/sources.list /tmp') end @@ -52,7 +52,7 @@ describe 'apt class' do end end - context 'with reset' do + context 'with test end reset' do it 'fixes the sources.list' do run_shell('cp /tmp/sources.list /etc/apt') end diff --git a/spec/classes/apt_spec.rb b/spec/classes/apt_spec.rb index 12479b1..cb65c1e 100644 --- a/spec/classes/apt_spec.rb +++ b/spec/classes/apt_spec.rb @@ -234,7 +234,7 @@ describe 'apt' do end end - context 'with lots of non-defaults' do + context 'with lots of non-defaults - one' do let :params do { update: { 'frequency' => 'always', 'timeout' => 1, 'tries' => 3 }, @@ -274,7 +274,7 @@ describe 'apt' do } end - context 'with lots of non-defaults' do + context 'with lots of non-defaults - two' do let :params do { update: { 'frequency' => 'always', 'timeout' => 1, 'tries' => 3 }, -- 2.45.2