From 739f1e66b7b3efe91edf96df4b4866f677cfef39 Mon Sep 17 00:00:00 2001 From: IBBoard Date: Wed, 23 Sep 2020 20:58:09 +0100 Subject: [PATCH] Fix extra quotes in firewall string matching As reported by Steve Traylon[1] and @patricknelson[2], the munging adds extra quotes to the string. This breaks the string matching in iptables, as it looks for literal single quotes in the match. Removing the munging fixes this. [1] https://tickets.puppetlabs.com/browse/MODULES-3454?focusedCommentId=686988&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-686988 [2] https://github.com/puppetlabs/puppetlabs-firewall/commit/3655c6bd33d662a3813c2f66cd0bc5889c68c2c2#diff-379160b60a9bdf297b92a51d20efd8c3R1426 --- lib/puppet/type/firewall.rb | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/puppet/type/firewall.rb b/lib/puppet/type/firewall.rb index 7ac3fdb..2b315a4 100644 --- a/lib/puppet/type/firewall.rb +++ b/lib/puppet/type/firewall.rb @@ -2062,10 +2062,6 @@ Puppet::Type.newtype(:firewall) do String matching feature. Matches the packet against the pattern given as an argument. PUPPETCODE - - munge do |value| - _value = "'" + value + "'" - end end newproperty(:string_hex) do -- 2.45.2