From 6ecf2118b28f7714cdd4c6d6c8aa2d3d43a3ba66 Mon Sep 17 00:00:00 2001 From: Rudy Grigar Date: Wed, 12 Aug 2015 11:25:16 -0700 Subject: [PATCH] Always use dport Using 'port' allows you to spoof a source port and offers a backdoor by sending a different destination port. sport 80 -> dport 11211 would be valid for 'port => 80' and give access to a memcache instance (port 11211) running on the server. --- README.markdown | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.markdown b/README.markdown index c770f3c..efba70b 100644 --- a/README.markdown +++ b/README.markdown @@ -216,7 +216,7 @@ IPv6 rules can be specified using the _ip6tables_ provider: ~~~puppet firewall { '006 Allow inbound SSH (v6)': - port => 22, + dport => 22, proto => tcp, action => accept, provider => 'ip6tables', @@ -240,7 +240,7 @@ class profile::apache { apache::vhost { 'mysite': ensure => present } firewall { '100 allow http and https access': - port => [80, 443], + dport => [80, 443], proto => tcp, action => accept, } -- 2.45.2