From 56c57323477c3342d66bc66287a3bdadc924efb1 Mon Sep 17 00:00:00 2001 From: Kevin Benton Date: Tue, 29 Sep 2015 09:36:11 -0700 Subject: [PATCH] Add note about negative feedback to 'effective neutron' Change-Id: I7808d23779c09f492eef5f024e19285820db57b0 --- doc/source/devref/effective_neutron.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/doc/source/devref/effective_neutron.rst b/doc/source/devref/effective_neutron.rst index 98bf8e9fb..df94f0318 100644 --- a/doc/source/devref/effective_neutron.rst +++ b/doc/source/devref/effective_neutron.rst @@ -167,6 +167,13 @@ Reviewer comments quickly, so that the reviewer remains engaged. If you disappear for a week after you posted a patchset, it is very likely that the patch will end up being neglected. +* Do not take negative feedback personally. Neutron is a large project with lots + of contributors with different opinions on how things should be done. Many come + from widely varying cultures and languages so the English, text-only feedback + can unintentionally come across as harsh. Getting a -1 means reviewers are + trying to help get the patch into a state that can be merged, it doesn't just + mean they are trying to block it. It's very rare to get a patch merged on the + first iteration that makes everyone happy. Commit messages ~~~~~~~~~~~~~~~ -- 2.45.2