From 4d0b66c843460202bdbafb48bbe569a1740241a4 Mon Sep 17 00:00:00 2001 From: Paul Carver Date: Tue, 6 Oct 2015 19:03:57 +0000 Subject: [PATCH] Add another patch scoping bullet point to effective_neutron This patch adds an alternative wording of the patch sizing/scoping recommendation that was left out of [1] [1] https://review.openstack.org/#/c/230217 Change-Id: I64b4f4aca90c19d7dbc81a8126a7254d64876699 --- doc/source/devref/effective_neutron.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/source/devref/effective_neutron.rst b/doc/source/devref/effective_neutron.rst index f62d2cff6..9d3df6d72 100644 --- a/doc/source/devref/effective_neutron.rst +++ b/doc/source/devref/effective_neutron.rst @@ -194,6 +194,11 @@ Scoping your patch appropriately in the refactor and changes required for the fix/feature. If it's a bug fix, try to implement the fix before the refactor to avoid making cherry-picks to stable branches difficult. +* Consider your reviewers' time before submitting your patch. A patch that + requires many hours or days to review will sit in the "todo" list until + someone has many hours or days free (which may never happen.) If you can + deliver your patch in small but incrementally understandable and testable + pieces you will be more likely to attract reviewers. Nits and pedantic comments ~~~~~~~~~~~~~~~~~~~~~~~~~~ -- 2.45.2