From 36e34e46c679a545ac5e7b726d508e2fdbf2194e Mon Sep 17 00:00:00 2001 From: Thomas Goirand Date: Wed, 9 Apr 2014 00:01:29 +0800 Subject: [PATCH] Adds OVS_lib_defer_apply_doesn_t_handle_concurrency.patch Change-Id: Ie1e469decd5ec1068133efffe29e15463812e086 Rewritten-From: 89bdc04ff97d1328aea97f53fa8ae0c662f99873 --- trusty/debian/changelog | 1 + ...fer_apply_doesn_t_handle_concurrency.patch | 38 +++++++++++++++++++ trusty/debian/patches/series | 1 + 3 files changed, 40 insertions(+) create mode 100644 trusty/debian/patches/OVS_lib_defer_apply_doesn_t_handle_concurrency.patch diff --git a/trusty/debian/changelog b/trusty/debian/changelog index edf7ce7b6..6526c7c4b 100644 --- a/trusty/debian/changelog +++ b/trusty/debian/changelog @@ -1,6 +1,7 @@ neutron (2014.1~rc1-2) experimental; urgency=low * More SQLite migration fixes for Icehouse. + * Added OVS_lib_defer_apply_doesn_t_handle_concurrency.patch -- Thomas Goirand Mon, 07 Apr 2014 14:23:29 +0800 diff --git a/trusty/debian/patches/OVS_lib_defer_apply_doesn_t_handle_concurrency.patch b/trusty/debian/patches/OVS_lib_defer_apply_doesn_t_handle_concurrency.patch new file mode 100644 index 000000000..5809fed09 --- /dev/null +++ b/trusty/debian/patches/OVS_lib_defer_apply_doesn_t_handle_concurrency.patch @@ -0,0 +1,38 @@ +Description: OVS lib defer apply doesn't handle concurrency + OVS lib defer apply doesn't handle concurrency + . + The OVS lib deferred apply methods use a dict to save flows to add, + modify or delete when deffered apply is switched off. + If another thread adds, modifies or deletes flows on that dict during + another process called deffered_apply_off, its flows could be ignored. + . + This fix stash reference flows list and point the flows list to a new + cleared flows list. Then, it applies flows from the stashed flows list. +Author: Édouard Thuleau +Origin: upstream, https://review.openstack.org/#/c/85492 +Date: Mon, 3 Mar 2014 17:08:33 +0000 (+0100) +X-Git-Url: https://review.openstack.org/gitweb?p=openstack%2Fneutron.git;a=commitdiff_plain;h=dc4ce5946de0686e07eff79704be497c649734d2 +Bug-Ubuntu: https://launchpad.net/bugs/1263866 +Last-Update: 2014-04-08 + +--- neutron-2014.1~rc1.orig/neutron/agent/linux/ovs_lib.py ++++ neutron-2014.1~rc1/neutron/agent/linux/ovs_lib.py +@@ -213,9 +213,16 @@ class OVSBridge(BaseOVS): + for line in flows.splitlines(): + LOG.debug(_('%(action)s: %(flow)s'), + {'action': action, 'flow': line}) +- self.run_ofctl('%s-flows' % action, ['-'], flows) ++ # Note(ethuleau): stash flows and disable deferred mode. Then apply ++ # flows from the stashed reference to be sure to not purge flows that ++ # were added between two ofctl commands. ++ stashed_deferred_flows, self.deferred_flows = ( ++ self.deferred_flows, {'add': '', 'mod': '', 'del': ''} ++ ) + self.defer_apply_flows = False +- self.deferred_flows = {'add': '', 'mod': '', 'del': ''} ++ for action, flows in stashed_deferred_flows.items(): ++ if flows: ++ self.run_ofctl('%s-flows' % action, ['-'], flows) + + def add_tunnel_port(self, port_name, remote_ip, local_ip, + tunnel_type=p_const.TYPE_GRE, diff --git a/trusty/debian/patches/series b/trusty/debian/patches/series index 25b97dfe6..a93e36f99 100644 --- a/trusty/debian/patches/series +++ b/trusty/debian/patches/series @@ -1,2 +1,3 @@ fix-alembic-migration-with-sqlite3.patch better-config-default.patch +OVS_lib_defer_apply_doesn_t_handle_concurrency.patch -- 2.45.2