From 345d511cd423e0dbcc108289df21c818b1fa1ab9 Mon Sep 17 00:00:00 2001 From: Jonathan Boyett Date: Tue, 10 May 2011 15:30:46 -0700 Subject: [PATCH] cleanup flush and insert_order methods --- lib/puppet/provider/firewall/iptables.rb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/puppet/provider/firewall/iptables.rb b/lib/puppet/provider/firewall/iptables.rb index 75d24da..427eb0f 100644 --- a/lib/puppet/provider/firewall/iptables.rb +++ b/lib/puppet/provider/firewall/iptables.rb @@ -60,8 +60,7 @@ Puppet::Type.type(:firewall).provide :iptables, :parent => Puppet::Provider::Fir # Flush the property hash once done. def flush debug("[flush]") - needs_change = @property_hash.delete(:needs_change) - if needs_change + if @property_hash.delete(:needs_change) notice("Properties changed - updating rule") update end @@ -143,8 +142,7 @@ Puppet::Type.type(:firewall).provide :iptables, :parent => Puppet::Provider::Fir # Find list of current rules based on chain self.class.instances.each do |rule| - next unless rule.chain == resource[:chain].to_s - rules << rule.name + rules << rule.name if rule.chain == resource[:chain].to_s end # No rules at all? Just bail now. -- 2.45.2