From 2adf6889233273f5bd03260d408dce91aa9c6275 Mon Sep 17 00:00:00 2001 From: Chuck Short Date: Wed, 2 Jan 2013 08:43:53 -0600 Subject: [PATCH] Add pyflakes Add tox option to use pyflakes. Change-Id: Ic77ec3f54cb89341d5b01feb3417e07f43d20c9c Signed-off-by: Chuck Short --- tools/flakes.py | 22 ++++++++++++++++++++++ tox.ini | 4 ++++ 2 files changed, 26 insertions(+) create mode 100644 tools/flakes.py diff --git a/tools/flakes.py b/tools/flakes.py new file mode 100644 index 000000000..4b93abc21 --- /dev/null +++ b/tools/flakes.py @@ -0,0 +1,22 @@ +""" + wrapper for pyflakes to ignore gettext based warning: + "undefined name '_'" + + From https://bugs.launchpad.net/pyflakes/+bug/844592 +""" +import __builtin__ +import os +import sys + +from pyflakes.scripts.pyflakes import main + +if __name__ == "__main__": + names = os.environ.get('PYFLAKES_BUILTINS', '_') + names = [x.strip() for x in names.split(',')] + for x in names: + if not hasattr(__builtin__, x): + setattr(__builtin__, x, True) + + del names, os, __builtin__ + + sys.exit(main()) diff --git a/tox.ini b/tox.ini index e766f1635..936ba66a4 100644 --- a/tox.ini +++ b/tox.ini @@ -44,3 +44,7 @@ commands = /bin/bash run_tests.sh -N --coverage-xml [testenv:jenkinsvenv] setenv = NOSE_WITH_XUNIT=1 commands = {posargs} + +[testenv:pyflakes] +deps = pyflakes +commands = python tools/flakes.py cinder -- 2.45.2