From 26b224b9ab7f8a527be2f271800f21d02a0fd0aa Mon Sep 17 00:00:00 2001 From: Dongcan Ye Date: Sat, 26 Dec 2015 18:02:59 +0800 Subject: [PATCH] VMware: optimize in get_cluster_refs In get_cluster_refs method, for the sake of getting cluster names references, there are two for loop sentences. This patch merges into one for loop. (Trivial fix) Change-Id: Ib7dfbe0294a5ee7988a18adfbf59159c2b6641e4 --- cinder/volume/drivers/vmware/volumeops.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cinder/volume/drivers/vmware/volumeops.py b/cinder/volume/drivers/vmware/volumeops.py index c238e32c6..6579a6829 100644 --- a/cinder/volume/drivers/vmware/volumeops.py +++ b/cinder/volume/drivers/vmware/volumeops.py @@ -1542,13 +1542,15 @@ class VMwareVolumeOps(object): :param names: list of cluster names :return: Dictionary of cluster names to references """ + clusters_ref = {} clusters = self._get_all_clusters() for name in names: if name not in clusters: LOG.error(_LE("Compute cluster: %s not found."), name) raise vmdk_exceptions.ClusterNotFoundException(cluster=name) + clusters_ref[name] = clusters[name] - return {name: clusters[name] for name in names} + return clusters_ref def get_cluster_hosts(self, cluster): """Get hosts in the given cluster. -- 2.45.2