From 0f1f35ff2307a048e2615dcf3750548462e20fdf Mon Sep 17 00:00:00 2001 From: Tomas Doran Date: Tue, 4 Sep 2012 17:04:35 +0100 Subject: [PATCH] Fix error reporting for insane hostnames. If you put some really silly values in (e.g. /) into hostnames then the error message s super super cryptic. This patch fixes that, so it's at least obvious what / where / why it's failing if you use --trace --debug --- lib/puppet/type/firewall.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/puppet/type/firewall.rb b/lib/puppet/type/firewall.rb index 942120b..e234685 100644 --- a/lib/puppet/type/firewall.rb +++ b/lib/puppet/type/firewall.rb @@ -97,7 +97,11 @@ Puppet::Type.newtype(:firewall) do EOS munge do |value| - @resource.host_to_ip(value) + begin + @resource.host_to_ip(value) + rescue Exception => e + self.fail("host_to_ip failed for #{value}, exception #{e}") + end end end -- 2.45.2