From 0ed77a4f7309e8391510e34a9f5ad86413f50412 Mon Sep 17 00:00:00 2001 From: Jon Bernard Date: Fri, 6 Mar 2015 15:26:19 -0500 Subject: [PATCH] Fix retype return value in volume driver base class Instead of raising an exception, the expected behaviour is to return a tuple indicating that the driver does not support retype operation. Closes-Bug: #1430605 Change-Id: I395dfc3213bb560767ac3fc95e5d68c4a87a7640 --- cinder/volume/driver.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cinder/volume/driver.py b/cinder/volume/driver.py index ea0afe8c4..228badb36 100644 --- a/cinder/volume/driver.py +++ b/cinder/volume/driver.py @@ -1101,8 +1101,7 @@ class VolumeDriver(ConsistencyGroupVD, TransferVD, ManageableVD, ExtendVD, raise NotImplementedError(msg) def retype(self, context, volume, new_type, diff, host): - msg = _("Retype existing volume not implemented.") - raise NotImplementedError(msg) + return False, None def reenable_replication(self, context, volume): msg = _("sync_replica not implemented.") -- 2.45.2