From 05f51b81947930b8ce42d9dbf55c620bea5f4eb6 Mon Sep 17 00:00:00 2001
From: david22swan <david.swan@puppet.com>
Date: Thu, 21 Apr 2022 10:07:03 +0100
Subject: [PATCH] (GH-cat-9) syntax:hiera:yaml exclusions added

---
 .puppet-lint.rc | 4 ++++
 .sync.yml       | 6 ++++++
 Rakefile        | 7 +++++--
 metadata.json   | 2 +-
 4 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/.puppet-lint.rc b/.puppet-lint.rc
index cc96ece..feb502c 100644
--- a/.puppet-lint.rc
+++ b/.puppet-lint.rc
@@ -1 +1,5 @@
 --relative
+--no-relative_classname_inclusion-check
+--no-parameter_types-check
+--no-top_scope_facts-check
+--no-legacy_facts-check
diff --git a/.sync.yml b/.sync.yml
index 247b988..0a986c4 100644
--- a/.sync.yml
+++ b/.sync.yml
@@ -31,3 +31,9 @@ spec/spec_helper.rb:
 .travis.yml:
   delete: true
 changelog_since_tag: 'v3.0.0'
+Rakefile:
+  extra_disabled_lint_checks:
+    - relative_classname_inclusion
+    - parameter_types
+    - top_scope_facts
+    - legacy_facts
diff --git a/Rakefile b/Rakefile
index de93172..7fc43e0 100644
--- a/Rakefile
+++ b/Rakefile
@@ -10,7 +10,7 @@ require 'puppet-strings/tasks' if Bundler.rubygems.find_name('puppet-strings').a
 
 def changelog_user
   return unless Rake.application.top_level_tasks.include? "changelog"
-  returnVal = "puppetlabs" || JSON.load(File.read('metadata.json'))['author']
+  returnVal = nil || JSON.load(File.read('metadata.json'))['author']
   raise "unable to find the changelog_user in .sync.yml, or the author in metadata.json" if returnVal.nil?
   puts "GitHubChangelogGenerator user:#{returnVal}"
   returnVal
@@ -42,6 +42,10 @@ def changelog_future_release
 end
 
 PuppetLint.configuration.send('disable_relative')
+PuppetLint.configuration.send('disable_relative_classname_inclusion')
+PuppetLint.configuration.send('disable_parameter_types')
+PuppetLint.configuration.send('disable_top_scope_facts')
+PuppetLint.configuration.send('disable_legacy_facts')
 
 
 if Bundler.rubygems.find_name('github_changelog_generator').any?
@@ -50,7 +54,6 @@ if Bundler.rubygems.find_name('github_changelog_generator').any?
     config.user = "#{changelog_user}"
     config.project = "#{changelog_project}"
     config.since_tag = "v3.0.0"
-    config.max_issues = 500
     config.future_release = "#{changelog_future_release}"
     config.exclude_labels = ['maintenance']
     config.header = "# Change log\n\nAll notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org)."
diff --git a/metadata.json b/metadata.json
index 57c2cee..da986ef 100644
--- a/metadata.json
+++ b/metadata.json
@@ -86,5 +86,5 @@
   ],
   "template-url": "https://github.com/puppetlabs/pdk-templates.git#main",
   "template-ref": "heads/main-0-g806810b",
-  "pdk-version": "2.3.0"
+  "pdk-version": "2.4.0"
 }
-- 
2.45.2