From 05e4e76fd70963f43263f6c27ac8b67f0185672a Mon Sep 17 00:00:00 2001 From: Jonathan Boyett Date: Mon, 15 Aug 2011 11:18:14 -0700 Subject: [PATCH] small refactor of value munging of existing rules --- lib/puppet/provider/firewall/iptables.rb | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/puppet/provider/firewall/iptables.rb b/lib/puppet/provider/firewall/iptables.rb index ebcee19..8318ac9 100644 --- a/lib/puppet/provider/firewall/iptables.rb +++ b/lib/puppet/provider/firewall/iptables.rb @@ -116,13 +116,11 @@ Puppet::Type.type(:firewall).provide :iptables, :parent => Puppet::Provider::Fir keys << :chain keys.zip(values.scan(/"[^"]*"|\S+/).reverse) { |f, v| hash[f] = v.gsub(/"/, '') } - [:dport, :sport, :destination, :source, :state].each do |prop| - if hash[prop] =~ /,/ - hash[prop] = hash[prop].split(',') - else - hash[prop] = [hash[prop]] - end + + [:dport, :sport, :state].each do |prop| + hash[prop] = hash[prop].split(',') if ! hash[prop].nil? end + hash[:provider] = self.name.to_s hash[:table] = table hash[:ensure] = :present -- 2.45.2