From 01ad4ccebd06503896c3921e9e026f8941073a1b Mon Sep 17 00:00:00 2001 From: David Sariel Date: Tue, 5 Jan 2016 10:37:42 +0200 Subject: [PATCH] Re-enabled hacking checks for H105 Following the upgrade to hacking version 0.10.0 the H105 issues were ignored. There was a note left in tox.ini to clean up the H105 issues and to re-enable the check. Updated tox.ini to re-enable the check of H105 and fixed corresponding pep8 issues. This way Cinder aligns rows with Nova, Neutron, Glance etc that have H105 enabled. Closes-Bug: 1531104 Change-Id: I2da70cbeb838f16ec8479284dda9d7c62566dace --- cinder/__init__.py | 6 ------ cinder/scheduler/__init__.py | 3 --- cinder/tests/unit/__init__.py | 6 ------ tox.ini | 13 +------------ 4 files changed, 1 insertion(+), 27 deletions(-) diff --git a/cinder/__init__.py b/cinder/__init__.py index 2b43c2faf..0712b0b63 100644 --- a/cinder/__init__.py +++ b/cinder/__init__.py @@ -21,10 +21,4 @@ .. automodule:: cinder :platform: Unix :synopsis: Infrastructure-as-a-Service Cloud platform. -.. moduleauthor:: Jesse Andrews -.. moduleauthor:: Devin Carlen -.. moduleauthor:: Vishvananda Ishaya -.. moduleauthor:: Joshua McKenty -.. moduleauthor:: Manish Singh -.. moduleauthor:: Andy Smith """ diff --git a/cinder/scheduler/__init__.py b/cinder/scheduler/__init__.py index a81012199..63a101bf8 100644 --- a/cinder/scheduler/__init__.py +++ b/cinder/scheduler/__init__.py @@ -19,7 +19,4 @@ .. automodule:: cinder.scheduler :platform: Unix :synopsis: Module that picks a volume node to create a volume. -.. moduleauthor:: Sandy Walsh -.. moduleauthor:: Ed Leafe -.. moduleauthor:: Chris Behrens """ diff --git a/cinder/tests/unit/__init__.py b/cinder/tests/unit/__init__.py index f59fa3d6e..1b5ffcd9a 100644 --- a/cinder/tests/unit/__init__.py +++ b/cinder/tests/unit/__init__.py @@ -20,12 +20,6 @@ .. automodule:: cinder.tests.unit :platform: Unix -.. moduleauthor:: Jesse Andrews -.. moduleauthor:: Devin Carlen -.. moduleauthor:: Vishvananda Ishaya -.. moduleauthor:: Joshua McKenty -.. moduleauthor:: Manish Singh -.. moduleauthor:: Andy Smith """ import eventlet diff --git a/tox.ini b/tox.ini index 3a6ac79a1..fb71b5829 100644 --- a/tox.ini +++ b/tox.ini @@ -121,18 +121,7 @@ commands = bandit -c tools/bandit.yaml -r cinder -n 5 -ll # # E251 unexpected spaces around keyword / parameter equals # reason: no improvement in readability -# -# Due to the upgrade to hacking 0.9.2 the following checking are -# ignored on purpose for the moment and should be re-enabled. -# -# H405 -# Due to the upgrade to hacking 0.10.0 the following checking are -# ignored on purpose for the moment and should be cleaned up and re-enabled. -# -# H105 Don't use author tags -# - -ignore = E251,H105 +ignore = E251 exclude = .git,.venv,.tox,dist,tools,doc,common,*egg,build max-complexity=30 -- 2.45.2