From 38263ac768349bf0eab56194aa70f4a78fb664af Mon Sep 17 00:00:00 2001 From: Nick Berard Date: Fri, 1 Jul 2016 17:31:05 -0700 Subject: [PATCH] After the repository is added, the ${::apt::sources_list_d}/${sources_list_d_filename} file is created as an empty file. The unless condition of Exec["add-apt-repository-${name}"] calls test -s, which returns 1 if the file is empty. Because the file is empty, the unless condition is never true and the repository is added on every execution. This commit replaces the -s test condition with -f, which is true if the file exists or false otherwise. --- manifests/ppa.pp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manifests/ppa.pp b/manifests/ppa.pp index dfa3d08..6b025d7 100644 --- a/manifests/ppa.pp +++ b/manifests/ppa.pp @@ -48,7 +48,7 @@ define apt::ppa( exec { "add-apt-repository-${name}": environment => $_proxy_env, command => "/usr/bin/add-apt-repository ${options} ${name}", - unless => "/usr/bin/test -s ${::apt::sources_list_d}/${sources_list_d_filename}", + unless => "/usr/bin/test -f ${::apt::sources_list_d}/${sources_list_d_filename}", user => 'root', logoutput => 'on_failure', notify => Class['apt::update'], -- 2.32.3