]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Remove create_export from volume create
authorJohn Griffith <john.griffith@solidfire.com>
Fri, 31 Jan 2014 03:53:37 +0000 (03:53 +0000)
committerjohn-griffith <john.griffith@solidfire.com>
Tue, 4 Feb 2014 13:39:44 +0000 (06:39 -0700)
commitbeecd769af02ba5915be827d28a7b46d970e41b0
tree385261ba565ce831147ff5b531cf37cee5f63d06
parent4e04f12ace3077c5fd1e3cd09435501766e24ef1
Remove create_export from volume create

Currently the LVM driver creates iscsi targets on
volume creation, even though it's only used at
attach time.  This isn't necessary and in fact
causes issues if a volume is extended because the
target information isn't currently updated after the
extend.  In addition a number of other drivers inclduing
the LIO iscsi driver require the target be created with
initiator info, so the tgt that's created initially
again isn't valid.

This change removes the create_export call from the
volume create process and makes it part of the
managers intialize_connection routine which is
more appropriate.

This change also removes the target on detach since
it's not used any longer and again as the volume may
be modified or extended.

Change-Id: I0b7dfdaf7e49a069da22f22f459861b0b49430a4
Closes-Bug: 1248947
cinder/brick/iscsi/iscsi.py
cinder/exception.py
cinder/tests/test_volume.py
cinder/volume/driver.py
cinder/volume/drivers/lvm.py
cinder/volume/flows/manager/create_volume.py
cinder/volume/manager.py
cinder/volume/rpcapi.py