]> review.fuel-infra Code Review - openstack-build/heat-build.git/commit
Do not initialize anything during import phase
authorClint Byrum <clint@fewbar.com>
Tue, 23 Apr 2013 22:51:57 +0000 (15:51 -0700)
committerClint Byrum <clint@fewbar.com>
Wed, 24 Apr 2013 17:03:06 +0000 (10:03 -0700)
commita60f6d45693c8a0d70f78a0fa9216a8c54c062e7
treee20ac0fbad20da223132488d1aa0c61ee03b2e40
parentf3be3d90b30b6beb5d1ba94a4589a4345469f544
Do not initialize anything during import phase

The structure of the program is compromised by doing too much logic in
the import phase. We can read the code more cleanly if we can see where
the intended initialization code is called. This may make tests slightly
more tedious to write, but that should be handled by writing generic
fixtures which can be reused for exactly this purpose.

Change-Id: I1d221e2f90d1f6e89717a37d2128caabd077d30a
16 files changed:
heat/db/__init__.py
heat/db/api.py
heat/engine/__init__.py
heat/engine/parser.py
heat/engine/resources/__init__.py
heat/engine/service.py
heat/tests/test_engine_service.py
heat/tests/test_event.py
heat/tests/test_loadbalancer.py
heat/tests/test_parser.py
heat/tests/test_rpc_client.py
heat/tests/test_security_group.py
heat/tests/test_user.py
heat/tests/test_validate.py
heat/tests/test_waitcondition.py
heat/tests/test_watch.py