]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Fix creation of iscsi targets
authorChuck Short <chuck.short@canonical.com>
Tue, 28 Aug 2012 20:06:25 +0000 (15:06 -0500)
committerJohn Griffith <john.griffith@solidfire.com>
Thu, 30 Aug 2012 20:58:32 +0000 (14:58 -0600)
commit9785963c841aff5ea1c159da81f93c2bf62c70c6
tree3ea9eca71cead79f14f9e65562b6e2b297a08ae3
parenta55430ce286b291e5a5611b1e908b325ab3de20d
Fix creation of iscsi targets

Previously when creating iscsi volumes, we were using

tgt-admin -e -c <config file> --update volume-id

Unfortunately the side affect of this is that tgt-admin
removed other volumes that weren't connected to an iscsi
connector. Which is obvlously not what we want.

In order to fix this we create the targets.conf for the
volume but we call tgt-admin --update icssi qualified name.

We're dropping the use of iscsi_targets table when using TgtAdm.
Compatability for other target admin types is maintained.

Fixes LP: #1038062

Change-Id: I9060a43208df5b79e9b17dadcab8bc0a8eeef55e
Signed-off-by: Chuck Short <chuck.short@canonical.com>
cinder/exception.py
cinder/tests/test_iscsi.py
cinder/tests/test_volume.py
cinder/volume/driver.py
cinder/volume/iscsi.py