]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Tidy up the SSH call to avoid injection attacks in storwize_svc
authorHaomai Wang <haomai@unitedstack.com>
Wed, 17 Jul 2013 13:36:55 +0000 (21:36 +0800)
committerHaomai Wang <haomai@unitedstack.com>
Wed, 17 Jul 2013 16:05:58 +0000 (00:05 +0800)
commit6be79a8e3b4607adbbe6a26ee565156cd0fb36b0
tree089d76cce2f5ce76e5d08916b1cd957e19a43b94
parente9b5abbaf67c8109d4548753bfd87480afe4a0a7
Tidy up the SSH call to avoid injection attacks in storwize_svc

Let the command and arguments form up a list and avoid the extra arguments
attackers inserted to the command string

fix bug 1192971

Change-Id: I72bb7ef137223381c9daa613e61f1fde4c3bc8ae
cinder/tests/test_storwize_svc.py
cinder/volume/drivers/storwize_svc.py