]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Code Review / openstack-build / cinder-build.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 1d77d79) | patch
context.elevated() should use copy.deepcopy()
authorJay S. Bryant <jsbryant@us.ibm.com>
Thu, 20 Nov 2014 17:06:48 +0000 (11:06 -0600)
committerJay S. Bryant <jsbryant@us.ibm.com>
Fri, 21 Nov 2014 01:24:33 +0000 (19:24 -0600)
commit285cfaf0954d4c3e320b205c288240c1828476fe
tree5060f9033812fe8e32791a19b16b77b0ffd9f96etree | snapshot
parent1d77d79f81cf5e6a808453432f6e510ad0ea5a25commit | diff
context.elevated() should use copy.deepcopy()

Currently context.elevated is just doing a copy.copy(self).
This needs to be changed to use copy.deepcopy so that the
list reference is not shared between objects which leaves
the possibility of an admin role leak.

This fix changes context.elevated use copy.deepcopy.

Change-Id: I349c53ccbe9e02ad2a3e84ae897424db9785a170
Closes-bug: 1386932
cinder/context.py diff | blob | history
cinder/tests/test_context.py diff | blob | history