puppet-modules/puppetlabs-apt.git
3 years agoRelease prep v8.0.1 v8.0.1
GitHub Action [Mon, 15 Mar 2021 09:18:49 +0000 (09:18 +0000)]
Release prep v8.0.1

3 years agoMerge pull request #973 from moritz-makandra/main
Paula Muir [Mon, 8 Mar 2021 11:26:46 +0000 (11:26 +0000)]
Merge pull request #973 from moritz-makandra/main

MODULES-10956 remove redundant code in provider apt_key

3 years agoMerge pull request #975 from puppetlabs/release
daianamezdrea [Tue, 2 Mar 2021 09:39:18 +0000 (11:39 +0200)]
Merge pull request #975 from puppetlabs/release

V8.0.0 Merge Back

3 years agoRelease version 8.0.0 v8.0.0
Auto-release [Mon, 1 Mar 2021 17:46:32 +0000 (17:46 +0000)]
Release version 8.0.0

3 years agoMerge pull request #974 from puppetlabs/pdksync_maint/main/perform_pdk_update
daianamezdrea [Thu, 25 Feb 2021 16:47:51 +0000 (18:47 +0200)]
Merge pull request #974 from puppetlabs/pdksync_maint/main/perform_pdk_update

pdksync - (MAINT) PDK update for GHA workflows + Litmus updates

3 years ago(MAINT) pdk update pdksync_maint/main/perform_pdk_update
Ciaran McCrisken [Thu, 25 Feb 2021 16:14:49 +0000 (16:14 +0000)]
(MAINT) pdk update

3 years agoMODULES-10956 remove redundant code in provider apt_key
Moritz Kraus [Wed, 24 Feb 2021 14:29:19 +0000 (15:29 +0100)]
MODULES-10956 remove redundant code in provider apt_key

The code in function `update_expired_key` is redundant to the logic in
the function `create`. The call to function `exist` will mark the key as
absent, in case it has expired and refres is set to true.

I debugged for hours why my keys weren't updated until I realized, that
the functionality is elsewhere.

3 years agoMerge pull request #972 from puppetlabs/maint/main/update_dependencies pdksync_maint/main/deprecate_rhel_5_normalise_os_names
Michael T Lombardi (He/Him) [Tue, 23 Feb 2021 01:29:53 +0000 (19:29 -0600)]
Merge pull request #972 from puppetlabs/maint/main/update_dependencies

(maint) Update major dependencies prior to release

3 years ago(maint) Update major dependencies prior to release maint/main/update_dependencies
Paula Muir [Mon, 22 Feb 2021 16:05:58 +0000 (16:05 +0000)]
(maint) Update major dependencies prior to release

3 years agoMerge pull request #971 from capsi-informatique/fix-typo
daianamezdrea [Mon, 22 Feb 2021 10:19:35 +0000 (12:19 +0200)]
Merge pull request #971 from capsi-informatique/fix-typo

Fix typo in weak_ssl documentation

3 years agoMerge pull request #969 from puppetlabs/pdksync_remove_puppet5
Paula Muir [Tue, 16 Feb 2021 15:29:35 +0000 (15:29 +0000)]
Merge pull request #969 from puppetlabs/pdksync_remove_puppet5

pdksync - Remove Puppet 5 from testing and bump minimal version to 6.0.0

3 years agopdk update
Daniel Carabas [Tue, 16 Feb 2021 13:36:48 +0000 (15:36 +0200)]
pdk update

3 years agoMerge pull request #970 from puppetlabs/release
Disha-maker [Tue, 16 Feb 2021 13:27:01 +0000 (13:27 +0000)]
Merge pull request #970 from puppetlabs/release

(MAINT) Release merge back for v7.1.1 merged

3 years agoFix typo in weak_ssl documentation
David Cachau [Tue, 16 Feb 2021 13:20:21 +0000 (14:20 +0100)]
Fix typo in weak_ssl documentation

3 years agoUpdate .sync.yml
Daniel Carabas [Tue, 16 Feb 2021 07:50:56 +0000 (09:50 +0200)]
Update .sync.yml

3 years agoBump minimal puppet version to 6.0.0 in metadata.json
Daniel Carabas [Mon, 15 Feb 2021 15:36:24 +0000 (17:36 +0200)]
Bump minimal puppet version to 6.0.0 in metadata.json

3 years agoRemove Puppet 5 testing
Daniel Carabas [Mon, 15 Feb 2021 15:20:01 +0000 (17:20 +0200)]
Remove Puppet 5 testing

3 years agoMerge pull request #968 from Disha-maker/release v7.7.1
Paula Muir [Mon, 15 Feb 2021 14:07:25 +0000 (14:07 +0000)]
Merge pull request #968 from Disha-maker/release

(IAC-1436) Release Prep PR version 7.7.1

3 years agoRelease version 7.7.1
Auto-release [Mon, 15 Feb 2021 13:06:46 +0000 (13:06 +0000)]
Release version 7.7.1

3 years agoMerge pull request #967 from puppetlabs/pdksync_gha-updates
david22swan [Wed, 3 Feb 2021 13:08:10 +0000 (13:08 +0000)]
Merge pull request #967 from puppetlabs/pdksync_gha-updates

pdksync - Update gha templates

3 years agoWrap apply_manifest into RSpec context; initialise litmus earlier pdksync_gha-updates
David Schmitt [Tue, 26 Jan 2021 18:21:04 +0000 (18:21 +0000)]
Wrap apply_manifest into RSpec context; initialise litmus earlier

This fixes the following error by exposing the necessary PuppetLitmus context:

```
An error occurred while loading ./spec/acceptance/01_apt_class_spec.rb.
Failure/Error: apply_manifest(lsb_package)
NameError:
  undefined local variable or method `os' for main:Object
# ./vendor/bundle/ruby/2.5.0/gems/puppet_litmus-0.22.0/lib/puppet_litmus/puppet_helpers.rb:86:in `block in apply_manifest'
# ./vendor/bundle/ruby/2.5.0/gems/honeycomb-beeline-2.4.0/lib/honeycomb/client.rb:70:in `start_span'
# ./vendor/bundle/ruby/2.5.0/gems/puppet_litmus-0.22.0/lib/puppet_litmus/puppet_helpers.rb:41:in `apply_manifest'
# ./spec/spec_helper_acceptance_local.rb:17:in `<top (required)>'
# ./spec/spec_helper_acceptance.rb:4:in `require'
# ./spec/spec_helper_acceptance.rb:4:in `<top (required)>'
# ./spec/acceptance/01_apt_class_spec.rb:3:in `require'
# ./spec/acceptance/01_apt_class_spec.rb:3:in `<top (required)>'
```

3 years ago(maint) Update github actions
David Schmitt [Tue, 26 Jan 2021 17:16:53 +0000 (17:16 +0000)]
(maint) Update github actions

3 years agoMerge pull request #965 from puppetlabs/RE-13436
david22swan [Mon, 25 Jan 2021 10:30:10 +0000 (10:30 +0000)]
Merge pull request #965 from puppetlabs/RE-13436

(RE-13415) Update GPG key in example

3 years ago(RE-13415) Update GPG key in example RE-13436
Eric Griswold [Wed, 20 Jan 2021 18:44:24 +0000 (10:44 -0800)]
(RE-13415) Update GPG key in example

Provide recently changed gpg key update in the example puppet code.

3 years agoMerge pull request #964 from kenyon/use-modern-os-facts
carabasdaniel [Mon, 18 Jan 2021 09:28:26 +0000 (11:28 +0200)]
Merge pull request #964 from kenyon/use-modern-os-facts

Use modern os facts

3 years agoreadmes: update note about lsb-release for Puppet 7
Kenyon Ralph [Sun, 20 Dec 2020 10:50:26 +0000 (02:50 -0800)]
readmes: update note about lsb-release for Puppet 7

3 years agospec/classes/apt_backports_spec.rb: fix Mint case
Kenyon Ralph [Sun, 20 Dec 2020 09:19:48 +0000 (01:19 -0800)]
spec/classes/apt_backports_spec.rb: fix Mint case

Per
https://github.com/camptocamp/facterdb/blob/master/facts/3.14/linuxmint-19-x86_64.facts#L324
(assuming LinuxMint 17 used the same capitalization as newer
versions).

3 years agoexamples/backports.pp: fix class usage
Kenyon Ralph [Sun, 20 Dec 2020 09:18:36 +0000 (01:18 -0800)]
examples/backports.pp: fix class usage

It's a class, not a defined type.

I missed this in https://github.com/puppetlabs/puppetlabs-apt/pull/962

3 years agoREADME: fix link to litmus tutorial
Kenyon Ralph [Sun, 20 Dec 2020 09:03:15 +0000 (01:03 -0800)]
README: fix link to litmus tutorial

3 years agospec_helper_acceptance_local.rb: improve comment about lsb-release
Kenyon Ralph [Sun, 20 Dec 2020 06:28:04 +0000 (22:28 -0800)]
spec_helper_acceptance_local.rb: improve comment about lsb-release

3 years agoadd an acceptance test for apt::backports
Kenyon Ralph [Sun, 20 Dec 2020 08:11:41 +0000 (00:11 -0800)]
add an acceptance test for apt::backports

3 years agomanifests: use modern os facts
Kenyon Ralph [Sun, 20 Dec 2020 06:31:48 +0000 (22:31 -0800)]
manifests: use modern os facts

3 years agowhitespace cleanup
Kenyon Ralph [Sun, 20 Dec 2020 05:14:38 +0000 (21:14 -0800)]
whitespace cleanup

3 years agoMerge pull request #963 from puppetlabs/pdksync
sanfrancrisko [Mon, 4 Jan 2021 16:28:26 +0000 (16:28 +0000)]
Merge pull request #963 from puppetlabs/pdksync

Update to puppet-module-gems 1.0, pdk-templates and new rubocop

3 years agoFix check for ubuntu version pdksync
David Schmitt [Mon, 4 Jan 2021 11:15:15 +0000 (11:15 +0000)]
Fix check for ubuntu version

3 years agoApply remaining rubocop fixes
David Schmitt [Wed, 16 Dec 2020 16:11:23 +0000 (16:11 +0000)]
Apply remaining rubocop fixes

3 years agoAdd all safe auto corrects
David Schmitt [Wed, 16 Dec 2020 13:05:12 +0000 (13:05 +0000)]
Add all safe auto corrects

3 years agoAdd the FrozenStrings magic comment
David Schmitt [Wed, 16 Dec 2020 13:05:06 +0000 (13:05 +0000)]
Add the FrozenStrings magic comment

3 years agoUpdate to pdk-templates and puppet-module-gems 1.0.0
David Schmitt [Wed, 16 Dec 2020 13:04:56 +0000 (13:04 +0000)]
Update to pdk-templates and puppet-module-gems 1.0.0

3 years agoMerge pull request #962 from kenyon/patch-1
david22swan [Mon, 14 Dec 2020 10:15:11 +0000 (10:15 +0000)]
Merge pull request #962 from kenyon/patch-1

backports.pp: correct example

3 years agobackports.pp: correct example
Kenyon Ralph [Mon, 14 Dec 2020 03:56:47 +0000 (19:56 -0800)]
backports.pp: correct example

The example treated this like a defined type, but it's a class.

3 years agoMerge pull request #961 from puppetlabs/release
Disha-maker [Tue, 8 Dec 2020 16:36:13 +0000 (16:36 +0000)]
Merge pull request #961 from puppetlabs/release

(maint) Release Merge Back PR  v7.7.0

3 years agoRelease version 7.7.0 v7.7.0
Auto-release [Tue, 8 Dec 2020 15:40:04 +0000 (15:40 +0000)]
Release version 7.7.0

3 years agoMerge pull request #960 from puppetlabs/pdksync_remove_el6_tests
sanfrancrisko [Mon, 7 Dec 2020 17:17:07 +0000 (17:17 +0000)]
Merge pull request #960 from puppetlabs/pdksync_remove_el6_tests

pdksync - Remove EL6 testing from Travis

3 years agoRemove EL6 testing from Travis pdksync_remove_el6_tests
Daniel Carabas [Mon, 7 Dec 2020 15:23:45 +0000 (17:23 +0200)]
Remove EL6 testing from Travis

3 years agoMerge pull request #957 from carabasdaniel/main
David Schmitt [Mon, 7 Dec 2020 13:53:15 +0000 (13:53 +0000)]
Merge pull request #957 from carabasdaniel/main

PDK Update for GA workflows

3 years agoMerge pull request #958 from puppetlabs/pdksync_bump_puppet7
carabasdaniel [Mon, 7 Dec 2020 13:02:29 +0000 (15:02 +0200)]
Merge pull request #958 from puppetlabs/pdksync_bump_puppet7

pdksync - (feat) - Add support for Puppet 7

3 years ago(feat) - Bump Puppet boundary pdksync_bump_puppet7
Daiana_Mezdrea [Thu, 3 Dec 2020 14:34:09 +0000 (16:34 +0200)]
(feat) - Bump Puppet boundary

3 years agoMerge pull request #956 from puppetlabs/pdksync_maint/main/release_checks_7_config
David Schmitt [Thu, 26 Nov 2020 08:18:50 +0000 (08:18 +0000)]
Merge pull request #956 from puppetlabs/pdksync_maint/main/release_checks_7_config

pdksync - (maint) Add release_checks_7 config to provision.yaml

3 years agoPDK Update for GA workflows
Daniel Carabas [Wed, 25 Nov 2020 14:14:04 +0000 (16:14 +0200)]
PDK Update for GA workflows

3 years ago(maint) Add release_checks_7 config to provision.yaml pdksync_maint/main/release_checks_7_config
Ciaran McCrisken [Wed, 25 Nov 2020 13:28:27 +0000 (13:28 +0000)]
(maint) Add release_checks_7 config to provision.yaml

3 years agoMerge pull request #953 from suchpuppet/main
david22swan [Mon, 23 Nov 2020 14:44:01 +0000 (14:44 +0000)]
Merge pull request #953 from suchpuppet/main

Make auth.conf contents Sensitive

3 years agoUpdate unit test to support Sensitive data type
Scott Brimhall [Wed, 18 Nov 2020 16:27:41 +0000 (10:27 -0600)]
Update unit test to support Sensitive data type

3 years agoMerge pull request #952 from puppetlabs/pdksync_gitpod
David Schmitt [Wed, 18 Nov 2020 08:58:48 +0000 (08:58 +0000)]
Merge pull request #952 from puppetlabs/pdksync_gitpod

pdksync - Update pdk-templates for gitpod and codespaces support

3 years agoMake auth.conf contents Sensitive
Scott Brimhall [Tue, 17 Nov 2020 22:09:12 +0000 (16:09 -0600)]
Make auth.conf contents Sensitive

3 years agoUpdate pdk-templates for gitpod and codespaces support pdksync_gitpod
David Schmitt [Tue, 17 Nov 2020 21:22:26 +0000 (21:22 +0000)]
Update pdk-templates for gitpod and codespaces support

3 years agoMerge pull request #950 from puppetlabs/release
sheenaajay [Tue, 15 Sep 2020 12:21:12 +0000 (13:21 +0100)]
Merge pull request #950 from puppetlabs/release

(maint) Release version v7.6.0

3 years agoRelease version 7.6.0 v7.6.0
Auto-release [Tue, 15 Sep 2020 10:25:05 +0000 (10:25 +0000)]
Release version 7.6.0

3 years agoMerge pull request #949 from IrimieBogdan/IAC-1143
sheenaajay [Tue, 15 Sep 2020 09:46:01 +0000 (10:46 +0100)]
Merge pull request #949 from IrimieBogdan/IAC-1143

(IAC-1143) Custom fact is called twice

3 years ago(IAC-1143) Remove temporary fix.
BogdanIrimie [Mon, 14 Sep 2020 14:07:43 +0000 (17:07 +0300)]
(IAC-1143) Remove temporary fix.

3 years agoMerge branch 'main' into IAC-1143
BogdanIrimie [Mon, 14 Sep 2020 14:07:11 +0000 (17:07 +0300)]
Merge branch 'main' into IAC-1143

3 years ago(IAC-1143) Run Facter.clear before each test.
BogdanIrimie [Mon, 14 Sep 2020 13:58:52 +0000 (16:58 +0300)]
(IAC-1143) Run Facter.clear before each test.

3 years agoMerge pull request #948 from sheenaajay/purgeoption
carabasdaniel [Mon, 14 Sep 2020 13:13:23 +0000 (16:13 +0300)]
Merge pull request #948 from sheenaajay/purgeoption

(MODULES-10804) option to force purge source.lists file

3 years ago(IAC-1143) Adding temporary workaround for facter failures.
sheena [Mon, 14 Sep 2020 12:33:30 +0000 (13:33 +0100)]
(IAC-1143) Adding temporary workaround for facter failures.

3 years ago(MODULES-10804) option to force purge source.lists file
sheena [Thu, 10 Sep 2020 09:07:41 +0000 (10:07 +0100)]
(MODULES-10804) option to force purge source.lists file

3 years agoMerge pull request #947 from david22swan/IAC-978
sheenaajay [Tue, 18 Aug 2020 10:19:20 +0000 (11:19 +0100)]
Merge pull request #947 from david22swan/IAC-978

(IAC-978) - Removal of inappropriate terminology

3 years ago(IAC-978) - Removal of inappropriate terminology
David Swan [Tue, 18 Aug 2020 09:59:26 +0000 (10:59 +0100)]
(IAC-978) - Removal of inappropriate terminology

3 years ago(IAC-978) - PDK Update
David Swan [Tue, 18 Aug 2020 09:15:01 +0000 (10:15 +0100)]
(IAC-978) - PDK Update

3 years agoMerge pull request #946 from puppetlabs/release
sanfrancrisko [Wed, 12 Aug 2020 16:35:23 +0000 (17:35 +0100)]
Merge pull request #946 from puppetlabs/release

(maint) - Release version 7.5.0 mergeback

3 years agoRelease version 7.5.0 v7.5.0
Auto-release [Wed, 12 Aug 2020 13:05:16 +0000 (13:05 +0000)]
Release version 7.5.0

3 years agoMerge pull request #942 from gguillotte/clarify-loglevel
Paula Muir [Wed, 5 Aug 2020 09:54:10 +0000 (10:54 +0100)]
Merge pull request #942 from gguillotte/clarify-loglevel

(MODULES-10763) loglevel won't affect reports

3 years ago(MODULES-10763) loglevel won't affect reports
Garrett Guillotte [Tue, 4 Aug 2020 16:24:26 +0000 (09:24 -0700)]
(MODULES-10763) loglevel won't affect reports

The README suggests that setting a sufficiently high `loglevel` metaparameter
value will squelch the `Exec[apt_update]` resource's corrective changes from
agent reports. This is not true. Correct and clarify this statement to limit
its scope to log output, and link to MODULES-10763 for context on the exec
resource's false-positive reporting of corrective changes as a known issue.

3 years agoMerge pull request #940 from puppetlabs/pdksync_IAC-973
Adrian Iurca [Tue, 4 Aug 2020 10:13:16 +0000 (13:13 +0300)]
Merge pull request #940 from puppetlabs/pdksync_IAC-973

pdksync - (IAC-973) - Update travis/appveyor to run on new default branch main

3 years ago(IAC-973) - Update travis/appveyor to run on new default branch main pdksync_IAC-973
David Swan [Tue, 4 Aug 2020 09:51:47 +0000 (10:51 +0100)]
(IAC-973) - Update travis/appveyor to run on new default branch main

4 years agoMerge pull request #938 from mdklapwijk-forks/support-acng-ssl master
daianamezdrea [Thu, 28 May 2020 10:36:13 +0000 (13:36 +0300)]
Merge pull request #938 from mdklapwijk-forks/support-acng-ssl

patch-acng-ssl-support

4 years agopatch-acng-ssl-support
mdklapwijk [Wed, 27 May 2020 17:25:03 +0000 (19:25 +0200)]
patch-acng-ssl-support

Support for https repositories via caching proxy apt-cacher-ng using the "tell-me-what-you-need" method as described in the documentation:
- https://www.unix-ag.uni-kl.de/~bloch/acng/html/howtos.html#ssluse

4 years agoMerge pull request #936 from puppetlabs/pdksync_IAC-746
daianamezdrea [Thu, 21 May 2020 08:24:24 +0000 (11:24 +0300)]
Merge pull request #936 from puppetlabs/pdksync_IAC-746

(IAC-746) - Add ubuntu 20.04 support

4 years ago(IAC-746) - Add ubuntu 20.04 support pdksync_IAC-746
David Swan [Wed, 20 May 2020 10:52:06 +0000 (11:52 +0100)]
(IAC-746) - Add ubuntu 20.04 support

4 years agoMerge pull request #935 from puppetlabs/pdksync_abs
sheenaajay [Tue, 19 May 2020 08:45:38 +0000 (09:45 +0100)]
Merge pull request #935 from puppetlabs/pdksync_abs

pdksync - Use abs instead of vmpooler to provision test resources

4 years agoSwitch to default spec_helper_acceptance file pdksync_abs
Daniel Carabas [Mon, 18 May 2020 07:02:01 +0000 (10:02 +0300)]
Switch to default spec_helper_acceptance file

4 years agoChange provision from vmpooler to abs
Daniel Carabas [Mon, 18 May 2020 06:55:44 +0000 (09:55 +0300)]
Change provision from vmpooler to abs

4 years agoMerge pull request #934 from puppetlabs/release
Paula Muir [Thu, 14 May 2020 15:42:17 +0000 (16:42 +0100)]
Merge pull request #934 from puppetlabs/release

(maint) v7.4.2 Release Merge Back

4 years agoAdding CI: true to github workflow v7.4.2
Paula Muir [Thu, 14 May 2020 11:37:16 +0000 (12:37 +0100)]
Adding CI: true to github workflow

4 years agoRelease version 7.4.2
Auto-release [Thu, 14 May 2020 10:59:36 +0000 (10:59 +0000)]
Release version 7.4.2

4 years agoMerge pull request #933 from puppetlabs/pdksync_PDK_UPDATE
sanfrancrisko [Thu, 14 May 2020 09:14:28 +0000 (10:14 +0100)]
Merge pull request #933 from puppetlabs/pdksync_PDK_UPDATE

pdksync - (maint) - Pdk Update

4 years ago(maint) - add back gems removed by pdk update pdksync_PDK_UPDATE
david22swan [Wed, 13 May 2020 09:06:04 +0000 (10:06 +0100)]
(maint) - add back gems removed by pdk update

4 years ago(maint) - Pdk Update
David Swan [Tue, 12 May 2020 14:39:45 +0000 (15:39 +0100)]
(maint) - Pdk Update

4 years agoMerge pull request #931 from puppetlabs/pdksync_dependency_gems_update
daianamezdrea [Tue, 28 Apr 2020 08:41:09 +0000 (11:41 +0300)]
Merge pull request #931 from puppetlabs/pdksync_dependency_gems_update

pdksync - Add dependency gems to development group

4 years agoAdd net-ssh dependency gems to development group pdksync_dependency_gems_update
Daniel Carabas [Mon, 27 Apr 2020 11:26:49 +0000 (14:26 +0300)]
Add net-ssh dependency gems to development group

4 years agoMerge pull request #924 from gimmyxd/facter_4
carabasdaniel [Fri, 10 Apr 2020 11:45:40 +0000 (14:45 +0300)]
Merge pull request #924 from gimmyxd/facter_4

(maint) Update apt custom facts

4 years agoMerge pull request #927 from tryfunc/fix_apt_mark
sheenaajay [Wed, 8 Apr 2020 14:54:44 +0000 (15:54 +0100)]
Merge pull request #927 from tryfunc/fix_apt_mark

fix apt-mark syntax

4 years agofix unless_cmd
Vadim Chernyshev [Thu, 19 Mar 2020 13:32:46 +0000 (16:32 +0300)]
fix unless_cmd

apt-mark supports the following syntax:

 * showauto
 * showmanual
 * showhold

Signed-off-by: Vadim Chernyshev <tryfunc@gmail.com>
4 years ago(maint) Update apt custom facts
gimmy [Fri, 13 Mar 2020 12:09:41 +0000 (14:09 +0200)]
(maint) Update apt custom facts

This commit updates apt custom facts because the evaluation
of custom facts code has changed between facter 2 and facter 4.
In facter 2, when a custom fact is loaded, the code in `add` block
was not executed.
In facter 4, when a custom fact is loaded, the code outside `setcode`
block is executed(same as Facter 3).

4 years agoMerge pull request #923 from anarcat/no-mode
cmccrisken-puppet [Thu, 12 Mar 2020 09:47:17 +0000 (09:47 +0000)]
Merge pull request #923 from anarcat/no-mode

Do not specify file modes unless relevant

4 years agodo not specify file modes unless relevant
Antoine Beaupré [Wed, 11 Mar 2020 13:58:15 +0000 (09:58 -0400)]
do not specify file modes unless relevant

MODULES-10583 makes a good point: "why are you messing with my file
permissions"? In my case, the entire reason I made the following
change (in PR #906):

ab2e06b72f2be8dc38d6e3ecec68dc2cdacbce4e MODULES-10548: make files readonly

... is exactly *because* Puppet was changing the file modes from under
me. I was migrating from our own in-house APT module to the forge one,
and our module did *not* intervene in those file modes: it left the
file resources alone. Which means we could have a directive like this:

    File {
        owner   => root,
        group   => root,
        mode    => '444',
        ensure  => file,
    }

... which made all files readonly by default. So when I migrated to
the Puppetlabs APT module, modes were changed to be writable, which I
did not want.

As I reasoned in MODULES-10548, having files readonly provides an
excellent indicator that a file is managed by Puppet, even if some
module does not add a warning header - either because it forgot or
because it's impossible. But I also understand if people do not like
that policy.

I think the proper way of doing this is not specifying a mode at all,
and let local site-specific policies apply. I specifically proppose
this as an alternative to #921 because I believe adding more
parameters to the resources will needlessly complicate the script,
when we have a native, Puppet-DSL supported way of changing those
modes according to the right scope and context.

In a similar way, we might want to reconsider user and group ownership
of the files, but that can be done in a later time.

This reverts commit 316fd8f4dd1eb6595b3be495ccc5f4924da4de1b.

Signed-off-by: Antoine Beaupré <anarcat@debian.org>
4 years agoMerge pull request #922 from michaeltlombardi/ticket/release/IAC-605 7.4.1 v7.4.1
david22swan [Tue, 10 Mar 2020 16:42:46 +0000 (16:42 +0000)]
Merge pull request #922 from michaeltlombardi/ticket/release/IAC-605

(IAC-605) Prep for 7.4.1 release

4 years ago(IAC-605) Prep for 7.4.1 release
Michael T Lombardi [Tue, 10 Mar 2020 16:41:05 +0000 (11:41 -0500)]
(IAC-605) Prep for 7.4.1 release

4 years agoMerge pull request #920 from carabasdaniel/rollback_permissions
David Schmitt [Tue, 10 Mar 2020 15:34:27 +0000 (15:34 +0000)]
Merge pull request #920 from carabasdaniel/rollback_permissions

(MODULES-10583) Revert "MODULES-10548: make files readonly"

4 years agoRevert "MODULES-10548: make files readonly"
Daniel Carabas [Mon, 9 Mar 2020 16:18:53 +0000 (18:18 +0200)]
Revert "MODULES-10548: make files readonly"

This reverts commit ab2e06b72f2be8dc38d6e3ecec68dc2cdacbce4e.

4 years agoMerge pull request #919 from michaeltlombardi/maint/master/update-docker-image-names
carabasdaniel [Tue, 10 Mar 2020 09:07:36 +0000 (11:07 +0200)]
Merge pull request #919 from michaeltlombardi/maint/master/update-docker-image-names

(MAINT) Update docker image names