]>
review.fuel-infra Code Review - puppet-modules/puppet-ceilometer.git/log
David Moreau Simard [Tue, 21 Jan 2014 18:30:02 +0000 (13:30 -0500)]
Remove log_dir from params and make logs configurable in init
log_dir does not seem to be used in other classes. In the use case where
it can be necessary to specify the location of ceilometer logs, this
patch makes it possible to do so while maintaining the default for
backwards compatibility. This patch also adds the possibility of
sending logs to syslog/rsyslog in the same way as implemented in
puppet-nova.
Change-Id: I1f970d5e3cc947308221fb2b2cdfb34f89c64314
Partial-Bug: #
1269482
(cherry picked from commit
3685997f0ed4a88d0ccacd0415b210a948c66910 )
David Moreau Simard [Tue, 7 Jan 2014 21:41:14 +0000 (16:41 -0500)]
Only add ceilometer user to nova group if using compute agent
When using ceilometer outside of the compute context (ex: with the
swift middleware), puppet-ceilometer attempts to add the user to
the nova group which does not (and probably should not) exist on
the swift nodes.
Change-Id: I6cc68152325a967c024ce611f92a90ce0afba8cc
(cherry picked from commit
d064997cd4c50d9b5365fe2ffca60e14a86b08e1 )
Mathieu Gagné [Wed, 28 Aug 2013 17:21:53 +0000 (13:21 -0400)]
Fail puppet-lint on warnings
Puppet-lint will now fail if there is any warnings.
Change-Id: I49e181bdfd0b27a61bf7242accd352a3625eaf93
(cherry picked from commit
ffde8588fd1360335fbfd376e00f8d53b0ef05e2 )
Mathieu Gagné [Mon, 12 Aug 2013 20:46:08 +0000 (16:46 -0400)]
Disable 80chars/class_parameter_defaults checks
* Disable warnings for "line has more than 80 characters"
* Disable warnings for "parameterised class parameter without a default value"
We do not wish to track warnings for such violations.
Change-Id: I4a00f219682a83f051c92b5e885e778b9422fdbf
(cherry picked from commit
9b901a5db9015129f98f189a4ddf5620f777ec7f )
Connor Kaz [Fri, 9 Aug 2013 01:52:00 +0000 (18:52 -0700)]
Update fixtures.yml for grizzly
This commit updates the .fixtures.yml to ensure this
module can be used to install stable/grizzly from source
and updates inifile to use puppetlabs/inifile.
Change-Id: I3c9efc1924372a9005d7493716c903964600749f
Jenkins [Thu, 8 Aug 2013 14:34:31 +0000 (14:34 +0000)]
Merge "Adding support for qpid in ceilometer, rspec for qpid part in ceilometer"
Xingchao Yu [Sun, 4 Aug 2013 09:09:06 +0000 (17:09 +0800)]
Update mysql allowed_hosts conditional statement
In the origin ceilometer::db::mysql, if the value of $allowed_hosts
contains or equals to $host, then puppet will complain duplicate
declaration error. This patch is aim to update the allowed_hosts
conditonal statement in ceilometer::db::mysql.
There are two cases to pass $allowed_hosts to $real_allowed_hosts:
- If $allowed_hosts is array,then remove $host from $allowed_hosts;
- elsif $allowed_hosts is string and not equivalent to $host;
At last, if $real_allowed_hosts is not undef, then run
ceilometer::db::mysql::host_access
Fix bug
1206444
Change-Id: Ib6c33e6a27113d01326bee32c105fea4003059ce
Francesco Vollero [Thu, 1 Aug 2013 12:42:23 +0000 (14:42 +0200)]
Adding support for qpid in ceilometer, rspec for qpid part in ceilometer
Change-Id: I45396d3175b7984d47dbdb626c1729e0b2fdc105
Mathieu Gagné [Mon, 1 Jul 2013 02:16:34 +0000 (22:16 -0400)]
Remove duplicated fixtures
Sort fixtures for better maintainability.
Change-Id: I17d4229584e2df2da2666e00f17bfcacdb8cdd03
Mathieu Gagné [Mon, 1 Jul 2013 02:08:36 +0000 (22:08 -0400)]
Replace deprecated :rubygems source
Fix deprecation warnings thrown by bundler:
The source :rubygems is deprecated because HTTP requests are insecure.
Please change your source to 'https://rubygems.org' if possible,
or 'http://rubygems.org' if not.
Change-Id: Ifaba2b94d7b47cd32b9bb6eec04cf7f4b89d0411
Jenkins [Mon, 17 Jun 2013 04:46:23 +0000 (04:46 +0000)]
Merge "Add auth_admin_prefix support for ceilometer::api"
François Charlier [Thu, 6 Jun 2013 10:23:53 +0000 (12:23 +0200)]
Switch deprecated rabbit_notifier to rpc_notifier
The 'nova.openstack.common.notifier.rabbit_notifier' is deprecated since
the G release of Openstack, it has to be replaced with
'nova.openstack.common.notifier.rpc_notifier'.
Change-Id: I2174bc1b6504bacfeb427b2f5b8f8dc19c167dcb
François Charlier [Thu, 6 Jun 2013 13:41:45 +0000 (15:41 +0200)]
Add auth_admin_prefix support for ceilometer::api
To support keystone urls like http://host:80/keystone/admin
Implements blueprint serve-keystone-from-wsgi
Change-Id: I68c17a5b76ed61b18337ee580fba63200d874792
Jenkins [Wed, 22 May 2013 04:21:46 +0000 (04:21 +0000)]
Merge "Capitalize boolean values in config files"
Jenkins [Wed, 22 May 2013 00:26:29 +0000 (00:26 +0000)]
Merge "Add .gitreview"
Mathieu Gagné [Tue, 21 May 2013 23:50:07 +0000 (19:50 -0400)]
Add puppet-lint to Gemfile
Change-Id: I34b20c29c27877c982c659253004df0a69cd0d27
Mathieu Gagné [Tue, 21 May 2013 23:47:00 +0000 (19:47 -0400)]
Capitalize boolean values in config files
This patch allows the usage of Puppet boolean values and still
configure values with OpenStack boolean style: True/False.
Change-Id: I413060bc2ec0a8d795a240cc144e503efae41e49
Mathieu Gagné [Tue, 21 May 2013 23:48:04 +0000 (19:48 -0400)]
Add .gitreview
Change-Id: Ia6bf51eb6acb37b12294f19151f63af419722f6b
François Charlier [Fri, 26 Apr 2013 10:09:21 +0000 (13:09 +0300)]
Update README
François Charlier [Tue, 23 Apr 2013 19:33:55 +0000 (12:33 -0700)]
Merge pull request #5 from fcharlier/lint
Merge back mgagne's 'grizzly' branch, fix some bugs & lint errors, add some tests. Fix #2 & #4
François Charlier [Tue, 23 Apr 2013 09:22:31 +0000 (11:22 +0200)]
Update existing puppetdoc & add missing puppetdoc
François Charlier [Tue, 23 Apr 2013 08:51:24 +0000 (10:51 +0200)]
Merge remote-tracking branch 'mgagne/grizzly' into lint
Conflicts:
manifests/db/mysql.pp
manifests/db/mysql/host_access.pp
manifests/keystone/auth.pp
Update some docs in the process
François Charlier [Mon, 22 Apr 2013 13:45:17 +0000 (15:45 +0200)]
Update tests to add DEFAULT/ to nova_config
Mathieu Gagné [Sun, 21 Apr 2013 21:46:58 +0000 (17:46 -0400)]
Fix notification relationship
Relationship was referring to Service[ceilometer] which does not exist.
Mathieu Gagné [Sun, 21 Apr 2013 21:43:27 +0000 (17:43 -0400)]
Update puppetdoc for ceilometer::keystone::auth
Mathieu Gagné [Sun, 21 Apr 2013 21:29:06 +0000 (17:29 -0400)]
Fix various puppet-lint errors and warnings
François Charlier [Sat, 20 Apr 2013 03:12:19 +0000 (05:12 +0200)]
Check that rabbit_hosts overrides rabbit_host|port
François Charlier [Sat, 20 Apr 2013 03:11:43 +0000 (05:11 +0200)]
Fix spec tests style
François Charlier [Sat, 20 Apr 2013 02:54:31 +0000 (04:54 +0200)]
Fix the ceilometer::client class
the client python library is python-ceilometerclient
• fix package name on Debian platforms
• fix Package resource name
François Charlier [Sat, 20 Apr 2013 02:30:56 +0000 (04:30 +0200)]
Remove the dbsync file, it's not used anymore
François Charlier [Sat, 20 Apr 2013 02:29:00 +0000 (04:29 +0200)]
Ensure passwords/secrets are specified by user
François Charlier [Sat, 20 Apr 2013 01:46:05 +0000 (03:46 +0200)]
Fix lint errors, add some documentation
François Charlier [Sat, 20 Apr 2013 01:10:45 +0000 (03:10 +0200)]
Merge remote-tracking branch 'mgagne/grizzly'
Mathieu Gagné [Fri, 19 Apr 2013 16:37:50 +0000 (12:37 -0400)]
Exclude 'master' branch from travis CI
'master' branch does not have the required files to make the build pass.
Mathieu Gagné [Fri, 19 Apr 2013 15:34:00 +0000 (11:34 -0400)]
Fix ceilometer client package name for Debian
The package name is python-ceilometerclient, not python-ceilometer.
python-ceilometer is a package providing python libraries required
by ceilometer to work.
Mathieu Gagné [Fri, 19 Apr 2013 15:25:46 +0000 (11:25 -0400)]
Add DEFAULT section to nova_config
nova_config now requires a section, add DEFAULT section.
François Charlier [Fri, 19 Apr 2013 08:24:31 +0000 (01:24 -0700)]
Merge pull request #3 from aimonb/inifile-scope-fix
inifile module now requires a section
Aimon Bustardo [Fri, 19 Apr 2013 08:00:37 +0000 (01:00 -0700)]
inifile module now requires a section
* Added DEFAULT where missing is compute class
Mathieu Gagné [Fri, 12 Apr 2013 16:26:41 +0000 (12:26 -0400)]
Update fixtures location to use stackforge.
Mathieu Gagné [Thu, 11 Apr 2013 18:50:54 +0000 (14:50 -0400)]
Remove rabbit_host/rabbit_port config when rabbit_hosts is provided
Mathieu Gagné [Thu, 11 Apr 2013 17:48:08 +0000 (13:48 -0400)]
Add rabbit_hosts parameter
Preserve rabbit_host parameter for backward compatibility
Mathieu Gagné [Mon, 8 Apr 2013 21:09:04 +0000 (17:09 -0400)]
Fix notification relationship with Service[nova-compute]
Was getting an error when applying ceilometer::agent::compute:
Could not find resource 'File_line[nova-notification-driver-common]
File_line[nova-notification-driver-ceilometer]' for relationship
on 'Service[nova-compute]'
Mathieu Gagné [Mon, 8 Apr 2013 20:45:25 +0000 (16:45 -0400)]
Fix Ubuntu support for ceilometer::agent::compute
The libvirt group is libvirtd on Ubuntu and libvirt on Debian.
Mathieu Gagné [Fri, 5 Apr 2013 16:01:38 +0000 (12:01 -0400)]
Fix service dependencies and add inheritance from ceilometer
Inheritance is required to modify User[ceilometer]
Mathieu Gagné [Fri, 5 Apr 2013 01:50:37 +0000 (21:50 -0400)]
Remove useless params
Mathieu Gagné [Fri, 5 Apr 2013 01:34:15 +0000 (21:34 -0400)]
Use implicit dependencies
Puppet has implicit dependencies:
- Users and Groups have an implicit dependency
- Implicitly orders users and groups
- Implicitly recognizes file hierarchy
- Implicitly creates relationship between file ownership and user resources
Mathieu Gagné [Fri, 5 Apr 2013 01:21:13 +0000 (21:21 -0400)]
Add rspec tests for ceilometer::keystone::auth
Mathieu Gagné [Fri, 5 Apr 2013 00:51:22 +0000 (20:51 -0400)]
Add rspec tests for ceilometer::db::mysql
Mathieu Gagné [Fri, 5 Apr 2013 00:44:41 +0000 (20:44 -0400)]
Fix dependencies and various typos
Mathieu Gagné [Fri, 5 Apr 2013 00:19:10 +0000 (20:19 -0400)]
Add rspec tests for ceilometer::collector
Mathieu Gagné [Fri, 5 Apr 2013 00:16:27 +0000 (20:16 -0400)]
Add rspec tests for ceilometer::client
Mathieu Gagné [Thu, 4 Apr 2013 23:51:49 +0000 (19:51 -0400)]
Remove inheritance from ceilometer
Mathieu Gagné [Thu, 4 Apr 2013 23:37:25 +0000 (19:37 -0400)]
Partially add support for RedHat plateform
Mathieu Gagné [Thu, 4 Apr 2013 21:53:52 +0000 (17:53 -0400)]
Add keystone_tenant parameter for api
Mathieu Gagné [Thu, 4 Apr 2013 21:40:02 +0000 (17:40 -0400)]
Add rspec tests for ceilometer and ceilometer::api
Mathieu Gagné [Wed, 3 Apr 2013 23:22:32 +0000 (19:22 -0400)]
Remove ceilometer-dbsync override
Mathieu Gagné [Wed, 3 Apr 2013 23:08:41 +0000 (19:08 -0400)]
Fix dependency syntax in Modulefile
François Charlier [Mon, 18 Mar 2013 13:56:49 +0000 (14:56 +0100)]
Remove version from endpoint.
The client has to specify it.
François Charlier [Mon, 18 Feb 2013 17:33:02 +0000 (18:33 +0100)]
Fix adding notification_driver parameters to the nova.conf
François Charlier [Mon, 18 Feb 2013 13:32:06 +0000 (14:32 +0100)]
Add required parameters to nova.conf
François Charlier [Thu, 10 Jan 2013 15:54:31 +0000 (16:54 +0100)]
Fix the auth_protocol keystone_authtoken parameter name
François Charlier [Thu, 10 Jan 2013 15:53:55 +0000 (16:53 +0100)]
Revert "Fix nova notifications"
This reverts commit
6c8b6630b0f671a055070c658e0e0d51350f8353 .
This has been fixed in the 2012.2.2 nova packages
François Charlier [Fri, 21 Dec 2012 22:41:15 +0000 (23:41 +0100)]
Fix order dependencies
François Charlier [Fri, 21 Dec 2012 22:39:43 +0000 (23:39 +0100)]
Fix nova notifications
Apply nova commit
670b3882 to get notifications on the right
control_exchange
François Charlier [Fri, 21 Dec 2012 13:49:33 +0000 (14:49 +0100)]
Fix glance exchange/topic to read notifications
One is a bad default value in ceilometer, waiting for the fix to be
merged.
The other is a bad value in Glance, fixed in Grizzly (maybe in 2012.2.3).
François Charlier [Thu, 20 Dec 2012 14:09:55 +0000 (15:09 +0100)]
Fix groups memberships for the ceilometer user
The ceilometer user must be member of libvirt group when the compute
agent is installed
François Charlier [Thu, 20 Dec 2012 14:09:08 +0000 (15:09 +0100)]
Agents, Api, Db & Collector classes inherit from ceilometer
François Charlier [Wed, 19 Dec 2012 23:34:45 +0000 (00:34 +0100)]
Add “log_dir” parameter
François Charlier [Wed, 19 Dec 2012 23:34:27 +0000 (00:34 +0100)]
The ceilometer user must be in the libvirt group
François Charlier [Wed, 19 Dec 2012 23:33:36 +0000 (00:33 +0100)]
Ensure services are started
… or not, depending on the parameter
François Charlier [Tue, 18 Dec 2012 17:58:37 +0000 (18:58 +0100)]
Update ceilometer user requirements
François Charlier [Mon, 17 Dec 2012 16:31:49 +0000 (17:31 +0100)]
Restart services when config file changes
François Charlier [Mon, 17 Dec 2012 16:31:19 +0000 (17:31 +0100)]
Rename default tenant to 'services' instead of 'service'
François Charlier [Mon, 17 Dec 2012 16:15:27 +0000 (17:15 +0100)]
Ceilometer_config requires package ceilometer-common
François Charlier [Mon, 17 Dec 2012 16:14:57 +0000 (17:14 +0100)]
Add user to localhost
François Charlier [Mon, 17 Dec 2012 16:13:00 +0000 (17:13 +0100)]
Fix $auth_user var name
François Charlier [Mon, 17 Dec 2012 15:10:53 +0000 (07:10 -0800)]
Merge pull request #1 from ekarlso/master
Add authentication options
Endre Karlson [Mon, 17 Dec 2012 01:45:58 +0000 (02:45 +0100)]
Forgot to pass the password also
Endre Karlson [Mon, 17 Dec 2012 01:43:31 +0000 (02:43 +0100)]
Only bother setting tenant_id if it's passed
Endre Karlson [Mon, 17 Dec 2012 01:38:13 +0000 (02:38 +0100)]
Fix duplicate opt
Endre Karlson [Mon, 17 Dec 2012 01:33:38 +0000 (02:33 +0100)]
Add authentication config opts
François Charlier [Fri, 14 Dec 2012 10:54:09 +0000 (11:54 +0100)]
Fix ownership/permissions on /etc/ceilometer/*
François Charlier [Fri, 14 Dec 2012 10:13:44 +0000 (11:13 +0100)]
Fix style
François Charlier [Fri, 14 Dec 2012 10:12:13 +0000 (11:12 +0100)]
Ensure the ceilometer user has ResellerAdmin role
Required to poll swift usage
François Charlier [Tue, 11 Dec 2012 17:35:54 +0000 (18:35 +0100)]
Add an example
François Charlier [Tue, 11 Dec 2012 17:18:16 +0000 (18:18 +0100)]
Update the dbsync_command
François Charlier [Tue, 11 Dec 2012 17:14:37 +0000 (18:14 +0100)]
Add the dbsync file, it's not yet in the packages
François Charlier [Tue, 11 Dec 2012 16:04:07 +0000 (17:04 +0100)]
Add the metering_secret parameter
François Charlier [Mon, 10 Dec 2012 17:33:33 +0000 (18:33 +0100)]
Default keystone_password to false to ensure error if not set
François Charlier [Mon, 10 Dec 2012 17:19:02 +0000 (18:19 +0100)]
Add admin user/tenant/password to authtoken config
François Charlier [Mon, 10 Dec 2012 17:00:20 +0000 (18:00 +0100)]
Remove wrong requirement for ceilometer-dbsync
François Charlier [Mon, 10 Dec 2012 16:56:10 +0000 (17:56 +0100)]
Fix incomplete subscribe declaration
François Charlier [Mon, 10 Dec 2012 16:31:18 +0000 (17:31 +0100)]
Fix user (group → gid)
François Charlier [Mon, 10 Dec 2012 16:29:37 +0000 (17:29 +0100)]
Fix the name of the ceilometer config provider
François Charlier [Mon, 10 Dec 2012 16:23:37 +0000 (17:23 +0100)]
Create ceilometer user/group
François Charlier [Mon, 10 Dec 2012 16:22:46 +0000 (17:22 +0100)]
Add ceilometer-dbsync and fix some db-related deps
François Charlier [Mon, 10 Dec 2012 15:53:39 +0000 (16:53 +0100)]
Refactoring/Style updates
François Charlier [Mon, 10 Dec 2012 15:52:40 +0000 (16:52 +0100)]
Move database settings to a different class
François Charlier [Mon, 10 Dec 2012 15:04:48 +0000 (16:04 +0100)]
Add dependencies into the Modulefile
François Charlier [Mon, 10 Dec 2012 14:58:20 +0000 (15:58 +0100)]
Finish moving Keystone Auth from init.pp to api.pp