]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log
adrianiurca [Thu, 8 Apr 2021 12:53:59 +0000 (15:53 +0300)]
mount kernel for docker container
Daniel Carabas [Fri, 2 Apr 2021 11:19:36 +0000 (14:19 +0300)]
PDK Update for release prep workflow
Adrian Iurca [Mon, 1 Mar 2021 15:41:06 +0000 (17:41 +0200)]
Merge pull request #973 from puppetlabs/release-prep
Release prep v3.0.0
GitHub Action [Mon, 1 Mar 2021 14:57:38 +0000 (14:57 +0000)]
Release prep v3.0.0
Paula Muir [Wed, 24 Feb 2021 21:33:19 +0000 (21:33 +0000)]
Merge pull request #977 from puppetlabs/pdksync_maint/main/deprecate_sles11
pdksync - (MAINT) Remove SLES 11 support
Ciaran McCrisken [Wed, 24 Feb 2021 17:04:19 +0000 (17:04 +0000)]
(MAINT) Remove SLES 11 support
Paula Muir [Wed, 24 Feb 2021 15:07:06 +0000 (15:07 +0000)]
Merge pull request #976 from puppetlabs/pdksync_maint/main/deprecate_rhel_5_family
pdksync - (MAINT) Remove RHEL 5 family support
Ciaran McCrisken [Wed, 24 Feb 2021 13:56:19 +0000 (13:56 +0000)]
(MAINT) Remove RHEL 5 OS family support
Michael T Lombardi (He/Him) [Tue, 23 Feb 2021 01:30:42 +0000 (19:30 -0600)]
Merge pull request #974 from puppetlabs/maint/main/update_dependency
(maint) Update major dependencies prior to release
Paula Muir [Mon, 22 Feb 2021 16:19:32 +0000 (16:19 +0000)]
(maint) Update major dependencies prior to release
David Schmitt [Thu, 18 Feb 2021 09:20:11 +0000 (09:20 +0000)]
Merge pull request #972 from puppetlabs/pdksync_remove_puppet5
pdksync - Remove Puppet 5 from testing and bump minimal version to 6.0.0
Daniel Carabas [Tue, 16 Feb 2021 17:19:03 +0000 (19:19 +0200)]
Add auto_release.yml to sync.yml
Daniel Carabas [Tue, 16 Feb 2021 13:36:49 +0000 (15:36 +0200)]
pdk update
Daniel Carabas [Tue, 16 Feb 2021 07:50:57 +0000 (09:50 +0200)]
Update .sync.yml
Daniel Carabas [Mon, 15 Feb 2021 15:36:25 +0000 (17:36 +0200)]
Bump minimal puppet version to 6.0.0 in metadata.json
Daniel Carabas [Mon, 15 Feb 2021 15:20:02 +0000 (17:20 +0200)]
Remove Puppet 5 testing
Disha-maker [Tue, 9 Feb 2021 18:43:03 +0000 (18:43 +0000)]
Merge pull request #970 from puppetlabs/release
Release merge back for v2.8.1 PR merged
sanfrancrisko [Tue, 9 Feb 2021 17:53:31 +0000 (17:53 +0000)]
Merge pull request #969 from Disha-maker/release
(IAC-1417) Release Prep version 2.8.1
Auto-release [Mon, 8 Feb 2021 17:13:30 +0000 (17:13 +0000)]
Release version 2.8.1
sanfrancrisko [Mon, 1 Feb 2021 09:46:10 +0000 (09:46 +0000)]
Merge pull request #968 from puppetlabs/pdksync_gha-updates
pdksync - Update gha templates
David Schmitt [Wed, 27 Jan 2021 09:33:31 +0000 (09:33 +0000)]
Remove obsolete rubocop annotations
David Schmitt [Tue, 26 Jan 2021 17:16:54 +0000 (17:16 +0000)]
(maint) Update github actions
sanfrancrisko [Mon, 11 Jan 2021 18:06:44 +0000 (18:06 +0000)]
Merge pull request #967 from adrianiurca/modules10907_avoid_remove_spaces
[MODULES-10907] Do not remove spaces from hex string with !
adrianiurca [Mon, 11 Jan 2021 17:17:48 +0000 (19:17 +0200)]
add acceptance test
adrianiurca [Mon, 11 Jan 2021 16:03:38 +0000 (18:03 +0200)]
avoid to remove spaces outside string hex
david22swan [Mon, 11 Jan 2021 09:25:43 +0000 (09:25 +0000)]
Merge pull request #964 from puppetlabs/pdksync
Update to puppet-module-gems 1.0, pdk-templates and new rubocop
TP Honey [Mon, 4 Jan 2021 14:04:23 +0000 (14:04 +0000)]
Merge pull request #966 from sheenaajay/oldworkflow
(maint) remove old workflow
David Schmitt [Mon, 4 Jan 2021 11:51:43 +0000 (11:51 +0000)]
Improve tests
David Schmitt [Mon, 4 Jan 2021 11:32:33 +0000 (11:32 +0000)]
Fix issues from the rubocop changes
David Schmitt [Wed, 16 Dec 2020 17:28:51 +0000 (17:28 +0000)]
Apply remaining rubocop fixes
David Schmitt [Wed, 16 Dec 2020 13:36:45 +0000 (13:36 +0000)]
Add all safe auto corrects
David Schmitt [Wed, 16 Dec 2020 13:36:32 +0000 (13:36 +0000)]
Add the FrozenStrings magic comment
David Schmitt [Wed, 16 Dec 2020 13:36:18 +0000 (13:36 +0000)]
Update to pdk-templates and puppet-module-gems 1.0.0
David Schmitt [Mon, 4 Jan 2021 11:59:09 +0000 (11:59 +0000)]
Merge pull request #963 from puppetlabs/release
Release merge-back 2.8.0
sheena [Mon, 4 Jan 2021 11:19:21 +0000 (11:19 +0000)]
(maint) remove old workflow
sanfrancrisko [Fri, 18 Dec 2020 13:54:19 +0000 (13:54 +0000)]
Merge pull request #965 from Disha-maker/IAC-1351/main/remove_rhel5_centos5
(IAC-1351) Remove CentOS 5 & RHEL 5 from provision.yaml file
Disha-maker [Fri, 18 Dec 2020 12:01:34 +0000 (12:01 +0000)]
(IAC-1351) Remove CentOS 5 & RHEL 5 from provision.yaml file
david22swan [Mon, 14 Dec 2020 11:50:17 +0000 (11:50 +0000)]
Merge pull request #962 from carabasdaniel/release280
Release-prep for version 2.8.0
Auto-release [Mon, 14 Dec 2020 09:43:27 +0000 (09:43 +0000)]
Release version 2.8.0
adrianiurca [Wed, 9 Dec 2020 09:28:13 +0000 (11:28 +0200)]
Merge branch 'pdksync_update_workflows' into main
adrianiurca [Wed, 2 Dec 2020 15:07:38 +0000 (17:07 +0200)]
pdksync: add GA workflows
sanfrancrisko [Mon, 7 Dec 2020 17:19:27 +0000 (17:19 +0000)]
Merge pull request #961 from puppetlabs/pdksync_remove_el6_tests
pdksync - Remove EL6 testing from Travis
Daniel Carabas [Mon, 7 Dec 2020 15:23:46 +0000 (17:23 +0200)]
Remove EL6 testing from Travis
david22swan [Mon, 7 Dec 2020 09:56:12 +0000 (09:56 +0000)]
Merge pull request #959 from puppetlabs/pdksync_bump_puppet7
pdksync - (feat) - Bump Puppet boundary
sanfrancrisko [Fri, 4 Dec 2020 14:14:33 +0000 (14:14 +0000)]
Merge pull request #941 from adrianiurca/add_acceptance_test
(IAC-966) - MODULES-10522: Add support for the --condition parameter
adrianiurca [Fri, 4 Dec 2020 13:36:24 +0000 (15:36 +0200)]
Merge branch 'add_acceptance_test' of github.com:adrianiurca/puppetlabs-firewall into add_acceptance_test
adrianiurca [Fri, 4 Dec 2020 13:34:38 +0000 (15:34 +0200)]
rename the filter to condition_parameter_test
Adrian Iurca [Fri, 4 Dec 2020 11:57:59 +0000 (13:57 +0200)]
Update lib/puppet/provider/firewall/iptables.rb
Co-authored-by: sanfrancrisko <55992494+sanfrancrisko@users.noreply.github.com>
Adrian Iurca [Fri, 4 Dec 2020 11:57:47 +0000 (13:57 +0200)]
Update README.md
Co-authored-by: sanfrancrisko <55992494+sanfrancrisko@users.noreply.github.com>
adrianiurca [Wed, 2 Sep 2020 06:51:29 +0000 (09:51 +0300)]
add aceptance test for condition parameter
Daiana_Mezdrea [Thu, 3 Dec 2020 14:34:11 +0000 (16:34 +0200)]
(feat) - Bump Puppet boundary
daianamezdrea [Thu, 26 Nov 2020 09:43:11 +0000 (11:43 +0200)]
Merge pull request #957 from puppetlabs/pdksync_add_centos_8_travis
(pdksync) - implement centos 8 on travis
Adrian Iurca [Wed, 25 Nov 2020 18:26:39 +0000 (20:26 +0200)]
Merge pull request #955 from puppetlabs/pdksync_maint/main/release_checks_7_config
pdksync - (maint) Add release_checks_7 config to provision.yaml
adrianiurca [Wed, 25 Nov 2020 18:25:50 +0000 (20:25 +0200)]
(pdksync) - implement centos 8 on travis
Adrian Iurca [Wed, 25 Nov 2020 17:42:39 +0000 (19:42 +0200)]
Merge branch 'main' into pdksync_maint/main/release_checks_7_config
Paula Muir [Wed, 25 Nov 2020 17:36:07 +0000 (17:36 +0000)]
Merge pull request #956 from puppetlabs/pdksyng_travis_centos_8
(pdksync) - implement centos 8 on travis
Adrian Iurca [Wed, 25 Nov 2020 16:58:26 +0000 (18:58 +0200)]
Merge branch 'main' into pdksyng_travis_centos_8
adrianiurca [Wed, 25 Nov 2020 16:44:27 +0000 (18:44 +0200)]
(pdksync) - implement centos 8 on travis
carabasdaniel [Wed, 25 Nov 2020 15:04:23 +0000 (17:04 +0200)]
Merge pull request #954 from puppetlabs/iac894-fails-centos8-docker
(IAC-894) - change hashlimit_htable_size to a lower value
adrianiurca [Mon, 23 Nov 2020 22:32:10 +0000 (00:32 +0200)]
change hashlimit_htable_size to a lower value and add policycoreutils
Ciaran McCrisken [Wed, 25 Nov 2020 13:28:27 +0000 (13:28 +0000)]
(maint) Add release_checks_7 config to provision.yaml
David Swan [Tue, 16 Jun 2020 15:24:49 +0000 (16:24 +0100)]
(IAC-890) - Implement CentOS 8 travis tests
David Schmitt [Wed, 18 Nov 2020 13:15:20 +0000 (13:15 +0000)]
Merge pull request #952 from puppetlabs/pdksync_gitpod
pdksync - Update pdk-templates for gitpod and codespaces support
David Schmitt [Tue, 17 Nov 2020 21:22:26 +0000 (21:22 +0000)]
Update pdk-templates for gitpod and codespaces support
daianamezdrea [Tue, 17 Nov 2020 10:39:23 +0000 (12:39 +0200)]
Merge pull request #950 from puppetlabs/skip_bytecode_test_oracle7
(IAC-1025) - skip bytecode test on oracle 7
David Schmitt [Tue, 17 Nov 2020 09:29:06 +0000 (09:29 +0000)]
Merge pull request #951 from puppetlabs/readd-copyright
Restore copyright names
adrianiurca [Mon, 16 Nov 2020 21:23:30 +0000 (23:23 +0200)]
change name to fetch_os_name
Adrian Iurca [Mon, 16 Nov 2020 21:09:28 +0000 (23:09 +0200)]
Update spec/spec_helper_acceptance_local.rb
Co-authored-by: David Schmitt <david.schmitt@puppet.com>
Hunter Haugen [Mon, 16 Nov 2020 19:07:40 +0000 (11:07 -0800)]
Restore copyright names
The copyright names were incorrectly removed by
00a1f3fb0369f5b4ca474a681114fbfd8c9f81bf as part of a modulesync
adrianiurca [Mon, 16 Nov 2020 13:20:01 +0000 (15:20 +0200)]
skip bytecode test on oracle 7
daianamezdrea [Mon, 2 Nov 2020 12:06:56 +0000 (14:06 +0200)]
Merge pull request #949 from puppetlabs/release
Release 2.7.0 merge back
Auto-release [Thu, 15 Oct 2020 10:57:07 +0000 (10:57 +0000)]
Release version 2.7.0
daianamezdrea [Wed, 14 Oct 2020 09:46:11 +0000 (12:46 +0300)]
Merge pull request #948 from DavidS/iac-1190-ignore_foreign
(IAC-1190) add `ignore_foreign` when purging firewallchains
David Schmitt [Fri, 9 Oct 2020 10:27:06 +0000 (11:27 +0100)]
(IAC-1190) add `ignore_foreign` when purging firewallchains
This stops `firewallchains` from purging rules that do not look
like rules the module puts into place. This capability can be used
to co-exist with other firewall management solutions on the same
machine.
Improved flow in the README around setting up purging, make it
a user decision to enable, and add a pointer to `ignore_foreign`.
david22swan [Mon, 5 Oct 2020 15:00:14 +0000 (16:00 +0100)]
Merge pull request #946 from puppetlabs/release
Release mergeback version 2.6.0
David Swan [Thu, 1 Oct 2020 13:14:52 +0000 (14:14 +0100)]
Release Version 2.6.0
Adrian Iurca [Thu, 1 Oct 2020 12:15:23 +0000 (15:15 +0300)]
Merge pull request #943 from jcpunk/puppet-lint
Resolve puppet-lint notices
Adrian Iurca [Thu, 1 Oct 2020 12:04:58 +0000 (15:04 +0300)]
Merge pull request #944 from IBBoard/patch-1
Fix extra quotes in firewall string matching
IBBoard [Sat, 26 Sep 2020 18:33:00 +0000 (19:33 +0100)]
Fix fixture tests
ARGS_TO_HASH was correct (unquoted) but HASH_TO_ARGS
contained the rogue single quotes
IBBoard [Wed, 23 Sep 2020 19:58:09 +0000 (20:58 +0100)]
Fix extra quotes in firewall string matching
As reported by Steve Traylon[1] and @patricknelson[2], the munging adds extra quotes to the string.
This breaks the string matching in iptables, as it looks for literal single quotes in the match.
Removing the munging fixes this.
[1] https://tickets.puppetlabs.com/browse/MODULES-3454?focusedCommentId=686988&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-686988
[2] https://github.com/puppetlabs/puppetlabs-firewall/commit/
3655c6bd33d662a3813c2f66cd0bc5889c68c2c2 #diff-379160b60a9bdf297b92a51d20efd8c3R1426
Pat Riehecky [Tue, 22 Sep 2020 18:47:41 +0000 (13:47 -0500)]
Resolve simple puppet-lint items
Adrian Iurca [Tue, 15 Sep 2020 08:34:42 +0000 (11:34 +0300)]
Merge pull request #942 from david22swan/IAC-987
(IAC-987) - Removal of inappropriate terminology
David Swan [Mon, 14 Sep 2020 14:57:49 +0000 (15:57 +0100)]
(maint) - Removal of legacy nodesets
David Swan [Mon, 14 Sep 2020 14:57:29 +0000 (15:57 +0100)]
(IAC-987) - Removal of inappropriate terminology
Samuli Seppänen [Fri, 31 Jan 2020 10:03:11 +0000 (12:03 +0200)]
MODULES-10522: Add support for the --condition parameter
Adrian Iurca [Mon, 10 Aug 2020 11:28:38 +0000 (14:28 +0300)]
Merge pull request #937 from operasoftware-osp/provider-regression
Fix problem with parsing rules without quotes
david22swan [Thu, 6 Aug 2020 09:54:58 +0000 (10:54 +0100)]
Merge pull request #938 from sanfrancrisko/fix/spec_helper_method
(IAC-1025) Fix spec test helper method
Ciaran McCrisken [Wed, 5 Aug 2020 16:13:09 +0000 (17:13 +0100)]
(IAC-1025) Fix spec test helper method
Tests failing on RHEL systems as the `install_iptables` method
always assumed it was running against Debian / Ubuntu.
Łukasz Czapliński [Wed, 5 Aug 2020 15:13:44 +0000 (17:13 +0200)]
Fix problem with parsing rules without quotes
Adrian Iurca [Tue, 4 Aug 2020 10:18:37 +0000 (13:18 +0300)]
Merge pull request #933 from puppetlabs/pdksync_IAC-973
pdksync - (IAC-973) - Update travis/appveyor to run on new default branch main
David Swan [Tue, 4 Aug 2020 09:51:48 +0000 (10:51 +0100)]
(IAC-973) - Update travis/appveyor to run on new default branch main
Adrian Iurca [Tue, 28 Jul 2020 17:05:44 +0000 (20:05 +0300)]
Merge pull request #932 from puppetlabs/release
Release prep version 2.5.0
Auto-release [Tue, 28 Jul 2020 13:26:56 +0000 (13:26 +0000)]
Release version 2.5.0
daianamezdrea [Wed, 22 Jul 2020 09:25:13 +0000 (12:25 +0300)]
Merge pull request #931 from adrianiurca/add_acceptance_and_unit_test
Add acceptance and unit test
Adrian Iurca [Wed, 22 Jul 2020 08:53:36 +0000 (11:53 +0300)]
Update firewall.rb
Adrian Iurca [Wed, 22 Jul 2020 08:50:18 +0000 (11:50 +0300)]
Update spec_helper_acceptance_local.rb
adrianiurca [Thu, 16 Jul 2020 16:10:31 +0000 (19:10 +0300)]
Add acceptance and unit test for notrack parameter
Jesper Brix Rosenkilde [Thu, 26 Mar 2020 07:57:53 +0000 (08:57 +0100)]
Fix RuboCop offence
Jesper Brix Rosenkilde [Tue, 24 Mar 2020 15:52:20 +0000 (16:52 +0100)]
Add --notrack flag
sanfrancrisko [Thu, 16 Jul 2020 10:14:19 +0000 (11:14 +0100)]
Merge pull request #930 from adrianiurca/add_acceptance_test_hex_string
[IAC-899] - Add acceptance test for string_hex parameter