]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log
Hailee Kenney [Mon, 18 Sep 2017 21:55:42 +0000 (14:55 -0700)]
(maint) modulesync
892c4cf
Paula McMaw [Fri, 8 Sep 2017 11:33:35 +0000 (12:33 +0100)]
Merge pull request #717 from tphoney/dummy_pr
remove whitespace at the EOL
Paula McMaw [Wed, 6 Sep 2017 13:25:06 +0000 (14:25 +0100)]
Merge pull request #719 from HelenCampbell/hashlimitfix
Update for hashlimit tests to not run on RedHat5 or Scientific 5
Helen Campbell [Wed, 6 Sep 2017 12:37:42 +0000 (13:37 +0100)]
Update for hashlimit tests to not run on RedHat5 or Scientific 5
Hashlimit doesn't seem to be fully supported on these OS'es so I've put a check to skip the tests.
TP Honey [Tue, 5 Sep 2017 14:13:30 +0000 (15:13 +0100)]
Merge pull request #718 from HelenCampbell/hashlimitfix
Yet another fix to hashlimit tests, smaller tests replace one large r…
Helen Campbell [Tue, 5 Sep 2017 13:27:34 +0000 (14:27 +0100)]
Yet another fix to hashlimit tests, smaller tests replace one large regex for match improvements.
TP Honey [Tue, 5 Sep 2017 09:58:26 +0000 (10:58 +0100)]
Merge pull request #716 from HelenCampbell/hashlimitfix
Fix to update hashlimit above test
Helen Campbell [Tue, 5 Sep 2017 08:50:28 +0000 (09:50 +0100)]
Unit test fix for travis
tphoney [Mon, 4 Sep 2017 14:48:05 +0000 (15:48 +0100)]
remove whitespace at the EOL
Helen Campbell [Mon, 4 Sep 2017 14:15:01 +0000 (15:15 +0100)]
Fix to update hashlimit above test
Helen [Tue, 29 Aug 2017 13:25:49 +0000 (14:25 +0100)]
Merge pull request #708 from ATIX-AG/master
MODULE-1805 Add hashlimit-module
TP Honey [Thu, 17 Aug 2017 14:34:00 +0000 (15:34 +0100)]
Merge pull request #715 from pmcmaw/rm_ubuntu
(MODULES-5501) - Remove unsupported Ubuntu
Paula McMaw [Thu, 17 Aug 2017 12:59:57 +0000 (13:59 +0100)]
(MODULES-5501) - Remove unsupported Ubuntu
Removing older version of Ubuntu that are not supported by the module.
Eric Putnam [Wed, 16 Aug 2017 21:54:15 +0000 (14:54 -0700)]
Merge pull request #713 from nbarrientos/sets
(MODULES-5340) Understand negated match sets
Nacho Barrientos [Thu, 27 Jul 2017 08:55:33 +0000 (10:55 +0200)]
(MODULES-5340) Understand negated match sets
This patch allows the provider to understand rules that contain negated
match sets when parsing the ruleset.
Paula McMaw [Fri, 28 Jul 2017 10:00:40 +0000 (11:00 +0100)]
Merge pull request #714 from puppetlabs/maint-modsync-
915cde70e20
(maint) modulesync
915cde70e20
Glenn Sarti [Thu, 27 Jul 2017 21:56:16 +0000 (14:56 -0700)]
(maint) modulesync
915cde70e20
Hunter Haugen [Mon, 10 Jul 2017 21:46:41 +0000 (14:46 -0700)]
Merge pull request #712 from puppetlabs/msync_modules5187
(MODULES-5187) mysnc puppet 5 and ruby 2.4
Eric Putnam [Thu, 6 Jul 2017 21:41:16 +0000 (14:41 -0700)]
(MODULES-5187) mysnc puppet 5 and ruby 2.4
Paula McMaw [Thu, 6 Jul 2017 08:59:43 +0000 (09:59 +0100)]
Merge pull request #711 from tphoney/MODULES-5177
(MODULES-5177) fixing tests for certain oses
tphoney [Wed, 5 Jul 2017 13:07:22 +0000 (14:07 +0100)]
(MODULES-5177) fixing tests for certain oses
Helen [Tue, 4 Jul 2017 15:43:50 +0000 (16:43 +0100)]
Merge pull request #710 from tphoney/MODULES-5173
(MODULES-5173) fix regex and test on el6
tphoney [Tue, 4 Jul 2017 14:13:06 +0000 (15:13 +0100)]
(MODULES-5173) fix regex and test on el6
TP Honey [Mon, 3 Jul 2017 11:31:53 +0000 (12:31 +0100)]
Merge pull request #709 from hunner/bump_metadata
(MODULES-5144) Prep for puppet 5
TP Honey [Mon, 3 Jul 2017 11:31:18 +0000 (12:31 +0100)]
Merge pull request #696 from traylenator/style
Puppet Lint Fixes
Hunter Haugen [Mon, 26 Jun 2017 21:04:54 +0000 (14:04 -0700)]
(MODULES-5144) Prep for puppet 5
Jonas Truestedt [Thu, 22 Jun 2017 08:27:22 +0000 (10:27 +0200)]
updated README for hashlimit-module
Jonas Truestedt [Thu, 22 Jun 2017 08:00:36 +0000 (10:00 +0200)]
added hashlimit-module for iptables & ip6tables with simple acceptance test
Helen [Wed, 21 Jun 2017 08:57:17 +0000 (09:57 +0100)]
Merge pull request #707 from spynappels/MODULES-5111-support_untracked_state
(MODULES-5111) Support UNTRACKED in state and ctstate rules
Stefan Pijnappels [Wed, 21 Jun 2017 06:16:36 +0000 (07:16 +0100)]
(MODULES-5111) Support UNTRACKED in state and ctstate rules
Type updated to permit UNTRACKED to be passed as a valid state
README updated to document above change
Spec tests updated to verify UNTRACKED is accepted for both state and ctstate, and additionally to verify alphabetic ordering still works as expected.
All tests relating to these changes have passed.
Hunter Haugen [Thu, 15 Jun 2017 17:34:36 +0000 (10:34 -0700)]
Merge pull request #698 from Kotty666/master
Philipp Frik [Wed, 3 May 2017 08:41:59 +0000 (10:41 +0200)]
fix MODULES-1988
Hunter Haugen [Thu, 15 Jun 2017 17:10:43 +0000 (10:10 -0700)]
Merge pull request #706 from alexharv074/fix_readme
commit
95f56586a6506ce4c0460106483a7982fbaf4e05
Author: Alex Harvey <Alex_Harvey@amp.com.au>
Date: Sun Jun 11 22:47:18 2017 +1000
Add test for README
This adds an Rspec test to fail the build if someone adds incorrectly
formatted heading markers again.
commit
b7b62ec28f9999ca499440838d26733aab530eb8
Author: Alex Harvey <Alex_Harvey@amp.com.au>
Date: Sun Jun 11 22:31:33 2017 +1000
(doc) Fix formatting in README.markdown
Without this patch applied, a large chunk of the README is not
displaying properly on Github.
Alex Harvey [Sun, 11 Jun 2017 12:47:18 +0000 (22:47 +1000)]
Add test for README
This adds an Rspec test to fail the build if someone adds incorrectly
formatted heading markers again.
Alex Harvey [Sun, 11 Jun 2017 12:31:33 +0000 (22:31 +1000)]
(doc) Fix formatting in README.markdown
Without this patch applied, a large chunk of the README is not
displaying properly on Github.
Helen [Tue, 23 May 2017 15:08:35 +0000 (16:08 +0100)]
Merge pull request #705 from spynappels/MODULES-1141-Error_on_ICMP_array
(Modules-1141) No longer accepts an array for icmp types #puppethack
Stefan Pijnappels [Tue, 23 May 2017 14:31:34 +0000 (15:31 +0100)]
(MODULES-1141) Update Unit test to fix failing rspec test
Helen [Tue, 23 May 2017 13:41:35 +0000 (14:41 +0100)]
Merge pull request #704 from neilbinney/MODULES-4828
MODULES-4828 version_requirement updated
Neil Binney [Tue, 23 May 2017 13:13:18 +0000 (14:13 +0100)]
MODULES-4828 version_requirement updated
Stefan Pijnappels [Tue, 23 May 2017 12:35:44 +0000 (13:35 +0100)]
(MODULES-1141) Fail on sending array of ICMP types
Glenn Sarti [Tue, 16 May 2017 17:14:15 +0000 (10:14 -0700)]
Merge pull request #701 from eputnam/maint/nflog_osversion
(maint) do not test nflog on older versions of iptables ( < 1.3.7)
Eric Putnam [Thu, 11 May 2017 18:24:36 +0000 (11:24 -0700)]
(maint) update nflog feature and tests
NFLOG is not available as a jump target until iptables version 1.3.7.
This adds an error to the provider when the version is lower than 1.3.7
and the user tries to use NFLOG options. This also updates the tests to
check and make sure the error is thrown on appropriate versions
Hunter Haugen [Wed, 10 May 2017 18:01:15 +0000 (11:01 -0700)]
Merge pull request #700 from eputnam/maint/spec_space
(maint) modify to account for spaces in iptables-save output
Eric Putnam [Wed, 10 May 2017 17:58:41 +0000 (10:58 -0700)]
(maint) modify to account for spaces in iptables-save output
for nflog_spec we check iptables-save output and for --nflog-prefix, there can be varying amounts of space, so this accounts for that
Helen [Wed, 10 May 2017 16:04:45 +0000 (17:04 +0100)]
Merge pull request #697 from eputnam/FM-4896
(FM-4896) add NFLOG support
Eric Putnam [Thu, 4 May 2017 17:39:33 +0000 (10:39 -0700)]
Merge pull request #684 from hunner/check-ebtables
Allow managing ebtables
Eric Putnam [Wed, 3 May 2017 20:17:21 +0000 (13:17 -0700)]
(FM-4896) add NFLOG support
This adds four new features to the firewall type: nflog_groups, _range, _prefix, and _threshold. Unit tests and acceptance tests were also added.
Steve Traylen [Tue, 2 May 2017 13:59:28 +0000 (15:59 +0200)]
Puppet Lint Fixes
Hunter Haugen [Fri, 28 Apr 2017 23:20:48 +0000 (16:20 -0700)]
Merge pull request #695 from blackknight36/firewalld_fix
Change - Ensure that firewalld is stopped before iptables starts
Michael Watters [Fri, 14 Apr 2017 20:41:46 +0000 (16:41 -0400)]
Change - Ensure that firewalld is stopped before iptables starts
firewalld must be stopped and disabled before the iptables service
will start properly.
Hunter Haugen [Tue, 4 Apr 2017 17:17:19 +0000 (10:17 -0700)]
Merge pull request #693 from vshn/mhu/fix_negated_physdev
Properly handle negated `--physdev-is-...` rules
Manuel Hutter [Mon, 3 Apr 2017 13:33:41 +0000 (15:33 +0200)]
Properly handle negated `--physdev-is-...` rules
Paula McMaw [Mon, 27 Mar 2017 12:39:21 +0000 (13:39 +0100)]
Merge pull request #691 from puppetlabs/modules-4528
modulesync e25ca9 - Add locales folder and config.yaml,
f4160bf replace version comparisons unnafected by MODULES-4528 to use versioncmp
Wilson McCoubrey [Thu, 16 Mar 2017 15:50:04 +0000 (15:50 +0000)]
[maint] modulesync e25ca9 - Add locales folder and config.yaml,
f4160bf replace version comparisons unnafected by MODULES-4528 to use versioncmp
Wilson McCoubrey [Tue, 21 Mar 2017 15:21:01 +0000 (15:21 +0000)]
Fix typo in spec tests
Hunter Haugen [Mon, 20 Mar 2017 18:01:52 +0000 (11:01 -0700)]
Merge pull request #690 from jg-development/master
MODULES-4279 use complete option for geoip
Hailee Kenney [Mon, 20 Mar 2017 14:02:51 +0000 (14:02 +0000)]
Merge pull request #689 from puppetlabs/MODULES-4528
[MODULES-4528] Replace Puppet.version.to_f with Puppet::Util::Package.versioncmp
Jan Gantzert [Sat, 18 Mar 2017 10:16:14 +0000 (11:16 +0100)]
MODULES-4279 use complete option for geoip
Wilson McCoubrey [Thu, 16 Mar 2017 15:50:04 +0000 (15:50 +0000)]
(maint) Replace version comparisons unnafected by MODULES-4528 to use versioncmp
For sake of consistency
Wilson McCoubrey [Thu, 16 Mar 2017 11:35:57 +0000 (11:35 +0000)]
[MODULES-4528] Replace Puppet.version.to_f with Puppet::Util::Package.versioncmp
Hunter Haugen [Thu, 9 Feb 2017 17:17:39 +0000 (09:17 -0800)]
Add docs and tests
Hunter Haugen [Mon, 13 Mar 2017 22:21:49 +0000 (15:21 -0700)]
Merge pull request #686 from blackknight36/selinux_fix
Change - Ensure that the iptables configuration file has proper context
Paula McMaw [Mon, 13 Mar 2017 10:18:27 +0000 (10:18 +0000)]
Merge pull request #688 from wilson208/ci_fix
[MODULES-4234] Move physdev_is_in and physdev_is_out tests
Wilson McCoubrey [Mon, 13 Mar 2017 08:41:47 +0000 (08:41 +0000)]
[MODULES-4234] Move physdev_is_in and physdev_is_out tests
To block of 'ip6tables physdev tests' which do not run on EL5 or SLES 10.
Michael Watters [Tue, 21 Feb 2017 15:04:00 +0000 (10:04 -0500)]
Change - Ensure that the iptables configuration file has proper context
The SELinux context for the iptables configuration file was not being set
properly on Redhat based platforms. The default context for this file
is 'system_u:object_r:system_conf_t:s0' which is shown by using the restorecon command.
Hunter Haugen [Wed, 8 Mar 2017 21:20:56 +0000 (13:20 -0800)]
Merge pull request #685 from mhutter/ticket/4234-fix-physdev
(MODULES-4234) Add support for --physdev-is-{in,out}
Manuel Hutter [Thu, 16 Feb 2017 08:44:31 +0000 (09:44 +0100)]
(MODULES-4234) Add support for physdev-is-{in,out}
Peter Wienemann [Fri, 27 Jan 2017 19:46:03 +0000 (20:46 +0100)]
[MODULES-4249] Introduce class parameter ebtables_manage
If set to true, it ensures that firewallchain resources work for the
ethernet protocol (default: false)
Hunter Haugen [Thu, 26 Jan 2017 17:45:36 +0000 (09:45 -0800)]
Merge pull request #680 from jg-development/master
MODULES-4279 Add support for the geoip module
Eric Putnam [Fri, 20 Jan 2017 20:40:03 +0000 (12:40 -0800)]
Merge pull request #681 from puppetlabs/hunner_msync
(MODULES-4098) Sync the rest of the files
Hunter Haugen [Fri, 20 Jan 2017 00:13:05 +0000 (16:13 -0800)]
(MODULES-4098) Sync the rest of the files
Eric Putnam [Fri, 13 Jan 2017 23:26:00 +0000 (15:26 -0800)]
Merge pull request #675 from puppetlabs/hunner_msync
(MODULES-4097) Sync travis.yml
Jan Gantzert [Thu, 12 Jan 2017 20:17:13 +0000 (21:17 +0100)]
MODULES-4279 Add support for the geoip module
Eric Putnam [Wed, 11 Jan 2017 14:47:30 +0000 (09:47 -0500)]
Merge pull request #679 from puppetlabs/implement-beaker-module_install_helper
[MODULES-4224] Implement beaker-module_install_helper
Hunter Haugen [Thu, 5 Jan 2017 23:31:17 +0000 (15:31 -0800)]
(MODULES-4097) Sync travis.yml
Wilson McCoubrey [Tue, 10 Jan 2017 11:42:40 +0000 (11:42 +0000)]
[MODULES-4224] Implement beaker-module_install_helper
Gemfile updated by modulesync PR: puppetlabs/modulesync_configs#122
Wilson McCoubrey [Tue, 10 Jan 2017 10:55:14 +0000 (10:55 +0000)]
Merge pull request #678 from puppetlabs/release
1.8.2 Release Mergeback
Eric Putnam [Mon, 9 Jan 2017 14:39:35 +0000 (09:39 -0500)]
Merge pull request #677 from wilson208/182-release-prep
Use only minor version bump for release 1.8.2, keep puppet 3 requirement
Wilson McCoubrey [Mon, 9 Jan 2017 14:00:15 +0000 (14:00 +0000)]
Use only minor version bump for release 1.8.2, keep puppet 3 requirement
David Schmitt [Fri, 6 Jan 2017 13:43:25 +0000 (13:43 +0000)]
Merge pull request #676 from wilson208/182-release-prep
Change from minor version bump to major version bump
Wilson McCoubrey [Fri, 6 Jan 2017 12:53:23 +0000 (12:53 +0000)]
Change from minor version bump to major version bump
Because of changing dependency on puppet to >= 4.0.0
Helen [Wed, 4 Jan 2017 17:28:24 +0000 (17:28 +0000)]
Merge pull request #673 from wilson208/182-release-prep
Prep for supported release 1.8.2
Wilson McCoubrey [Tue, 3 Jan 2017 17:39:18 +0000 (17:39 +0000)]
Prep for supported release 1.8.2
David Schmitt [Tue, 3 Jan 2017 17:00:47 +0000 (17:00 +0000)]
Merge pull request #672 from wilson208/rhel-fix
Fixes ip6tables errors on RHEL 6/7
Wilson McCoubrey [Tue, 3 Jan 2017 16:33:27 +0000 (16:33 +0000)]
Fixes ip6tables errors on RHEL 6/7
Caused through merge of PR's #658 and then subsequently this older PR #641
Rob Reynolds [Wed, 28 Dec 2016 16:35:07 +0000 (10:35 -0600)]
Merge pull request #671 from wilson208/lint-fix
Add RHEL7 SELinux support for new service_name_v6 param, subsequently fix puppet lint error
Wilson McCoubrey [Wed, 28 Dec 2016 12:01:58 +0000 (12:01 +0000)]
Fix SELinux support for service_name_v6 param
TP Honey [Fri, 23 Dec 2016 12:21:35 +0000 (12:21 +0000)]
Merge pull request #646 from kindred/master
Fixing issue with double quotes being removed when part of the comment
TP Honey [Fri, 23 Dec 2016 12:08:35 +0000 (12:08 +0000)]
Merge pull request #650 from pimpolderman/patch-2
ip6tables_version fact doesn't return the version
Marco Fretz [Fri, 23 Dec 2016 12:05:57 +0000 (13:05 +0100)]
(MODULES-3572) Ip6tables service is not managed in the redhat family. (#641)
* Manage ip6tables service in RHEL. Add parameter to specify service_name for iptables and ip6tables. update README
For the redhat OS family the service for managing ip6tables is called
ip6tables. This service is currently not managed with this module.
This commit fixes this issue by introducing an additional parameter
$service_name_v6 for the ipv6 version of the service.
* remove validate_string, no stdlib
TP Honey [Fri, 23 Dec 2016 11:55:33 +0000 (11:55 +0000)]
Merge pull request #647 from mwhahaha/iptables-wait
Add --wait to iptables commands
Hunter Haugen [Thu, 15 Dec 2016 16:18:35 +0000 (08:18 -0800)]
Merge pull request #669 from puppetlabs/modsync
(FM-5972) gettext and spec.opts
Eric Putnam [Wed, 14 Dec 2016 21:28:51 +0000 (13:28 -0800)]
gettext and spec.opts
Bryan Jen [Tue, 13 Dec 2016 18:37:08 +0000 (11:37 -0700)]
Merge pull request #667 from genebean/ticket/MODULES-1222_containment
[#puppethack] MODULES-1222 - added containment
Gene Liverman [Tue, 13 Dec 2016 18:08:11 +0000 (13:08 -0500)]
MODULES-1222 - added containment
David Schmitt [Wed, 7 Dec 2016 17:08:20 +0000 (17:08 +0000)]
Merge pull request #661 from puppetlabs/hunner_msync
(MODULES-3631) msync Gemfile for 1.9 frozen strings
Hunter Haugen [Wed, 7 Dec 2016 00:20:44 +0000 (16:20 -0800)]
Merge pull request #665 from eputnam/specopts
(FM-5939) removes spec.opts
Eric Putnam [Tue, 6 Dec 2016 23:45:24 +0000 (15:45 -0800)]
removes spec.opts
Hunter Haugen [Fri, 2 Dec 2016 20:59:28 +0000 (12:59 -0800)]
Merge pull request #664 from bmjen/fix-ci
Fixes SELinux compatibility with EL6
Bryan Jen [Fri, 2 Dec 2016 20:18:14 +0000 (20:18 +0000)]
Fixes SELinux compatibility with EL6