]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log
Travis Fields [Tue, 16 Dec 2014 22:29:09 +0000 (14:29 -0800)]
Merge pull request #443 from mhaskel/1.3.0-prep
1.3.0 prep
Morgan Haskel [Tue, 16 Dec 2014 22:05:54 +0000 (14:05 -0800)]
1.3.0 prep
Morgan Haskel [Tue, 16 Dec 2014 01:15:36 +0000 (17:15 -0800)]
Merge pull request #427 from stesie/fix-set_mark-limit
Don't arbitrarily limit set_mark to certain chains
Colleen Murphy [Tue, 16 Dec 2014 01:11:46 +0000 (17:11 -0800)]
Merge pull request #442 from mhaskel/MODULES-556
MODULES-556: tcp_flags support for ip6tables
Morgan Haskel [Tue, 16 Dec 2014 01:05:23 +0000 (17:05 -0800)]
MODULES-556: tcp_flags support for ip6tables
tcp_flags was listed as a supported feature for the ip6tables provider,
but it wasn't actually implemented
Morgan Haskel [Fri, 12 Dec 2014 21:05:29 +0000 (13:05 -0800)]
Merge pull request #434 from cyberious/master
FM-2022 Add SLES 12 to metadata
Morgan Haskel [Fri, 12 Dec 2014 21:02:16 +0000 (13:02 -0800)]
Merge pull request #437 from alexjurkiewicz/master
README cosmetics
Colleen Murphy [Fri, 12 Dec 2014 20:49:38 +0000 (12:49 -0800)]
Merge pull request #441 from mhaskel/MODULES-1572
MODULES-1572 - Fix logic broken from MODULES-1309
Morgan Haskel [Fri, 12 Dec 2014 20:21:48 +0000 (12:21 -0800)]
MODULES-1572 - Fix logic broken from MODULES-1309
Accidentally changed some behavior and broke things with the fix for
MODULES-1309
Morgan Haskel [Tue, 9 Dec 2014 16:21:39 +0000 (08:21 -0800)]
Merge pull request #439 from cmurphy/master
Update .travis.yml, Gemfile, Rakefile, and CONTRIBUTING.md
Colleen Murphy [Tue, 9 Dec 2014 06:52:14 +0000 (22:52 -0800)]
Add json gem
The puppet_facts gem implicitly depends on the json gem.
On Ruby 1.8.7, json is not built in. On Puppet 2.7, it is
not explicitly pulled in by the hiera gem. So we add it
here explicitly.
Colleen Murphy [Mon, 8 Dec 2014 18:23:24 +0000 (10:23 -0800)]
Update .travis.yml, Gemfile, Rakefile, and CONTRIBUTING.md
Colleen Murphy [Thu, 4 Dec 2014 17:01:56 +0000 (09:01 -0800)]
Merge pull request #438 from mhaskel/MODULES-1565
MODULES-1565 - Fix regexes for EL5
Morgan Haskel [Thu, 4 Dec 2014 16:07:00 +0000 (11:07 -0500)]
MODULES-1565 - Fix regexes for EL5
iptables outputs are slightly different in EL5. Update the regexes to
account for this.
Alex Jurkiewicz [Thu, 4 Dec 2014 04:51:41 +0000 (15:51 +1100)]
README cosmetics
Hunter Haugen [Wed, 3 Dec 2014 23:20:56 +0000 (15:20 -0800)]
Merge pull request #436 from mhaskel/MODULES-1309
MODULES-1309 - Make package and service names configurable
Morgan Haskel [Wed, 3 Dec 2014 21:11:00 +0000 (16:11 -0500)]
MODULES-1309 - Make package and service names configurable
This was motivated by a need to make this work on Debian Jessie.
Colleen Murphy [Wed, 3 Dec 2014 17:44:25 +0000 (09:44 -0800)]
Merge pull request #435 from mhaskel/squash_433
MODULES-1469 MODULES-1470 Support alias (eth0:0), negation for iniface, ...
Hugh Esco [Mon, 10 Nov 2014 18:31:48 +0000 (13:31 -0500)]
MODULES-1469 MODULES-1470 Support alias (eth0:0), negation for iniface, outiface
Travis Fields [Fri, 21 Nov 2014 22:06:41 +0000 (17:06 -0500)]
FM-2022 Add SLES 12 to metadata
Travis Fields [Tue, 4 Nov 2014 23:16:16 +0000 (15:16 -0800)]
Merge pull request #432 from mhaskel/test
Merge 1.2.x into master
Morgan Haskel [Tue, 4 Nov 2014 23:02:33 +0000 (15:02 -0800)]
Merge remote-tracking branch 'upstream/1.2.x' into test
Travis Fields [Mon, 3 Nov 2014 21:11:56 +0000 (13:11 -0800)]
Merge pull request #431 from mhaskel/1.2.0-prep
1.2.0 prep
Morgan Haskel [Fri, 31 Oct 2014 21:26:18 +0000 (14:26 -0700)]
1.2.0 prep
Colleen Murphy [Fri, 31 Oct 2014 23:18:03 +0000 (16:18 -0700)]
Merge pull request #430 from mhaskel/1.2.0-prep
1.2.0 prep
Morgan Haskel [Fri, 31 Oct 2014 21:26:18 +0000 (14:26 -0700)]
1.2.0 prep
Travis Fields [Fri, 31 Oct 2014 21:35:38 +0000 (14:35 -0700)]
Merge pull request #429 from mhaskel/1.2.x-ff
1.2.x ff
Morgan Haskel [Thu, 30 Oct 2014 23:29:42 +0000 (16:29 -0700)]
Merge pull request #426 from paramite/firewalld-fix
Fixed firewalld package issue
Travis Fields [Thu, 30 Oct 2014 22:15:33 +0000 (15:15 -0700)]
Merge pull request #428 from mhaskel/el5_test_fix
ip6tables isn't supported on EL5
Morgan Haskel [Thu, 30 Oct 2014 22:12:42 +0000 (15:12 -0700)]
ip6tables isn't supported on EL5
No need to test ip6tables purging on EL5 since the ip6tables provider
isn't supported.
Morgan Haskel [Tue, 28 Oct 2014 16:52:03 +0000 (12:52 -0400)]
Merge pull request #405 from cdenneen/master
EL7 Fixes for CentOS
cdenneen [Tue, 28 Oct 2014 01:23:59 +0000 (21:23 -0400)]
Merge pull request #1 from cmurphy/fix_el7_tests
Update tests for EL 7
Stefan Siegl [Mon, 27 Oct 2014 21:05:07 +0000 (22:05 +0100)]
Don't arbitrarily limit set_mark to certain chains
set_mark is not only allowed in PREROUTING or OUTPUT chain,
but also in custom chains, which are called from these.
Colleen Murphy [Mon, 27 Oct 2014 20:36:46 +0000 (13:36 -0700)]
Update tests for EL 7
Without this patch, unit tests make no distinction between EL < 7 and
EL 7. This is a problem because the iptables save exec is different
between the two operating systems, so the tests will fail for EL 7.
This patch fixes the problem by updating the tests to include the new
exec command for EL 7.
Colleen Murphy [Fri, 24 Oct 2014 21:23:24 +0000 (14:23 -0700)]
Merge pull request #424 from mhaskel/purge_ip6_fix
Missing a provider specification
Martin Mágr [Fri, 24 Oct 2014 07:37:01 +0000 (09:37 +0200)]
Fixed firewalld package issue
Firewalld package cannot be uninstalled, because other packages might be dependent
on it. This patch makes just firewalld service to stop and be disabled.
For more info please check: https://bugzilla.redhat.com/show_bug.cgi?id=
1148399
Hunter Haugen [Thu, 23 Oct 2014 22:15:45 +0000 (15:15 -0700)]
Merge pull request #383 from vzctl/ipset
add ipset support
Morgan Haskel [Thu, 23 Oct 2014 16:31:57 +0000 (10:31 -0600)]
Missing a provider specification
Hunter Haugen [Wed, 22 Oct 2014 17:44:38 +0000 (10:44 -0700)]
Merge pull request #423 from mhaskel/metadata_fix
Invalid metadata
Morgan Haskel [Wed, 22 Oct 2014 17:43:27 +0000 (10:43 -0700)]
Invalid metadata
Morgan Haskel [Mon, 20 Oct 2014 21:01:29 +0000 (14:01 -0700)]
Merge pull request #422 from hunner/fix_instances
(MODULES-41) Change source for ip6tables provider
Hunter Haugen [Mon, 20 Oct 2014 20:33:36 +0000 (13:33 -0700)]
(MODULES-41) Change source for ip6tables provider
This will allow purging of ipv6 rules
Hunter Haugen [Mon, 20 Oct 2014 16:56:47 +0000 (09:56 -0700)]
Merge pull request #420 from mhaskel/metadata_update
Update to support PE3.x
Hunter Haugen [Mon, 20 Oct 2014 16:56:39 +0000 (09:56 -0700)]
Merge pull request #419 from mhaskel/future_parser
Fix for future parser
Alexey Lapitsky [Fri, 19 Sep 2014 19:39:22 +0000 (15:39 -0400)]
add more ipset documentation
Alexey Lapitsky [Fri, 19 Sep 2014 19:19:49 +0000 (15:19 -0400)]
add negation support for ipset
Patrick Hemmer [Sat, 26 Apr 2014 16:13:59 +0000 (12:13 -0400)]
add ipset support
Morgan Haskel [Sun, 19 Oct 2014 00:22:03 +0000 (17:22 -0700)]
Update to support PE3.x
Morgan Haskel [Sun, 19 Oct 2014 00:08:41 +0000 (17:08 -0700)]
Fix for future parser
I'm not entirely sure why this was having issues with the future parser,
but there was something funny with the pp function.
Hunter Haugen [Fri, 17 Oct 2014 21:22:22 +0000 (14:22 -0700)]
Merge pull request #418 from mhaskel/remove_oel5
Doesn't actually support OEL5
Morgan Haskel [Fri, 17 Oct 2014 21:15:37 +0000 (14:15 -0700)]
Doesn't actually support OEL5
There are weird interactions between the version of iptables and the
kernel on OEL5.
Morgan Haskel [Fri, 17 Oct 2014 17:26:21 +0000 (10:26 -0700)]
Merge pull request #417 from jbondpdx/fix-readme
DOCUMENT-75: cstate param in my_fw::pre example should be state
jbondpdx [Fri, 17 Oct 2014 17:20:39 +0000 (10:20 -0700)]
DOCUMENT-75: cstate param in my_fw::pre example should be state
Fixed!
Hunter Haugen [Thu, 16 Oct 2014 23:38:29 +0000 (16:38 -0700)]
Merge pull request #416 from mhaskel/selinux_fixes
Don't do the idempotency checks with selinux
Morgan Haskel [Thu, 16 Oct 2014 23:21:47 +0000 (16:21 -0700)]
Don't do the idempotency checks with selinux
Eventually the types should use autobefore, but until then, just don't
do the idempotency checks.
Hunter Haugen [Tue, 14 Oct 2014 18:56:42 +0000 (11:56 -0700)]
Merge pull request #414 from mhaskel/spec_helper_fix
Use puppet() so the module install works better
Morgan Haskel [Tue, 14 Oct 2014 18:53:23 +0000 (11:53 -0700)]
Use puppet() so the module install works better
This was failing on SLES10 due to path issues.
Travis Fields [Tue, 14 Oct 2014 03:02:26 +0000 (20:02 -0700)]
Merge pull request #413 from mhaskel/rhel5_fixes
Fix for RHEL5
Morgan Haskel [Mon, 13 Oct 2014 23:54:01 +0000 (16:54 -0700)]
Fix for RHEL5
iptables-save output is in a different order for RHEL5 systems. Make
the tests check that ordering.
Colleen Murphy [Thu, 9 Oct 2014 23:16:56 +0000 (16:16 -0700)]
Merge pull request #412 from mhaskel/resource_cmd_spec_fix
Fix for resource_cmd_spec
Morgan Haskel [Thu, 9 Oct 2014 23:03:16 +0000 (19:03 -0400)]
Fix for resource_cmd_spec
Was checking for empty stderr in a few places, and also setting an
iptables rule that doesn't work on deb7 and ubuntu trusty.
Morgan Haskel [Mon, 29 Sep 2014 19:18:51 +0000 (14:18 -0500)]
Merge pull request #410 from justinstoller/bug/master/FM-1923-fixup-hieraconf
(FM-1923) Fix spec_helper_acceptance to run against PE
Justin Stoller [Mon, 29 Sep 2014 19:16:10 +0000 (12:16 -0700)]
(FM-1923) Fix spec_helper_acceptance to run against PE
Travis Fields [Wed, 17 Sep 2014 16:05:24 +0000 (09:05 -0700)]
Merge pull request #407 from hunner/redirect_validate
(MODULES-1086) toports is not reqired with jump == REDIRECT
Hunter Haugen [Mon, 15 Sep 2014 23:20:09 +0000 (16:20 -0700)]
(MODULES-1086) toports is not reqired with jump == REDIRECT
From the man page for REDIRECT and --to-ports: "This specifies a
destination port or range of ports to use: without this, the destination
port is never altered."
Hunter Haugen [Wed, 10 Sep 2014 18:50:04 +0000 (11:50 -0700)]
Merge pull request #406 from cyberious/master
Remove puppet_module_install in favor of copy_module_to
Travis Fields [Wed, 10 Sep 2014 18:47:53 +0000 (11:47 -0700)]
Remove puppet_module_install in favor of copy_module_to
cdenneen [Thu, 4 Sep 2014 02:42:19 +0000 (22:42 -0400)]
Update redhat.pp
cdenneen [Thu, 4 Sep 2014 02:23:57 +0000 (22:23 -0400)]
Update firewall.rb
cdenneen [Wed, 3 Sep 2014 17:14:06 +0000 (13:14 -0400)]
Centos 7 won't work with operatingsystemrelease 7.0
Centos 7 operatingsystemrelease is 7.0.1406 for example so switching to operatingsystemmajrelease would allow for 7 to be used for all EL7 products
cdenneen [Wed, 3 Sep 2014 17:08:17 +0000 (13:08 -0400)]
Add CentOS to facter value operatingsystem test
Ashley Penney [Thu, 28 Aug 2014 21:39:52 +0000 (17:39 -0400)]
Merge pull request #404 from mhaskel/spec_updates
Update the spec_helper for consistency.
Morgan Haskel [Thu, 28 Aug 2014 15:29:20 +0000 (11:29 -0400)]
Update the spec_helper for consistency.
Hunter Haugen [Tue, 26 Aug 2014 19:35:56 +0000 (12:35 -0700)]
Merge pull request #374 from starstable/master
Fixed bug which arbitrarily limited iniface and outiface parameters
Hunter Haugen [Mon, 25 Aug 2014 19:53:55 +0000 (12:53 -0700)]
Merge pull request #403 from rra/bug/iptables-persistent
Support netfilter-persistent for later versions
Russ Allbery [Sun, 24 Aug 2014 06:09:54 +0000 (23:09 -0700)]
Support netfilter-persistent for later versions
iptables-persistent 1.0 and later is now a plugin module for
netfilter-persistent and does not have its own init script or
service file. Instead, the save action must be run on the
netfilter-persistent service.
Hunter Haugen [Thu, 21 Aug 2014 19:51:04 +0000 (12:51 -0700)]
Merge pull request #402 from hunner/bugfix_statprob
Bugfix stat_prob -> stat_probability
Hunter Haugen [Thu, 21 Aug 2014 19:50:01 +0000 (12:50 -0700)]
Bugfix stat_prob -> stat_probability
I also aligned arrows and sorted the resource map
Hunter Haugen [Thu, 21 Aug 2014 00:33:54 +0000 (17:33 -0700)]
Merge pull request #400 from hunner/feature/statistic_module_support
Feature/statistic module support
Hunter Haugen [Wed, 20 Aug 2014 23:39:59 +0000 (16:39 -0700)]
Update docs, remove feature, and rename property
Daniel Selans [Thu, 12 Jun 2014 02:57:04 +0000 (22:57 -0400)]
Added unit tests
Daniel Selans [Wed, 11 Jun 2014 03:27:59 +0000 (23:27 -0400)]
Added support for statistic module
Hunter Haugen [Tue, 19 Aug 2014 19:34:57 +0000 (12:34 -0700)]
Merge pull request #397 from jbondpdx/firewall-readme
Firewall readme
jbondpdx [Fri, 15 Aug 2014 15:49:20 +0000 (08:49 -0700)]
Docs: code formatting edits on readme
Responding to comments from earlier PR to change formatting for some snippets of puppet code.
jbondpdx [Wed, 13 Aug 2014 18:30:37 +0000 (11:30 -0700)]
Docs: Reference information added to firewall module readme
I have added reference information to the firewall module readme. I also fixed errors introduced during squashing in my last commit.
jbondpdx [Wed, 30 Jul 2014 22:34:41 +0000 (15:34 -0700)]
Docs: Reference info added to firewall
Added reference information to the firewall module readme.
Ashley Penney [Fri, 1 Aug 2014 21:56:07 +0000 (17:56 -0400)]
Merge pull request #395 from hunner/remove_print
Remove stray print
Hunter Haugen [Fri, 1 Aug 2014 21:52:17 +0000 (14:52 -0700)]
Remove stray print
Ashley Penney [Fri, 1 Aug 2014 21:39:32 +0000 (17:39 -0400)]
Merge pull request #394 from hunner/fix_negate
(MODULES-450) Enable rule inversion
Hunter Haugen [Wed, 30 Jul 2014 23:32:31 +0000 (16:32 -0700)]
(MODULES-450) Enable rule inversion
iptables has many rule arguments that may be inverted by prefixing with
an exclamation mark. This commit enables inversion for most every
property currently in the firewall provider that supports inversion by
prefixing the value with a bang+space.
Array elements must have all array elements prefixed with a bang+space
otherwise a warning will be raised, as it would look confusing to negate
a single value and then have iptables negate all of them.
Morgan Haskel [Thu, 31 Jul 2014 17:13:35 +0000 (13:13 -0400)]
Merge pull request #388 from thias/cbt
Add cbt protocol, to be able to mitigate some DDoS attacks
Hunter Haugen [Sat, 26 Jul 2014 20:46:34 +0000 (13:46 -0700)]
Merge pull request #337 from damjanek/master
Add support for mac address source rules pt2
Damian Szeluga [Fri, 21 Mar 2014 14:12:02 +0000 (15:12 +0100)]
Making it mergable:
* Missing type definition
* Fix failing test
* Acceptance testing + fix parameter match
* Renamed mac_addr to mac_source
Jeff '2 bits' Bachtel [Wed, 5 Mar 2014 17:32:02 +0000 (12:32 -0500)]
Add support for mac address source rules
This is necessary to parse rules generated on OpenStack Havana + Neutron + OpenVSwitch
Hunter Haugen [Wed, 23 Jul 2014 00:38:14 +0000 (17:38 -0700)]
Merge pull request #393 from hunner/develop
Improve support for EL7 and other related fixes
Trey Dockendorf [Mon, 21 Jul 2014 18:55:24 +0000 (13:55 -0500)]
Improve support for EL7 and other related fixes
* Support RHEL7 by removing firewalld before installing iptables-services
* Autorequire Package[iptables-services] for Firewall and Firewallchain types
* Ensure /etc/sysconfig/iptables exists before starting Service[iptables]
Hunter Haugen [Wed, 23 Jul 2014 00:06:48 +0000 (17:06 -0700)]
Merge branch '1.2.x'
Hunter Haugen [Tue, 22 Jul 2014 16:38:10 +0000 (09:38 -0700)]
Merge pull request #390 from dnaeon/master
Typo fix
Marin Atanasov Nikolov [Thu, 17 Jul 2014 14:41:35 +0000 (17:41 +0300)]
Typo fix
Travis Fields [Mon, 14 Jul 2014 22:50:24 +0000 (15:50 -0700)]
Merge pull request #389 from hunner/fix_metadata
Update metadata to match checksum