]>
review.fuel-infra Code Review - openstack-build/neutron-build.git/log
Salvatore Orlando [Wed, 7 Sep 2011 10:19:10 +0000 (11:19 +0100)]
Fixing bad indent
Salvatore Orlando [Tue, 30 Aug 2011 17:06:14 +0000 (18:06 +0100)]
Avoiding deserializing body multiple times with several parameters
Salvatore Orlando [Tue, 30 Aug 2011 16:37:12 +0000 (17:37 +0100)]
Test on param_value changes as follows:
# If the parameter wasn't found and it was required, return 400
if param_value is None and param['required']:
msg = ("Failed to parse request. " +
"Parameter: " + param_name + " not specified")
for line in msg.split('\n'):
LOG.error(line)
raise exc.HTTPBadRequest(msg)
Salvatore Orlando [Tue, 30 Aug 2011 16:30:15 +0000 (17:30 +0100)]
Merging lp:~salvatore-orlando/quantum/bug834449
Fix for Bug #834449
Salvatore Orlando [Tue, 30 Aug 2011 16:00:11 +0000 (17:00 +0100)]
Merge trunk
Updating names for APIRouter in CLI and CLI tests
Dan Wendlandt [Tue, 30 Aug 2011 06:32:52 +0000 (23:32 -0700)]
merge trunk
Dan Wendlandt [Tue, 30 Aug 2011 01:59:14 +0000 (18:59 -0700)]
lp835216 client lib was not passing in kwargs when creating exceptions
Dan Wendlandt [Tue, 30 Aug 2011 01:16:39 +0000 (18:16 -0700)]
lp834694 fix integrity error when deleting network with unattached ports. Add unit test.
Dan Wendlandt [Fri, 26 Aug 2011 20:22:18 +0000 (13:22 -0700)]
make CLI show_port command display interface-id, add additional test case
Dan Wendlandt [Fri, 26 Aug 2011 19:54:33 +0000 (12:54 -0700)]
merge salvatore's new cli code
Dan Wendlandt [Fri, 26 Aug 2011 19:25:31 +0000 (12:25 -0700)]
merge two pep8 branch
Ying Liu [Fri, 26 Aug 2011 18:21:46 +0000 (11:21 -0700)]
fix pep8 warnings
Salvatore Orlando [Fri, 26 Aug 2011 10:20:55 +0000 (11:20 +0100)]
Updating common/extensions.py in order not to instantiate a QuantumManager when retrieving plugin
Also renaming API router: APIRouterV01 --> APIRouterV1
Salvatore Orlando [Fri, 26 Aug 2011 09:56:43 +0000 (10:56 +0100)]
Cleaning pep8
Salvatore Orlando [Fri, 26 Aug 2011 09:21:05 +0000 (10:21 +0100)]
Merging lp:~danwent/quantum/lp834491
Fixing Bug #834491: api alignment merge broke ovs plugin (Critical)
Salvatore Orlando [Fri, 26 Aug 2011 08:41:19 +0000 (09:41 +0100)]
Addressing comments from Dan
Also solved issue with output from plug_iface and unplug_iface
Dan Wendlandt [Fri, 26 Aug 2011 08:15:01 +0000 (01:15 -0700)]
merge cisco extensions branch
Dan Wendlandt [Fri, 26 Aug 2011 08:02:41 +0000 (01:02 -0700)]
lp834491: change plugin to work with API code after the API alignment merge
Ying Liu [Thu, 25 Aug 2011 19:34:01 +0000 (12:34 -0700)]
add cisco_faults under l2network package.
Ying Liu [Thu, 25 Aug 2011 19:30:20 +0000 (12:30 -0700)]
move faults/exceptions to l2network package,
remove unecessary faults definitions
change the portprofile action api's method
fix imports order and other comments issues
Sumit Naiksatam [Thu, 25 Aug 2011 18:52:06 +0000 (11:52 -0700)]
Merging from Sumit's branch, import ordering related changes.
Sumit Naiksatam [Thu, 25 Aug 2011 18:39:44 +0000 (11:39 -0700)]
Changing the order of imports (to satisfy convention).
Sumit Naiksatam [Thu, 25 Aug 2011 18:20:16 +0000 (11:20 -0700)]
Merging the Cisco branch.
Salvatore Orlando [Thu, 25 Aug 2011 17:50:05 +0000 (18:50 +0100)]
Finishing cli work
Fixing bug with XML deserialization
Salvatore Orlando [Thu, 25 Aug 2011 11:49:38 +0000 (12:49 +0100)]
Completing Unit Tests
Salvatore Orlando [Thu, 25 Aug 2011 09:43:36 +0000 (10:43 +0100)]
Merging lp:~salvatore-orlando/quantum/quantum-api-alignment
Bug #813433: Align API implementation with specifcation (Critical)
Bug #821628: Getting network details is failing (Undecided)
Bug #823841: Remove constraint on network names (Medium)
Blueprint: Quantum API v1.0 Implementation (Essential)
Salvatore Orlando [Thu, 25 Aug 2011 00:52:32 +0000 (01:52 +0100)]
Adding unit test for rename_network
Salvatore Orlando [Thu, 25 Aug 2011 00:21:19 +0000 (01:21 +0100)]
Added logging to syslog or file specified at command line
removed plugin direct mode
fixed unit tests to reflect changes in cli code
fixex pep8 errors
todo: complete unit tests
auto-detect function names from stack trace
rohitagarwalla [Wed, 24 Aug 2011 21:11:10 +0000 (14:11 -0700)]
fixing relative import in nexus_db.py
Ying Liu [Wed, 24 Aug 2011 20:36:32 +0000 (13:36 -0700)]
merge latest quantum branch and resolve conflicts
Salvatore Orlando [Wed, 24 Aug 2011 20:03:10 +0000 (21:03 +0100)]
Merging lp:~asomya/quantum/lp833163
Fix for Bug #833163: Pep8 violations in recent packaging changes that were merged into trunk (Critical)
Thanks Arvind!
Salvatore Orlando [Wed, 24 Aug 2011 18:10:03 +0000 (19:10 +0100)]
Templated output for CLI completed!
Arvind Somy [Wed, 24 Aug 2011 17:10:29 +0000 (13:10 -0400)]
PEP8 fixes for setup.py
Ying Liu [Wed, 24 Aug 2011 16:55:47 +0000 (09:55 -0700)]
delete quantum/common/test_lib.py to prepare for quantum merge
Ying Liu [Wed, 24 Aug 2011 16:43:25 +0000 (09:43 -0700)]
Made changes according to reviewer's comments.
Add addtional information on extension test in README.
Salvatore Orlando [Wed, 24 Aug 2011 11:54:53 +0000 (12:54 +0100)]
Merge trunk
Salvatore Orlando [Wed, 24 Aug 2011 11:45:58 +0000 (12:45 +0100)]
Merging lp:~cisco-openstack/quantum/802dot1qbh-vifdriver-scheduler
VIF driver to support 802.1qbh
Quantum-aware scheduler
This modules are meant to be run by Nova to communicated with Quantum.
Salvatore Orlando [Wed, 24 Aug 2011 11:29:49 +0000 (12:29 +0100)]
Merging lp:~cisco-openstack/quantum/l2network-plugin-persistence
Improvements on cisco plugin:
- Persistence support
- Improved pylint score (now 8.29)
Sumit Naiksatam [Wed, 24 Aug 2011 10:27:54 +0000 (03:27 -0700)]
Noticed some pep8 errors, fixed them.
Sumit Naiksatam [Wed, 24 Aug 2011 10:19:06 +0000 (03:19 -0700)]
Merging lp:quantum
Sumit Naiksatam [Wed, 24 Aug 2011 10:15:54 +0000 (03:15 -0700)]
Changes to incorporate reviwer's comments. Also changed client.py to handle extension URLs.
Shweta P [Wed, 24 Aug 2011 07:02:10 +0000 (00:02 -0700)]
Review Changes
Ying Liu [Tue, 23 Aug 2011 22:15:16 +0000 (15:15 -0700)]
remove unnecessary code and sync faults and exception handling
Edgar Magana [Tue, 23 Aug 2011 20:05:22 +0000 (13:05 -0700)]
Code changed base on Reviews
pep8 passed
pylint 9.10
rohitagarwalla [Tue, 23 Aug 2011 19:36:06 +0000 (12:36 -0700)]
merging with lp:quantum
rohitagarwalla [Tue, 23 Aug 2011 19:34:18 +0000 (12:34 -0700)]
merging from lp:quantum
rohitagarwalla [Tue, 23 Aug 2011 18:36:50 +0000 (11:36 -0700)]
Fixes based on review comments
Brad Hall [Tue, 23 Aug 2011 15:29:45 +0000 (08:29 -0700)]
merge lp:~bgh/quantum/lp837174
Brad Hall [Tue, 23 Aug 2011 11:50:55 +0000 (04:50 -0700)]
Fix unit test printing (lp837174)
Salvatore Orlando [Mon, 22 Aug 2011 23:57:33 +0000 (00:57 +0100)]
Fixing issue in view builders concerning attachment identifiers
Sumit Naiksatam [Mon, 22 Aug 2011 23:17:33 +0000 (16:17 -0700)]
Code clean up as per reviewr's request; documentation strings, unused code, etc.
Edgar Magana [Mon, 22 Aug 2011 23:04:55 +0000 (16:04 -0700)]
Rewording of the README file to clarify the use of the SSh port
Ying Liu [Mon, 22 Aug 2011 20:13:29 +0000 (13:13 -0700)]
clean up code and fix some comments
Ying Liu [Mon, 22 Aug 2011 20:02:00 +0000 (13:02 -0700)]
clean code and fix some comments.
Salvatore Orlando [Mon, 22 Aug 2011 14:30:54 +0000 (15:30 +0100)]
Merge trunk
Solving conflict in common/exceptions.py
Removing unused error code from client.py
Salvatore Orlando [Mon, 22 Aug 2011 14:16:24 +0000 (15:16 +0100)]
Merging lp:~raxnetworking/quantum/bug827272
Fix for bug #827272 - collection actions for PUT and DELETE methods on resource extension routes ...
Salvatore Orlando [Mon, 22 Aug 2011 14:14:09 +0000 (15:14 +0100)]
Merging branch: lp:~danwent/quantum/test-refactor
Makes it easier for plugins to haave their own unit tests with minimal code duplication
Salvatore Orlando [Mon, 22 Aug 2011 11:39:47 +0000 (12:39 +0100)]
Removing "excess" file
rohitagarwalla [Sat, 20 Aug 2011 06:54:02 +0000 (23:54 -0700)]
fixing the the test_database.py tests
Ying Liu [Sat, 20 Aug 2011 05:21:21 +0000 (22:21 -0700)]
Merge Shweta's new propose. Chnage profile-id ot profile_id
Shweta P [Sat, 20 Aug 2011 04:58:27 +0000 (21:58 -0700)]
Merge with Cisco branch
Shweta P [Sat, 20 Aug 2011 04:55:50 +0000 (21:55 -0700)]
Change profile-id
Ying Liu [Sat, 20 Aug 2011 04:46:15 +0000 (21:46 -0700)]
merged Shweta's branch for ext test. Minor fix for review comments.
Shweta P [Sat, 20 Aug 2011 04:26:56 +0000 (21:26 -0700)]
Merge with the Cisco Branch
Shweta P [Sat, 20 Aug 2011 04:05:25 +0000 (21:05 -0700)]
Review Changes
Ying Liu [Sat, 20 Aug 2011 03:33:15 +0000 (20:33 -0700)]
merged Shweta's ext test branch
Shweta P [Sat, 20 Aug 2011 03:02:49 +0000 (20:02 -0700)]
Moved the conf file uncer the cisco directory
Shweta P [Sat, 20 Aug 2011 03:01:52 +0000 (20:01 -0700)]
Moved the conf file uncer the cisco directory
Shweta P [Sat, 20 Aug 2011 02:47:37 +0000 (19:47 -0700)]
Updated conf file
Shweta P [Sat, 20 Aug 2011 02:42:04 +0000 (19:42 -0700)]
Adding Entension API unt tests
Sumit Naiksatam [Sat, 20 Aug 2011 01:48:20 +0000 (18:48 -0700)]
Syncing with lp:quantum
Sumit Naiksatam [Sat, 20 Aug 2011 01:46:34 +0000 (18:46 -0700)]
Code refactored, made changes are per reviwer's suggestions.
Ying Liu [Fri, 19 Aug 2011 23:53:38 +0000 (16:53 -0700)]
sync up with l2network exception handling for extension
Ying Liu [Fri, 19 Aug 2011 23:28:42 +0000 (16:28 -0700)]
merged Cisco branch's latest changes
Edgar Magana [Fri, 19 Aug 2011 20:48:12 +0000 (13:48 -0700)]
Adding changes from Sumit's latest merge
Ying Liu [Fri, 19 Aug 2011 20:42:36 +0000 (13:42 -0700)]
merge with lp:~cisco-openstack/quantum/l2network-plugin-extensions
Ying Liu [Fri, 19 Aug 2011 20:37:33 +0000 (13:37 -0700)]
replace exception handler by using cisco_exceptions
Sumit Naiksatam [Fri, 19 Aug 2011 20:05:56 +0000 (13:05 -0700)]
Raising exceptions in extension resources handling (where missing). Changing exception name to QosNotFound.
Sumit Naiksatam [Fri, 19 Aug 2011 18:02:53 +0000 (11:02 -0700)]
Changing exception name to QosNotFound.
Sumit Naiksatam [Fri, 19 Aug 2011 17:58:32 +0000 (10:58 -0700)]
Mergin from Cisco branch.
Sumit Naiksatam [Fri, 19 Aug 2011 17:55:46 +0000 (10:55 -0700)]
Raising exceptions in extension resources handling (where missing).
Somik Behera [Fri, 19 Aug 2011 17:55:36 +0000 (10:55 -0700)]
Merging fixes to client side exception handling. Thanks lp:tylesmit !
Somik Behera [Fri, 19 Aug 2011 17:53:00 +0000 (10:53 -0700)]
Merging fixes and changes batch-config script. Thanks lp:danwent !
Edgar Magana [Fri, 19 Aug 2011 17:13:53 +0000 (10:13 -0700)]
Adding the Nexus support to the Persistence Framwork
Modification of the Nexus Unit Case to be running with Persistence Framework
pep8 passed
pylint 8.81/10
rohitagarwalla [Fri, 19 Aug 2011 16:06:43 +0000 (09:06 -0700)]
added nexus exception in cisco_exceptions.py
added log to methods in l2network_db.py
added nexus_db.py and nexus_models.py - persistence modules for nexus plugin
Ying Liu [Fri, 19 Aug 2011 15:14:17 +0000 (08:14 -0700)]
add plugins.ini back
Ying Liu [Fri, 19 Aug 2011 15:00:37 +0000 (08:00 -0700)]
add all conf/*.ini back
Ying Liu [Fri, 19 Aug 2011 07:47:07 +0000 (00:47 -0700)]
merge with ying's branch
Ying Liu [Fri, 19 Aug 2011 07:44:07 +0000 (00:44 -0700)]
merging with Ying's extension branch
Ying Liu [Fri, 19 Aug 2011 07:41:25 +0000 (00:41 -0700)]
remove ying's test ciscoplugin
Ying Liu [Fri, 19 Aug 2011 07:14:44 +0000 (00:14 -0700)]
remove all configuration files
Ying Liu [Fri, 19 Aug 2011 01:57:51 +0000 (18:57 -0700)]
remove cisco_demo and test_scripts directory, which were used by our local tests
Sumit Naiksatam [Thu, 18 Aug 2011 23:53:57 +0000 (16:53 -0700)]
Removed concatenation per review comments.
Ying Liu [Thu, 18 Aug 2011 23:33:08 +0000 (16:33 -0700)]
change the configuration files to the default values
Ying Liu [Thu, 18 Aug 2011 22:57:36 +0000 (15:57 -0700)]
pylint and pep8 fix
Ying Liu [Thu, 18 Aug 2011 22:45:58 +0000 (15:45 -0700)]
merging with ~cisco-openstack/quantum/l2network-plugin-extensions
Ying Liu [Thu, 18 Aug 2011 22:36:09 +0000 (15:36 -0700)]
fix pylint issuses
Somik Behera [Thu, 18 Aug 2011 21:39:37 +0000 (14:39 -0700)]
Merging bug fix for Bug 821733. Thanks lp:salvatore-orlando !
Tyler Smith [Thu, 18 Aug 2011 19:58:27 +0000 (12:58 -0700)]
Fixing typo
Tyler Smith [Thu, 18 Aug 2011 19:49:20 +0000 (12:49 -0700)]
Making the client raise the appropriate exception if needed. Also increasing the pylint score to above 8.