]> review.fuel-infra Code Review - openstack-build/cinder-build.git/log
openstack-build/cinder-build.git
10 years agoAdd initiator target map in EMC SMI-S FC driver.
Xing Yang [Sun, 2 Mar 2014 04:45:45 +0000 (23:45 -0500)]
Add initiator target map in EMC SMI-S FC driver.

This patch add the initiator target map in initialize_connection
and terminate_connection as it is required by the FC Zone Manager.

Change-Id: I84729968b8e4e6ee74536fb28d3d921a9baf9f6e
Closes-Bug: #1286694

10 years agoMerge "Give a way to save why a service has been disabled"
Jenkins [Sun, 2 Mar 2014 01:25:39 +0000 (01:25 +0000)]
Merge "Give a way to save why a service has been disabled"

10 years agoMerge "Remove unused variable"
Jenkins [Sat, 1 Mar 2014 08:26:16 +0000 (08:26 +0000)]
Merge "Remove unused variable"

10 years agoMake EMC SMI-S driver unit tests faster.
Xing Yang [Fri, 28 Feb 2014 22:07:32 +0000 (17:07 -0500)]
Make EMC SMI-S driver unit tests faster.

Some of EMC SMI-S driver unit tests are very slow.
This patch uses a fake_sleep in unit tests to return right away.

Change-Id: Ia8a429799066ccde51079be68408498805869774
Closes-Bug: #1285927

10 years agoMerge "Python 3: replace "im_self" by "__self__""
Jenkins [Fri, 28 Feb 2014 10:07:08 +0000 (10:07 +0000)]
Merge "Python 3: replace "im_self" by "__self__""

10 years agoMerge "Restrict rootwrap find filter for NetAppNFS driver"
Jenkins [Fri, 28 Feb 2014 07:51:16 +0000 (07:51 +0000)]
Merge "Restrict rootwrap find filter for NetAppNFS driver"

10 years agoMerge "Fix volume stats with multiple LeftHand clusters"
Jenkins [Fri, 28 Feb 2014 07:34:07 +0000 (07:34 +0000)]
Merge "Fix volume stats with multiple LeftHand clusters"

10 years agoMerge "TSM backup driver changes to support file backup"
Jenkins [Fri, 28 Feb 2014 01:43:50 +0000 (01:43 +0000)]
Merge "TSM backup driver changes to support file backup"

10 years agoMerge "Add optional ionice to volume clearing process"
Jenkins [Fri, 28 Feb 2014 01:43:41 +0000 (01:43 +0000)]
Merge "Add optional ionice to volume clearing process"

10 years agoMerge "Don't clear host_state_map when scheduling"
Jenkins [Fri, 28 Feb 2014 01:43:14 +0000 (01:43 +0000)]
Merge "Don't clear host_state_map when scheduling"

10 years agoMerge "Export and import backup service metadata"
Jenkins [Thu, 27 Feb 2014 23:42:10 +0000 (23:42 +0000)]
Merge "Export and import backup service metadata"

10 years agoFix volume stats with multiple LeftHand clusters
Jim Branen [Thu, 27 Feb 2014 18:41:34 +0000 (10:41 -0800)]
Fix volume stats with multiple LeftHand clusters

When more than one cluster exists in a LeftHand management
group, get_volume_stats may return the stats for the wrong
cluster. This patch fixes the problem by listing the cluster
name in the getClusterInfo query.

Change-Id: I2d5a76869c6bb1b3d514f0546ea00998e5ee32fb
Closes-Bug: #1279897

10 years agoExport and import backup service metadata
Ronen Kat [Thu, 23 Jan 2014 09:58:58 +0000 (11:58 +0200)]
Export and import backup service metadata

Add new admin API for backup-export and backup-import.
The new commands export the backup details (not actual backup) to
a string that can be imported again in another OpenStack cloud or
if the backup database was corrupted.
The code includes a default backup driver implementation.
Backup test code converted to use mock.

blueprint cinder-backup-recover-api
DocImpact new admin API calls backup-import and backup-export

Change-Id: I564194929962e75c67630e73d8711ee6587706d4

10 years agoMerge "Add volume metadata backup suport to swift driver"
Jenkins [Thu, 27 Feb 2014 02:32:57 +0000 (02:32 +0000)]
Merge "Add volume metadata backup suport to swift driver"

10 years agoMerge "GlusterFS: Increase snapshot delete job timeout to two hours"
Jenkins [Thu, 27 Feb 2014 02:25:24 +0000 (02:25 +0000)]
Merge "GlusterFS: Increase snapshot delete job timeout to two hours"

10 years agoDon't clear host_state_map when scheduling
Zhiteng Huang [Thu, 27 Feb 2014 01:58:17 +0000 (09:58 +0800)]
Don't clear host_state_map when scheduling

host_state_map was added to scheduler for the purpose of caching latest
host_state in memory for scheduler.  With this cache, scheduler has the
latest host_state (e.g. free_capacity, allocated_capacity, etc) of hosts
even hosts haven't reported their updated status to scheduler.

Unfortunately, this cache is flushed when scheduling pulling all available
volume services from DB in current implementation, which is a bug.

This change remove the host_state_map.clear() so that scheduler is able to
maintain an up-to-date (well, mostly) view of all volume services in memory.
Also, added code to remove non-active host from the cache every time when
scheduler handles a new request.  Multi-line docstrings in cinder/scheduler/
host_manager.py are also fixed.

Change-Id: Ib47be483fa26631a1483721e2ae6d972994e150f
Fixes-bug: 1271162

10 years agoMerge "updating testing readme with more current information."
Jenkins [Wed, 26 Feb 2014 21:58:56 +0000 (21:58 +0000)]
Merge "updating testing readme with more current information."

10 years agoMerge "Change warning message in NetApp driver for vsadmin creds"
Jenkins [Wed, 26 Feb 2014 21:58:47 +0000 (21:58 +0000)]
Merge "Change warning message in NetApp driver for vsadmin creds"

10 years agoAdd volume metadata backup suport to swift driver
Duncan Thomas [Tue, 25 Feb 2014 18:08:04 +0000 (18:08 +0000)]
Add volume metadata backup suport to swift driver

Add volume metadata backup support to swift, to match that added to the
ceph backup driver

Change-Id: I6b872d8c13c94492a9c109707de46aae96222295

10 years agoAdd optional ionice to volume clearing process
Duncan Thomas [Wed, 19 Feb 2014 19:03:24 +0000 (19:03 +0000)]
Add optional ionice to volume clearing process

Allow the volume clearing process to have an ionice priority set to
reduce the performance impact of volume zeroing. Note that this may
cause volume clearing processes to get backed up on  a busy system, use
with care.

DocImpact
Change-Id: I2d556f57aaca8a8ccc6f0f767f1cec28c3f9bc86
Implements: blueprint when-deleting-volume-dd-performance

10 years agoRestrict rootwrap find filter for NetAppNFS driver
Daniel Gollub [Wed, 19 Feb 2014 06:37:20 +0000 (07:37 +0100)]
Restrict rootwrap find filter for NetAppNFS driver

Additional make the name of the filter unique, so it does not override
any other rule. Like the find rule of the GPFS driver.
Rootwrap is making use of plain python ConfigParser which handles INI files
with key=value pair like fashion. Where the key is unique.

Closes-Bug: 1250101

Change-Id: Id2f193485089e12f00008b38fad2b95a09674ff2

10 years agoGlusterFS: Increase snapshot delete job timeout to two hours
Eric Harney [Wed, 26 Feb 2014 16:38:29 +0000 (11:38 -0500)]
GlusterFS: Increase snapshot delete job timeout to two hours

Increase the timeout for Nova snapshot delete operations from ten
minutes to two hours.  This helps prevent Cinder from terminating
operations prematurely that are still being processed by Nova.

It is not uncommon for snapshot delete jobs to run for longer than
ten minutes depending on the size of the snapshot and speed of the
storage backend.

This will be followed up with a more robust mechanism to keep track
of snapshot job progress as a later effort.

Related-Bug: 1273894

Change-Id: I1ad52568aed1ce1bf593e71704e481b6fe5f44fb

10 years agoupdating testing readme with more current information.
Dan Radez [Mon, 17 Feb 2014 15:16:19 +0000 (10:16 -0500)]
updating testing readme with more current information.

Change-Id: I3ef39f5484170c1886c3b88e81b42450339a0d39
Closes-Bug: 1277179

10 years agoMerge "Use len instead of for-loop to get the end index"
Jenkins [Wed, 26 Feb 2014 12:46:32 +0000 (12:46 +0000)]
Merge "Use len instead of for-loop to get the end index"

10 years agoRemove unused variable
KIYOHIRO ADACHI [Wed, 26 Feb 2014 08:35:07 +0000 (17:35 +0900)]
Remove unused variable

o cinder/api/openstack/wsgi.py:_CONTENT_TYPE_MAP = {

  This variable was added in the following commit.

    commit c53d8e343e50d4cf7ea9a6a81258848c2d893bfb
    Author: Jenkins <jenkins@review.openstack.org>
    Date:   Thu May 3 10:48:26 2012 -0700

        Initial fork out of Nova.

  But there is no evidence that was used.

Change-Id: I6af64126cf1747ded3369a6237a4cb6cfd250922

10 years agoPython 3: replace "im_self" by "__self__"
Shuangtai Tian [Thu, 20 Feb 2014 06:43:11 +0000 (14:43 +0800)]
Python 3: replace "im_self" by "__self__"

The Python 3 removed the "im_self" attribute and only supports the
"__self__". This patch replaces "im_self" by "__self__" attribute.

Closes-Bug: #1282514
Change-Id: Ib017fff4b720a5dd7ee27fd01b36a531d9b6ca9c

10 years agoMerge "Update FibreChannel Zone Manager config"
Jenkins [Wed, 26 Feb 2014 06:30:59 +0000 (06:30 +0000)]
Merge "Update FibreChannel Zone Manager config"

10 years agoMerge "Fix test_delete_should_not_.. to assert something"
Jenkins [Wed, 26 Feb 2014 06:20:45 +0000 (06:20 +0000)]
Merge "Fix test_delete_should_not_.. to assert something"

10 years agoMerge "Fix silly error in comment"
Jenkins [Wed, 26 Feb 2014 04:05:04 +0000 (04:05 +0000)]
Merge "Fix silly error in comment"

10 years agoUpdate FibreChannel Zone Manager config
Walter A. Boring IV [Mon, 24 Feb 2014 20:10:52 +0000 (12:10 -0800)]
Update FibreChannel Zone Manager config

This patch changes the way the config options are
layed out in the cinder.conf to follow the
standards for grouping settings together.

Instead of using dynamic config names to group
settings together by fabric name, we look for
fabric groups based upon the fc_fabric_names.
We also create a new fc-zone-manager group
for all of the global fczm settings.

Change-Id: I91c8a05adec2fb12f664ca0df6007465c1a460e0
Closes-Bug: #1284338
DocImpact

10 years agoMerge "3PAR: Fix extend volume GiB to MiB"
Jenkins [Wed, 26 Feb 2014 01:08:09 +0000 (01:08 +0000)]
Merge "3PAR: Fix extend volume GiB to MiB"

10 years agoMerge "3PAR: Create volume from snapshot with larger size"
Jenkins [Wed, 26 Feb 2014 01:08:00 +0000 (01:08 +0000)]
Merge "3PAR: Create volume from snapshot with larger size"

10 years agoMerge "Brick support for pNFS"
Jenkins [Tue, 25 Feb 2014 20:50:32 +0000 (20:50 +0000)]
Merge "Brick support for pNFS"

10 years agoMerge "Storwize/SVC: Change volume copy task to async"
Jenkins [Tue, 25 Feb 2014 20:47:30 +0000 (20:47 +0000)]
Merge "Storwize/SVC: Change volume copy task to async"

10 years agoMerge "Replace tearDown with addCleanup"
Jenkins [Tue, 25 Feb 2014 20:47:21 +0000 (20:47 +0000)]
Merge "Replace tearDown with addCleanup"

10 years agoMerge "Removes use of timeutils.set_time_override"
Jenkins [Tue, 25 Feb 2014 20:47:11 +0000 (20:47 +0000)]
Merge "Removes use of timeutils.set_time_override"

10 years agoChange warning message in NetApp driver for vsadmin creds
Ben Swartzlander [Tue, 25 Feb 2014 19:44:14 +0000 (11:44 -0800)]
Change warning message in NetApp driver for vsadmin creds

The new warning messages explicitly lists the extra_specs that
can't be supported depending on the access level fo the creds
that were provided. Also corrects a spelling error for the
netapp_nodedup extra_spec.

Change-Id: I1b27d9f4043321a4812e4e457c32a1040676c8e5
Closes-Bug: 1284796

10 years ago3PAR: Fix extend volume GiB to MiB
Kurt Martin [Tue, 25 Feb 2014 16:30:01 +0000 (08:30 -0800)]
3PAR: Fix extend volume GiB to MiB

Extend volume was sending GiB instead of MiB to the 3PAR
array. This patch is now sending the growth size in MiBs
instead of GiBs.

Change-Id: Ib4903315a32e090e760883cc80c50f3698fe015f
Closes-Bug: #1284368

10 years agoTSM backup driver changes to support file backup
Bill Owen [Thu, 13 Feb 2014 21:55:47 +0000 (14:55 -0700)]
TSM backup driver changes to support file backup

Extend TSM backup driver to support backup of file based volumes,
as well as restore and delete of the backups.  This in addition
to the current block based volume support.  This involves determining
the type of volume this is requested to be backed up, and modifying
the dsmc command options accordingly.  When a volume is backed
up, the backup mode and backup path are saved in the backup
service_metadata for use on restore and delete operations.

This commit includes some further refactoring based on pylint
feedback and system testing.

Implements: blueprint tsm-backup-driver-enhancement
Change-Id: Ic994a8c2f7302e59358dd858b50df746c9a7d76f

10 years agoFix silly error in comment
Duncan Thomas [Tue, 25 Feb 2014 17:56:56 +0000 (17:56 +0000)]
Fix silly error in comment

Fixing since it threw me for a second or two...

Change-Id: I53ecbe8a7bf31bd5c88cb0d025ff3d46aa741ce9

10 years agoMerge "Fix free_capacity reporting in SolidFire driver"
Jenkins [Tue, 25 Feb 2014 18:59:02 +0000 (18:59 +0000)]
Merge "Fix free_capacity reporting in SolidFire driver"

10 years ago3PAR: Create volume from snapshot with larger size
Ramy Asselin [Mon, 24 Feb 2014 22:54:08 +0000 (14:54 -0800)]
3PAR: Create volume from snapshot with larger size

Refactored the migrate_volume code to be usable by both migrate volume
and create volume from snapshot with a larger size. The common functionality
is to clone a volume as a base volume. Migrate volume specifies a different
CPG, whereas create volume from snapshot uses the same CPG.

Change-Id: I4081807294d918fc0e9c2e17bae89b6df7ee1513
Closes-Bug: #1279478

10 years agoMerge "Use six.StringIO instead of StringIO.StringIO"
Jenkins [Tue, 25 Feb 2014 17:17:11 +0000 (17:17 +0000)]
Merge "Use six.StringIO instead of StringIO.StringIO"

10 years agoFix free_capacity reporting in SolidFire driver
john-griffith [Tue, 25 Feb 2014 06:02:11 +0000 (23:02 -0700)]
Fix free_capacity reporting in SolidFire driver

The SolidFire driver reports capacity info in bytes, the
capabilities update reports available_GB.  Sadly we neglected
to convert the bytes to gigibytes here which made for a VERY
large backend and caused things like capacity filtering to not
work correctly.

This patch just adds conversion to GiB when reporting capabilities.

Change-Id: I62c6ad2edd8c2ced344df766c198504894f4902b
Closes-Bug: 1284452

10 years agoFix test_delete_should_not_.. to assert something
Alex Meade [Mon, 24 Feb 2014 19:08:37 +0000 (14:08 -0500)]
Fix test_delete_should_not_.. to assert something

This changes test_delete_should_not_delete_if_provider_location_not_provided
to assert the case it is testing.

Closes-bug: 1284263

Change-Id: I25160140e15721e0de4251ba2373a560d4b0ad46

10 years agoReplace assertEqual(None, *) with assertIsNone in tests
Alexander Bochkarev [Tue, 25 Feb 2014 11:32:11 +0000 (15:32 +0400)]
Replace assertEqual(None, *) with assertIsNone in tests

Replace assertEqual(None, *) with assertIsNone in tests to have
more clear messages in case of failure.

Change-Id: I2560aa559580fb068eb27174c9a7c8cd57e11b69

10 years agoReplace tearDown with addCleanup
Julia Varlamova [Wed, 12 Feb 2014 14:52:45 +0000 (18:52 +0400)]
Replace tearDown with addCleanup

Infra team has indicated that tearDown should not be used and should
be replaced with addCleanup in all places.

This patch replaces tearDown with addCleanup methods in cinder/tests/api.

Implements blueprint replace-teardown-with-addcleanup

Change-Id: I640c1985bf7fce6f2fbd4de8e56448b6c9af51ca

10 years agoUse six.StringIO instead of StringIO.StringIO
He Yongli [Mon, 17 Feb 2014 04:42:33 +0000 (12:42 +0800)]
Use six.StringIO instead of StringIO.StringIO

to keep Python 3.x compatibility, use six.StringIO/BytesIO to
replace StringIO.StringIO

StringIO works for unicode
BytesIO works for bytes

Change-Id: I5e40809b2347d4dbe031ba92dac4848b044d3af6
Closes-Bug: #1280100

10 years agoMerge "3PAR: Delete missing snapshot stuck in error_del"
Jenkins [Tue, 25 Feb 2014 07:03:04 +0000 (07:03 +0000)]
Merge "3PAR: Delete missing snapshot stuck in error_del"

10 years agoMerge "Implement retype in IBM GPFS Driver and refactor"
Jenkins [Tue, 25 Feb 2014 06:59:11 +0000 (06:59 +0000)]
Merge "Implement retype in IBM GPFS Driver and refactor"

10 years agoMerge "Added 3par initiator target map for FCZM"
Jenkins [Tue, 25 Feb 2014 06:59:02 +0000 (06:59 +0000)]
Merge "Added 3par initiator target map for FCZM"

10 years agoMerge "Fix invalid facilities documented in rootwrap.conf"
Jenkins [Tue, 25 Feb 2014 06:25:18 +0000 (06:25 +0000)]
Merge "Fix invalid facilities documented in rootwrap.conf"

10 years agoMerge "Fix race in test_delete_backup"
Jenkins [Mon, 24 Feb 2014 22:54:29 +0000 (22:54 +0000)]
Merge "Fix race in test_delete_backup"

10 years agoImplement retype in IBM GPFS Driver and refactor
Bill Owen [Thu, 13 Feb 2014 14:54:33 +0000 (07:54 -0700)]
Implement retype in IBM GPFS Driver and refactor

1. Add retype method to GPFS driver.  Currently only storge_pool
   attribute is handled.  Future patches will extend this.
2. Refactor migrate method to handle migration locally if source
   and target are in the same gpfs cluster.
3. Move driver into 'ibm' directory.
4. Refactor based on pylint feedback.
5. Replace mox with mock in unit test.
6. Improve exception handling and logging.

DocImpact

Implements: blueprint gpfs-volume-retype
Change-Id: Ibc3bc367e5d42940c69d6747774c82c8cad22a35

10 years ago3PAR: Delete missing snapshot stuck in error_del
Ramy Asselin [Mon, 24 Feb 2014 20:29:01 +0000 (12:29 -0800)]
3PAR: Delete missing snapshot stuck in error_del

If the snapshot is deleted outside of cinder, attempting
to delete it again results in the snapshot state stuck in
error_deleting.

This is because the current code raises a NotFound exception,
but the base cinder code does not catch this and update its db.

Instead, log a warning, and simply tell the base cinder code that it was
successfully deleted.

Change-Id: I5c5d24bc113e320346ff4f1f4f62fffdf7cddfc4
Closes-Bug: #1283233

10 years agoAdded 3par initiator target map for FCZM
Walter A. Boring IV [Mon, 24 Feb 2014 19:35:32 +0000 (11:35 -0800)]
Added 3par initiator target map for FCZM

This patch adds the required initiator target map
for the Fibre Channel Zone Manager.   The
FCZM looks for the initiator_target_map to try and
automatically zone up the endpoints.

Change-Id: I61aaf31752f8a5eebb672887c9a943584df66995
Closes-Bug: #1284275

10 years agoMerge "3PAR: Backend assisted volume migrate"
Jenkins [Mon, 24 Feb 2014 19:00:58 +0000 (19:00 +0000)]
Merge "3PAR: Backend assisted volume migrate"

10 years agoMerge "Add encrypted flag to volumes"
Jenkins [Mon, 24 Feb 2014 19:00:49 +0000 (19:00 +0000)]
Merge "Add encrypted flag to volumes"

10 years agoMerge "Sync oslo imageutils, strutils to cinder"
Jenkins [Mon, 24 Feb 2014 18:07:22 +0000 (18:07 +0000)]
Merge "Sync oslo imageutils, strutils to cinder"

10 years agoMerge "Add support for FC zone lifecycle management"
Jenkins [Mon, 24 Feb 2014 18:07:19 +0000 (18:07 +0000)]
Merge "Add support for FC zone lifecycle management"

10 years agoFix race in test_delete_backup
Avishay Traeger [Mon, 24 Feb 2014 17:55:15 +0000 (19:55 +0200)]
Fix race in test_delete_backup

Unit test sporadically failed due to timing issue - the deletion
timestamp on the backup was exactly the same as timeutils.utcnow(),
causing the AssertGreater check to fail.  Change to AssertGreaterEqual.

Change-Id: Ia66d0d4bdae3242780a91f0d384cbd17caa8c197
Closes-bug: #1284227

10 years agoMerge "Add x-openstack-request-id to cinder responses"
Jenkins [Mon, 24 Feb 2014 17:26:20 +0000 (17:26 +0000)]
Merge "Add x-openstack-request-id to cinder responses"

10 years agoMerge "Driver for IBM SONAS and Storwize V7000 Unified"
Jenkins [Mon, 24 Feb 2014 17:04:29 +0000 (17:04 +0000)]
Merge "Driver for IBM SONAS and Storwize V7000 Unified"

10 years agoDriver for IBM SONAS and Storwize V7000 Unified
Nilesh Bhosale [Fri, 27 Dec 2013 03:32:56 +0000 (09:02 +0530)]
Driver for IBM SONAS and Storwize V7000 Unified

The IBM NAS Driver currently implemented to work over NFS protocol,
and implements required set of features for OpenStack Icehouse release,
using the features of these storage products. It allows IBM® SONAS®
and Storwize® V7000 Unified filers to host storage for OpenStack
environment by integrating with Openstack Cinder service.

DocImpact

Change-Id: I0d630bf7e69454b88e9d1e93b4099631f6138204
Implements: blueprint ibm-nas-volume-driver
Related-Bug: #1281152

10 years agoMerge "Nexenta iSCSI driver: fixed volume_migration"
Jenkins [Mon, 24 Feb 2014 09:32:32 +0000 (09:32 +0000)]
Merge "Nexenta iSCSI driver: fixed volume_migration"

10 years agoMerge "Change default policy for volume_extension:volume_tenant_attribute"
Jenkins [Mon, 24 Feb 2014 08:39:02 +0000 (08:39 +0000)]
Merge "Change default policy for volume_extension:volume_tenant_attribute"

10 years agoMerge "Fix FC connection handling in the storwize driver"
Jenkins [Mon, 24 Feb 2014 08:16:24 +0000 (08:16 +0000)]
Merge "Fix FC connection handling in the storwize driver"

10 years agoMerge "Fix webob.exc.HTTPForbidden parameter miss"
Jenkins [Mon, 24 Feb 2014 08:16:16 +0000 (08:16 +0000)]
Merge "Fix webob.exc.HTTPForbidden parameter miss"

10 years agoFix webob.exc.HTTPForbidden parameter miss
Haiwei Xu [Mon, 24 Feb 2014 11:39:19 +0000 (20:39 +0900)]
Fix webob.exc.HTTPForbidden parameter miss

HTTPForbidden should use the parameter 'explanation'
instead of 'detail'.
This patch fixes this bug.

Change-Id: I688145f7ea942277c7d3ed3221d6ff2bc7a852ad
Closes-Bug: #1283872

10 years agoStorwize/SVC: Change volume copy task to async
LarryLiu [Fri, 14 Feb 2014 07:46:07 +0000 (15:46 +0800)]
Storwize/SVC: Change volume copy task to async

If Cinder crashes during a migration or retype (where data is moved and
the operation can take a long time), the storage ends up with multiple
copies of the same volume which requires storage admin intervention.

This patch maintain a list of pending operations which is backed up in
admin metadata, and a periodic task reviews the list and removes volume
copies whose copy operation completed. When Cinder comes up, check the
admin metadata and rebuild the list.

Change-Id: I6549712bb0083996faced89c2207a4c438ae953d
Closes-Bug: #1278035

10 years agoFix FC connection handling in the storwize driver
Zoltan Arnold Nagy [Wed, 12 Feb 2014 22:01:10 +0000 (23:01 +0100)]
Fix FC connection handling in the storwize driver

Creating FC connections was not working due to several issues:

1. The lsfabric command in the Storwize/SVC omitted the delimeter and so
the output was not correctly parsed by the driver.
2. In some cases comparisons of WWPNs were not case insensitive - ensure
we compare lower-case WWPNs.
3. If the host supplied extra information in the connector (e.g. iSCSI
initiator name in case of an FC setup, or FC WWNNs/WWPNs in an iSCSI
setup), the driver would try to make those host mappings on the storage
too.  This could lead into unwanted behaviour and confusing error
messages (for example, in an FC setup reaching the maximum number of
iSCSI mappings).

In addition, unit tests weren't properly testing FC - instead they were
always testing iSCSI due to an error in parsing extra_specs. This patch
fixes that error and the unit tests as well.

These changes must all be made together for unit tests to pass.

Closes-bug: 1279758
Change-Id: I64e21609ba089cf5bfd52ce2644f6f229bcc69dc

10 years agoMerge "Remove old driver mapping deprecation"
Jenkins [Sun, 23 Feb 2014 13:00:13 +0000 (13:00 +0000)]
Merge "Remove old driver mapping deprecation"

10 years agoAdd support for FC zone lifecycle management
Santhoshkumar Kolathur [Sat, 31 Aug 2013 02:48:52 +0000 (19:48 -0700)]
Add support for FC zone lifecycle management

Allows automated zone lifecycle management in the attach/detach
entry points of the volume manager for FC volumes (when fabric
zoning is enabled). Zones are configured automatically as part
of the active zone set in the FC SAN to provide a more flexible
and secure way of controlling access. FC zone manager enables
SAN vendors to add support for pluggable implementations.

Change-Id: I86e02e11afec71ffa25dfbcbd0dc3ddcc35741ea
Implements: blueprint cinder-fc-zone-manager

10 years agoGive a way to save why a service has been disabled
Jay Lau [Sat, 22 Feb 2014 10:47:47 +0000 (05:47 -0500)]
Give a way to save why a service has been disabled

Port from nova https://review.openstack.org/#/c/26020/

We added a field to the table of service to log a reason when a
service has been disabled.

We added a new API extension called os-extended-services.

The new extension will extend the os-services extension adding a
method for disabling a service and specify a reason for that:
PUT /v2/{tenant_id}/os-services/disable-log-reason

When the os-extended-extension is loaded the call:
GET /V2/{tenant_id}/os-services
will return the list of services with disable reason information
if that exists.

DocImpact

Change-Id: I885e43132b0e49b63f7858abd3fcffe1b78d3fd8
Implements bp record-reason-for-disabling-service

10 years agoMerge "Add HP MSA Fiber Channel driver"
Jenkins [Sat, 22 Feb 2014 05:05:11 +0000 (05:05 +0000)]
Merge "Add HP MSA Fiber Channel driver"

10 years agoMerge "Use six.moves cStringIO instead of cStringIO"
Jenkins [Sat, 22 Feb 2014 02:07:10 +0000 (02:07 +0000)]
Merge "Use six.moves cStringIO instead of cStringIO"

10 years agoRemove old driver mapping deprecation
Mike Perez [Tue, 18 Feb 2014 02:21:12 +0000 (18:21 -0800)]
Remove old driver mapping deprecation

This deprecation was introduced back in Grizzly, which will be EOL after
IceHouse. Removing to clean things up.

Change-Id: I509bb4115c3c88a7af7326125feb760f20847b8d

10 years agoMerge "Add support for qos_specs feature to 3PAR drivers"
Jenkins [Fri, 21 Feb 2014 19:15:22 +0000 (19:15 +0000)]
Merge "Add support for qos_specs feature to 3PAR drivers"

10 years agoMerge "Update 3PAR drivers to pass cert test"
Jenkins [Fri, 21 Feb 2014 19:10:05 +0000 (19:10 +0000)]
Merge "Update 3PAR drivers to pass cert test"

10 years ago3PAR: Backend assisted volume migrate
Ramy Asselin [Thu, 13 Feb 2014 00:23:15 +0000 (16:23 -0800)]
3PAR: Backend assisted volume migrate

This patch implements volume migrate using native 3PAR APIs.

Prerequisites:
1. Same 3PAR backend
2. Volume cannot be attached
3. Source and Dest CPGS are in the same domain

Steps:
1. Create a temporary volume in the destination with a copy of the source
2. Wait for the copy to complete
3. Delete the source
4. Rename the temporary to the same name as the original

Change-Id: Ia42503d41bf8afd908cd3ffb0288f0d353f313f1
Implements: blueprint native-3par-migrate-volume

10 years agoMerge "Ensure return for db api functions"
Jenkins [Fri, 21 Feb 2014 00:18:54 +0000 (00:18 +0000)]
Merge "Ensure return for db api functions"

10 years agoMerge "Update gpfs driver volume creation process"
Jenkins [Thu, 20 Feb 2014 20:08:44 +0000 (20:08 +0000)]
Merge "Update gpfs driver volume creation process"

10 years agoMerge "Remove unused function"
Jenkins [Thu, 20 Feb 2014 16:35:58 +0000 (16:35 +0000)]
Merge "Remove unused function"

10 years agoAdd HP MSA Fiber Channel driver
Gauvain Pocentek [Thu, 13 Feb 2014 20:34:59 +0000 (21:34 +0100)]
Add HP MSA Fiber Channel driver

This commit implements a driver for the HP MSA arrays. Only Fiber
Channel is supported for now.

Implements: blueprint add-msa-2040-driver
DocImpact
Change-Id: I75232cafadf7f6d15c5959d6c054f2e0f4d14e2c

10 years agoEnsure return for db api functions
Avishay Traeger [Thu, 20 Feb 2014 11:22:37 +0000 (13:22 +0200)]
Ensure return for db api functions

Functions in db/api.py should return whatever the implementation of
those functions return. This is important for qos_specs_update which
returns something for the sqlalchemy implementation, but for others as
well for future implementations.

Added 'return' for functions that were missing it.

Change-Id: I384b1cf915b2d2238fd75d23b17558cae2cf9f50
Closes-Bug: #1272365

10 years agoMerge "HP LeftHand Backend assisted volume migrate"
Jenkins [Thu, 20 Feb 2014 10:11:35 +0000 (10:11 +0000)]
Merge "HP LeftHand Backend assisted volume migrate"

10 years agoMerge "IBM XIV and DS8000 Driver reorganizing (IBM dir)"
Jenkins [Thu, 20 Feb 2014 03:30:30 +0000 (03:30 +0000)]
Merge "IBM XIV and DS8000 Driver reorganizing (IBM dir)"

10 years agoMerge "GPFS: Implement volume backup and restore"
Jenkins [Wed, 19 Feb 2014 23:17:02 +0000 (23:17 +0000)]
Merge "GPFS:  Implement volume backup and restore"

10 years agoHP LeftHand Backend assisted volume migrate
Jim Branen [Sat, 15 Feb 2014 00:02:55 +0000 (16:02 -0800)]
HP LeftHand Backend assisted volume migrate

This patch implements volume migrate using native LeftHand APIs.

Limitations:
1. Same LeftHand backend
2. Volume cannot be attached
3. Volumes with snapshots cannot be migrated
4. Source and Destination clusters must be in the same management group
5. Volume re-type not supported

Change-Id: I503d5a10ee59db14130c676a5c3a07abf9a2b7af
Implements: blueprint native-lefthand-volume-migrate

10 years agoAdd support for qos_specs feature to 3PAR drivers
Kurt Martin [Wed, 12 Feb 2014 01:38:13 +0000 (17:38 -0800)]
Add support for qos_specs feature to 3PAR drivers

This patch includes the ability to set the qos-specs for the
existing 3PAR qos settings (maxIOP and maxBWS) in addition to
the new settingis listed below. We would prefer that the
new qos-specs associated to a volume type be used, but this
patch also supports setting these values the old way in extra-specs
for backwards compatibility.

This patch also adds two additional personas to the list of
valid personas that are now support by the 3PAR backends.

DocImpact: Implements new qos settings
minIOPS - The minimum IOPs per second
minBWS - The minimum bandwidth per second
latency - The QOS I/O target latency
priority - The QOS scheduling priority (high, normal, low)
The priority defaults to normal

Two new personas added include HPUX and WindowsServer

Change-Id: I7f94a493919dc2d34daac91d684369d1f51c974c
Implements: blueprint add-qosspec-support-to-3par-drivers

10 years agoAdd x-openstack-request-id to cinder responses
Chris Buccella [Fri, 14 Feb 2014 23:29:28 +0000 (23:29 +0000)]
Add x-openstack-request-id to cinder responses

x-openstack-request-id is the common header name for request ID going forward.
Currently, only glance and neutron return this header. Using the request_id
middleware is a convenient way to ensure this header is in the response. We will
also be using the middleware to generate the request ID.

The ID will be generated by the middleware and is inserted into the request
environment. The current code generates the request ID in the constructor of
RequestConext; with this change, the ID is generated beforehand and passed in to
the RequestContext constructor. Not much different here: a request ID is
generated and is available for use in the handling of the request.

On the response end, the middleware is again used, this time to attach the
x-openstack-request-id header, using the value of the generated request ID. The
current code attaches the x-compute-request-id header.

This change is a necessary step toward logging the mapping of request IDs across
OpenStack services.

UpgradeImpact: api-paste.ini is modified

Change-Id: I30c4e5efa77f9ebffb485d2ea6a6c3f78eb1573f
Implements: blueprint add-standard-req-id-header

10 years agoMerge "Sync request_id, request_utils for cinder"
Jenkins [Wed, 19 Feb 2014 17:06:17 +0000 (17:06 +0000)]
Merge "Sync request_id, request_utils for cinder"

10 years agoUpdate 3PAR drivers to pass cert test
Walter A. Boring IV [Mon, 10 Feb 2014 21:09:28 +0000 (13:09 -0800)]
Update 3PAR drivers to pass cert test

This patch updates both the HP 3PAR Fibre Channel
and HP 3PAR iSCSI block storage drivers so that they
can pass the driver certification tests.  We also updated
the unit tests to use mock instead of mox.

These versions of the drivers require the new 3.0.0 hp3parclient,
which can be downloaded from the pypi repository:
https://pypi.python.org/pypi/hp3parclient
The new hp3parclient requires the 3.1.3 firmware on the HP 3PAR.

The driver certification results:
Related-Bug: #1278575
Related-Bug: #1278577

Closes-Bug: #1279137

Change-Id: I72e0a76c865e54c58e41cc4409555d9042e30267
DocImpact: Document new driver requirements.

10 years agoMerge "Implement retype in HP LeftHand driver"
Jenkins [Wed, 19 Feb 2014 16:58:21 +0000 (16:58 +0000)]
Merge "Implement retype in HP LeftHand driver"

10 years agoRemove unused function
Wu Wenxiang [Wed, 19 Feb 2014 13:58:48 +0000 (21:58 +0800)]
Remove unused function

Romove unused function stub_out_rate_limiting in
cinder/tests/api/fakes.py

Change-Id: Ib6fea599eacb140108ca4293cdd089b010a8b979
Closes-Bug: #1282098

10 years agoUse len instead of for-loop to get the end index
Wu Wenxiang [Wed, 19 Feb 2014 13:39:41 +0000 (21:39 +0800)]
Use len instead of for-loop to get the end index

Use len() instead of for-loop to get the end index in file
cinder/tests/test_backup_tsm.py

Change-Id: I3a7b0e418f8af4881e21eb5273a03dbcd317c27d
Closes-Bug: #1282084

10 years agoEnsures NetApp iSCSI driver correctly compares int values for size
Andrew Kerr [Tue, 18 Feb 2014 22:38:12 +0000 (17:38 -0500)]
Ensures NetApp iSCSI driver correctly compares int values for size

The NetApp iSCSI driver needs to verify that the new size requested
during an extend operation does not exceed the max_resize of the
lun.  However, the driver was doing a >= compare against str values
of the sizes rather than the int values.  This caused the incorrect
code path to be used in certain situations.

Change-Id: I8bc66c71db6b469c7adf00ce8b5091513fccb740
Closes-Bug: 1281279

10 years agoSync request_id, request_utils for cinder
Chris Buccella [Sat, 15 Feb 2014 02:29:43 +0000 (02:29 +0000)]
Sync request_id, request_utils for cinder

This is in preparation for work being done on request ID tracing across
OpenStack services.

Per discussion in blueprint cross-service-request-id , the standard header
name for the request ID across OpenStack projects should be
x-openstack-request-id. The request_id middleware was created for just this
purpose, as oslo change Ic7967cd62e7b743343d70f751b9238339171e013 . Using the
same middleware allows for consistency across projects.

There is an additional oslo module, request_utils, introduced as
change Id085c4444fee2bb68b80738bfe77ccb0ba1908ec to allow uniform logging of
request IDs. Bring that in as well so we have it when necessary.

Implements: blueprint add-standard-req-id-header
Change-Id: If080df2a323347924c93a912538dab5ffeffe982

10 years agoIBM XIV and DS8000 Driver reorganizing (IBM dir)
erikzaadi [Mon, 10 Feb 2014 11:01:36 +0000 (13:01 +0200)]
IBM XIV and DS8000 Driver reorganizing (IBM dir)

    * renamed:    cinder/volume/drivers/xiv_ds8k.py
                  -> cinder/volume/drivers/ibm/xiv_ds8k.py
    * updated all references to old xiv_ds8k paths
    * regenerated sample.conf

Change-Id: Iab094c78a0e4eb1753fe8809089ba1337d95e2e0
Partially implements: blueprint ibm-volume-driver-reorg

10 years agoSync oslo imageutils, strutils to cinder
Zhongyue Luo [Mon, 13 Jan 2014 01:44:56 +0000 (09:44 +0800)]
Sync oslo imageutils, strutils to cinder

Changes in imageutils:
===============================
bec3a5e Implements SI/IEC unit system conversion to bytes
8b2b0b7 Use hacking import_exceptions for gettextutils._
aad179d Fixing misspelled encryption key in QemuImgInfo
12bcdb7 Remove vim header
2bd46eb Refactors byte size extraction logic

Changes in strutils:
====================
bec3a5e Implements SI/IEC unit system conversion to bytes
e53fe85 strutils bool_from_string, allow specified default
8b2b0b7 Use hacking import_exceptions for gettextutils._
84d461e Fix a bug in safe_encode where it returns a bytes object in py3
12bcdb7 Remove vim header
3970d46 Fix typos in oslo
1a2df89 Enable H302 hacking check
67bd769 python3: Fix traceback while running python3.
b0c51ec Refactors to_bytes

Change-Id: I765bcd40f959162874bfda412b69e673c6e5f732
Related-bug: #1189635
Related-bug: #1193765
Related-Bug: #1257829