]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log
summary |
shortlog | log |
commit |
commitdiff |
review |
tree
first ⋅ prev ⋅ next
Ken Barber [Sat, 17 Sep 2011 22:40:53 +0000 (23:40 +0100)]
(#9576) Align spec framework with Puppet core.
The point of this change is to align the spec testing behaviour with Puppet core
so we can get similar behaviour and less problems if we ever want to move this
type into core.
Jonathan Boyett [Mon, 29 Aug 2011 19:02:46 +0000 (12:02 -0700)]
Merge pull request #9 from bookest/patch-1
use iptables-save in the persistent rules example
Christopher Grim [Sat, 27 Aug 2011 01:52:44 +0000 (22:52 -0300)]
use iptables-save in the persistent rules example
Jonathan Boyett [Tue, 16 Aug 2011 17:54:35 +0000 (10:54 -0700)]
fix provider source parameter
Jonathan Boyett [Tue, 16 Aug 2011 17:06:22 +0000 (10:06 -0700)]
create ip6tables test manifest
Jonathan Boyett [Tue, 16 Aug 2011 17:05:58 +0000 (10:05 -0700)]
create ip6tables provider
Jonathan Boyett [Tue, 16 Aug 2011 17:05:20 +0000 (10:05 -0700)]
add newvalue ipv6-icmp to proto
Jonathan Boyett [Tue, 16 Aug 2011 17:04:27 +0000 (10:04 -0700)]
improving rule slicing and dicing
Jonathan Boyett [Mon, 15 Aug 2011 22:49:54 +0000 (15:49 -0700)]
convert class variables to instance variables so we can have unique attributes for each type
Jonathan Boyett [Mon, 15 Aug 2011 18:18:14 +0000 (11:18 -0700)]
small refactor of value munging of existing rules
Jonathan Boyett [Mon, 15 Aug 2011 18:16:14 +0000 (11:16 -0700)]
Merge branch 'master' of github.com:puppetlabs/puppetlabs-firewall
Jonathan Boyett [Mon, 15 Aug 2011 18:13:20 +0000 (11:13 -0700)]
allow only a single source or destination value per resource. fixes #2
Jonathan Boyett [Mon, 15 Aug 2011 18:13:20 +0000 (11:13 -0700)]
allow only a single source or destination value per resource. fixes #4
Jonathan Boyett [Mon, 15 Aug 2011 17:13:25 +0000 (10:13 -0700)]
fix state array in readme.pp rule
Jonathan Boyett [Mon, 15 Aug 2011 16:42:21 +0000 (09:42 -0700)]
fix --libdir in iptables example run script
Ken Barber [Mon, 8 Aug 2011 12:07:58 +0000 (14:07 +0200)]
Fix iptables option ordering issues (thanks to Adrian Bridgett)
Ken Barber [Sun, 17 Jul 2011 02:51:50 +0000 (04:51 +0200)]
Removed a bug I introduced from the last commit. 'desc' is not valid in ensure values.
Ken Barber [Sat, 16 Jul 2011 19:45:00 +0000 (21:45 +0200)]
(#6) - added action property to type for future provider support.
Ken Barber [Sat, 16 Jul 2011 19:33:40 +0000 (21:33 +0200)]
Applied docs to explain putting rejects in post stage (#4). Plus some re-organisation of documentation to bundle property types together.
Ken Barber [Sat, 16 Jul 2011 19:19:49 +0000 (21:19 +0200)]
Removed iptables stuff, introduced features and cleaned up docs & validation.
I've removed a lot of iptables specific stuff from the type, also
allowed any chain to be defined in :chain or :jump so we can support
user chains.
A lot of the documentation for the type has been cleaned up a little
and validation has been simplified where applicable.
This commit brings in the usage of features so we can start to introduce
more backend providers. The work is just a start for now and will
probably radically change once we have other working providers in
place.
Jonathan Boyett [Mon, 11 Jul 2011 17:19:07 +0000 (10:19 -0700)]
replace String#lines with a String#split to ensure compatibility with Ruby 1.8.5
Jonathan Boyett [Mon, 11 Jul 2011 17:18:20 +0000 (10:18 -0700)]
ensure the name parameter starts with a digit
Ken Barber [Sun, 10 Jul 2011 22:42:25 +0000 (23:42 +0100)]
Added quickstart not on how to make firewall rules persistent.
Jonathan Boyett [Tue, 28 Jun 2011 18:41:03 +0000 (11:41 -0700)]
use setup methods in iptables_prov_spec
Jonathan Boyett [Tue, 28 Jun 2011 18:40:43 +0000 (11:40 -0700)]
use setup_resource method in iptables_type_spec
Jonathan Boyett [Tue, 28 Jun 2011 18:39:51 +0000 (11:39 -0700)]
create helper methods for provider, resource, and instance setup
Ken Barber [Wed, 22 Jun 2011 19:16:53 +0000 (20:16 +0100)]
Add note about pluginsync for installation.
Jonathan Boyett [Wed, 22 Jun 2011 17:23:52 +0000 (10:23 -0700)]
add masquerade sample to test manifest
Jonathan Boyett [Wed, 22 Jun 2011 17:23:19 +0000 (10:23 -0700)]
fix outiface validation to check for postrouting chain
Ken Barber [Mon, 20 Jun 2011 22:30:01 +0000 (23:30 +0100)]
Small example for MASQUERADE.
Ken Barber [Mon, 20 Jun 2011 22:26:49 +0000 (23:26 +0100)]
Fix 1 line in doc.
Ken Barber [Mon, 20 Jun 2011 22:24:18 +0000 (23:24 +0100)]
Some initial parameter documentation for README.markdown.
Jonathan Boyett [Mon, 20 Jun 2011 20:06:06 +0000 (13:06 -0700)]
add additional iptables provider unit tests
Jonathan Boyett [Thu, 16 Jun 2011 22:54:07 +0000 (15:54 -0700)]
add instances test
Jonathan Boyett [Thu, 16 Jun 2011 21:50:13 +0000 (14:50 -0700)]
remove unnecessary require from type
Jonathan Boyett [Thu, 16 Jun 2011 21:46:29 +0000 (14:46 -0700)]
let icmp param accept integers in addition to strings
Jonathan Boyett [Thu, 16 Jun 2011 18:59:13 +0000 (11:59 -0700)]
remove array length validation from dport and sport
Jonathan Boyett [Thu, 16 Jun 2011 18:33:14 +0000 (11:33 -0700)]
move rspec options to rakefile
Jonathan Boyett [Thu, 16 Jun 2011 18:13:53 +0000 (11:13 -0700)]
remove extra file
Jonathan Boyett [Thu, 16 Jun 2011 18:12:07 +0000 (11:12 -0700)]
add tests for remaining params
Jonathan Boyett [Wed, 15 Jun 2011 22:08:33 +0000 (15:08 -0700)]
add tests for table, proto, jump, source, and destination params
Jonathan Boyett [Wed, 15 Jun 2011 21:22:11 +0000 (14:22 -0700)]
Merge branch 'master' of github.com:puppetlabs/puppetlabs-firewall
Jonathan Boyett [Wed, 15 Jun 2011 21:18:58 +0000 (14:18 -0700)]
add test for name, table, chain, dport, and sport parameters
Ken Barber [Wed, 15 Jun 2011 20:54:56 +0000 (22:54 +0200)]
Added some notes about how to run tests.
Jonathan Boyett [Wed, 15 Jun 2011 20:42:58 +0000 (13:42 -0700)]
add rakefile
Jonathan Boyett [Wed, 15 Jun 2011 20:42:49 +0000 (13:42 -0700)]
add type tests
Jonathan Boyett [Wed, 15 Jun 2011 20:42:36 +0000 (13:42 -0700)]
add provider tests
Jonathan Boyett [Wed, 15 Jun 2011 20:42:15 +0000 (13:42 -0700)]
add spec.opts
Jonathan Boyett [Wed, 15 Jun 2011 20:42:01 +0000 (13:42 -0700)]
add spec_helper
Ken Barber [Wed, 15 Jun 2011 15:34:26 +0000 (17:34 +0200)]
More doc improvements.
Ken Barber [Wed, 15 Jun 2011 15:28:52 +0000 (17:28 +0200)]
Added some more examples and README cleanup.
Ken Barber [Wed, 15 Jun 2011 15:15:53 +0000 (17:15 +0200)]
Ignore pkg/ so when we generate a forge module we don't also try to add that
croft as well to our git repo.
Ken Barber [Wed, 15 Jun 2011 15:15:35 +0000 (17:15 +0200)]
Added LICENSE and Modulefile to complete scaffolding.
Ken Barber [Wed, 15 Jun 2011 15:14:10 +0000 (17:14 +0200)]
Firewall wasn't acknowledging new properties, only ones that were created at
resource creation time. This patch fixes that by analyzing the resource_map
hash.
The proto property needs to be defaulted to 'all' when it doesn't exist as well
to stop the provider from trying to change it each time.
Jonathan Boyett [Fri, 13 May 2011 20:40:37 +0000 (13:40 -0700)]
remove rulenum param
Jonathan Boyett [Fri, 13 May 2011 20:37:59 +0000 (13:37 -0700)]
munge is data to be of the same type as should
Jonathan Boyett [Fri, 13 May 2011 20:37:30 +0000 (13:37 -0700)]
allow arrays in dport, sport, destination, source, and state
Jonathan Boyett [Thu, 12 May 2011 02:07:27 +0000 (19:07 -0700)]
join arrays and use insert order to determine replacement position
Jonathan Boyett [Thu, 12 May 2011 02:06:48 +0000 (19:06 -0700)]
use array_matching for values which accept arrays
Jonathan Boyett [Wed, 11 May 2011 21:28:39 +0000 (14:28 -0700)]
fix typo
Jonathan Boyett [Wed, 11 May 2011 18:45:47 +0000 (11:45 -0700)]
change default forward drop to use the correct chain
Jonathan Boyett [Wed, 11 May 2011 18:08:52 +0000 (11:08 -0700)]
add missing commas to test manifest. whoops.
Jonathan Boyett [Wed, 11 May 2011 18:07:29 +0000 (11:07 -0700)]
add additional test rules to examples
Jonathan Boyett [Wed, 11 May 2011 16:59:16 +0000 (09:59 -0700)]
convert dports and sports to port numbers during munge
Jonathan Boyett [Wed, 11 May 2011 16:44:14 +0000 (09:44 -0700)]
outiface requires the output chain
Jonathan Boyett [Wed, 11 May 2011 16:37:11 +0000 (09:37 -0700)]
include Puppet::Util::Firewall to fix icmp values
Jonathan Boyett [Tue, 10 May 2011 22:30:46 +0000 (15:30 -0700)]
cleanup flush and insert_order methods
Jonathan Boyett [Tue, 10 May 2011 21:41:07 +0000 (14:41 -0700)]
mk_resource_methods prevents method_missing from running. also add rulenum param
Jonathan Boyett [Tue, 10 May 2011 17:07:38 +0000 (10:07 -0700)]
convert resource[:chain] to string when checking equality and just add name to array
Jonathan Boyett [Mon, 9 May 2011 23:24:29 +0000 (16:24 -0700)]
add examples
Jonathan Boyett [Mon, 9 May 2011 23:24:18 +0000 (16:24 -0700)]
add facter facts
Jonathan Boyett [Mon, 9 May 2011 23:23:50 +0000 (16:23 -0700)]
fix namespacing issues
Jonathan Boyett [Mon, 9 May 2011 23:23:26 +0000 (16:23 -0700)]
convert unless values in validation to strings
Jonathan Boyett [Mon, 9 May 2011 23:22:32 +0000 (16:22 -0700)]
add iptables provider
Jonathan Boyett [Mon, 9 May 2011 17:53:18 +0000 (10:53 -0700)]
firewall type only needs to require firewall util
Jonathan Boyett [Mon, 9 May 2011 17:52:48 +0000 (10:52 -0700)]
add firewall util
Jonathan Boyett [Mon, 9 May 2011 17:52:26 +0000 (10:52 -0700)]
add ipcidr util
Jonathan Boyett [Mon, 9 May 2011 17:31:14 +0000 (10:31 -0700)]
add firewall type to module
Jonathan Boyett [Mon, 9 May 2011 15:56:43 +0000 (08:56 -0700)]
fix readme header
Jonathan Boyett [Mon, 9 May 2011 15:55:19 +0000 (08:55 -0700)]
initial commit