]> review.fuel-infra Code Review - openstack-build/heat-build.git/log
openstack-build/heat-build.git
11 years agoPorts depend on the subnets in the same network.
Steve Baker [Thu, 27 Jun 2013 01:39:30 +0000 (13:39 +1200)]
Ports depend on the subnets in the same network.

Without establishing this implicit dependency, the following
sometimes occurs:
- Ports get assigned to instances without any IP address
- Stack delete fails as ports still exist in subnets.

Fixes bug: #1192371

Change-Id: Ifd892cef4c2eebaea5568afbd320c8865c845d70

11 years agoMerge "Pass before and after snippets to template diff"
Jenkins [Wed, 26 Jun 2013 19:24:58 +0000 (19:24 +0000)]
Merge "Pass before and after snippets to template diff"

11 years agoMerge "Changes for HOT hello world template processing"
Jenkins [Wed, 26 Jun 2013 19:15:53 +0000 (19:15 +0000)]
Merge "Changes for HOT hello world template processing"

11 years agoMerge "engine : stack_resource change state_description to status_reason"
Jenkins [Wed, 26 Jun 2013 12:49:41 +0000 (12:49 +0000)]
Merge "engine : stack_resource change state_description to status_reason"

11 years agoMerge "Cache snippets in StackUpdate"
Jenkins [Wed, 26 Jun 2013 12:05:56 +0000 (12:05 +0000)]
Merge "Cache snippets in StackUpdate"

11 years agoengine : stack_resource change state_description to status_reason
Steven Hardy [Wed, 26 Jun 2013 11:27:05 +0000 (12:27 +0100)]
engine : stack_resource change state_description to status_reason

The internal API changed this name recently, but this got missed
due to lack of test coverage for this exception.  Turns out adding
that test coverage is really hard due to all the coroutine magic,
so we'll have to fix that at some later time.

Change-Id: I98a0c5bb8f3f001a7d215bcdf64cad841e42ef85

11 years agoMerge "Store created nova client in OpenStackClients."
Jenkins [Wed, 26 Jun 2013 05:29:20 +0000 (05:29 +0000)]
Merge "Store created nova client in OpenStackClients."

11 years agoMerge "Allow a resource delete to be re-attempted."
Jenkins [Wed, 26 Jun 2013 04:45:22 +0000 (04:45 +0000)]
Merge "Allow a resource delete to be re-attempted."

11 years agoMerge "Handle YAML parser error as well"
Jenkins [Wed, 26 Jun 2013 03:50:03 +0000 (03:50 +0000)]
Merge "Handle YAML parser error as well"

11 years agoMerge "Simplify a stack update unit test"
Jenkins [Wed, 26 Jun 2013 02:51:53 +0000 (02:51 +0000)]
Merge "Simplify a stack update unit test"

11 years agoMerge "Refactor and partly parallelise stack update code"
Jenkins [Wed, 26 Jun 2013 02:42:16 +0000 (02:42 +0000)]
Merge "Refactor and partly parallelise stack update code"

11 years agoMerge "Allow JSON values for parameters"
Jenkins [Wed, 26 Jun 2013 01:52:02 +0000 (01:52 +0000)]
Merge "Allow JSON values for parameters"

11 years agoMerge "OS::Quantum::Subnet resource, add enable_dhcp"
Jenkins [Tue, 25 Jun 2013 16:26:52 +0000 (16:26 +0000)]
Merge "OS::Quantum::Subnet resource, add enable_dhcp"

11 years agoHandle YAML parser error as well
Jianing YANG [Tue, 25 Jun 2013 15:55:40 +0000 (23:55 +0800)]
Handle YAML parser error as well

Fixes bug: #1185590
Change-Id: Id561e2769d1f0192dd831450f10e05e8213bffa8

11 years agoMerge "Add initial suspend logic to engine"
Jenkins [Tue, 25 Jun 2013 15:10:59 +0000 (15:10 +0000)]
Merge "Add initial suspend logic to engine"

11 years agoChanges for HOT hello world template processing
Thomas Spatzier [Mon, 17 Jun 2013 11:50:52 +0000 (13:50 +0200)]
Changes for HOT hello world template processing

This patch contains the base enabling code required for processing a most
simple HOT template ("hot hello world"), so that the template can be
parsed and a stack with a single instance can be deployed.

Contributes to blueprint hot-hello-world

Change-Id: I4f0a04a06fab2f5472cb4481dcdf10d5239d5def

11 years agoOS::Quantum::Subnet resource, add enable_dhcp
Steven Hardy [Tue, 25 Jun 2013 08:49:34 +0000 (09:49 +0100)]
OS::Quantum::Subnet resource, add enable_dhcp

Add enable_dhcp to the properties schema, since quantumclient
code indicates this is allowed in the body (not only expected
in the response as currently indicated by the docs)

Fixes bug #1194394

Change-Id: I19770b033696ea9a27b6e985a52bf2cfadb16f52

11 years agoMerge "Use print_function compatible syntax"
Jenkins [Tue, 25 Jun 2013 01:57:54 +0000 (01:57 +0000)]
Merge "Use print_function compatible syntax"

11 years agoMerge "Adding common base class for Rackspace Resource providers"
Jenkins [Tue, 25 Jun 2013 00:20:42 +0000 (00:20 +0000)]
Merge "Adding common base class for Rackspace Resource providers"

12 years agoStore created nova client in OpenStackClients.
Steve Baker [Mon, 24 Jun 2013 03:21:43 +0000 (15:21 +1200)]
Store created nova client in OpenStackClients.

All created clients are stored in the instance of OpenStackClients
which is associated with a stack - this prevents clients from
being repeatedly created throughout the request.

Commit f3fc5c5 introduced a regression which stopped storing the
nova client. This change addresses that regression.

Change-Id: I60088b60f623aac11e473d185f2924d4f4bd1cfe

12 years agoAllow JSON values for parameters
Randall Burt [Wed, 19 Jun 2013 01:38:27 +0000 (20:38 -0500)]
Allow JSON values for parameters

Adds a paramter type that accepts JSON objects or strings representing JSON
objects as values.

Implements: blueprint json-parameters
Change-Id: I1ad62df28832a2e07249452133fd9f14995f8e23

12 years agoAdd initial suspend logic to engine
Steven Hardy [Wed, 15 May 2013 18:01:39 +0000 (19:01 +0100)]
Add initial suspend logic to engine

blueprint: stack-suspend-resume
Change-Id: Icf81672534de6b07d938785e659b7f6c733eacc4

12 years agoUse print_function compatible syntax
Dirk Mueller [Mon, 24 Jun 2013 13:41:51 +0000 (15:41 +0200)]
Use print_function compatible syntax

This changes the code to use a python 3.x compatible
print function syntax (or import from __future__ where
necessary)

Change-Id: Ia1f19d0ac082853d25c7c9b754b440469c0526eb

12 years agoMerge "Fixup some trivial license header mismatches"
Jenkins [Mon, 24 Jun 2013 10:44:06 +0000 (10:44 +0000)]
Merge "Fixup some trivial license header mismatches"

12 years agoMerge "Emit alarm actions if a rule remains in ALARM state."
Jenkins [Mon, 24 Jun 2013 10:42:12 +0000 (10:42 +0000)]
Merge "Emit alarm actions if a rule remains in ALARM state."

12 years agoMerge "make stack creation return json response"
Jenkins [Mon, 24 Jun 2013 09:16:25 +0000 (09:16 +0000)]
Merge "make stack creation return json response"

12 years agoAllow a resource delete to be re-attempted.
Steve Baker [Mon, 24 Jun 2013 02:30:23 +0000 (14:30 +1200)]
Allow a resource delete to be re-attempted.

If a resource is in a DELETE IN_PROGRESS state, and the resource
is deleted again, another attempt will be made to delete the resource.

Fixes bug: #1193975

Change-Id: I615612b4e5f21f2a2cb168f47c33a8f9db7e9e81

12 years agoEmit alarm actions if a rule remains in ALARM state.
Steve Baker [Mon, 24 Jun 2013 02:19:36 +0000 (14:19 +1200)]
Emit alarm actions if a rule remains in ALARM state.

It looks like the original intent of this edge-triggering was to
prevent actions being emitted too frequently, causing overshoot of
scaling resources.

However this causes an issue when one scaling resource change is not
enough to bring the alarm state under the threshold.

Proper use of Period, EvaluationPeriods and Threshold should be sufficient
to prevent scaling resource overshoot.

Fixes bug: #1193970

Change-Id: I5b38eb82cd1ad568fe4af77999e9d52f9eb99328

12 years agoFixup some trivial license header mismatches
Dirk Mueller [Sun, 23 Jun 2013 18:57:04 +0000 (20:57 +0200)]
Fixup some trivial license header mismatches

Newer Hacking releases are pedantic about the
license header. Fix up the trivial mismatch.

Change-Id: I418222734303b8578ab0b34b8eb044d9543fc888

12 years agoAdding common base class for Rackspace Resource providers
Vijendar Komalla [Thu, 20 Jun 2013 17:09:02 +0000 (12:09 -0500)]
Adding common base class for Rackspace Resource providers

Change-Id: If7d15e01c53fb6db4bdee5759b0ef4f087640c58

12 years agoPass before and after snippets to template diff
Zane Bitter [Thu, 13 Jun 2013 18:03:28 +0000 (20:03 +0200)]
Pass before and after snippets to template diff

The before template should be passed explicitly, rather than relying on
some state stored in the object.

Change-Id: I5b0af8da2e1df3f6ad3291554cbbc243b51e3fe5

12 years agoCache snippets in StackUpdate
Zane Bitter [Thu, 13 Jun 2013 18:03:28 +0000 (20:03 +0200)]
Cache snippets in StackUpdate

Change-Id: I1720a7c14edaf1d70b0894c2a4655f101d1c38eb

12 years agoSimplify a stack update unit test
Zane Bitter [Thu, 13 Jun 2013 18:03:27 +0000 (20:03 +0200)]
Simplify a stack update unit test

Separate out the two resources into separate classes that can be mocked (or
not) independently.

Change-Id: I0d8fc73262256330c0f3e7fd50cc655a12332dc4

12 years agoRefactor and partly parallelise stack update code
Zane Bitter [Fri, 21 Jun 2013 16:01:32 +0000 (18:01 +0200)]
Refactor and partly parallelise stack update code

Make this easier to read, and also use co-routines to make it run in
parallel where possible.

Change-Id: Ib37f4c04bd250cb15604ba9adb4cca8a97a2c4fb

12 years agoMerge "Unrestricted username length causing error."
Jenkins [Fri, 21 Jun 2013 11:27:01 +0000 (11:27 +0000)]
Merge "Unrestricted username length causing error."

12 years agoMerge "Add VerifyAll to test methods using mox."
Jenkins [Fri, 21 Jun 2013 07:35:27 +0000 (07:35 +0000)]
Merge "Add VerifyAll to test methods using mox."

12 years agomake stack creation return json response
Liang Chen [Mon, 17 Jun 2013 10:19:15 +0000 (18:19 +0800)]
make stack creation return json response

added a serializer to handle create response serialization

fixes bug #1187883

Change-Id: Ibdeb8b810d759901979becb8b29bdc337f2f5bec

12 years agoMerge "Give alarm a physical_resource_name which need no id."
Jenkins [Fri, 21 Jun 2013 01:37:56 +0000 (01:37 +0000)]
Merge "Give alarm a physical_resource_name which need no id."

12 years agoMerge "Fix BaseException.message DeprecationWarning"
Jenkins [Fri, 21 Jun 2013 01:37:49 +0000 (01:37 +0000)]
Merge "Fix BaseException.message DeprecationWarning"

12 years agoGive alarm a physical_resource_name which need no id.
Steve Baker [Fri, 21 Jun 2013 00:21:51 +0000 (12:21 +1200)]
Give alarm a physical_resource_name which need no id.

This restores previous behaviour, including workarounds for
circular dependencies.

Fixes bug: #1192814

Change-Id: I33e8e4d7806fb397553944dbd6ebb85b575b9cb5

12 years agoDo not refresh timestamp from database on read.
Steve Baker [Thu, 20 Jun 2013 22:18:37 +0000 (10:18 +1200)]
Do not refresh timestamp from database on read.

Doing a database refresh on timestamp read is causing errors
such as:
heat.openstack.common.rpc.amqp InvalidRequestError:
  Could not refresh instance '<Stack at 0x2c95a90>'

This has only been seen using postgres, possibly because the problem is
being masked on mysql due to the driver's lack of concurrency.

The database refresh seems to be unnecessary, as there appears to be
no logic which depends on timestamps being accurate (nor is there
any timestamp comparison logic at all)

Fixes bug: #1193132
Change-Id: I22c3c4546a0f44b76a95e473b68b6fbb2e423b90

12 years agoUnrestricted username length causing error.
Andrew Plunk [Thu, 20 Jun 2013 15:02:37 +0000 (10:02 -0500)]
Unrestricted username length causing error.

When we tried to create a username in keystone with
a length > 64 characters, an error was being raised.
Only use the first 64 characters of the dynamically
generated name in this case.

Change-Id: I5a5f863d721da8d187facb48230aeab251c7d240

12 years agoAdd VerifyAll to test methods using mox.
Randall Burt [Thu, 20 Jun 2013 01:38:38 +0000 (20:38 -0500)]
Add VerifyAll to test methods using mox.

Missed this comment in an earlier review.

Change-Id: If9737a03ba003331d0e20288e3bbc09002c6dbdb

12 years agoMerge "Fix and enable H303 and F403 No wildcard (*) import."
Jenkins [Thu, 20 Jun 2013 14:13:14 +0000 (14:13 +0000)]
Merge "Fix and enable H303 and F403  No wildcard (*) import."

12 years agoFix BaseException.message DeprecationWarning
Steven Hardy [Wed, 19 Jun 2013 13:27:00 +0000 (14:27 +0100)]
Fix BaseException.message DeprecationWarning

https://review.openstack.org/#/c/32154/ introduces a deprecated
TypeError.message reference, which won't work in python3 and
causes a DeprecationWarning to be output on >= python 2.6

Change-Id: Ibd11d4ad6b82e96ede8f38fe76112bd71e98c5c9

12 years agoMerge "Updated common module from oslo"
Jenkins [Thu, 20 Jun 2013 10:30:48 +0000 (10:30 +0000)]
Merge "Updated common module from oslo"

12 years agoFix one of the last stack.state's -> status
Angus Salkeld [Thu, 20 Jun 2013 06:56:04 +0000 (16:56 +1000)]
Fix one of the last stack.state's -> status

Change-Id: I3a246c472371ef6ca4c34f358ebecfe79b9eaa88
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
12 years agoRevert "check content type in JSONRequestDeserializer"
Steve Baker [Thu, 20 Jun 2013 02:47:01 +0000 (14:47 +1200)]
Revert "check content type in JSONRequestDeserializer"

For details of the regression this caused see
bug: #1187882

This reverts commit 2f35c942e34b6c6538a2ae2da3d01b690af3a47f.

Change-Id: Ib739d271f5caf0e8ce26c3b27a3436a20e9e311d

12 years agoMerge "Implement attribute schema for resources"
Jenkins [Thu, 20 Jun 2013 01:58:52 +0000 (01:58 +0000)]
Merge "Implement attribute schema for resources"

12 years agoFix and enable H303 and F403 No wildcard (*) import.
Angus Salkeld [Thu, 20 Jun 2013 01:52:53 +0000 (11:52 +1000)]
Fix and enable H303 and F403  No wildcard (*) import.

F403 is related the message is:
F403 'from bla import *' used; unable to detect undefined names

Change-Id: I486c0b2fc15a616e3fdf1e7e2eaeae1e45075537

12 years agoImplement attribute schema for resources
Randall Burt [Thu, 13 Jun 2013 17:58:29 +0000 (12:58 -0500)]
Implement attribute schema for resources

Similar to properties, adds attribute_schema and attributes members to
Resources in order to facilitate document generation and template
provider stubs for resources.

Change-Id: Ie858fc71a91078e14af552d8cafe0f2448f5d2b8
Implements: blueprint attributes-schema

12 years agoMerge "Introduce a schema for attributes"
Jenkins [Wed, 19 Jun 2013 23:46:15 +0000 (23:46 +0000)]
Merge "Introduce a schema for attributes"

12 years agoMerge "Convert Stack to separate action/status"
Jenkins [Wed, 19 Jun 2013 23:46:08 +0000 (23:46 +0000)]
Merge "Convert Stack to separate action/status"

12 years agoIntroduce a schema for attributes
Randall Burt [Thu, 13 Jun 2013 17:41:50 +0000 (12:41 -0500)]
Introduce a schema for attributes

Similar to properties, adds attribute_schema and attributes members to
Resources in order to facilitate document generation and template
provider stubs for resources.

Change-Id: I5e207360816fbc685c66db68a7fab8afad11bf10
Implements: blueprint attributes-schema

12 years agoRestore babel setup config options
Matt Riedemann [Wed, 19 Jun 2013 19:35:14 +0000 (12:35 -0700)]
Restore babel setup config options

Restore the babel configuration values from setup.cfg before the pbr
change so that you can compile the message catalog using "python
setup.py compile_catalog" again.

Fixes bug 1192685

Change-Id: I6db624940b7b8017700e8d2bc7ba56ba4295f091

12 years agoMerge "Add dependency between FloatingIP and RouterGateway"
Jenkins [Wed, 19 Jun 2013 17:46:43 +0000 (17:46 +0000)]
Merge "Add dependency between FloatingIP and RouterGateway"

12 years agoMerge "Initial provider template uploading"
Jenkins [Wed, 19 Jun 2013 17:46:18 +0000 (17:46 +0000)]
Merge "Initial provider template uploading"

12 years agoMerge "check content type in JSONRequestDeserializer"
Jenkins [Wed, 19 Jun 2013 17:44:22 +0000 (17:44 +0000)]
Merge "check content type in JSONRequestDeserializer"

12 years agoConvert Stack to separate action/status
Steven Hardy [Tue, 18 Jun 2013 17:07:57 +0000 (18:07 +0100)]
Convert Stack to separate action/status

Next and hopefully final step in decoupling action/status

This adjusts the Stack DB columns, model and class to be consistent with
Event/Resource, and split action/status.  This also modifies the both
APIs to join the action/status to avoid changing the API

Change-Id: Ifbdf254c62cad271b775b88de5b873f4e0b6d736

12 years agoUpdated common module from oslo
guohliu [Wed, 19 Jun 2013 12:18:39 +0000 (20:18 +0800)]
Updated common module from oslo

This patch updated common module from oslo for known issue.

Fixed bug: #1175808
Fixed bug: #1072917

Change-Id: Ic1de6b786a9d67b39d186e31a37049729d367464

12 years agoMerge "Detect failed instance creation in autoscaling"
Jenkins [Wed, 19 Jun 2013 11:44:56 +0000 (11:44 +0000)]
Merge "Detect failed instance creation in autoscaling"

12 years agoMerge "scheduler: Simplify DependencyTaskGroup interface"
Jenkins [Wed, 19 Jun 2013 09:49:45 +0000 (09:49 +0000)]
Merge "scheduler: Simplify DependencyTaskGroup interface"

12 years agoInitial provider template uploading
Angus Salkeld [Wed, 19 Jun 2013 08:54:51 +0000 (18:54 +1000)]
Initial provider template uploading

blueprint provider-upload
Change-Id: Iee475c6cccaa7ab87c630036cff120f46ab42103

12 years agocheck content type in JSONRequestDeserializer
Zhang Lei (Sneeze) [Wed, 19 Jun 2013 08:26:45 +0000 (16:26 +0800)]
check content type in JSONRequestDeserializer

Fixed Bug #1187882

Change-Id: I67dc20bddff570e7b9cf43093e06509a20aa9b60

12 years agoDetect failed instance creation in autoscaling
Thomas Herve [Wed, 19 Jun 2013 07:17:48 +0000 (09:17 +0200)]
Detect failed instance creation in autoscaling

Wait for instances to be created sucessfully before adding them to the
list in the Autoscaling resource.

Fixes: bug #1192125
Change-Id: Ie8676c23de5a62d3b8b2b4088b67d249ae90ceef

12 years agoMerge "Support cloud-specific suffixes to server status."
Jenkins [Tue, 18 Jun 2013 23:22:17 +0000 (23:22 +0000)]
Merge "Support cloud-specific suffixes to server status."

12 years agoMerge "Cleanup the doc strings in heat/rpc/client.py"
Jenkins [Tue, 18 Jun 2013 23:05:34 +0000 (23:05 +0000)]
Merge "Cleanup the doc strings in heat/rpc/client.py"

12 years agoMerge "API support for Environments"
Jenkins [Tue, 18 Jun 2013 23:05:27 +0000 (23:05 +0000)]
Merge "API support for Environments"

12 years agoMerge "Make template_format.parse usable by environments"
Jenkins [Tue, 18 Jun 2013 23:05:19 +0000 (23:05 +0000)]
Merge "Make template_format.parse usable by environments"

12 years agoMerge "Remove unused parameter.user_parameters()"
Jenkins [Tue, 18 Jun 2013 23:05:12 +0000 (23:05 +0000)]
Merge "Remove unused parameter.user_parameters()"

12 years agoMerge "Use the Environment from within the engine"
Jenkins [Tue, 18 Jun 2013 23:05:10 +0000 (23:05 +0000)]
Merge "Use the Environment from within the engine"

12 years agoMerge "Add a Fn::Split function to aid provider templates"
Jenkins [Tue, 18 Jun 2013 21:03:56 +0000 (21:03 +0000)]
Merge "Add a Fn::Split function to aid provider templates"

12 years agoMerge "suppress and log API internal exceptions"
Jenkins [Tue, 18 Jun 2013 20:18:19 +0000 (20:18 +0000)]
Merge "suppress and log API internal exceptions"

12 years agoSupport cloud-specific suffixes to server status.
Monty Taylor [Mon, 17 Jun 2013 21:34:33 +0000 (17:34 -0400)]
Support cloud-specific suffixes to server status.

Some clouds, *cough*HP*cough* append extra data to their
status strings. Such as: BUILD(scheduling) or BUILD(networking).
We don't really want to be on the hook for keeping a list of those,
but if we just grab the bit in front of the parenthetical, we should
be able to tell state sensibly, even when people are being weird.

Change-Id: Idaf079d6090db50c9041f398a257b427d63ff48d

12 years agoMerge "scheduler: Improve task descriptions in debug logs"
Jenkins [Tue, 18 Jun 2013 18:12:46 +0000 (18:12 +0000)]
Merge "scheduler: Improve task descriptions in debug logs"

12 years agoautoscaling fix LoadBalancer reload static resolve
Steven Hardy [Mon, 17 Jun 2013 14:54:51 +0000 (15:54 +0100)]
autoscaling fix LoadBalancer reload static resolve

Since https://review.openstack.org/#/c/31083/ we're using the
Resource.update() method to update the LoadBalancer, which requires
the resource snippet to be statically resolved (as is done in
parser.Stack for stack updates)

Fixes bug #1191705

Change-Id: Id2017a912472ddb48245682c5b6392cbcb9e4c60

12 years agoReturn None for physical resource name during validation
Zane Bitter [Tue, 18 Jun 2013 08:41:40 +0000 (10:41 +0200)]
Return None for physical resource name during validation

During template validation, the resources have not been stored in the
database. Therefore any resources that return self.physical_resource_name()
in either FnGetRef() or FnGetAtt() would cause assertions whenever either
of those functions were called during validation. Instead, return None from
physical_resource_name() in this phase, as we do for other data that is not
available yet during validation.

Fixes bug #1191931

Change-Id: I1a5b17557ae1ca2600fb930e74eb5248c82e0326

12 years agoStandardise resource names in Invalid Attribute errors
Zane Bitter [Tue, 18 Jun 2013 08:25:52 +0000 (10:25 +0200)]
Standardise resource names in Invalid Attribute errors

These should always refer to the resource name in the template (i.e.
logical resource name), and never the physcial resource name (since these
errors necessarily occur during validation, before any physical resource is
created).

Change-Id: I6cf6625cf32a90acb27adc6348695c086dc5e119

12 years agoMerge "Add InstanceId property to EIP resource"
Jenkins [Tue, 18 Jun 2013 03:11:00 +0000 (03:11 +0000)]
Merge "Add InstanceId property to EIP resource"

12 years agosuppress and log API internal exceptions
Liang Chen [Fri, 7 Jun 2013 15:01:02 +0000 (23:01 +0800)]
suppress and log API internal exceptions

add a context manager to handle exceptions generated by API
implementation methods or their decorators

Fixes bug #1187881

Change-Id: I4bd75e1e13f8327aaf2283380bf165a57a11ed8c

12 years agoMerge "engine : abstract state-transition logic"
Jenkins [Tue, 18 Jun 2013 01:05:13 +0000 (01:05 +0000)]
Merge "engine : abstract state-transition logic"

12 years agoMerge "Convert Resource to separate action/status"
Jenkins [Tue, 18 Jun 2013 01:05:09 +0000 (01:05 +0000)]
Merge "Convert Resource to separate action/status"

12 years agoAdd a Fn::Split function to aid provider templates
Angus Salkeld [Tue, 18 Jun 2013 00:15:41 +0000 (10:15 +1000)]
Add a Fn::Split function to aid provider templates

This needed to convert a parameter in CommaDelimedList into
a property of type List.

part of blueprint provider-resource
Change-Id: Id77a2c6be47427360a2be89ca1fea3c097807bac

12 years agoAdd dependency between FloatingIP and RouterGateway
Steve Baker [Tue, 21 May 2013 01:21:22 +0000 (13:21 +1200)]
Add dependency between FloatingIP and RouterGateway

When a template has a FloatingIP and a RouterGateway on the same
external network, there is an implicit dependency on create where
the gateway must be created before the floating ip.

This is implemented by overiding add_dependencies in FloatingIP
and looking in the stack for RouterGateway resource to depend on.

Fixed bug: #1182266

Change-Id: I40f281e5bf2a27280d328fe11d32e6404f412a79

12 years agoMerge "Initial Environment class and test"
Jenkins [Mon, 17 Jun 2013 17:01:50 +0000 (17:01 +0000)]
Merge "Initial Environment class and test"

12 years agoAdd InstanceId property to EIP resource
Jeff Peeler [Mon, 17 Jun 2013 16:19:49 +0000 (12:19 -0400)]
Add InstanceId property to EIP resource

This also changes the InstanceId property for an EIPAssociation
to not be required, which was necessary for testing and is inline
with AWS documentation.

Change-Id: I49dd506309fe6a38df6727bca7f6bbebd45fba3f
Fixes: bug #1164864
12 years agoscheduler: Simplify DependencyTaskGroup interface
Zane Bitter [Thu, 13 Jun 2013 18:03:27 +0000 (20:03 +0200)]
scheduler: Simplify DependencyTaskGroup interface

Instead of passing a function that takes one argument and returns a task
that takes no arguments, simply pass a task that takes one argument.

Change-Id: I73d5f137d5db492c09e6887f80e7e759734c211f

12 years agoscheduler: Improve task descriptions in debug logs
Zane Bitter [Mon, 17 Jun 2013 15:42:04 +0000 (17:42 +0200)]
scheduler: Improve task descriptions in debug logs

Tasks that were simply defined as ordinary functions (not methods) were
identified by their repr() in the logs, which is only really desirable as a
last resort and for objects (where the __call__() method is the task). Use
the function name instead.

Change-Id: Ie34a3602deb968979118b0961bcddf226cf5983f

12 years agoCleanup the doc strings in heat/rpc/client.py
Angus Salkeld [Mon, 3 Jun 2013 03:05:27 +0000 (13:05 +1000)]
Cleanup the doc strings in heat/rpc/client.py

Change-Id: Ia760937f729a1aa17d84c48054cb143bf6891bfd

12 years agoAPI support for Environments
Angus Salkeld [Mon, 17 Jun 2013 04:39:19 +0000 (14:39 +1000)]
API support for Environments

Support "Environment" section in the create/update body.
We the roll up the parameters and the environment and send
that as json using the rpc "params" argument. So no changes
to the rpc layer are needed. The engine knows how to deal
with both formats in the Environments class.

blueprint envirnonments
Change-Id: I6d6085d5c052a5f9115ecd46891b00d2fad4d1db

12 years agoMake template_format.parse usable by environments
Angus Salkeld [Thu, 13 Jun 2013 02:24:02 +0000 (12:24 +1000)]
Make template_format.parse usable by environments

(environments don't want template sections)

blueprint environments
Change-Id: I68ac0b8fb0889d245ace4d0ea8d298460c4c1b1a

12 years agoUse PhysName for testing Swift container names
Zane Bitter [Mon, 17 Jun 2013 10:24:50 +0000 (12:24 +0200)]
Use PhysName for testing Swift container names

Change-Id: Icc000a9235fcd9ee810581b932ded73319decfee

12 years agoFix bizarre Swift DeletionPolicy unit tests
Zane Bitter [Mon, 17 Jun 2013 10:24:50 +0000 (12:24 +0200)]
Fix bizarre Swift DeletionPolicy unit tests

If something shouldn't be called... don't tell the mocks to expect it to be
called. We will get UnexpectedMethodCallError if it is.

Change-Id: I61a7b77cb273b42177a37efa98fc62fd69770545

12 years agoUse physical_resource_name() for Swift containers
Zane Bitter [Mon, 17 Jun 2013 10:24:50 +0000 (12:24 +0200)]
Use physical_resource_name() for Swift containers

This returns names which are of the same form, but which are based on the
resource id (and hence are stable).

Change-Id: Id091bdef74e07fc0df0e6e4914dae8af8b29384c

12 years agoRemove unused parameter.user_parameters()
Angus Salkeld [Thu, 30 May 2013 01:51:17 +0000 (11:51 +1000)]
Remove unused parameter.user_parameters()

blueprint environments
Change-Id: I21246a62f82064120d6ebd4c5e1c607f43df55bc

12 years agoUse the Environment from within the engine
Angus Salkeld [Fri, 14 Jun 2013 10:56:02 +0000 (20:56 +1000)]
Use the Environment from within the engine

at this point the concept only exists in the engine, the
api and client changes will come in later patches.

blueprint environments
Change-Id: I3e208bb72a04bf275bead2aec89006cf680b501b

12 years agoUse physical resource names with a short_id
Zane Bitter [Mon, 17 Jun 2013 10:24:49 +0000 (12:24 +0200)]
Use physical resource names with a short_id

The short_id is a random, but stable, 12-character alphanumeric ID.

This will allow two resources of the same name to exist concurrently. That
is necessary for resources to be replaced during an update without
interruption.

Change-Id: If32904a47c6f8fb651e317ce91f2a04f6eadcc0b

12 years agoInitial Environment class and test
Angus Salkeld [Thu, 13 Jun 2013 03:59:08 +0000 (13:59 +1000)]
Initial Environment class and test

This implements the "resource-registry" and "parameters" section
I am holding off on the "properties" section until we really
know we need it.

blueprint environments
Change-Id: Ib6e9e5cd1c68c255dc048bdde21a6b3e1dc54243

12 years agoMerge "Remove unused python-memcached from requirements."
Jenkins [Mon, 17 Jun 2013 00:39:34 +0000 (00:39 +0000)]
Merge "Remove unused python-memcached from requirements."

12 years agoengine : abstract state-transition logic
Steven Hardy [Mon, 10 Jun 2013 15:27:18 +0000 (16:27 +0100)]
engine : abstract state-transition logic

Refactor to abstract the handle_create/check_create_complete
logic, so it can be reused without lots of duplication for
other action transitions

Prompted by review comments from:
https://review.openstack.org/#/c/31982/2/heat/engine/resource.py
related to blueprint: stack-suspend-resume

Change-Id: Idb18913ef6ff700b63d5ec6d340d2353fc2294b7