]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log
Morgan Haskel [Fri, 23 Jan 2015 18:15:01 +0000 (10:15 -0800)]
MODULES-633 - Fix for ip6tables
If the packages for ip6tables aren't installed, the provider will throw
an exception. Fix the provider to check to make sure the variable exists
first, and update params.pp to include the required package for EL6.
Colleen Murphy [Mon, 26 Jan 2015 17:36:39 +0000 (09:36 -0800)]
Merge pull request #479 from mhaskel/MODULES-1453
MODULES-1453 - overly aggressive gsub
Travis Fields [Sat, 24 Jan 2015 21:19:35 +0000 (13:19 -0800)]
Merge pull request #480 from jonnytpuppet/fix_unit_tests
Fixed unit tests to stub out ip6tables version.
Jonathan Tripathy [Sat, 24 Jan 2015 01:49:55 +0000 (17:49 -0800)]
Fixed unit tests to stub out ip6tables version.
Morgan Haskel [Fri, 23 Jan 2015 23:36:54 +0000 (15:36 -0800)]
MODULES-1453 - overly aggressive gsub
Make sure there's a space after '-A' before gsubbing with '-D'. Was
causing issues with `ensure => absent` and `log_prefix =>
'FW-A-<whatever>'`
Morgan Haskel [Fri, 23 Jan 2015 23:04:25 +0000 (15:04 -0800)]
Merge pull request #478 from cyberious/FirewallChain
Fix issue with firewallchain unit tests
Travis Fields [Fri, 23 Jan 2015 22:52:01 +0000 (14:52 -0800)]
Fix issue with local testing firewallchain
Morgan Haskel [Fri, 23 Jan 2015 21:09:13 +0000 (13:09 -0800)]
Merge pull request #476 from jonnytpuppet/fix_recent_os
Fix recent os
Jonathan Tripathy [Thu, 22 Jan 2015 23:39:40 +0000 (15:39 -0800)]
MODULES-1029
Fixed issues with Ubuntu 14.10
pcheliniy [Thu, 25 Dec 2014 07:32:50 +0000 (10:32 +0300)]
fixed package name on Ubuntu 14.10
Morgan Haskel [Thu, 22 Jan 2015 21:58:28 +0000 (13:58 -0800)]
Merge pull request #471 from mlehner616/master
Fixing regressions for Amazon Linux since RH7 support was added
Hunter Haugen [Thu, 22 Jan 2015 19:50:11 +0000 (11:50 -0800)]
Merge pull request #475 from jonnytpuppet/uid_negation_fix
MODULES-753 further fixes
Mike Lehner [Fri, 16 Jan 2015 21:21:59 +0000 (13:21 -0800)]
Removing Amazon from the list OSs that are grouped with Red Hat 7.
Red Hat 7 has diverged from the Amazon system architecture and Amazon
uses a different versioning scheme. It's possible Amazon may re-align
with Red Hat 7 in later releases. Additional logic may be required
when that happens.
Description: Adding an exception for Amazon as the conditions for
RH7 were incorrectly catching Amazon because the version YYYY.MM
will always evaluate to true
Jonathan Tripathy [Wed, 21 Jan 2015 23:48:22 +0000 (15:48 -0800)]
MODULES-753
Fixes user adding and removing using either UID or string username.
Tested with both negated and non-negated values and works on all
supported operating systems.
Remote whitespace
Travis Fields [Wed, 21 Jan 2015 19:06:01 +0000 (11:06 -0800)]
Merge pull request #474 from jonnytpuppet/uid_negation_fix
Uid negation fix
Jonathan Tripathy [Wed, 21 Jan 2015 08:48:12 +0000 (00:48 -0800)]
Fix for MODULES-1688
Re-applying a manifest with an unchanged UID will now not re-apply
the rule unnecessarily.
Dan Bode [Thu, 8 Jan 2015 17:06:10 +0000 (18:06 +0100)]
Lookup username from uuid
When using the uid feature of the firewall module,
it did not work with string based usernames as
documented.
The uid propery always synchronized with a message of
<number> does not match <username>.
This code overrides the uid getter method to perform
a check of both the data from the property hash as well
as using that data (assuming it is a uid) to resolve the
username.
While this patch is pretty simple, I have only tested it
on Ubuntu 14.04. I am not sure if it could be problematic
with other versions.
I have not yet written tests b/c I wanted to submit
my proposed fix for discussion while I get those
written.
Hunter Haugen [Tue, 20 Jan 2015 21:53:04 +0000 (13:53 -0800)]
Merge pull request #473 from jonnytpuppet/physdev
Added support for iptables physdev_in and physdev_out parameters
Jonathan Tripathy [Sun, 18 Jan 2015 22:11:58 +0000 (14:11 -0800)]
Added support for seperate physdev-in and physdev-out parameters.
Aron Parsons [Mon, 29 Sep 2014 00:17:07 +0000 (20:17 -0400)]
fix bridge value validation
Aron Parsons [Fri, 26 Sep 2014 20:58:05 +0000 (16:58 -0400)]
add physdev support
rebased from https://github.com/puppetlabs/puppetlabs-firewall/pull/82
Travis Fields [Fri, 16 Jan 2015 21:38:11 +0000 (13:38 -0800)]
Merge pull request #472 from mhaskel/QENG-1678
QENG-1678 - Need to stop iptables to install ipset
Morgan Haskel [Fri, 16 Jan 2015 21:35:26 +0000 (13:35 -0800)]
QENG-1678 - Need to stop iptables to install ipset
Firewalls are fun :)
Colleen Murphy [Wed, 14 Jan 2015 21:01:00 +0000 (13:01 -0800)]
Merge pull request #470 from mhaskel/MODULES-1612
MODULES-1612 - mask isn't supported on deb7
Morgan Haskel [Wed, 14 Jan 2015 20:58:07 +0000 (12:58 -0800)]
MODULES-1612 - mask isn't supported on deb7
Colleen Murphy [Wed, 14 Jan 2015 19:20:40 +0000 (11:20 -0800)]
Merge pull request #469 from mhaskel/MODULES-1612
MODULES-1612 - sync mask
Morgan Haskel [Wed, 14 Jan 2015 19:12:02 +0000 (11:12 -0800)]
MODULES-1612 - add tests and README updates for syncing mask
Jonathan Wright [Sun, 11 Jan 2015 17:40:42 +0000 (17:40 +0000)]
Add missing Mask on ip6tables
The :mask option was missing in the ip6tables provider which prevented
it from correctly working with the recent module with the following
error:
Could not evaluate: Parser error: rttl was meant to be a boolean but received value: "--mask."
Hunter Haugen [Wed, 14 Jan 2015 17:16:43 +0000 (09:16 -0800)]
Merge pull request #468 from mhaskel/MODULES-1612
MODULES-1612 - sync ipset
Morgan Haskel [Wed, 14 Jan 2015 16:22:24 +0000 (11:22 -0500)]
MODULES-1612 - sync ipset
Colleen Murphy [Wed, 7 Jan 2015 20:33:13 +0000 (12:33 -0800)]
Merge pull request #464 from mhaskel/MODULES-1612
MODULES-1612 - sync set_mark
Morgan Haskel [Wed, 7 Jan 2015 20:26:55 +0000 (15:26 -0500)]
MODULES-1612 - sync set_mark
README and provider already claimed ip6tables provider supported `mark`
feature, but the code wasn't there.
Fixes puppetlabs/puppetlabs-firewall#387
Hunter Haugen [Wed, 7 Jan 2015 18:54:46 +0000 (10:54 -0800)]
Merge pull request #462 from mhaskel/MODULES-1552
MODULES-1552 - Issues parsing `-m (tcp|udp)` rules
Morgan Haskel [Wed, 7 Jan 2015 17:29:56 +0000 (12:29 -0500)]
MODULES-1552 - Issues parsing `-m (tcp|udp)` rules
The parser was arbitrarily requiring `--(d|s)port` or `-m multiport` with
`-m tcp` or `-m udp`. Remove `-m (tcp|udp)` when converting to hash
unless it's `-m tcp --tcp-flags`.
Travis Fields [Sat, 3 Jan 2015 00:12:17 +0000 (16:12 -0800)]
Merge pull request #459 from mhaskel/MODULES-1612
MODULES-1612 - Sync ipsec_dir and ipsec_policy
Morgan Haskel [Fri, 2 Jan 2015 21:12:50 +0000 (16:12 -0500)]
MODULES-1612 - Sync ipsec_dir and ipsec_policy
Morgan Haskel [Wed, 31 Dec 2014 18:27:51 +0000 (10:27 -0800)]
Merge pull request #458 from cmurphy/lucid
Lucid template platform names have '.' in them
Colleen Murphy [Wed, 31 Dec 2014 18:26:21 +0000 (10:26 -0800)]
Lucid template platform names have '.' in them
Colleen Murphy [Wed, 31 Dec 2014 00:33:16 +0000 (16:33 -0800)]
Merge pull request #457 from mhaskel/MODULES-1612
MODULES-1612 - sync socket
Morgan Haskel [Wed, 31 Dec 2014 00:19:10 +0000 (16:19 -0800)]
MODULES-1612 - sync socket
Colleen Murphy [Tue, 30 Dec 2014 23:29:45 +0000 (15:29 -0800)]
Merge pull request #454 from mhaskel/MODULES-1612
MODULES-1612 - sync mac_source
Morgan Haskel [Tue, 30 Dec 2014 01:28:27 +0000 (17:28 -0800)]
MODULES-1612 - sync mac_source
Add mac_source to the ip6tables provider
Morgan Haskel [Tue, 30 Dec 2014 22:35:20 +0000 (14:35 -0800)]
Merge pull request #456 from cmurphy/fix_tests
Only run ip6tables dst/src_type tests on platforms that support it
Colleen Murphy [Tue, 30 Dec 2014 22:32:00 +0000 (14:32 -0800)]
Only run ip6tables dst/src_type tests on platforms that support it
Morgan Haskel [Tue, 30 Dec 2014 20:57:55 +0000 (12:57 -0800)]
Merge pull request #455 from cmurphy/fix_tests
Fix puppet resource acceptance tests
Colleen Murphy [Tue, 30 Dec 2014 20:46:55 +0000 (12:46 -0800)]
Fix puppet resource acceptance tests
The dport/sport test needs iptables-persistent pre-installed in order
for the iptables_persistent_version fact to work.
This commit also changes the test to create the rule with a comment and
with the default protocol so that the puppet resource command is
checking the existence of a resource and not creating a new one or
altering an existing one.
After those changes, checking stderr still fails because of puppet's
deprecation warnings. This commit fixes puppet.conf to avoid the
warnings so that we can actually check stderr. With that accomplished I
added checks for stderr to the other puppet resource tests since they
should now be reliable.
Travis Fields [Tue, 30 Dec 2014 00:39:53 +0000 (16:39 -0800)]
Merge pull request #453 from mhaskel/MODULES-1612
MODULES-1612 - sync src_type and dst_type
Morgan Haskel [Tue, 30 Dec 2014 00:15:25 +0000 (16:15 -0800)]
MODULES-1612 - sync src_type and dst_type
Add addrtype feature to ip6tables provider, which allows src_type and
dst_type to be used.
Colleen Murphy [Mon, 29 Dec 2014 21:56:05 +0000 (13:56 -0800)]
Merge pull request #452 from mhaskel/MODULES-1612
MODULES-1612 - sync src_range and dst_range
Morgan Haskel [Mon, 29 Dec 2014 21:41:06 +0000 (13:41 -0800)]
MODULES-1612 - sync src_range and dst_range
The the firewall type and the ip6tables provider did not support
src_range and dst_range for ip6tables. Added this functionality.
Hunter Haugen [Mon, 29 Dec 2014 21:01:05 +0000 (13:01 -0800)]
Merge pull request #451 from mhaskel/MODULES-1355
MODUELES-1355 - support dport/sport in ip6tables provider
Morgan Haskel [Mon, 29 Dec 2014 19:41:16 +0000 (11:41 -0800)]
MODULES-1355 - Add acceptance test to verify
Use the example rule from the ticket to make sure this is working
Fixes puppetlabs/puppetlabs-firewall#408
Gustavo Lopes [Fri, 26 Sep 2014 13:41:09 +0000 (15:41 +0200)]
Support --sport/--dport on ip6tables
Morgan Haskel [Mon, 29 Dec 2014 19:23:26 +0000 (11:23 -0800)]
Merge pull request #450 from cmurphy/master
Add IntelliJ files to the ignore list
Colleen Murphy [Mon, 29 Dec 2014 18:41:00 +0000 (10:41 -0800)]
Add IntelliJ files to the ignore list
Morgan Haskel [Tue, 23 Dec 2014 20:53:55 +0000 (12:53 -0800)]
Merge pull request #448 from cmurphy/fix_tests
Fix netmap acceptance tests
Colleen Murphy [Tue, 23 Dec 2014 19:48:19 +0000 (11:48 -0800)]
Fix netmap acceptance tests
This commit:
- Updates the netmap acceptance tests to have the correct identifying
comment
- Resets iptables inbetween the two tests since the rules can't be
changed
- Updates a regex in the iptables provider to check for spaces before
and after a flag so that "--to" isn't confused with "--to-port"
Morgan Haskel [Fri, 19 Dec 2014 01:19:04 +0000 (17:19 -0800)]
Merge pull request #421 from nemski/bug/master/add_netmap
(MODULES-464) Add netmap feature
Morgan Haskel [Wed, 17 Dec 2014 23:52:49 +0000 (15:52 -0800)]
Merge pull request #445 from laurenrother/master
Updates to format to fit style guide.
Lauren [Wed, 17 Dec 2014 23:44:53 +0000 (15:44 -0800)]
Updates to format to fit style guide.
Colleen Murphy [Wed, 17 Dec 2014 01:07:12 +0000 (17:07 -0800)]
Merge pull request #444 from mhaskel/merge_1.3.x_into_master
Merge 1.3.x into master
nemski [Mon, 20 Oct 2014 07:58:34 +0000 (18:58 +1100)]
Add netmap feature and acceptance tests
Travis Fields [Tue, 16 Dec 2014 22:29:09 +0000 (14:29 -0800)]
Merge pull request #443 from mhaskel/1.3.0-prep
1.3.0 prep
Morgan Haskel [Tue, 16 Dec 2014 22:05:54 +0000 (14:05 -0800)]
1.3.0 prep
Morgan Haskel [Tue, 16 Dec 2014 01:15:36 +0000 (17:15 -0800)]
Merge pull request #427 from stesie/fix-set_mark-limit
Don't arbitrarily limit set_mark to certain chains
Colleen Murphy [Tue, 16 Dec 2014 01:11:46 +0000 (17:11 -0800)]
Merge pull request #442 from mhaskel/MODULES-556
MODULES-556: tcp_flags support for ip6tables
Morgan Haskel [Tue, 16 Dec 2014 01:05:23 +0000 (17:05 -0800)]
MODULES-556: tcp_flags support for ip6tables
tcp_flags was listed as a supported feature for the ip6tables provider,
but it wasn't actually implemented
Morgan Haskel [Fri, 12 Dec 2014 21:05:29 +0000 (13:05 -0800)]
Merge pull request #434 from cyberious/master
FM-2022 Add SLES 12 to metadata
Morgan Haskel [Fri, 12 Dec 2014 21:02:16 +0000 (13:02 -0800)]
Merge pull request #437 from alexjurkiewicz/master
README cosmetics
Colleen Murphy [Fri, 12 Dec 2014 20:49:38 +0000 (12:49 -0800)]
Merge pull request #441 from mhaskel/MODULES-1572
MODULES-1572 - Fix logic broken from MODULES-1309
Morgan Haskel [Fri, 12 Dec 2014 20:21:48 +0000 (12:21 -0800)]
MODULES-1572 - Fix logic broken from MODULES-1309
Accidentally changed some behavior and broke things with the fix for
MODULES-1309
Morgan Haskel [Tue, 9 Dec 2014 16:21:39 +0000 (08:21 -0800)]
Merge pull request #439 from cmurphy/master
Update .travis.yml, Gemfile, Rakefile, and CONTRIBUTING.md
Colleen Murphy [Tue, 9 Dec 2014 06:52:14 +0000 (22:52 -0800)]
Add json gem
The puppet_facts gem implicitly depends on the json gem.
On Ruby 1.8.7, json is not built in. On Puppet 2.7, it is
not explicitly pulled in by the hiera gem. So we add it
here explicitly.
Colleen Murphy [Mon, 8 Dec 2014 18:23:24 +0000 (10:23 -0800)]
Update .travis.yml, Gemfile, Rakefile, and CONTRIBUTING.md
Colleen Murphy [Thu, 4 Dec 2014 17:01:56 +0000 (09:01 -0800)]
Merge pull request #438 from mhaskel/MODULES-1565
MODULES-1565 - Fix regexes for EL5
Morgan Haskel [Thu, 4 Dec 2014 16:07:00 +0000 (11:07 -0500)]
MODULES-1565 - Fix regexes for EL5
iptables outputs are slightly different in EL5. Update the regexes to
account for this.
Alex Jurkiewicz [Thu, 4 Dec 2014 04:51:41 +0000 (15:51 +1100)]
README cosmetics
Hunter Haugen [Wed, 3 Dec 2014 23:20:56 +0000 (15:20 -0800)]
Merge pull request #436 from mhaskel/MODULES-1309
MODULES-1309 - Make package and service names configurable
Morgan Haskel [Wed, 3 Dec 2014 21:11:00 +0000 (16:11 -0500)]
MODULES-1309 - Make package and service names configurable
This was motivated by a need to make this work on Debian Jessie.
Colleen Murphy [Wed, 3 Dec 2014 17:44:25 +0000 (09:44 -0800)]
Merge pull request #435 from mhaskel/squash_433
MODULES-1469 MODULES-1470 Support alias (eth0:0), negation for iniface, ...
Hugh Esco [Mon, 10 Nov 2014 18:31:48 +0000 (13:31 -0500)]
MODULES-1469 MODULES-1470 Support alias (eth0:0), negation for iniface, outiface
Travis Fields [Fri, 21 Nov 2014 22:06:41 +0000 (17:06 -0500)]
FM-2022 Add SLES 12 to metadata
Travis Fields [Tue, 4 Nov 2014 23:16:16 +0000 (15:16 -0800)]
Merge pull request #432 from mhaskel/test
Merge 1.2.x into master
Morgan Haskel [Tue, 4 Nov 2014 23:02:33 +0000 (15:02 -0800)]
Merge remote-tracking branch 'upstream/1.2.x' into test
Travis Fields [Mon, 3 Nov 2014 21:11:56 +0000 (13:11 -0800)]
Merge pull request #431 from mhaskel/1.2.0-prep
1.2.0 prep
Morgan Haskel [Fri, 31 Oct 2014 21:26:18 +0000 (14:26 -0700)]
1.2.0 prep
Colleen Murphy [Fri, 31 Oct 2014 23:18:03 +0000 (16:18 -0700)]
Merge pull request #430 from mhaskel/1.2.0-prep
1.2.0 prep
Morgan Haskel [Fri, 31 Oct 2014 21:26:18 +0000 (14:26 -0700)]
1.2.0 prep
Travis Fields [Fri, 31 Oct 2014 21:35:38 +0000 (14:35 -0700)]
Merge pull request #429 from mhaskel/1.2.x-ff
1.2.x ff
Morgan Haskel [Thu, 30 Oct 2014 23:29:42 +0000 (16:29 -0700)]
Merge pull request #426 from paramite/firewalld-fix
Fixed firewalld package issue
Travis Fields [Thu, 30 Oct 2014 22:15:33 +0000 (15:15 -0700)]
Merge pull request #428 from mhaskel/el5_test_fix
ip6tables isn't supported on EL5
Morgan Haskel [Thu, 30 Oct 2014 22:12:42 +0000 (15:12 -0700)]
ip6tables isn't supported on EL5
No need to test ip6tables purging on EL5 since the ip6tables provider
isn't supported.
Morgan Haskel [Tue, 28 Oct 2014 16:52:03 +0000 (12:52 -0400)]
Merge pull request #405 from cdenneen/master
EL7 Fixes for CentOS
cdenneen [Tue, 28 Oct 2014 01:23:59 +0000 (21:23 -0400)]
Merge pull request #1 from cmurphy/fix_el7_tests
Update tests for EL 7
Stefan Siegl [Mon, 27 Oct 2014 21:05:07 +0000 (22:05 +0100)]
Don't arbitrarily limit set_mark to certain chains
set_mark is not only allowed in PREROUTING or OUTPUT chain,
but also in custom chains, which are called from these.
Colleen Murphy [Mon, 27 Oct 2014 20:36:46 +0000 (13:36 -0700)]
Update tests for EL 7
Without this patch, unit tests make no distinction between EL < 7 and
EL 7. This is a problem because the iptables save exec is different
between the two operating systems, so the tests will fail for EL 7.
This patch fixes the problem by updating the tests to include the new
exec command for EL 7.
Colleen Murphy [Fri, 24 Oct 2014 21:23:24 +0000 (14:23 -0700)]
Merge pull request #424 from mhaskel/purge_ip6_fix
Missing a provider specification
Martin Mágr [Fri, 24 Oct 2014 07:37:01 +0000 (09:37 +0200)]
Fixed firewalld package issue
Firewalld package cannot be uninstalled, because other packages might be dependent
on it. This patch makes just firewalld service to stop and be disabled.
For more info please check: https://bugzilla.redhat.com/show_bug.cgi?id=
1148399
Hunter Haugen [Thu, 23 Oct 2014 22:15:45 +0000 (15:15 -0700)]
Merge pull request #383 from vzctl/ipset
add ipset support
Morgan Haskel [Thu, 23 Oct 2014 16:31:57 +0000 (10:31 -0600)]
Missing a provider specification