]> review.fuel-infra Code Review - openstack-build/cinder-build.git/log
openstack-build/cinder-build.git
11 years agoCreate key manager interface
Joel Coffman [Tue, 30 Jul 2013 14:06:28 +0000 (10:06 -0400)]
Create key manager interface

This interface provides a thin wrapper around an underlying key
management implementation such as Barbican or a KMIP server. The key
manager interface is used by the volume encryption code to retrieve
keys for volumes.

This change is a copy-paste of the key manager interface accepted by
Nova. The major modifications are to the module imports (i.e.,
nova -> cinder).

Change-Id: I8f79165d66d67ad8faaca60946959c5a61811c59
Implements: blueprint encrypt-cinder-volumes

11 years agoMerge "Fix unit suffix and add no_suffix option."
Jenkins [Mon, 29 Jul 2013 09:39:40 +0000 (09:39 +0000)]
Merge "Fix unit suffix and add no_suffix option."

11 years agoMerge "Removed the dep on cinder.utils"
Jenkins [Mon, 29 Jul 2013 03:23:12 +0000 (03:23 +0000)]
Merge "Removed the dep on cinder.utils"

11 years agoMerge "Create volume from snapshot must be in the same AZ as snapshot"
Jenkins [Sat, 27 Jul 2013 15:59:02 +0000 (15:59 +0000)]
Merge "Create volume from snapshot must be in the same AZ as snapshot"

11 years agoRemoved the dep on cinder.utils
Walter A. Boring IV [Thu, 25 Jul 2013 20:45:14 +0000 (13:45 -0700)]
Removed the dep on cinder.utils

This patch ensures that we don't have any
dependency on cinder's utils.py.

bug 1205100

Change-Id: Ic8b7cc532a1804e0f3b7ad89e24f8edf73cf78a5

11 years agoMerge "Imported Translations from Transifex"
OpenStack Jenkins [Fri, 26 Jul 2013 04:31:23 +0000 (04:31 +0000)]
Merge "Imported Translations from Transifex"

11 years agoMerge "Fix volumes search by metadata"
Jenkins [Thu, 25 Jul 2013 19:16:46 +0000 (19:16 +0000)]
Merge "Fix volumes search by metadata"

11 years agoImported Translations from Transifex
OpenStack Jenkins [Thu, 25 Jul 2013 18:10:10 +0000 (18:10 +0000)]
Imported Translations from Transifex

Change-Id: Ief9b93dbcfd4fad56d97442b698c0c5844332e48

11 years agoMerge "Using volume name property instead of using template and id."
Jenkins [Thu, 25 Jul 2013 17:53:36 +0000 (17:53 +0000)]
Merge "Using volume name property instead of using template and id."

11 years agoMerge "fix name 'update_volume_status' to 'update_volume_stats'"
Jenkins [Thu, 25 Jul 2013 17:51:41 +0000 (17:51 +0000)]
Merge "fix name 'update_volume_status' to 'update_volume_stats'"

11 years agoCreate volume from snapshot must be in the same AZ as snapshot
Michael Kerrin [Tue, 23 Jul 2013 09:49:57 +0000 (09:49 +0000)]
Create volume from snapshot must be in the same AZ as snapshot

This issue and patch also apply to cloning volumes.

When creating a volume from a snapshot we need to pick the
availability zone of the snapshot's source volume. This patch
goes further and enforces that the new volume must be in the same
AZ as the snapshot. It raises an user error if the user tries
to create a volume in a different AZ to the snapshot.

This is enforced across all drivers because creating a volume from
a snapshot is implemented in the drivers and not all drivers are
guaranteed to support creating a volume from snapshot is a foreign
AZ. More to point if you don't support create a volume like this,
and we allow this then you can create volumes and instances that
get stuck in some weird states that require a support call to fix.

If you do support cross AZ functionality then you can override
the enforcement of that cloned volumes most be in the same AZ
as their source via the 'cloned_volume_same_az' option.

Change-Id: Iafc8f35ecc6a6b51dbe6df8bf44eaa3e79c3bd01
Fixes: bug #1202648
11 years agoMerge "Migration for detached volumes with no snaps."
Jenkins [Thu, 25 Jul 2013 11:11:53 +0000 (11:11 +0000)]
Merge "Migration for detached volumes with no snaps."

11 years agoUsing volume name property instead of using template and id.
Nikolay Sobolevskiy [Thu, 25 Jul 2013 10:27:35 +0000 (14:27 +0400)]
Using volume name property instead of using template and id.

Change-Id: I478f875ed509fb591799a78b7fd52bc830e6fd1c

11 years agoMerge "use encode('utf8') instead of str()"
Jenkins [Thu, 25 Jul 2013 00:59:20 +0000 (00:59 +0000)]
Merge "use encode('utf8') instead of str()"

11 years agoMerge "get_snapshot should populate the snapshot metadata"
Jenkins [Thu, 25 Jul 2013 00:59:06 +0000 (00:59 +0000)]
Merge "get_snapshot should populate the snapshot metadata"

11 years agoMerge "Fix further Hacking 0.6.x warnings"
Jenkins [Thu, 25 Jul 2013 00:48:24 +0000 (00:48 +0000)]
Merge "Fix further Hacking 0.6.x warnings"

11 years agoMerge "GPFS stub calls to truncate and dd in unit tests"
Jenkins [Thu, 25 Jul 2013 00:19:04 +0000 (00:19 +0000)]
Merge "GPFS stub calls to truncate and dd in unit tests"

11 years agoMerge "Storwize/SVC: Use VolumeDriver's copy vol<->image."
Jenkins [Thu, 25 Jul 2013 00:06:24 +0000 (00:06 +0000)]
Merge "Storwize/SVC: Use VolumeDriver's copy vol<->image."

11 years agoFix unit suffix and add no_suffix option.
John Griffith [Fri, 19 Jul 2013 00:30:36 +0000 (18:30 -0600)]
Fix unit suffix and add no_suffix option.

In Cinder we've been using gibibytes, however
we have code in some places using Gigabytes, the brick
LVM code was one of those places.

This change sets the default suffix to gibibytes/mibibytes (1024 based)
and also provides an option to omit the suffix from the response now
that we can say that we're consistent in what is expected.

Change-Id: Id6274ba732bbdf484c5544e005155aebd68eaf2f

11 years agoGPFS stub calls to truncate and dd in unit tests
Bill Owen [Wed, 24 Jul 2013 16:08:16 +0000 (09:08 -0700)]
GPFS stub calls to truncate and dd in unit tests

gpfs unit tests had calls to truncate, and allowed
driver call to dd and df.  Modify tests to stub these
out.

Also remove references to image_path.  This was a temp file
created using truncate that is no longer used.

Change-Id: I437b56505ba025b256b051dfaf43d8124005f854
Fixes: bug #1203075
11 years agoMerge "GPFS convert glance image to raw only when needed"
Jenkins [Wed, 24 Jul 2013 20:57:02 +0000 (20:57 +0000)]
Merge "GPFS convert glance image to raw only when needed"

11 years agoMerge "Implements extend volume feature in HP 3PAR driver"
Jenkins [Wed, 24 Jul 2013 20:23:04 +0000 (20:23 +0000)]
Merge "Implements extend volume feature in HP 3PAR driver"

11 years agoStorwize/SVC: Use VolumeDriver's copy vol<->image.
Avishay Traeger [Mon, 22 Jul 2013 10:43:29 +0000 (13:43 +0300)]
Storwize/SVC: Use VolumeDriver's copy vol<->image.

Inherit the VolumeDriver copy volume<->image functions. This patch also
creates a new SanDriver class which is protocol-agnostic, and leaves
the SanISCSIDriver class for drivers that wish to use it.

Change-Id: Iad5cb030545ef7f4e01d006f1e63cdeeec713bf6

11 years agoMerge "Implement extend volume for Storwize/SVC."
Jenkins [Wed, 24 Jul 2013 20:09:46 +0000 (20:09 +0000)]
Merge "Implement extend volume for Storwize/SVC."

11 years agoImplements extend volume feature in HP 3PAR driver
Viraj Hardikar [Mon, 22 Jul 2013 18:53:47 +0000 (11:53 -0700)]
Implements extend volume feature in HP 3PAR driver

This patch enables the extend volume feature to be used in cinder
when the backend storage is a 3PAR array.

Change-Id: I8c8422f0ffc6d55ebe80fa8b2962b54eca266974

11 years agouse encode('utf8') instead of str()
Kun Huang [Wed, 24 Jul 2013 16:19:56 +0000 (00:19 +0800)]
use encode('utf8') instead of str()

It is not clear for converting a unicode to string by using str().
Instead we should use var.encode('utf8') to do this.

Change-Id: I8ce4c98f819c98e835a6d8298fe22f2fd0ca18b6

11 years agoImported Translations from Transifex
OpenStack Jenkins [Wed, 24 Jul 2013 18:10:04 +0000 (18:10 +0000)]
Imported Translations from Transifex

Change-Id: Ia984fca524ee33c0ce76931187a5293fb80d8b26

11 years agoMigration for detached volumes with no snaps.
Avishay Traeger [Tue, 18 Jun 2013 18:53:15 +0000 (21:53 +0300)]
Migration for detached volumes with no snaps.

Implementation of volume migration for detached volumes with no
snapshots. Migration is initiated by an admin API. The scheduler
confirms that the specified destination host can accept the volume.
The source driver is given the opportunity to migrate the volume on
their own. Otherwise, a new volume is created on the destination, both
volumes are attached, the data is copied over, the volumes are
detached, the source is deleted, and the destination is renamed. In
the database, the destination volume's attributes are copied to the
source so that the volume-id remains unchanged, and the destination
volume row is deleted.

DocImpact

Implements: bp volume-migration
Change-Id: Ib6fcf27051f45e60aa3ba5f599e88c1421db753e

11 years agoget_snapshot should populate the snapshot metadata
Ollie Leahy [Wed, 24 Jul 2013 10:06:41 +0000 (10:06 +0000)]
get_snapshot should populate the snapshot metadata

Update the query in db api snapshot_get() to join with the table
snapshot_metadata, so that snapshot metadata is returned. This makes the
api snapshot_get() function in the same way as volume_get().

Fixes: bug #1204446
Change-Id: I37004140f6a11b96aaeb3af6c631028a44541d3a

11 years agoMerge "Adding driver minimum features and volume stats to dev doc"
Jenkins [Wed, 24 Jul 2013 09:49:27 +0000 (09:49 +0000)]
Merge "Adding driver minimum features and volume stats to dev doc"

11 years agoAdding driver minimum features and volume stats to dev doc
Mike Perez [Tue, 23 Jul 2013 21:58:06 +0000 (14:58 -0700)]
Adding driver minimum features and volume stats to dev doc

This is a first pass in getting information out of the wiki and into the
dev docs, so changes can be reviewed properly as discussed at the Havana
summit.

Change-Id: I75e71b3e5df69e6b507ee64d330a9ec2455266c5

11 years agoUpdate RBD driver to be compliant with HACKING
Mike Perez [Wed, 24 Jul 2013 00:17:20 +0000 (17:17 -0700)]
Update RBD driver to be compliant with HACKING

Fixes imports, doc strings, and dict style.

Change-Id: Id678d972b9bf744239460fe97155a6a7bd8a868e

11 years agoGPFS convert glance image to raw only when needed
Bill Owen [Mon, 22 Jul 2013 00:35:50 +0000 (17:35 -0700)]
GPFS convert glance image to raw only when needed

Modify _gpfs_fetch_to_raw to check image format.  If already in raw
format, no need to call convert_image.  In that case, simply rename
to destination name.

Change-Id: I197d99194f93c02ce3c501de25433d89b23e6a35
Fixes: bug #1201676
11 years agoMerge "Add create & attach times to SolidFire attributes."
Jenkins [Tue, 23 Jul 2013 18:24:44 +0000 (18:24 +0000)]
Merge "Add create & attach times to SolidFire attributes."

11 years agoFixes RBD driver docstring format issues.
Edward Hope-Morley [Mon, 22 Jul 2013 22:52:06 +0000 (23:52 +0100)]
Fixes RBD driver docstring format issues.

All docstrings should now comply with HACKING.rst

Change-Id: I0892af8d81415880d5e0f9aab5c7cd95ff3bf6b9
Fixes: bug #1203697
11 years agoMerge "Cleanup README.rst"
Jenkins [Tue, 23 Jul 2013 03:34:50 +0000 (03:34 +0000)]
Merge "Cleanup README.rst"

11 years agoMerge "Refactor SSHPool.get() to use Pool.get()"
Jenkins [Tue, 23 Jul 2013 03:34:48 +0000 (03:34 +0000)]
Merge "Refactor SSHPool.get() to use Pool.get()"

11 years agoMerge "Added incremental backup support to Ceph backup driver"
Jenkins [Mon, 22 Jul 2013 19:16:37 +0000 (19:16 +0000)]
Merge "Added incremental backup support to Ceph backup driver"

11 years agofix name 'update_volume_status' to 'update_volume_stats'
Kun Huang [Sat, 20 Jul 2013 18:00:33 +0000 (02:00 +0800)]
fix name 'update_volume_status' to 'update_volume_stats'

_update_volume_status() private method is called by
get_volume_stats(). This is confusing as the volume's
stats and not status gets updated.

fixes bug #1199327

Change-Id: I9f7971e457250798320c14d3f58bdc199c8cfceb

11 years agoFix further Hacking 0.6.x warnings
Dirk Mueller [Fri, 19 Jul 2013 23:14:44 +0000 (01:14 +0200)]
Fix further Hacking 0.6.x warnings

* Add missing Apache license header
* Avoid using locals() in string formatting

Change-Id: Ib9fa878babae5c50bc77e48c62b33a8ebfe39f7f

11 years agoAdd create & attach times to SolidFire attributes.
John Griffith [Fri, 19 Jul 2013 23:05:55 +0000 (17:05 -0600)]
Add create & attach times to SolidFire attributes.

This change simply adds create_time and attach_time to
the SolidFire devices attributes.

Times are taken from the volume-ref object, attach_time
is only set/present after an attach, and is also removed
from the attributes list on a detach.

This also required that we actually set attach_time on the
volume in the db.  We have the column, but we weren't actually
setting it, so this change required that be fixed.

In the future we should also look at changing the attach_time
from a string to a proper date-time object.

Change-Id: Ib9577ac160596a6878d1729f6022885b6cfa90e2

11 years agoImplement extend volume for Storwize/SVC.
Avishay Traeger [Wed, 10 Jul 2013 11:10:15 +0000 (14:10 +0300)]
Implement extend volume for Storwize/SVC.

This implements the extend volume functionality for the Storwize/SVC
driver.  Extending volumes with snapshots is not supported, as this
will require converting the snapshots into full copies, which will eat
up free space.

Change-Id: I5fb8c6967e6f3df1adfef46e05c832a953dd7131

11 years agoCleanup README.rst
Thomas Bechtold [Mon, 22 Jul 2013 09:25:38 +0000 (11:25 +0200)]
Cleanup README.rst

Change-Id: Ia7413db4d71c85cbb382f289f36c02b0f838571d

11 years agoMerge "3PAR Driver modifications to support QOS"
Jenkins [Mon, 22 Jul 2013 06:46:07 +0000 (06:46 +0000)]
Merge "3PAR Driver modifications to support QOS"

11 years agoFix volumes search by metadata
Mathieu Gagné [Wed, 26 Jun 2013 20:27:43 +0000 (16:27 -0400)]
Fix volumes search by metadata

The metadata parameter is urlencoded (to string) by cinderclient
but isn't decoded back to dict by the API.

The metadata parameter needs to be converted back to dict
to be of any use by the filters parameter of get_all().

The original implementation has been done by:
Mathieu Gagne <mgagne@iweb.com>

Fixes: bug #1195015
Change-Id: I19d7d386afddddc067e9f4ef86967c9b72d9e530

11 years agoMerge "Sync gettextutils from oslo"
Jenkins [Fri, 19 Jul 2013 21:59:56 +0000 (21:59 +0000)]
Merge "Sync gettextutils from oslo"

11 years agoAdd test for volume status check when extending
Mathieu Gagné [Fri, 19 Jul 2013 19:49:54 +0000 (15:49 -0400)]
Add test for volume status check when extending

Ensure exception is raised if volume status is not 'available'
when extending volume.

Change-Id: I21337d5ca78090665b2feba50c74f853d3703650

11 years ago3PAR Driver modifications to support QOS
Kurt Martin [Thu, 18 Jul 2013 17:56:21 +0000 (10:56 -0700)]
3PAR Driver modifications to support QOS

Currently, the OpenStack HP 3PAR Fibre Channel (FC) and iSCSI Drivers
do not support Quality of Service (QoS) extra specs. The QoS settings
added in this patch include;
•   maximum MB/second (maxBWS)
•   maximum IO/second (maxIOPS)
These new extra specs will be scoped keys, the scoping will be
qos:maxBWS and qos:maxIOPS. A new key hp3par:vvs was also
added to allow the admin to predefine QOS settings on a 3PAR
virtual volume set and any volume created would be added
to that predefined volume set.

The 3PAR storage arrays set these values on virtual volume sets,
not the actual volume. So the change includes creating a virtual
volume set with these settings and then adding the volume to the
volume set.
1.  Max IO/S & Max MB/S are not QoS guarantees
2.  These are per volume maximums which the 3PAR is guaranteed
not to exceed.
3.  Settings these values does not guarantee these performance
rates will be achievable

DocImpact

Implements blueprint 3par-qos-support

Change-Id: I69031c6d3febe11dd5f9ff17095b86f3fe72a2a4

11 years agoMerge "Clone_image should return dict of vol properties, clone status."
Jenkins [Fri, 19 Jul 2013 16:57:22 +0000 (16:57 +0000)]
Merge "Clone_image should return dict of vol properties, clone status."

11 years agoMake Storwize/SVC tests work without simulator.
Avishay Traeger [Tue, 16 Jul 2013 11:55:58 +0000 (14:55 +0300)]
Make Storwize/SVC tests work without simulator.

Moved to using brick to get connector info and fixed a small bug to get
tests working on real storage again. Also fixed up simulator to handle
the multihostmap case properly.

Change-Id: I7f5804aa94eac29d8c3cec0f8e9ae9339d4e0816

11 years agoRevert hardening of Storwize/SVC SSH commands.
Avishay Traeger [Fri, 19 Jul 2013 13:30:11 +0000 (16:30 +0300)]
Revert hardening of Storwize/SVC SSH commands.

This reverts commit 6be79a8e3b4607adbbe6a26ee565156cd0fb36b0.
Paramiko expects string commands, not lists.

Change-Id: I1b762c0311a0ac810427ea033f737fd067761b1c

11 years agoAdded incremental backup support to Ceph backup driver
Edward Hope-Morley [Tue, 2 Jul 2013 08:40:44 +0000 (09:40 +0100)]
Added incremental backup support to Ceph backup driver

The Ceph backup driver is now capable of doing differential
and incremental backups between or within Ceph clusters.

Implements: blueprint cinder-backup-to-ceph

Change-Id: Id59bf1963c6d35aae4baf6f49be17340982c205c

11 years agoSync gettextutils from oslo
Luis A. Garcia [Mon, 8 Jul 2013 23:03:20 +0000 (23:03 +0000)]
Sync gettextutils from oslo

Bring in the necessary code for handling cinder translations

Partially implements bp user-locale-api

Change-Id: Ibcf087c0f099262b90c115a155fdef619d3c5851

11 years agoImported Translations from Transifex
OpenStack Jenkins [Thu, 18 Jul 2013 18:09:57 +0000 (18:09 +0000)]
Imported Translations from Transifex

Change-Id: I4d20bf6b7a7e6d35e1319dbc758f1ccc305b4971

11 years agoMerge "Imported Translations from Transifex"
OpenStack Jenkins [Thu, 18 Jul 2013 15:04:28 +0000 (15:04 +0000)]
Merge "Imported Translations from Transifex"

11 years agoMerge "Tidy up the SSH call to avoid injection attacks in storwize_svc"
Jenkins [Thu, 18 Jul 2013 15:04:27 +0000 (15:04 +0000)]
Merge "Tidy up the SSH call to avoid injection attacks in storwize_svc"

11 years agoMerge "Fix duplicate config options"
Jenkins [Thu, 18 Jul 2013 10:05:29 +0000 (10:05 +0000)]
Merge "Fix duplicate config options"

11 years agoFix duplicate config options
Zhongyue Luo [Thu, 18 Jul 2013 07:42:34 +0000 (16:42 +0900)]
Fix duplicate config options

This is causing an error in the config file tool generator.
Removed them since they are registered in cinder.api.common

Change-Id: I23988d5133bbb95637dd9514813009ea8b460982

11 years agoMerge "Move copy_volume function to volume/utils.py."
Jenkins [Thu, 18 Jul 2013 07:34:16 +0000 (07:34 +0000)]
Merge "Move copy_volume function to volume/utils.py."

11 years agoMerge "Delete snapshot metadata when snapshot is deleted"
Jenkins [Thu, 18 Jul 2013 07:21:24 +0000 (07:21 +0000)]
Merge "Delete snapshot metadata when snapshot is deleted"

11 years agoMerge "Fix indent in cincer/volume/configuration.py"
Jenkins [Thu, 18 Jul 2013 07:17:19 +0000 (07:17 +0000)]
Merge "Fix indent in cincer/volume/configuration.py"

11 years agoMerge "Fixes Opt type of use_multipath_for_image_xfer"
Jenkins [Thu, 18 Jul 2013 07:17:12 +0000 (07:17 +0000)]
Merge "Fixes Opt type of use_multipath_for_image_xfer"

11 years agoMove copy_volume function to volume/utils.py.
Avishay Traeger [Wed, 17 Jul 2013 12:35:03 +0000 (15:35 +0300)]
Move copy_volume function to volume/utils.py.

There are several copy-pastes of running dd, so moved the most
correct one (LVM) to volume/utils.py, and also updated
BlockDeviceDriver to use it. Other drivers (e.g., NFS, GPFS, Scality)
should be updated as well. Volume migration for detached volumes
is a future use case.

Change-Id: I56c64c94eccf0a311e6f3d611738ad0403351971

11 years agoMerge "Implement validate_connector for Storwize/SVC."
Jenkins [Thu, 18 Jul 2013 04:57:21 +0000 (04:57 +0000)]
Merge "Implement validate_connector for Storwize/SVC."

11 years agoFixes default value of use_default_quota_class
Zhongyue Luo [Wed, 17 Jul 2013 05:19:26 +0000 (14:19 +0900)]
Fixes default value of use_default_quota_class

Changed 'True' to True

Change-Id: I69d5cefd888044b5544e41b34ab4f8974efb0a14

11 years agoMerge "Rename SolidFire driver for consistency"
Jenkins [Wed, 17 Jul 2013 23:23:36 +0000 (23:23 +0000)]
Merge "Rename SolidFire driver for consistency"

11 years agoMerge "Fixes Opt types in cinder/backup/drivers/ceph.py"
Jenkins [Wed, 17 Jul 2013 23:23:29 +0000 (23:23 +0000)]
Merge "Fixes Opt types in cinder/backup/drivers/ceph.py"

11 years agoMerge "Fix extend_volume error handling."
Jenkins [Wed, 17 Jul 2013 22:24:01 +0000 (22:24 +0000)]
Merge "Fix extend_volume error handling."

11 years agoMerge "Fixes race condition in LVMVolumeDriver create_cloned_volume method"
Jenkins [Wed, 17 Jul 2013 18:58:54 +0000 (18:58 +0000)]
Merge "Fixes race condition in LVMVolumeDriver create_cloned_volume method"

11 years agoImported Translations from Transifex
OpenStack Jenkins [Wed, 17 Jul 2013 18:10:23 +0000 (18:10 +0000)]
Imported Translations from Transifex

Change-Id: I71bcb713fc49faea2e1e442f08087800e0ea417a

11 years agoDelete snapshot metadata when snapshot is deleted
Ollie Leahy [Wed, 17 Jul 2013 17:44:04 +0000 (17:44 +0000)]
Delete snapshot metadata when snapshot is deleted

When a volume is deleted all rows in the volume_metadata table for that
volume are deleted as part of the database operation. This patch updates
the snapshot delete operation to delete corresponding rows in the
snapshot_metadata table.

Change-Id: I17543a82be370bed57d4165ad8756ccb390bc0d9

11 years agoTidy up the SSH call to avoid injection attacks in storwize_svc
Haomai Wang [Wed, 17 Jul 2013 13:36:55 +0000 (21:36 +0800)]
Tidy up the SSH call to avoid injection attacks in storwize_svc

Let the command and arguments form up a list and avoid the extra arguments
attackers inserted to the command string

fix bug 1192971

Change-Id: I72bb7ef137223381c9daa613e61f1fde4c3bc8ae

11 years agoFix extend_volume error handling.
Avishay Traeger [Wed, 17 Jul 2013 05:17:14 +0000 (08:17 +0300)]
Fix extend_volume error handling.

If the async call to the manager/driver failed, the API still updated
the quota and volume size in the DB. Solution is to move these tasks
down to the manager, where we know if the extend succeeded.

Change-Id: I668fd659830bd6d410be64a1f5116377b08a9e96
Fixes: bug 1201814
11 years agoFixes race condition in LVMVolumeDriver create_cloned_volume method
Rongze Zhu [Wed, 17 Jul 2013 10:15:04 +0000 (18:15 +0800)]
Fixes race condition in LVMVolumeDriver create_cloned_volume method

When we create a clone volume, LVMVolumeDriver will firstly create a temp
snapshot for copying, the temp snapshot name is
"clone-snap-%s" % source_volume['id']. When we create multiple clone volumes
of the same volume simultaneously, which would trigger the race issuse.

I changes the temp snapshot name template to "clone-snap-%s" % volume['id'],
so temp snapshot name will be unique.

Fixes bug #1202139

Change-Id: I3a4f2585ea9e6f70b6f6f9889e900f19559b8176

11 years agoChecks the volume_clear flag and just return if it is none
Rongze Zhu [Wed, 17 Jul 2013 08:34:21 +0000 (16:34 +0800)]
Checks the volume_clear flag and just return if it is none

Refactors the clear_volume method in LVMVolumeDriver, checks the
volume_clear flag firstly and return directly if it is none.

Change-Id: Id2523cfaaf61c7d6dec51c0daf6255d9de5d50f3

11 years agoMerge "Minor reorg for (array resource usage and backend options naming)"
Jenkins [Wed, 17 Jul 2013 06:23:45 +0000 (06:23 +0000)]
Merge "Minor reorg for (array resource usage and backend options naming)"

11 years agoMerge "remove improper assert usage"
Jenkins [Wed, 17 Jul 2013 06:23:14 +0000 (06:23 +0000)]
Merge "remove improper assert usage"

11 years agoMerge "Add tests for cinder/api/urlmap.py"
Jenkins [Wed, 17 Jul 2013 06:00:38 +0000 (06:00 +0000)]
Merge "Add tests for cinder/api/urlmap.py"

11 years agoMerge "Fix error when QuotaUsage.updated_at is NULL"
Jenkins [Wed, 17 Jul 2013 06:00:27 +0000 (06:00 +0000)]
Merge "Fix error when QuotaUsage.updated_at is NULL"

11 years agoMerge "Add te field user_id into the volume detailed information."
Jenkins [Wed, 17 Jul 2013 05:49:54 +0000 (05:49 +0000)]
Merge "Add te field user_id into the volume detailed information."

11 years agoFixes Opt type of use_multipath_for_image_xfer
Zhongyue Luo [Wed, 17 Jul 2013 05:36:27 +0000 (14:36 +0900)]
Fixes Opt type of use_multipath_for_image_xfer

Changed use_multipath_for_image_xfer from StrOpt to BoolOpt

Change-Id: Id02ba23b233d348885250ccb8c14fcf04667adec

11 years agoFixes Opt types in cinder/backup/drivers/ceph.py
Zhongyue Luo [Wed, 17 Jul 2013 05:26:23 +0000 (14:26 +0900)]
Fixes Opt types in cinder/backup/drivers/ceph.py

Changed backup_ceph_chunk_size, backup_ceph_stripe_unit and
backup_ceph_stripe_count from StrOpt to IntOpt.

Change-Id: I30a0b4d905b41f00e6450bc5cbfbf0c4d8593ab3

11 years agoFix indent in cincer/volume/configuration.py
Zhongyue Luo [Wed, 17 Jul 2013 05:09:18 +0000 (14:09 +0900)]
Fix indent in cincer/volume/configuration.py

Change-Id: I7d6e01de7dbc542ebe8fc35c0776de7a099f91e6

11 years agoMerge "Mark methods used in class only with prefix "_""
Jenkins [Wed, 17 Jul 2013 03:52:29 +0000 (03:52 +0000)]
Merge "Mark methods used in class only with prefix "_""

11 years agoMerge "Add Brick Fibre Channel attach/detach support."
Jenkins [Wed, 17 Jul 2013 03:52:25 +0000 (03:52 +0000)]
Merge "Add Brick Fibre Channel attach/detach support."

11 years agoImplement validate_connector for Storwize/SVC.
Avishay Traeger [Tue, 16 Jul 2013 09:24:30 +0000 (12:24 +0300)]
Implement validate_connector for Storwize/SVC.

Implement the new validate_connector API for the Storwize/SVC driver.

Change-Id: I637f406c2592b158a7941da3657a0517972b0996

11 years agoMerge "Fixes ceph-backup failure if original volume deleted"
Jenkins [Wed, 17 Jul 2013 03:32:10 +0000 (03:32 +0000)]
Merge "Fixes ceph-backup failure if original volume deleted"

11 years agoFix error when QuotaUsage.updated_at is NULL
Haomai Wang [Tue, 16 Jul 2013 13:47:19 +0000 (21:47 +0800)]
Fix error when QuotaUsage.updated_at is NULL

When QuotaUsage.updated_at is None, it will raise non-expected exception.
Just verify it.

Fix bug 1197259

Change-Id: I2b41d025f8cffa6c0b3f0153a5194d5e7b1a05df

11 years agoRename SolidFire driver for consistency
Mathieu Gagné [Wed, 17 Jul 2013 01:03:52 +0000 (21:03 -0400)]
Rename SolidFire driver for consistency

Rename driver to SolidFireDriver for consistency.

Fixes: bug #1136081
Change-Id: I83aef90706474e8a079ab5247b72b33c7a2c8472

11 years agoAdd Brick Fibre Channel attach/detach support.
Walter A. Boring IV [Wed, 10 Jul 2013 22:22:06 +0000 (15:22 -0700)]
Add Brick Fibre Channel attach/detach support.

This patch adds the required code to do
Fibre Channel attach and detaches of volumes.
This code has been pulled over from Nova's
implementation of FC attach/detach.

Also adds a new driver config entry to enable
multipath support for iSCSI and FC attaches
during volume to image and image
to volume transfers.

DocImpact

blueprint cinder-refactor-attach

Change-Id: I436592f958a6c14cd2a0b5d7e53362dd1a7c1a48

11 years agoIncrease timeout period for clone volume.
John Griffith [Wed, 17 Jul 2013 00:27:19 +0000 (18:27 -0600)]
Increase timeout period for clone volume.

Current timeout value for clone volume in the
SolidFire driver is 20 seconds, this is fine
in many cases however there seems to be a
number of customers doing clones of
volumes >= 400G.

A populated 400G volume is taking upwards of
35 seconds to clone in some cases resulting in failure.

There's no reason not to bump this timeout value up
significantly to a worst case scenario (ie multi-terrabyte volume).

Fixes bug: 1202007

Change-Id: I98c399f5d647e14f031018f7fc1cc43bb0d94c84

11 years agoMerge "Adds multiple iSCSI port support to 3PAR"
Jenkins [Wed, 17 Jul 2013 00:13:55 +0000 (00:13 +0000)]
Merge "Adds multiple iSCSI port support to 3PAR"

11 years agoMerge "Be sure to check deleted types on quota update."
Jenkins [Tue, 16 Jul 2013 21:15:44 +0000 (21:15 +0000)]
Merge "Be sure to check deleted types on quota update."

11 years agoMerge "CoraidDriver: Allow volumes in error state to be deleted"
Jenkins [Tue, 16 Jul 2013 19:54:25 +0000 (19:54 +0000)]
Merge "CoraidDriver: Allow volumes in error state to be deleted"

11 years agoBe sure to check deleted types on quota update.
John Griffith [Fri, 12 Jul 2013 23:43:27 +0000 (17:43 -0600)]
Be sure to check deleted types on quota update.

If a volume-type is deleted, and later a volume
that's assigned that type is deleted the quota
update will fail and result in a trace for
VolumeTypeNotFound exception.

The volume is succesfully deleted, however the
quota information for the volume-type let alone
the other quota items for the volume are not
updated.

Fixes bug: 1200709

Change-Id: Idd687514be9d622df84aad54b1b33ddc6615851b

11 years agoCoraidDriver: Allow volumes in error state to be deleted
Jean-Baptiste Ransy [Fri, 12 Jul 2013 13:41:12 +0000 (15:41 +0200)]
CoraidDriver: Allow volumes in error state to be deleted

This fix will allow the delete call to be successfull if volume
doesn't exists on the SAN.

Fixes bug 1195788

Change-Id: I0396f1252c8faafff3e8b4f9a4aeffb930350a8d

11 years agoAdds multiple iSCSI port support to 3PAR
Jim Branen [Wed, 10 Jul 2013 19:34:09 +0000 (12:34 -0700)]
Adds multiple iSCSI port support to 3PAR

Added support to the 3PAR iSCSI OpenStack driver to provide the
ability to select the best fit target iSCSI port from a list of
candidate ports. The first time a volume is attached to a host,
all iSCSI ports configured for driver selection, are examined for
best fit. The port with the least active volumes attached will
then be selected as the path to the 3PAR array. Any subsequent
volume attach, to the same host, will use the established target
port.

DocImpact

Fixes bug #1197036

Change-Id: Icf8c28ea3f201e5e21c9a6ed00a2fbdda445c8b3

11 years agoImplement extend volume functionality in Sheepdog
Haomai Wang [Tue, 16 Jul 2013 09:04:34 +0000 (17:04 +0800)]
Implement extend volume functionality in Sheepdog

This implements the extend volume functionality for Sheepdog driver.

Change-Id: Id7361e9571742bea210f13ced722829f489e7cb0
Implements: blueprint extend-sheepdog-volume

11 years agoMark methods used in class only with prefix "_"
Seif Lotfy [Sun, 14 Jul 2013 23:05:44 +0000 (23:05 +0000)]
Mark methods used in class only with prefix "_"

In the swift driver the three methods prepare_nbackup, backup_chunk
and finalize_backup are used internally in the class only and are
not meant to be used from outside. Thus marked with prefix "_"

Change-Id: Idf3a75f2e799c16b1442a349e0724d3e5af2795a

11 years agoMerge "Add flag argument to 'cinder-manage config list'"
Jenkins [Tue, 16 Jul 2013 08:15:57 +0000 (08:15 +0000)]
Merge "Add flag argument to 'cinder-manage config list'"