]>
review.fuel-infra Code Review - openstack-build/heat-build.git/log
Angus Salkeld [Mon, 23 Apr 2012 02:04:46 +0000 (12:04 +1000)]
Fix more pep8 errors.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Steven Dake [Mon, 23 Apr 2012 01:39:11 +0000 (18:39 -0700)]
Update version to v3
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Fri, 20 Apr 2012 21:48:59 +0000 (14:48 -0700)]
Wordpress 2 instance with EBS and EIP
srs.
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Hardy [Fri, 20 Apr 2012 19:54:04 +0000 (20:54 +0100)]
heat cli : Add bash_completion.d entry for heat
issue #87 Adds basic bash smart-complete script for heat to bash_completion.d
Signed-off-by: Steven Hardy <shardy@redhat.com>
Steven Hardy [Fri, 20 Apr 2012 19:42:29 +0000 (20:42 +0100)]
heat cli: Use python logging module
Issue #88 : Adds support for logging via the python logging module
Signed-off-by: Steven Hardy <shardy@redhat.com>
Ian Main [Fri, 20 Apr 2012 18:49:13 +0000 (11:49 -0700)]
Fix another print -> logger.warn.
Signed-off-by: Ian Main <imain@redhat.com>
Ian Main [Fri, 20 Apr 2012 18:45:07 +0000 (11:45 -0700)]
resources.py had a bunch of print's in it.
This patch removes all the print statements and puts in proper logging
statements. Some of these (db tracebacks) are now logged as warnings.
Signed-off-by: Ian Main <imain@redhat.com>
Ian Main [Fri, 20 Apr 2012 18:38:59 +0000 (11:38 -0700)]
Add an exception around EIP fetching.
I was getting a traceback here causing the whole 'heat describe' to
return an error when really it was just the one aspect failing. Use
try/rescue and log a warning.
Signed-off-by: Ian Main <imain@redhat.com>
Ian Main [Fri, 20 Apr 2012 18:07:36 +0000 (11:07 -0700)]
Fix a typo in the command line help.
Signed-off-by: Ian Main <imain@redhat.com>
Steven Dake [Fri, 20 Apr 2012 17:43:18 +0000 (10:43 -0700)]
Use v1 / v2 / v3 for version numbers to match tags
In the next several months since we wont be supporting maintenance releases,
Just use v1/v2/v3/v4 for releases to match our tags.
We can switch to an x.y.z or openstack style versioning when appropriate
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Fri, 20 Apr 2012 17:36:18 +0000 (10:36 -0700)]
Set proper author and mailing list in setup.py
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Fri, 20 Apr 2012 17:31:39 +0000 (10:31 -0700)]
Remove BUILDING.rst since there is no building taking place inside project
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Fri, 20 Apr 2012 17:29:51 +0000 (10:29 -0700)]
Remove rpm spec file and Makefile. Will track packaging in a different repo
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Fri, 20 Apr 2012 17:28:55 +0000 (10:28 -0700)]
Remove tito - likely track this in a different repo
Signed-off-by: Steven Dake <sdake@redhat.com>
Tomas Sedovic [Thu, 19 Apr 2012 16:23:56 +0000 (18:23 +0200)]
Fix the EIP cleanup
Fixes #69
Signed-off-by: Tomas Sedovic <tomas@sedovic.cz>
Ian Main [Wed, 18 Apr 2012 20:25:44 +0000 (13:25 -0700)]
Add documentation for the per command CLI help options.
Signed-off-by: Ian Main <imain@redhat.com>
Steven Hardy [Wed, 18 Apr 2012 19:47:03 +0000 (20:47 +0100)]
heat, heat-api: Add missing licence to header
Adds missing licence header to heat and heat-api
Signed-off-by: Steven Hardy <shardy@redhat.com>
Jeff Peeler [Wed, 18 Apr 2012 19:17:51 +0000 (15:17 -0400)]
Remove rootpw from tdls and add ec2-user to sudoers file
Fixes #72
Fixes #73
Signed-off-by: Jeff Peeler <jpeeler@redhat.com>
Chris Alfonso [Wed, 18 Apr 2012 16:29:52 +0000 (12:29 -0400)]
Deleting parsed and raw template when deleting stacks
Ian Main [Wed, 18 Apr 2012 15:53:54 +0000 (08:53 -0700)]
A little more detail on network create.
Signed-off-by: Ian Main <imain@redhat.com>
Tomas Sedovic [Wed, 18 Apr 2012 09:29:48 +0000 (11:29 +0200)]
Fix the test environment
Made sure that `run_tests.sh` works properly (it was failing on the heat/bin
directory) and that all tests pass and the generated logs are .gitignored.
Signed-off-by: Tomas Sedovic <tomas@sedovic.cz>
Angus Salkeld [Wed, 18 Apr 2012 06:16:32 +0000 (16:16 +1000)]
Fix another template attribute in the output section
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Wed, 18 Apr 2012 06:15:47 +0000 (16:15 +1000)]
Use the correct api to get the volume object.
It must be volume not nova. But nova is used for the attachment.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Wed, 18 Apr 2012 06:14:24 +0000 (16:14 +1000)]
Save the resource if complete or failed
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Wed, 18 Apr 2012 05:47:21 +0000 (15:47 +1000)]
Fix the delete of a volume attach when the create partially succeeded
Fixes #70
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Wed, 18 Apr 2012 05:08:47 +0000 (15:08 +1000)]
To properly populate the output section.
We need to get ipaddresses which are lost as they are
not stored in the template so we need to retrieve them
at runtime.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Wed, 18 Apr 2012 04:45:22 +0000 (14:45 +1000)]
Use the instance_id for the event "physical_resource_id"
Just to provide a bit more info.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Wed, 18 Apr 2012 04:44:08 +0000 (14:44 +1000)]
Fix the output attribute in single instance wp template
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Wed, 18 Apr 2012 04:43:18 +0000 (14:43 +1000)]
Save the parsed_template so user parameters are available.
This caused parsing errors when deleting, as required
references were not available.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Wed, 18 Apr 2012 04:02:25 +0000 (14:02 +1000)]
Fix the parsed_template columns (missing created_at and updated_at)
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Wed, 18 Apr 2012 02:25:16 +0000 (12:25 +1000)]
Fix the version file (don't import glance's git commit)
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Steven Dake [Tue, 17 Apr 2012 17:12:04 +0000 (10:12 -0700)]
Add WordPress_Single_Instance_With_EBS_EIP.template
This template uses EBS, EIP, security groups in a single instance.
Unfortunately because of issue #83 the template doesn't fully start.
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Tue, 17 Apr 2012 16:36:31 +0000 (09:36 -0700)]
Rename EBS_Volume to just EBS to pave way for EBS_EIP
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Tue, 17 Apr 2012 16:30:21 +0000 (09:30 -0700)]
Make WordPress_Single_Instance_With_EIP.template work
Note I receive an exception in engine.log:
ClientException: Associate floating ip failed (HTTP 500)
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Tue, 17 Apr 2012 16:06:16 +0000 (09:06 -0700)]
Initialize sec to None to avoid exception in security group
When an existing security group is not found in nova, heat will trigger
an exception and the stack won't be created.
Signed-off-by: Steven Dake <sdake@redhat.com>
Zane Bitter [Tue, 17 Apr 2012 16:04:04 +0000 (18:04 +0200)]
Fix invalid JSON in template
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Tue, 17 Apr 2012 15:38:48 +0000 (17:38 +0200)]
Store all event data in DB
Fixes #64
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Tue, 17 Apr 2012 15:38:48 +0000 (17:38 +0200)]
Remove hard-coded paths from DB setup script
Since versions of heat can and will change, we do not want want them
hard-coded in the DB setup script. Instead, use the Python import logic to
determine the location of the module.
This will use the local copy of heat (which is usually what you want) if
run from the top level of the repository. Otherwise it will use the
installed version, as determined by Python.
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Tue, 17 Apr 2012 15:38:48 +0000 (17:38 +0200)]
Avoid printing exception in db-setup
If the db-setup is run multiple times without dropping the database, the
attempt to set up version control again causes an exception. Since this is
an expected condition, just print a message and exit normally.
Signed-off-by: Zane Bitter <zbitter@redhat.com>
root [Tue, 17 Apr 2012 15:38:48 +0000 (17:38 +0200)]
Handle exception on Ctrl-C
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Steven Dake [Tue, 17 Apr 2012 14:12:21 +0000 (07:12 -0700)]
Updated WordPress_Single_Instance.template to work properly.
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Tue, 17 Apr 2012 03:45:26 +0000 (20:45 -0700)]
Update templates README with list of secure vs insecure templates
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Tue, 17 Apr 2012 03:43:28 +0000 (20:43 -0700)]
Make WordPress_Single_Instance_With_EBS_Volume.template functional
Signed-off-by: Steven Dake <sdake@redhat.com>
Angus Salkeld [Tue, 17 Apr 2012 02:09:30 +0000 (12:09 +1000)]
remove old experimental code
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Tue, 17 Apr 2012 01:58:57 +0000 (11:58 +1000)]
kill all pep8 errors in parser and resources
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Steven Dake [Mon, 16 Apr 2012 23:46:27 +0000 (16:46 -0700)]
Updated templates/README directory to more clearly explain templates
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Mon, 16 Apr 2012 23:36:57 +0000 (16:36 -0700)]
Rename WordPress_Single_Instance_cfntools.template to not have cfntools in name
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Mon, 16 Apr 2012 23:36:22 +0000 (16:36 -0700)]
Rename WordPress_Single_Instance.template to have gold in name
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Mon, 16 Apr 2012 23:34:53 +0000 (16:34 -0700)]
Adjust cfn-init -f flag to be implicit
Fixes issue #75 for WordPress_Single_Instance_cfntools.template
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Mon, 16 Apr 2012 23:33:45 +0000 (16:33 -0700)]
Adjust cfn-init to not use -f option
Fixes issue #75 for WordPress_2_Instances_With_EBS_Volume.template
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Mon, 16 Apr 2012 23:32:09 +0000 (16:32 -0700)]
Adjust cfn-init to not take a parameter in the initialization
WordPress_2_Instances.template
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Mon, 16 Apr 2012 23:29:35 +0000 (16:29 -0700)]
Fix bug in path on cfn-init
Fixes issue #75
Signed-off-by: Steven Dake <sdake@redhat.com>
Greg Blomquist [Mon, 16 Apr 2012 21:27:43 +0000 (17:27 -0400)]
Fix for issue #75: no more -f in cfn-init
Removed -f in cfn-init. Instead, cfn-init reads resource metadata from
/var/lib/cloud/data-cfn-init-data.
Also, added logging. cfn-init now logs to stdout and to /var/log/cfn-init.log
Steven Dake [Mon, 16 Apr 2012 21:12:19 +0000 (14:12 -0700)]
gold plating the WordPress_2_Instances template
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Mon, 16 Apr 2012 20:51:50 +0000 (13:51 -0700)]
Wordpress 2 with EBS working
Signed-off-by: Steven Dake <sdake@redhat.com>
Chris Alfonso [Mon, 16 Apr 2012 17:46:58 +0000 (13:46 -0400)]
Resolving rpmlint errors and adding man pages.
Fixes #67
Tomas Sedovic [Mon, 16 Apr 2012 14:35:08 +0000 (16:35 +0200)]
Register security group with launched instances
Signed-off-by: Tomas Sedovic <tomas@sedovic.cz>
Tomas Sedovic [Mon, 16 Apr 2012 13:10:31 +0000 (15:10 +0200)]
Fix creation of security group and rules
When the group or rule already exists, The Nova API and client errored out.
Signed-off-by: Tomas Sedovic <tomas@sedovic.cz>
Angus Salkeld [Mon, 16 Apr 2012 07:07:07 +0000 (17:07 +1000)]
Fix a heap of pep8 errors
./run_tests.sh is much cleaner now.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Mon, 16 Apr 2012 05:37:26 +0000 (15:37 +1000)]
Make an attempt at passing exception messages from engine to cli.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Mon, 16 Apr 2012 03:36:07 +0000 (13:36 +1000)]
Fix 'heat describe'
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Steven Dake [Mon, 16 Apr 2012 03:51:46 +0000 (20:51 -0700)]
Add a traceback on exception caught
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Mon, 16 Apr 2012 02:13:12 +0000 (19:13 -0700)]
Add a README to the templates directory to aid in navigation of the templates
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Mon, 16 Apr 2012 01:53:39 +0000 (18:53 -0700)]
Add a tools/heat-db-drop script for fatal error recovery
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Mon, 16 Apr 2012 00:44:10 +0000 (17:44 -0700)]
Make Wordpress_2_Instances.template work properly
note the mysql instance is not secure because both IPs must be known
ahead of time. To resolve this problem, we will be using elastic IPs.
Signed-off-by: Steven Dake <sdake@redhat.com>
Angus Salkeld [Mon, 16 Apr 2012 00:00:39 +0000 (10:00 +1000)]
Check errors better in resolve_attributes()
Add a little more debug.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Steven Dake [Sun, 15 Apr 2012 18:12:42 +0000 (11:12 -0700)]
Add yum-plugin-fastestmirror on F17-x86_64 cfntools image
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Sun, 15 Apr 2012 18:10:50 +0000 (11:10 -0700)]
Add yum-plugin-fastestmirror to the cfntools images
Should speed up the downloading of packages on launch
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Sun, 15 Apr 2012 17:28:52 +0000 (10:28 -0700)]
Update WordPress_2_Instances.template to use cfntools and cfn-init
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Sat, 14 Apr 2012 16:36:33 +0000 (09:36 -0700)]
resources: remove insert_package_and_services
Now that we have cfn-init, this hackery is no longer needed
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Sat, 14 Apr 2012 15:10:38 +0000 (08:10 -0700)]
Properly launches a cfntools image with the appropriate userdata mime blob
Note that cfn-init should be run as follows in the userdata script
/opt/aws/bin/cfn-init -f /var/lib/cloud/data/cfn-init-data
This will install the appropriate RPMS and enable them
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Sat, 14 Apr 2012 14:57:06 +0000 (07:57 -0700)]
Correct path to cfninit data
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Sat, 14 Apr 2012 14:34:08 +0000 (07:34 -0700)]
Yet more typos in cfntools template
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Sat, 14 Apr 2012 14:27:15 +0000 (07:27 -0700)]
Fix typo in template
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Sat, 14 Apr 2012 14:23:20 +0000 (07:23 -0700)]
Add a cfn-init call to cfntools
Signed-off-by: Steven Dake <sdake@redhat.com>
Chris Alfonso [Sat, 14 Apr 2012 12:15:22 +0000 (08:15 -0400)]
Automatic commit of package [heat] release [0.0.1-1].
Chris Alfonso [Sat, 14 Apr 2012 12:12:14 +0000 (08:12 -0400)]
Adding instructions on building the project with tito
Chris Alfonso [Sat, 14 Apr 2012 11:58:27 +0000 (07:58 -0400)]
Removing the PKG-INFO and vcsversion.py from the rpm
Chris Alfonso [Fri, 13 Apr 2012 20:05:40 +0000 (16:05 -0400)]
Initialized to use tito.
Jeff Peeler [Fri, 13 Apr 2012 21:10:30 +0000 (17:10 -0400)]
Add unit test framework nose and associated helper scripts
For usage documentation, refer to heat/tests/testing-overview.txt.
run_tests.sh is what runs the tests.
Fixes #44
Signed-off-by: Jeff Peeler <jpeeler@redhat.com>
Ian Main [Fri, 13 Apr 2012 20:29:57 +0000 (13:29 -0700)]
Document all methods in the EngineManager class. These ones seem important.
Signed-off-by: Ian Main <imain@redhat.com>
Chris Alfonso [Fri, 13 Apr 2012 19:59:12 +0000 (15:59 -0400)]
Updating the heat spec to pull in cloudinit files and i386 jeos templates
Chris Alfonso [Fri, 13 Apr 2012 19:01:41 +0000 (15:01 -0400)]
renaming CloudFormations to CloudFormation
Zane Bitter [Fri, 13 Apr 2012 15:58:23 +0000 (17:58 +0200)]
Handle errors when listing events
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Fri, 13 Apr 2012 15:58:23 +0000 (17:58 +0200)]
Show stack description when status is unknown
Apply the same improvement that
d41193cbff97caf68a5eaa5b105593af17e3339d
made for list_stacks to show_stack.
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Fri, 13 Apr 2012 15:58:23 +0000 (17:58 +0200)]
Allow listing of all events
Make filtering by StackName optional.
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Tomas Sedovic [Fri, 13 Apr 2012 13:56:29 +0000 (15:56 +0200)]
Use security groups in the multi-instance wp template
Tomas Sedovic [Fri, 13 Apr 2012 12:43:07 +0000 (14:43 +0200)]
Fix listing stacks
`heat list` was failing for non-empty stacks because the `Stack` model had no
`template` attribute.
Also fixed an issue where we didn't show the template description when the
stack status was unknown.
Angus Salkeld [Fri, 13 Apr 2012 10:15:23 +0000 (20:15 +1000)]
Fix the stack.delete() by populating the resource id/state from the db.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Fri, 13 Apr 2012 10:13:09 +0000 (20:13 +1000)]
move the db stack delete into parser.py as it is non-blocking.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Fri, 13 Apr 2012 07:23:29 +0000 (17:23 +1000)]
Cleanup db imports (use heat code, don't import nova modules)
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Fri, 13 Apr 2012 06:25:07 +0000 (16:25 +1000)]
Consistently create the db resource entry.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Fri, 13 Apr 2012 05:26:09 +0000 (15:26 +1000)]
Add SecurityGroups to make is easier to use EIP
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Zane Bitter [Fri, 13 Apr 2012 10:10:10 +0000 (12:10 +0200)]
Eliminate overly-broad exception catching
We probably don't want to catch e.g. KeyboardInterrupt in these cases.
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Fri, 13 Apr 2012 10:10:10 +0000 (12:10 +0200)]
Improvements to DB setup
Don't fail if the database or user already exists.
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Fri, 13 Apr 2012 10:10:10 +0000 (12:10 +0200)]
Issue #52: Fix error in db-setup script
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Steven Dake [Fri, 13 Apr 2012 04:16:42 +0000 (21:16 -0700)]
Start systemd services properly with cfn-init tool
Signed-off-by: Steven Dake <sdake@redhat.com>
Angus Salkeld [Fri, 13 Apr 2012 02:37:13 +0000 (12:37 +1000)]
Fix the jeos path when running from installed code.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Fri, 13 Apr 2012 00:16:29 +0000 (10:16 +1000)]
Delete extra white space
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Fri, 13 Apr 2012 00:13:42 +0000 (10:13 +1000)]
Fix 'heat list' when there are no stacks
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>