]>
review.fuel-infra Code Review - openstack-build/heat-build.git/log
Angus Salkeld [Wed, 23 May 2012 12:15:38 +0000 (22:15 +1000)]
Use the new CheckedDict for Parameters
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Wed, 23 May 2012 11:53:11 +0000 (21:53 +1000)]
Add some better checking for parameters and properties
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Chris Alfonso [Tue, 22 May 2012 21:05:55 +0000 (17:05 -0400)]
Fixing path lookup to make sure the templates can be found
Change-Id: Ib48c27a9d0a794d243e48661aaebb108728af6bb
Conflicts:
heat/tests/test_resources.py
heat/tests/test_stacks.py
Jenkins [Tue, 22 May 2012 20:03:24 +0000 (20:03 +0000)]
Merge "tools/openstack: Updated to latest openstack F16/F17 tools"
Chris Alfonso [Tue, 22 May 2012 17:29:25 +0000 (13:29 -0400)]
Adding the AWS::IAM::User and AWS::IAM::AccessKey to the mapping
Steven Dake [Tue, 22 May 2012 16:50:53 +0000 (09:50 -0700)]
tools/openstack: Updated to latest openstack F16/F17 tools
Change-Id: I8e6b376a90ad1641c10eea2ef6711a9cd09ee2e0
Signed-off-by: Steven Dake <sdake@redhat.com>
Andrew Hutchings [Tue, 22 May 2012 12:11:39 +0000 (13:11 +0100)]
Update gitreview for new Stackforge remote
Change-Id: I265b771fa2b4d040a9e90ceb265941acdea90156
Monty Taylor [Thu, 17 May 2012 20:02:04 +0000 (16:02 -0400)]
Align with project standards.
Rebased from: Change-Id: Ifc9fff4f88dfaebe97b7caba4d603d23c645e346
Reviewed-by: Steven Dake <sdake@redhat.com>
Steven Dake [Mon, 21 May 2012 23:43:48 +0000 (16:43 -0700)]
Fedora openstack projects use new tools to setup databases
Signed-off-by: Steven Dake <sdake@redhat.com>
Andrew Hutchings [Thu, 17 May 2012 10:16:00 +0000 (11:16 +0100)]
Add .gitreview for Gerrit
Reviewed-by: Steven dake <sdake@redhat.com>
Zane Bitter [Mon, 21 May 2012 21:41:17 +0000 (23:41 +0200)]
Add an integration test script
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Chris Alfonso [Mon, 21 May 2012 19:41:29 +0000 (15:41 -0400)]
Pep8 fixes
Chris Alfonso [Mon, 21 May 2012 19:39:11 +0000 (15:39 -0400)]
Merge branch 'puppet_instances'
Conflicts:
heat/api/v1/__init__.py
heat/engine/parser.py
Chris Alfonso [Mon, 21 May 2012 19:33:08 +0000 (15:33 -0400)]
Merge branch 'puppet_instances' of github.com:heat-api/heat into puppet_instances
Conflicts:
heat/api/v1/__init__.py
Chris Alfonso [Mon, 21 May 2012 18:50:54 +0000 (14:50 -0400)]
Fixing _decompress to handle bundled and compressed
The api call to os.path.splitext returns the root and the ext;
however, for a .tar.gz the ext would just be the .gz, which meant
there was no handler for a file with a .gz extension.
Zane Bitter [Mon, 21 May 2012 12:53:42 +0000 (14:53 +0200)]
Handle failures when deleting stacks
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Mon, 21 May 2012 18:18:33 +0000 (20:18 +0200)]
Fix problem with updating parsed template in DB
The parsed template would not always be updated correctly when the actual
template object had not changed (only the contents). This change forces an
update by making a copy.
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Mon, 21 May 2012 13:08:36 +0000 (15:08 +0200)]
Fix copy-paste errors in template descriptions
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Mon, 21 May 2012 12:53:03 +0000 (14:53 +0200)]
Improvements to uninstall script
- Kill only the specific heat processes we want (heat-api and heat-engine).
- Remove installations wherever they may be located.
- More robust handling of input.
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Fri, 18 May 2012 12:02:39 +0000 (14:02 +0200)]
Refactor some not-particularly-Pythonic code
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Fri, 18 May 2012 12:02:39 +0000 (14:02 +0200)]
Delete networks when erasing OpenStack
This is required to remove any network interfaces created using nova. If
these are left behind they prevent a new installation of OpenStack
re-adding them.
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Chris Alfonso [Fri, 18 May 2012 15:10:55 +0000 (11:10 -0400)]
Adding chaining to CommandRunner
Chris Alfonso [Thu, 17 May 2012 14:33:39 +0000 (10:33 -0400)]
Making PrivateDnsName return the ip address
Chris Alfonso [Wed, 16 May 2012 20:15:34 +0000 (16:15 -0400)]
Adding puppet and puppet master instances
Zane Bitter [Fri, 18 May 2012 12:02:38 +0000 (14:02 +0200)]
Wait for instance startup in GettingStarted test
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Steven Hardy [Thu, 17 May 2012 20:43:51 +0000 (21:43 +0100)]
api : fix pep8 warning
Fix long-line pep8 warning
Signed-off-by: Steven Hardy <shardy@redhat.com>
Tomas Sedovic [Thu, 17 May 2012 14:49:15 +0000 (16:49 +0200)]
Allow engine and metadata server start in any order
When the metadata server starts first, it will wait for the engine to come up
and only then registers it's hostname and port and becomes available.
Signed-off-by: Tomas Sedovic <tomas@sedovic.cz>
Chris Alfonso [Thu, 17 May 2012 14:33:39 +0000 (10:33 -0400)]
Making PrivateDnsName return the ip address
Tomas Sedovic [Wed, 16 May 2012 13:15:39 +0000 (15:15 +0200)]
Clean up the API routes
Signed-off-by: Tomas Sedovic <tomas@sedovic.cz>
Chris Alfonso [Wed, 16 May 2012 20:15:34 +0000 (16:15 -0400)]
Adding puppet and puppet master instances
Tomas Sedovic [Wed, 16 May 2012 13:15:39 +0000 (15:15 +0200)]
Clean up the API routes
Signed-off-by: Tomas Sedovic <tomas@sedovic.cz>
Angus Salkeld [Tue, 8 May 2012 04:26:23 +0000 (14:26 +1000)]
Make the wait condition behave better when the stack is deleted.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Steven Hardy [Wed, 16 May 2012 08:36:43 +0000 (09:36 +0100)]
heat cli : Add options to bash completion script
Ref #87 add completion of long-format options, align the command options with
the "heat help" option
Signed-off-by: Steven Hardy <shardy@redhat.com>
Steven Hardy [Tue, 15 May 2012 21:01:18 +0000 (22:01 +0100)]
heat client : reduce duplication between functions
Move common code into utility function to reduce duplication
Signed-off-by: Steven Hardy <shardy@redhat.com>
Steven Hardy [Mon, 14 May 2012 22:27:02 +0000 (23:27 +0100)]
API and heat-cli rework to align with AWS CloudFormation API
Ref #115, rework API mapper to route by Action= query parameter,
not by path, and align heat CLI tool with revised API.
Signed-off-by: Steven Hardy <shardy@redhat.com>
Zane Bitter [Tue, 15 May 2012 13:03:38 +0000 (15:03 +0200)]
Report errors when resource creation fails
In order for the Stack creation to fail, resources must raise an exception
when their creation fails. The Stack's create code will set the resource
state appropriately; resources should not silently do it themselves.
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Tue, 15 May 2012 09:42:37 +0000 (11:42 +0200)]
Modify command names for consistency
Replace 'events_list' with 'event-list' and 'jeos_create' with
'jeos-create'. This makes things consistent with the conventions of
OpenStack projects. The old versions will continue to work for now.
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Chris Alfonso [Mon, 14 May 2012 18:24:25 +0000 (14:24 -0400)]
Updated the version to 4
Signed-off-by: Chris Alfonso <calfonso@redhat.com>
Zane Bitter [Mon, 14 May 2012 15:56:33 +0000 (17:56 +0200)]
Make 'heat help' show a list of commands
Previously we just printed an error message about not specifying a command
to get help about, and no hint about how to work out which commands even
existed.
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Mon, 14 May 2012 14:03:49 +0000 (16:03 +0200)]
Allow the Getting Started script to run non-interactively
Related: #84
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Chris Alfonso [Mon, 14 May 2012 13:55:50 +0000 (09:55 -0400)]
Fix pep8 errors
Tomas Sedovic [Mon, 14 May 2012 11:56:27 +0000 (13:56 +0200)]
Set cfn-hup to send events to the metadata server
Fixes #107
This is implemented using a logging handler that sends events to the metadata
server.
Signed-off-by: Tomas Sedovic <tomas@sedovic.cz>
Angus Salkeld [Mon, 14 May 2012 11:15:23 +0000 (21:15 +1000)]
Slim down the getting_started template.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Mon, 14 May 2012 11:14:55 +0000 (21:14 +1000)]
Check for the presence of Metadat before trying to include it the multipart
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Jeff Peeler [Fri, 11 May 2012 23:23:27 +0000 (19:23 -0400)]
Add status argument that shows service status for all required services
Signed-off-by: Jeff Peeler <jpeeler@redhat.com>
Steven Dake [Fri, 11 May 2012 22:12:56 +0000 (15:12 -0700)]
Kill some pep8 errors in test_stacks.py
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Fri, 11 May 2012 22:10:47 +0000 (15:10 -0700)]
Kill some pep8 errors in engine directory
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Fri, 11 May 2012 22:07:34 +0000 (15:07 -0700)]
Kill few pep8 errors
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Fri, 11 May 2012 21:58:14 +0000 (14:58 -0700)]
Properly test ref valid against proper input
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Fri, 11 May 2012 21:55:24 +0000 (14:55 -0700)]
Use manager to test ref validation
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Fri, 11 May 2012 21:52:31 +0000 (14:52 -0700)]
Add test cases to test valid and invalid keys in FindInMap
Partially Fixes issue #111
Signed-off-by: Steven Dake <sdake@redhat.com>
Ian Main [Fri, 11 May 2012 20:54:40 +0000 (13:54 -0700)]
List stacks tests
Implements a list stacks test. This one calls straight into engine
manager.
Signed-off-by: Ian Main <imain@redhat.com>
Ian Main [Fri, 11 May 2012 18:14:08 +0000 (11:14 -0700)]
Move list_events into the class.
I think I went too far last time, this should at least be a method
of the class.
Signed-off-by: Ian Main <imain@redhat.com>
Ian Main [Fri, 11 May 2012 17:47:17 +0000 (10:47 -0700)]
Factor out a start_wordpress_stack()
There was a lot of code duplication in the tests so I factored out
a function to start a wordpress stack.
Signed-off-by: Ian Main <imain@redhat.com>
Ian Main [Fri, 11 May 2012 17:23:38 +0000 (10:23 -0700)]
Add event_list test.
I moved parse_event out of the method and into the class so we could
call it from the event_list test.
Signed-off-by: Ian Main <imain@redhat.com>
Zane Bitter [Fri, 11 May 2012 16:54:38 +0000 (18:54 +0200)]
Add uninstall script
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Fri, 11 May 2012 16:54:38 +0000 (18:54 +0200)]
Add Getting Started guide to repo
Convert the Getting Started wiki page to ReStructuredText format and add it
to the repository. Also add a script that will extract the shell commands
from the document and run them, so we can use it as an integration test.
The script can be run using the command:
> bash -c "$(./tools/rst2script.sed docs/GettingStarted.rst)"
Related: #84
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Fri, 11 May 2012 16:54:38 +0000 (18:54 +0200)]
Add cfn-get-metadata to the manifest
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Zane Bitter [Fri, 11 May 2012 16:54:38 +0000 (18:54 +0200)]
Fixed problems with starting MySQL in heat-db-setup
Signed-off-by: Zane Bitter <zbitter@redhat.com>
Steven Dake [Fri, 11 May 2012 16:41:51 +0000 (09:41 -0700)]
Add test_validate_ref for invalid and valid inputs
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Fri, 11 May 2012 15:33:13 +0000 (08:33 -0700)]
Check for invalid Fn::FindInMap key
Partially Fixes Issue #111
Signed-off-by: Steven Dake <sdake@redhat.com>
Steven Dake [Fri, 11 May 2012 15:30:17 +0000 (08:30 -0700)]
Check for invalid Ref keys in validate
Partially Fixes Issue #111
Signed-off-by: Steven Dake <sdake@redhat.com>
Angus Salkeld [Fri, 11 May 2012 00:45:35 +0000 (10:45 +1000)]
TEST: slightly better version with minimal template in place.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Steven Dake [Fri, 11 May 2012 00:10:53 +0000 (17:10 -0700)]
Add volumeattachment validation
Signed-off-by: Steven Dake <sdake@redhat.com>
Chris Alfonso [Thu, 10 May 2012 19:31:31 +0000 (15:31 -0400)]
Allowed the database call to return no parsed template.
The database impl was raising an exception if no parsed template
exists. The logic that was looking up the parsed template
expects None to be returned if the template isn't stored.
* I also fixed some pep8 errors.
Chris Alfonso [Thu, 10 May 2012 19:02:46 +0000 (15:02 -0400)]
Adding a deepcopy of the template before stack create validation
Calling stack.validate will modify the stack's template, which
we don't want to do. We just want to validate the template and move
on with an already parsed template.
Chris Alfonso [Thu, 10 May 2012 18:04:16 +0000 (14:04 -0400)]
Add stack delete test, and set stack to DELETE_COMPLETE when done.
Chris Alfonso [Thu, 10 May 2012 17:40:15 +0000 (13:40 -0400)]
Removing stack validation on create
Chris Alfonso [Wed, 9 May 2012 20:49:45 +0000 (16:49 -0400)]
Adding stack create test
Steven Dake [Wed, 9 May 2012 20:35:22 +0000 (13:35 -0700)]
Validate invalid mountpoint.device entries
Since KVM only allows /dev/vd[a-z], we validate that implementation-specific
sd[a-z] is rejected by heat validation.
See:
http://docs.openstack.org/trunk/openstack-compute/admin/content/managing-volumes.html
Search device name
Resolves issue #71
Signed-off-by: Steven Dake <sdake@redhat.com>
Tomas Sedovic [Wed, 9 May 2012 16:23:22 +0000 (18:23 +0200)]
Allow sending events using metadata server
Signed-off-by: Tomas Sedovic <tomas@sedovic.cz>
Tomas Sedovic [Wed, 9 May 2012 15:02:28 +0000 (17:02 +0200)]
Typo in a logging declaration
Signed-off-by: Tomas Sedovic <tomas@sedovic.cz>
Chris Alfonso [Wed, 9 May 2012 13:45:15 +0000 (09:45 -0400)]
Fix stack creation - CREATE_FAILED issue
The stack creation call to validate the stack was resetting the
stack template attribute. I've made a copy of the stack purely
for validation purposes.
Jeff Peeler [Tue, 8 May 2012 21:39:08 +0000 (17:39 -0400)]
Add ability to automate testing with tox.
Install tox via easy_install. Tox automates the creation of multiple
virtual environments, each of which can be used with a different
interpreter or specific custom tests (and is what StackForge uses).
Signed-off-by: Jeff Peeler <jpeeler@redhat.com>
Jeff Peeler [Tue, 8 May 2012 18:41:21 +0000 (14:41 -0400)]
Add option to exclude pep8 examination to run_test.sh.
Signed-off-by: Jeff Peeler <jpeeler@redhat.com>
Jeff Peeler [Tue, 8 May 2012 15:31:25 +0000 (11:31 -0400)]
Add test coverage option to run_tests.sh
Signed-off-by: Jeff Peeler <jpeeler@redhat.com>
Angus Salkeld [Mon, 7 May 2012 13:04:35 +0000 (23:04 +1000)]
Connect up the waitcondition code to poll the metadata for the signal.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Mon, 7 May 2012 12:04:04 +0000 (22:04 +1000)]
Save to parsed template as that is used in the parser.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Mon, 7 May 2012 10:49:39 +0000 (20:49 +1000)]
WaitCondition: fix the url to the new metadata server.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Mon, 7 May 2012 10:47:28 +0000 (20:47 +1000)]
Add WaitConditions to HA template
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Mon, 7 May 2012 10:46:44 +0000 (20:46 +1000)]
Download cfn tools from the master branch.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Mon, 7 May 2012 10:15:02 +0000 (20:15 +1000)]
Escape the quotes going into cfn-signal shell command.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Mon, 7 May 2012 08:58:36 +0000 (18:58 +1000)]
More peppy fixes...
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Mon, 7 May 2012 08:29:17 +0000 (18:29 +1000)]
Add implementation to cfn-signal
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Mon, 7 May 2012 08:27:35 +0000 (18:27 +1000)]
Fix undefined LOG variable in db.session
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Mon, 7 May 2012 08:25:48 +0000 (18:25 +1000)]
Remove unused "cloudinit_path" setup in resources.py
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Angus Salkeld [Mon, 7 May 2012 08:25:03 +0000 (18:25 +1000)]
Metadata: Add bind_host to the config
This needs to be set to the nova interface to work.
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Tomas Sedovic [Sat, 5 May 2012 01:01:31 +0000 (03:01 +0200)]
Register metadata server's entry point with Engine
Signed-off-by: Tomas Sedovic <tomas@sedovic.cz>
Tomas Sedovic [Sat, 5 May 2012 01:00:16 +0000 (03:00 +0200)]
Remove obsoleted metadata files
Signed-off-by: Tomas Sedovic <tomas@sedovic.cz>
Tomas Sedovic [Fri, 4 May 2012 13:16:11 +0000 (15:16 +0200)]
Connect metadata server to the engine via RPC
Similarly to the way heat-api works, the engine does all the heavy lifting (db
access, etc.) while the metadata server provides the API layer that communicates
with the engine.
Signed-off-by: Tomas Sedovic <tomas@sedovic.cz>
Chris Alfonso [Fri, 4 May 2012 18:53:17 +0000 (14:53 -0400)]
Moving key validation into instance validate
Ian Main [Fri, 4 May 2012 18:23:09 +0000 (11:23 -0700)]
Apparently boto expects / to be list stacks.
This patch just makes / redirect to list_stacks.
Signed-off-by: Ian Main <imain@redhat.com>
Steven Dake [Fri, 4 May 2012 17:09:41 +0000 (10:09 -0700)]
ValidateTemplate API call framework
This is a start on issue #111
While no actual validation is done by this patch, this patch introduces
the framework for validating in each of the resource types and returning
an appropriate error when a validation error occurs.
Signed-off-by: Steven Dake <sdake@redhat.com>
Angus Salkeld [Fri, 4 May 2012 01:21:55 +0000 (11:21 +1000)]
Fix the sql in the rails template (didn't work with the mysql in f16)
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Chris Alfonso [Thu, 3 May 2012 21:45:18 +0000 (17:45 -0400)]
uncommenting the metadata server attribute so the tests work
Chris Alfonso [Thu, 3 May 2012 19:06:20 +0000 (15:06 -0400)]
Validating the KeyName against nova on stack_create
Fixes Issue #98
Tomas Sedovic [Thu, 3 May 2012 14:19:17 +0000 (16:19 +0200)]
Connect cfn utils to the remote server
The cfn_helper's `Metadata` class can now connect to the metadata server
prodived it's URL is known and available.
Engine will pass metadata server's URL via the User Data to the following file:
/var/lib/cloud/data/cfn-metadata-server
If the file doesn't exist or the server is unreachable, cfntools will read
metadata from the `/var/lib/cloud/data/cfn-init-data` file as they did so far.
Note that Engine dosen't currently know the metadata server's URL so it's not
passing it to the instance yet.
Tomas Sedovic [Thu, 3 May 2012 14:33:53 +0000 (16:33 +0200)]
Fix cfn-get-metadata params and output
Marked the `--stack` and `--resource` parameters as required and set it to
actually write the metadata out.
Signed-off-by: Tomas Sedovic <tomas@sedovic.cz>
Angus Salkeld [Thu, 3 May 2012 13:26:25 +0000 (23:26 +1000)]
Fixed the interpretation of the file extension.
My initial lack of understanding of "is" and "==".
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
Chris Alfonso [Thu, 3 May 2012 13:10:13 +0000 (09:10 -0400)]
Only showing the Outputs when the status of a stack is CREATE_COMPLETE
This fixes issues #96