]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/log
pellisesol [Fri, 2 Oct 2020 17:06:33 +0000 (12:06 -0500)]
Update firewall.rb
On Gentoo using 'vrrp' sets the proto to 112 but when puppet runs it interprets 112 as 'carp' which it then corrects to 'vrrp' which is still 112. So it redoes the rule every time puppet runs. Adding carp here allows carp to be set as a valid option which removes the loop.
Adrian Iurca [Mon, 6 Sep 2021 18:29:41 +0000 (21:29 +0300)]
Merge pull request #1006 from bastelfreak/testpr
Replace travis link in README.md with GHA
Tim Meusel [Mon, 16 Aug 2021 11:49:34 +0000 (13:49 +0200)]
Replace travis link in README.md with GHA
Adrian Iurca [Mon, 6 Sep 2021 13:12:32 +0000 (16:12 +0300)]
Merge pull request #1012 from puppetlabs/release-prep
Release prep v3.2.0
GitHub Action [Mon, 6 Sep 2021 13:10:59 +0000 (13:10 +0000)]
Release prep v3.2.0
sheenaajay [Mon, 6 Sep 2021 13:07:30 +0000 (14:07 +0100)]
Merge pull request #1011 from puppetlabs/pdksync-changelog-max-issues-500
pdksync: changelog_max_issues set to 500
adrianiurca [Mon, 6 Sep 2021 12:33:50 +0000 (15:33 +0300)]
pdksync: changelog_max_issues set to 500
Adrian Iurca [Mon, 6 Sep 2021 12:17:41 +0000 (15:17 +0300)]
Merge pull request #1010 from drivenet/feature/fix-nil-gsub-for-uid-setup
Fix "undefined method `gsub' for nil:NilClass" when changing existing rule UID from absent to any present
Aristarkh Zagorodnikov [Tue, 31 Aug 2021 09:31:01 +0000 (12:31 +0300)]
Fix "undefined method `gsub' for nil:NilClass" when changing existing rule UID from absent to present
Michael T Lombardi (He/Him) [Mon, 30 Aug 2021 16:54:41 +0000 (11:54 -0500)]
Merge pull request #1009 from smortex/stdlib-ci
(IAC-1739) Fix CI with stdlib 8.0.0
adrianiurca [Mon, 30 Aug 2021 15:52:21 +0000 (18:52 +0300)]
oracle-7 is using iptables instead of iptables-services
Romain Tartière [Thu, 26 Aug 2021 17:34:27 +0000 (07:34 -1000)]
(IAC-1741) Prefer 'installed' to 'present' for packages
stdlib 8.0.0 fixed this value for `ensure_package`, so we have to sync
with it. While here, also use `installed` for package resources.
Because 'present' is still something that works, this is not a breaking
change.
david22swan [Wed, 25 Aug 2021 10:24:35 +0000 (11:24 +0100)]
(IAC-1741) Allow stdlib v8.0.0
daianamezdrea [Mon, 9 Aug 2021 08:46:58 +0000 (11:46 +0300)]
Merge pull request #1005 from puppetlabs/pdksync_IAC-1709/main/add_debian_11_support
pdksync - (IAC-1709) - Add Support for Debian 11
adrianiurca [Sun, 8 Aug 2021 21:21:50 +0000 (00:21 +0300)]
mac_source is downcased by iptables also on debian-11
David Swan [Wed, 4 Aug 2021 14:42:25 +0000 (15:42 +0100)]
(IAC-1709) - Add Support for Debian 11
Adrian Iurca [Mon, 26 Jul 2021 08:52:30 +0000 (11:52 +0300)]
Merge pull request #1003 from puppetlabs/release-prep
Release prep v3.1.0
GitHub Action [Mon, 26 Jul 2021 08:47:12 +0000 (08:47 +0000)]
Release prep v3.1.0
daianamezdrea [Fri, 23 Jul 2021 06:56:48 +0000 (09:56 +0300)]
Merge pull request #1002 from puppetlabs/modules-11138-Facter-fact-error
(MODULES-11138) - Fix mac_source Facter.fact().value() issue with Facter 3
adrianiurca [Thu, 22 Jul 2021 15:27:35 +0000 (18:27 +0300)]
use new facts instead of legacy facts
adrianiurca [Wed, 21 Jul 2021 12:58:09 +0000 (15:58 +0300)]
(MODULES-11138) - Facter.fact().value() not supported by facter 3
david22swan [Wed, 21 Jul 2021 10:09:45 +0000 (11:09 +0100)]
Merge pull request #1001 from puppetlabs/pdksync_iac-1149
pdksync - (maint) - Updating Contribution Guidelines
Paula Muir [Tue, 20 Jul 2021 14:28:52 +0000 (15:28 +0100)]
(maint) Updating CONTRIBUTING guidelines
Adrian Iurca [Mon, 19 Jul 2021 12:42:59 +0000 (15:42 +0300)]
Merge pull request #998 from vchepkov/rocky
add compatibility with Rocky Linux
carabasdaniel [Mon, 19 Jul 2021 12:35:10 +0000 (15:35 +0300)]
Merge pull request #1000 from puppetlabs/release-prep
Release prep v3.0.2
adrianiurca [Mon, 19 Jul 2021 12:04:30 +0000 (15:04 +0300)]
update HISTORY.md and cleanup CHANGELOG.md
GitHub Action [Mon, 19 Jul 2021 11:24:16 +0000 (11:24 +0000)]
Release prep v3.0.2
carabasdaniel [Mon, 19 Jul 2021 11:08:35 +0000 (14:08 +0300)]
Merge pull request #999 from puppetlabs/update-since-tag
Update changelog_since_tag
adrianiurca [Mon, 19 Jul 2021 10:17:42 +0000 (13:17 +0300)]
pdksync v2.1.1
Adrian Iurca [Tue, 13 Jul 2021 11:37:12 +0000 (14:37 +0300)]
Update changelog_since_tag
Vadym Chepkov [Sat, 10 Jul 2021 22:46:53 +0000 (18:46 -0400)]
add compatibility with Rocky Linux
Adrian Iurca [Tue, 6 Jul 2021 11:29:51 +0000 (14:29 +0300)]
Merge pull request #996 from operasoftware-osp/fix-parsing
fix: parsing random_fully in ip6tables
Łukasz Czapliński [Thu, 1 Jul 2021 13:21:29 +0000 (15:21 +0200)]
fix: parsing random_fully in ip6tables
Looks like
https://github.com/puppetlabs/puppetlabs-firewall/commit/
9a4bc6a81cf0cd4a56ba458fadac830a2c4df529
added relevant params only to iptables, not ip6tables.
This results in warnings like
```
Warning: Puppet::Type::Firewall::ProviderIp6tables: Skipping unparsable iptables rule: keys (3) and values (4) count mismatch on line: -A KUBE-POSTROUTING -m comment --comment "kubernetes service traffic requiring SNAT" -j MASQUERADE --random-fully
```
carabasdaniel [Mon, 5 Jul 2021 14:58:31 +0000 (17:58 +0300)]
Merge pull request #997 from puppetlabs/mac_source-idempotency
sles-15: mac_source is downcased by iptables
adrianiurca [Mon, 5 Jul 2021 10:34:49 +0000 (13:34 +0300)]
mac_source is downcased by iptables
sheenaajay [Mon, 21 Jun 2021 14:26:36 +0000 (15:26 +0100)]
Merge pull request #995 from puppetlabs/release-prep
Release prep v3.0.1
GitHub Action [Mon, 21 Jun 2021 11:50:51 +0000 (11:50 +0000)]
Release prep v3.0.1
Michael T Lombardi (He/Him) [Mon, 7 Jun 2021 15:21:19 +0000 (10:21 -0500)]
Merge pull request #994 from puppetlabs/pdksync_pdkupdate
pdksync - (maint) PDKSync - PDK Update
Daniel Carabas [Mon, 7 Jun 2021 10:07:18 +0000 (13:07 +0300)]
(maint) pdksync - PDK Update
Adrian Iurca [Mon, 17 May 2021 08:45:18 +0000 (11:45 +0300)]
Merge pull request #993 from Samgarr/patch-1
Fixed link to REFERENCE.md
Jan Pechek [Thu, 29 Apr 2021 15:35:07 +0000 (17:35 +0200)]
Fixed link to REFERENCE.md
daianamezdrea [Tue, 27 Apr 2021 11:40:54 +0000 (14:40 +0300)]
Merge pull request #992 from puppetlabs/pdksync_pdk_update
pdksync - (maint) Running pdk update
Paula Muir [Mon, 26 Apr 2021 20:07:53 +0000 (21:07 +0100)]
(maint) Running a pdk update to consume latest pdk-template changes
Paula Muir [Thu, 22 Apr 2021 16:43:41 +0000 (17:43 +0100)]
Merge pull request #989 from puppetlabs/nightly-failures
mount /lib/modules/5.4.0-azure to docker containers
adrianiurca [Thu, 22 Apr 2021 16:13:28 +0000 (19:13 +0300)]
mount /lib/modules/5.4.0-azure to docker containers
daianamezdrea [Wed, 21 Apr 2021 15:07:32 +0000 (18:07 +0300)]
Merge pull request #983 from puppetlabs/pdksync_releaseprepupdate
pdksync - PDK Update for auto release prep workflow
adrianiurca [Thu, 8 Apr 2021 12:53:59 +0000 (15:53 +0300)]
mount kernel for docker container
david22swan [Mon, 19 Apr 2021 09:24:26 +0000 (10:24 +0100)]
Merge pull request #986 from arjenz/patch-1
Update README.md
Arjen Zonneveld [Thu, 15 Apr 2021 12:21:42 +0000 (14:21 +0200)]
Update README.md
`state` does not allow inversion, nor in the puppet code in this project nor in iptables rules.
Adrian Iurca [Mon, 12 Apr 2021 11:18:05 +0000 (14:18 +0300)]
Merge pull request #985 from pmcmaw/manage_inventory_loc
(GH-380) - Litmus, move inventory location
Paula Muir [Thu, 8 Apr 2021 09:21:07 +0000 (10:21 +0100)]
(GH-380) - Litmus, move inventory location
Disha-maker [Thu, 8 Apr 2021 08:46:22 +0000 (09:46 +0100)]
Merge pull request #984 from puppetlabs/pdksync-locales_remove
pdksync - (maint) - Remove Locales Folder
David Swan [Wed, 7 Apr 2021 14:40:51 +0000 (15:40 +0100)]
(maint) - Removal of Locales Folder
Daniel Carabas [Fri, 2 Apr 2021 11:19:36 +0000 (14:19 +0300)]
PDK Update for release prep workflow
Adrian Iurca [Mon, 1 Mar 2021 15:41:06 +0000 (17:41 +0200)]
Merge pull request #973 from puppetlabs/release-prep
Release prep v3.0.0
GitHub Action [Mon, 1 Mar 2021 14:57:38 +0000 (14:57 +0000)]
Release prep v3.0.0
Paula Muir [Wed, 24 Feb 2021 21:33:19 +0000 (21:33 +0000)]
Merge pull request #977 from puppetlabs/pdksync_maint/main/deprecate_sles11
pdksync - (MAINT) Remove SLES 11 support
Ciaran McCrisken [Wed, 24 Feb 2021 17:04:19 +0000 (17:04 +0000)]
(MAINT) Remove SLES 11 support
Paula Muir [Wed, 24 Feb 2021 15:07:06 +0000 (15:07 +0000)]
Merge pull request #976 from puppetlabs/pdksync_maint/main/deprecate_rhel_5_family
pdksync - (MAINT) Remove RHEL 5 family support
Ciaran McCrisken [Wed, 24 Feb 2021 13:56:19 +0000 (13:56 +0000)]
(MAINT) Remove RHEL 5 OS family support
Michael T Lombardi (He/Him) [Tue, 23 Feb 2021 01:30:42 +0000 (19:30 -0600)]
Merge pull request #974 from puppetlabs/maint/main/update_dependency
(maint) Update major dependencies prior to release
Paula Muir [Mon, 22 Feb 2021 16:19:32 +0000 (16:19 +0000)]
(maint) Update major dependencies prior to release
David Schmitt [Thu, 18 Feb 2021 09:20:11 +0000 (09:20 +0000)]
Merge pull request #972 from puppetlabs/pdksync_remove_puppet5
pdksync - Remove Puppet 5 from testing and bump minimal version to 6.0.0
Daniel Carabas [Tue, 16 Feb 2021 17:19:03 +0000 (19:19 +0200)]
Add auto_release.yml to sync.yml
Daniel Carabas [Tue, 16 Feb 2021 13:36:49 +0000 (15:36 +0200)]
pdk update
Daniel Carabas [Tue, 16 Feb 2021 07:50:57 +0000 (09:50 +0200)]
Update .sync.yml
Daniel Carabas [Mon, 15 Feb 2021 15:36:25 +0000 (17:36 +0200)]
Bump minimal puppet version to 6.0.0 in metadata.json
Daniel Carabas [Mon, 15 Feb 2021 15:20:02 +0000 (17:20 +0200)]
Remove Puppet 5 testing
Disha-maker [Tue, 9 Feb 2021 18:43:03 +0000 (18:43 +0000)]
Merge pull request #970 from puppetlabs/release
Release merge back for v2.8.1 PR merged
sanfrancrisko [Tue, 9 Feb 2021 17:53:31 +0000 (17:53 +0000)]
Merge pull request #969 from Disha-maker/release
(IAC-1417) Release Prep version 2.8.1
Auto-release [Mon, 8 Feb 2021 17:13:30 +0000 (17:13 +0000)]
Release version 2.8.1
sanfrancrisko [Mon, 1 Feb 2021 09:46:10 +0000 (09:46 +0000)]
Merge pull request #968 from puppetlabs/pdksync_gha-updates
pdksync - Update gha templates
David Schmitt [Wed, 27 Jan 2021 09:33:31 +0000 (09:33 +0000)]
Remove obsolete rubocop annotations
David Schmitt [Tue, 26 Jan 2021 17:16:54 +0000 (17:16 +0000)]
(maint) Update github actions
sanfrancrisko [Mon, 11 Jan 2021 18:06:44 +0000 (18:06 +0000)]
Merge pull request #967 from adrianiurca/modules10907_avoid_remove_spaces
[MODULES-10907] Do not remove spaces from hex string with !
adrianiurca [Mon, 11 Jan 2021 17:17:48 +0000 (19:17 +0200)]
add acceptance test
adrianiurca [Mon, 11 Jan 2021 16:03:38 +0000 (18:03 +0200)]
avoid to remove spaces outside string hex
david22swan [Mon, 11 Jan 2021 09:25:43 +0000 (09:25 +0000)]
Merge pull request #964 from puppetlabs/pdksync
Update to puppet-module-gems 1.0, pdk-templates and new rubocop
TP Honey [Mon, 4 Jan 2021 14:04:23 +0000 (14:04 +0000)]
Merge pull request #966 from sheenaajay/oldworkflow
(maint) remove old workflow
David Schmitt [Mon, 4 Jan 2021 11:51:43 +0000 (11:51 +0000)]
Improve tests
David Schmitt [Mon, 4 Jan 2021 11:32:33 +0000 (11:32 +0000)]
Fix issues from the rubocop changes
David Schmitt [Wed, 16 Dec 2020 17:28:51 +0000 (17:28 +0000)]
Apply remaining rubocop fixes
David Schmitt [Wed, 16 Dec 2020 13:36:45 +0000 (13:36 +0000)]
Add all safe auto corrects
David Schmitt [Wed, 16 Dec 2020 13:36:32 +0000 (13:36 +0000)]
Add the FrozenStrings magic comment
David Schmitt [Wed, 16 Dec 2020 13:36:18 +0000 (13:36 +0000)]
Update to pdk-templates and puppet-module-gems 1.0.0
David Schmitt [Mon, 4 Jan 2021 11:59:09 +0000 (11:59 +0000)]
Merge pull request #963 from puppetlabs/release
Release merge-back 2.8.0
sheena [Mon, 4 Jan 2021 11:19:21 +0000 (11:19 +0000)]
(maint) remove old workflow
sanfrancrisko [Fri, 18 Dec 2020 13:54:19 +0000 (13:54 +0000)]
Merge pull request #965 from Disha-maker/IAC-1351/main/remove_rhel5_centos5
(IAC-1351) Remove CentOS 5 & RHEL 5 from provision.yaml file
Disha-maker [Fri, 18 Dec 2020 12:01:34 +0000 (12:01 +0000)]
(IAC-1351) Remove CentOS 5 & RHEL 5 from provision.yaml file
david22swan [Mon, 14 Dec 2020 11:50:17 +0000 (11:50 +0000)]
Merge pull request #962 from carabasdaniel/release280
Release-prep for version 2.8.0
Auto-release [Mon, 14 Dec 2020 09:43:27 +0000 (09:43 +0000)]
Release version 2.8.0
adrianiurca [Wed, 9 Dec 2020 09:28:13 +0000 (11:28 +0200)]
Merge branch 'pdksync_update_workflows' into main
adrianiurca [Wed, 2 Dec 2020 15:07:38 +0000 (17:07 +0200)]
pdksync: add GA workflows
sanfrancrisko [Mon, 7 Dec 2020 17:19:27 +0000 (17:19 +0000)]
Merge pull request #961 from puppetlabs/pdksync_remove_el6_tests
pdksync - Remove EL6 testing from Travis
Daniel Carabas [Mon, 7 Dec 2020 15:23:46 +0000 (17:23 +0200)]
Remove EL6 testing from Travis
david22swan [Mon, 7 Dec 2020 09:56:12 +0000 (09:56 +0000)]
Merge pull request #959 from puppetlabs/pdksync_bump_puppet7
pdksync - (feat) - Bump Puppet boundary
sanfrancrisko [Fri, 4 Dec 2020 14:14:33 +0000 (14:14 +0000)]
Merge pull request #941 from adrianiurca/add_acceptance_test
(IAC-966) - MODULES-10522: Add support for the --condition parameter
adrianiurca [Fri, 4 Dec 2020 13:36:24 +0000 (15:36 +0200)]
Merge branch 'add_acceptance_test' of github.com:adrianiurca/puppetlabs-firewall into add_acceptance_test
adrianiurca [Fri, 4 Dec 2020 13:34:38 +0000 (15:34 +0200)]
rename the filter to condition_parameter_test
Adrian Iurca [Fri, 4 Dec 2020 11:57:59 +0000 (13:57 +0200)]
Update lib/puppet/provider/firewall/iptables.rb
Co-authored-by: sanfrancrisko <55992494+sanfrancrisko@users.noreply.github.com>