Yalei Wang [Wed, 11 Nov 2015 15:50:20 +0000 (23:50 +0800)]
Add the missing arg of RetryRequest exception in _lock_subnetpool
RetryRequest exception defined in oslo.db need be called with a arg
which describes the inner exception. _lock_subnetpool method missed this
arg, and this patch adds it.
The lease duration isn't DHCP agent specific. DHCP is a feature that
should be provided by whatever plugin is loaded and operators would
still like to set lease times for DHCP.
In the reference implementation we just consume it directly in the
agent, but that doesn't mean it's specific to the agent implementation.
Bogdan Tabor [Wed, 7 Oct 2015 13:49:08 +0000 (15:49 +0200)]
Switch to using neutron.common.utils:replace_file()
neutron.agent.linux.utils:replace_file() and
neutron.common.utils:replace_file() have same functionality.
This is the 1st patch in the series of 4 patches.
It modifies neutron.common.utils:replace_file(),
so it can be used by all components as a replacement
for neutron.agent.linux.utils:replace_file().
New keyword parameter 'file_mode=0o644' is added
to neutron.common.utils:replace_file().
Ann Kamyshnikova [Wed, 21 Oct 2015 14:37:34 +0000 (17:37 +0300)]
Skip bindings with agent_id=None
To avoid having extra L3HARouterAgentPortBinding with l3_agent as None,
operation of setting l3_agent should be atomic.
For this purpose, transaction was added in methods
create_ha_port_and_bind and _bind_ha_router_to_agents in change
Iaad82fe522cfd70061daecf411c924fdc11b7e41
In case if router was just created and l3 agent was not scheduled yet,
so l3_agent_id is None, l3-agent-list-hosting-router <router> will fail.
This change makes it work by skipping binding with agent_id=None.
Oleg Bondarev [Wed, 28 Oct 2015 06:08:26 +0000 (15:08 +0900)]
Use admin context when requesting floating ip's router info
Currently it is possible for admin to create router and add any
tenant subnet to it, thus connecting the subnet to the external
network. In this case tenant user can assign floating ips to its
VMs though it does not own the router.
For proper notification we need to get router info using admin
context.
Eugene Nikanorov [Sun, 25 Oct 2015 11:47:38 +0000 (15:47 +0400)]
Cleanup dhcp namespace upon dhcp setup.
In some cases when more than 1 DHCP agents were assigned
to a network and then they became dead, their DHCP ports
become reserved. Later, when those agents revive or start
again, they acquire reserved ports, but it's not guaranteed
that they get exactly same ports. In such case DHCP agent
may create interface in the namespaces despite that another
interface already exist. In such case there will be two
hosts with dhcp namespaces each containing duplicate ports,
e.g. one port will be present on two hosts. This breaks
DHCP.
Elena Ezhova [Fri, 13 Nov 2015 11:26:45 +0000 (14:26 +0300)]
Refactor test_server functional tests
* Launching services with 0 workers makes no sense and would soon
be prohibited in oslo.service. Passing workers=1 means that a
service will be run in a current process.
* Extract the dummy _check_active method to the base class.
Ihar Hrachyshka [Fri, 13 Nov 2015 11:26:55 +0000 (12:26 +0100)]
Undeprecate force_gateway_on_subnet option
There are valid use cases for gateways outside of subnet range. F.e.
deployers may decide to provide external connectivity in that way, by
injecting link routes.
Ann Kamyshnikova [Fri, 25 Sep 2015 12:30:30 +0000 (15:30 +0300)]
Add transaction for setting agent_id in L3HARouterAgentPortBinding
To avoid having extra L3HARouterAgentPortBinding with l3_agent as
None, operation of setting l3_agent should be atomic.
For this purpose, transaction was added in methods
create_ha_port_and_bind and _bind_ha_router_to_agents.
Dongcan Ye [Thu, 29 Oct 2015 12:50:43 +0000 (20:50 +0800)]
Check missed IPSet utility using neutron-sanity-check
In some case, host may lack ipset utility (e.g., due to a
dependency issue)
This patch allows checking IPSet utility support from CLI:
neutron-sanity-check --ipset_installed
Or using configuration options, for example:
neutron-sanity-check --config-file /etc/neutron/neutron.conf
--config-file /etc/neutron/plugins/ml2/ml2_conf.ini
The revert was merged too quickly, without waiting for tox project to fix us.
The gate passed for the revert only because infra folks removed images
that had new tox in them. We will be broken by the next images though.
Clarify that RFE bug reports should not have an importance set
Filling the Importance field [1] with anything other than Wishlist for RFE bug reports
is wrong. People confuse priority with Severity (which is what the importance field is
about), and that can cause us some grief.
Therefore let's state clearly that from now on, RFE bug reports will be marked 'Wishlist'
only.
rossella [Wed, 11 Nov 2015 19:08:36 +0000 (19:08 +0000)]
Remove TEMPEST_CONFIG_DIR in the api tox env
Setting TEMPEST_CONFIG_DIR in tox.ini is breaking the gate,
probably because of a tox bug [1].
Removing the line to unblock the gate. This implies that
for local execution of the tests TEMPEST_CONFIG_DIR
should be set manually.
Ryan Moats [Wed, 11 Nov 2015 18:51:21 +0000 (12:51 -0600)]
Lower l2pop "isn't bound to any segement" log to debug
Per the discussion in bug 1362242, the log statement doesn't
appear to be associated with anything bad happening. Therefore,
this patch lowers the log level from WARNING to DEBUG to avoid
polluting operator's logs.
Change-Id: I55b6d1d30ed2ed55659c9a6809531cfcbc57f17c Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
Closes-Bug: 1362242
Jian Wen [Wed, 11 Nov 2015 03:32:20 +0000 (11:32 +0800)]
More graceful ovs-agent restart
When the neutron server is down/busy the agent is not able to get any
port info. After the agent restarts, it will not install any new flow.
Cleaning the existing flows will break all networking until the agent
succeeds to sync with the neturon server.
This patch ensures the agent cleans the stale flows only after it
succeeds to sync with the neturon server.
Cedric Brandily [Thu, 5 Nov 2015 23:49:21 +0000 (00:49 +0100)]
Replace get_all_neutron_bridges by get_deletable_bridges
Currently LinuxBridge L2-agent[1] defines get_all_neutron_bridges which
lists all bridges managed by the agent including user-defined ones BUT
this method is only used by neutron-linuxbridge-cleanup[2] in order to
remove empty non-user-defined bridges returned get_all_neutron_bridges.
This change replaces this method by get_deletable_bridges which returns
bridges managed by LB agent which are "deletable" (ie: non user-defined).
This allows to simplify code and move the computation of "deletable"
bridges to LB agent code.
Pavel Bondar [Wed, 28 Oct 2015 09:22:52 +0000 (12:22 +0300)]
Add call to pluggable IPAM from ml2 delete_subnet
ml2 plugin overrides delete_subnet and do not call super(),
so pluggable IPAM action defined in db_base_plugin_v2 are not called.
As a result subnets can not be deleted from IPAM driver if ml2 plugin
is used.
Added ipam.delete_subnet call into ml2 delete_subnet.
Patch includes UT to verify IPAM driver is called on subnet
allocation and deallocation.
Test class is inherited from TestMl2SubnetsV2, so all SubnetV2 tests are
additionally executed for ml2 plugin with reference IPAM driver.
Kyle Mestery [Tue, 10 Nov 2015 00:46:27 +0000 (00:46 +0000)]
Add "unreleased" release notes page
We need a release notes page to show notes for unreleased versions by
scanning the "current" branch. This ensures that notes files cannot be
merged if they break the releasenotes job.
Update internal snat port prefix for multiple IPv6 subnets
In neutron when multiple IPv6 subnets on the same
network are added to a router interface, the router
interface port is updated with multiple fixed_ips rather
than creating a new port. In the case of IPv4 subnets
a new port is created for every added interface.
For dvr routers there are internal snat ports that are
created for every router interface that is added to a
router. So when multiple IPv6 subnets on the same network
was added to a dvr router, the internal snat ports were not
appended with the IPv6 prefix properly.
An error log message was thrown for the SNAT port not
matching the given internal port for the IPv6 address.
This patch will address this issue when IPv6 subnets are
added or removed from the dvr router that are on the
same network.
Cedric Brandily [Sat, 7 Nov 2015 21:36:59 +0000 (22:36 +0100)]
Reduce duplicated code in test_linuxbridge_neutron_agent
This change defines and uses get_linuxbridge_manager method which
mocks some methods in order to instantiate and returns a
LinuxBridgeManager instance, this method allows to remove some
duplicated code from test_linuxbridge_neutron_agent.
Russell Bryant [Mon, 9 Nov 2015 14:31:36 +0000 (09:31 -0500)]
Document the neutron-release team.
Gerrit includes a neutron-release team. Document what this team means
today. Also propose that this team have merge rights to *all* Neutron
git repos so that a small group has the ability to quickly unblock
things if needed, which is especially important around release time.
Change-Id: Id3d4d051278930841f64a4153e40a2dd3d893e44 Signed-off-by: Russell Bryant <rbryant@redhat.com>
Code Review / openstack-build / neutron-build.git / log