]>
review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/log
Ashley Penney [Thu, 17 Apr 2014 17:00:50 +0000 (13:00 -0400)]
Merge pull request #285 from blkperl/fix_metadata
Fix metadata.json file
Ashley Penney [Mon, 3 Mar 2014 21:39:10 +0000 (21:39 +0000)]
Add back in missing fields to work around Puppet bug.
(cherry picked from commit
dc472717163d30a4463f687a577238ec2539601c )
Ashley Penney [Fri, 28 Feb 2014 15:34:08 +0000 (15:34 +0000)]
Prepare metadata for supported module release.
(cherry picked from commit
ab03a989df37df3660f0916519d0f78f7ab73a13 )
Ashley Penney [Sat, 12 Apr 2014 18:37:40 +0000 (14:37 -0400)]
Merge pull request #283 from johanfleury/master
Change proxy's configuration file to be consistent with other config files in apt.conf.d
Johan Fleury [Fri, 11 Apr 2014 06:35:25 +0000 (08:35 +0200)]
Writing proxy configuration in apt.conf.d/01proxy.
This commit changes the proxy file name to be more consistent with other files
in `apt.conf.d`. The old file (`apt.conf.d/proxy`) is removed.
Tests has been updated.
Ashley Penney [Mon, 7 Apr 2014 18:06:47 +0000 (14:06 -0400)]
Merge pull request #282 from laurenrother/security
Add security warning re: short keys
Lauren Rother [Mon, 7 Apr 2014 17:56:20 +0000 (10:56 -0700)]
Add security warning re: short keys
Ashley Penney [Thu, 3 Apr 2014 17:59:51 +0000 (13:59 -0400)]
Merge pull request #280 from daenney/fix-pin-comments
Fix pin comments
Ashley Penney [Thu, 3 Apr 2014 17:59:15 +0000 (13:59 -0400)]
Merge pull request #281 from daenney/unattended-upgrades-squeeze-origins
unattended-upgrades: Fix origins for Squeeze.
Daniele Sluijters [Wed, 2 Apr 2014 09:17:04 +0000 (11:17 +0200)]
unattended-upgrades: Fix origins for Squeeze.
Because Squeeze is now oldstable we need to add an oldstable line too
otherwise security updates won't be picked up. This is still because we
can't match on codename.
Daniele Sluijters [Fri, 28 Mar 2014 07:49:18 +0000 (08:49 +0100)]
pin: caller_module_name is not a topscope variable
Daniele Sluijters [Fri, 28 Mar 2014 07:47:19 +0000 (08:47 +0100)]
pin: Fix the template.
In APT preferences files the only allowed comments are lines that start
with `Explanation:`, commented lines that start with a # trigger a
myriad of interesting bugs. This is considered a feature of APT.
Because we're only ever writing a single file at a time with only a #
comment at the top we were getting away with this but it shouldn't be
there in the first place.
Ashley Penney [Thu, 27 Mar 2014 16:43:27 +0000 (12:43 -0400)]
Merge pull request #279 from apenney/fix-spacing
Small patch to fix the spacing that makes lint fail.
Ashley Penney [Thu, 27 Mar 2014 16:40:36 +0000 (16:40 +0000)]
Small patch to fix the spacing that makes lint fail.
Ashley Penney [Thu, 27 Mar 2014 12:59:51 +0000 (08:59 -0400)]
Merge pull request #278 from daenney/fix-unattended-upgrades
unattended_upgrades: Fix matching security archive
Daniele Sluijters [Thu, 27 Mar 2014 12:51:08 +0000 (13:51 +0100)]
unattended_upgrades: Fix matching security archive
The default configuration we were writing for Debian was only working
for Squeeze, from Wheezy and onwards this wasn't working anymore. This
has to do with the fact that we should now be using Origins-Pattern
according to the unattended-upgrades docs. However, Ubuntu didn't
entirely get with the program yet...
This change reflects the defaults that unattended-upgrade installs on
every platform we support. In order to do so the unattended-upgrades
Debian archive for Squeeze, Wheezy, Lucid, Precise and Trusty were
downloaded and the default /etc/apt/apt.conf.d/50unattended-upgrades
checked for its content with regard to using Allow-Origins or
Origins-Pattern.
Fixes #277
Hunter Haugen [Wed, 26 Mar 2014 21:53:26 +0000 (14:53 -0700)]
Merge pull request #275 from daenney/backports-pin-priority
backports: Allow setting a custom priority.
Daniele Sluijters [Wed, 26 Mar 2014 16:13:08 +0000 (17:13 +0100)]
backports: Allow setting a custom priority.
The module used to always pin backports to a priority of 200. This
default is still retained but is now configurable.
Additionally the default is now an Integer, not a 'quoted Integer' and
the tests have been updated to reflect this. This matters for future
parser as it will now kick people if they pass in a stringified integer
as priority.
Hunter Haugen [Wed, 26 Mar 2014 18:08:14 +0000 (11:08 -0700)]
Merge pull request #276 from blkperl/fix_rake
Pin Rake to 10.1.1 in Gemfile
William Van Hevelingen [Wed, 26 Mar 2014 17:51:29 +0000 (10:51 -0700)]
Pin Rake to 10.1.1 in Gemfile
The latest Rake update requires Ruby >= 1.9. This update
fixes the failing 1.8.7 tests by pinning Rake to the last
supported version on ruby 1.8.7.
Hunter Haugen [Wed, 26 Mar 2014 16:56:49 +0000 (09:56 -0700)]
Merge pull request #274 from fdrouet/fix_typo
Fix typo in ppa.pp
Frédéric DROUET [Thu, 20 Mar 2014 22:09:07 +0000 (23:09 +0100)]
Fix typo in ppa.pp
Hunter Haugen [Mon, 17 Mar 2014 17:03:22 +0000 (10:03 -0700)]
Merge pull request #268 from daenney/apt_key-ftp-weirdness
Use File.expand_path with require.
Daniele Sluijters [Sun, 16 Mar 2014 11:44:05 +0000 (12:44 +0100)]
Use File.expand_path with require.
For some reason, even though our own tests pass with `require
puppet_x/apt_key/patch_openuri` every other module that depends on
puppetlabs-apt is now breaking in tests claiming it can't load that
module.
Somewhere along the way something is probably messing with LOADPATH
causing this to trip up. This should fix the issues for everyone.
This commit affects:
* puppetlabs/puppetlabs-apt#229
* puppetlabs/puppetlabs-postgresql#391
Hunter Haugen [Fri, 7 Mar 2014 18:00:58 +0000 (10:00 -0800)]
Merge pull request #248 from electrical/fix_params_fail
Fix fail message
Ashley Penney [Fri, 7 Mar 2014 17:35:55 +0000 (12:35 -0500)]
Merge pull request #263 from daenney/remove-puppet-27
Remove testing for Puppet 2.7 compatibility.
Daniele Sluijters [Fri, 7 Mar 2014 17:32:37 +0000 (18:32 +0100)]
Remove testing for Puppet 2.7 compatibility.
With official supported modules now being a thing and having a version
of the APT module to which we will backport fixes until the next major
release it is time to say goodbye to Puppet 2.7.
So long and thanks for all the fish.
Ashley Penney [Fri, 7 Mar 2014 17:24:20 +0000 (12:24 -0500)]
Merge pull request #262 from daenney/shrink-test-matrix
Remove ancient Puppet versions from matrix.
Daniele Sluijters [Fri, 7 Mar 2014 15:10:54 +0000 (16:10 +0100)]
Remove ancient Puppet versions from matrix.
With PE 3.2 out of the door shipping with 3.4.3 I think it's time to
shrink the matrix and get rid of 3.1 and 3.2. PE 3.x customers should
just upgrade to 3.2, OS users should really be on 3.3+ by now.
Richard Pijnenburg [Fri, 7 Mar 2014 15:03:44 +0000 (16:03 +0100)]
Fail early when its not debian or ubuntu ( or debian like distro )
Hunter Haugen [Thu, 6 Mar 2014 17:52:44 +0000 (09:52 -0800)]
Merge pull request #193 from ianunruh/feature/retry-update
Added retry to update operation
Ian Unruh [Wed, 5 Mar 2014 22:01:37 +0000 (16:01 -0600)]
Updated documentation
Ian Unruh [Wed, 5 Mar 2014 21:59:21 +0000 (15:59 -0600)]
Added retry to update operation
Hunter Haugen [Wed, 5 Mar 2014 19:15:26 +0000 (11:15 -0800)]
Merge pull request #209 from pabl0/proxy
Make apt.conf.d/proxy world readable and add a newline
Hunter Haugen [Wed, 5 Mar 2014 19:06:43 +0000 (11:06 -0800)]
Merge pull request #249 from ghoneycutt/define_apt_source_in_hiera
Add ability to specify hash of apt sources in hiera
Ashley Penney [Wed, 5 Mar 2014 18:17:12 +0000 (13:17 -0500)]
Merge pull request #258 from sodabrew/patch-1
Add Ubuntu Trusty
Ashley Penney [Wed, 5 Mar 2014 18:16:38 +0000 (13:16 -0500)]
Merge pull request #259 from daenney/apt-hold
apt::hold: Add a mechanism to hold a package.
Ashley Penney [Wed, 5 Mar 2014 18:16:24 +0000 (13:16 -0500)]
Merge pull request #260 from daenney/zomg-ze-chars
pin: Replace invalid chars with _ in file names.
Daniele Sluijters [Wed, 5 Mar 2014 15:12:04 +0000 (16:12 +0100)]
pin: Replace invalid chars with _ in file names.
This needs to be merged for #259 to work.
Ashley Penney [Wed, 5 Mar 2014 17:54:02 +0000 (12:54 -0500)]
Merge pull request #230 from daenney/apt-key-defined
Rework apt::key to use apt_key.
Ashley Penney [Wed, 5 Mar 2014 17:17:55 +0000 (12:17 -0500)]
Merge pull request #261 from hunner/remove_autorelease
Remove autorelease
Hunter Haugen [Wed, 5 Mar 2014 17:14:39 +0000 (09:14 -0800)]
Remove autorelease
Daniele Sluijters [Wed, 5 Mar 2014 14:02:06 +0000 (15:02 +0100)]
Update the README about apt_key and apt::key.
Daniele Sluijters [Wed, 5 Mar 2014 09:13:42 +0000 (10:13 +0100)]
apt::hold: Add a mechanism to hold a package.
I am aware this can be done with `dpkg --set-selections`, `apt-mark`
or `ensure => 'held'` on a package resource. The changes to the README
include the full rationale for wanting another mechanism.
Aaron Stone [Tue, 4 Mar 2014 20:51:32 +0000 (12:51 -0800)]
Oneiric is available on the old-releases mirror
Aaron Stone [Tue, 4 Mar 2014 20:50:37 +0000 (12:50 -0800)]
Remove hardy, maverick, natty
They are not on the mirrors anymore.
Aaron Stone [Tue, 4 Mar 2014 20:46:27 +0000 (12:46 -0800)]
Add Ubuntu Trusty
It's in Beta now and has landed on the main mirrors.
Daniele Sluijters [Thu, 20 Feb 2014 15:18:37 +0000 (16:18 +0100)]
apt::key: Redo apt::key, make it use apt_key.
Introducing a totally rewritten and tested apt::key. This commit also
patches the spec's of apt::source because it was passing in data that
is no longer allowed by the new validation rules in apt::key.
It does its best to not touch any other specs and where we touch them
only minimally to ensure that we're not introducing breaking changes.
Richard Pijnenburg [Thu, 27 Feb 2014 09:23:11 +0000 (10:23 +0100)]
Add spec test to test for failure
Hunter Haugen [Wed, 26 Feb 2014 22:13:57 +0000 (14:13 -0800)]
Merge branch '1.4.x'
Daniel Tremblay [Wed, 4 Dec 2013 18:05:26 +0000 (18:05 +0000)]
Add ability to specify hash of apt sources in hiera
This patch uses create_resources() to call apt::source which lets you
specify your sources in hiera.
Richard Pijnenburg [Wed, 26 Feb 2014 10:52:54 +0000 (11:52 +0100)]
Fix fail message
the fail message was including a fact that was not used in the whole case statement and caused some confusion.
Hunter Haugen [Tue, 25 Feb 2014 19:34:43 +0000 (11:34 -0800)]
Merge branch 'fix_pin_quotes' into 1.4.x
Hunter Haugen [Tue, 25 Feb 2014 19:34:12 +0000 (11:34 -0800)]
Pin quotes were removed for a Lucid bugfix
Hunter Haugen [Tue, 25 Feb 2014 19:12:40 +0000 (11:12 -0800)]
Merge branch 'missed_one' into 1.4.x
Martin Konrad [Tue, 18 Feb 2014 18:37:05 +0000 (13:37 -0500)]
Update Debian signing key for backports.
(cherry picked from commit
d5efdf0016a535068660c3dd52a1554d8880e3bc )
Hunter Haugen [Tue, 25 Feb 2014 17:58:36 +0000 (09:58 -0800)]
Merge pull request #246 from hunner/buncha_picks
Buncha picks
Henrik Ahlgren [Fri, 10 Jan 2014 15:09:18 +0000 (17:09 +0200)]
Make apt.conf.d/proxy world readable and add a newline
Daniele Sluijters [Fri, 21 Feb 2014 17:39:52 +0000 (18:39 +0100)]
README: Fix white space / mixed indents.
(cherry picked from commit
47c8def0f7acde99ddb0b1820a7a2e5a7566418d )
Daniele Sluijters [Fri, 21 Feb 2014 17:39:39 +0000 (18:39 +0100)]
README/LICENSE: Fix licensing.
Closes #152
(cherry picked from commit
08c1283437e2a7072e788f489f1de73dbc9a6c5d )
Martin Konrad [Tue, 18 Feb 2014 21:57:01 +0000 (16:57 -0500)]
Update out-of-date Debian signing key in remaining files.
(cherry picked from commit
3aa293a53fb7a2bd789ce3db35950778968079fd )
Konrad Lother [Wed, 29 Jan 2014 23:33:45 +0000 (00:33 +0100)]
changed proxy_host default value from false to undef. fixes #211
(cherry picked from commit
0207fcd19a91b4cbdb356c230ded64799a8615cd )
Daniel Lawrence [Wed, 19 Feb 2014 00:41:01 +0000 (11:41 +1100)]
Force owner and mode on ppa files
(cherry picked from commit
0bf44fc167405a6a0e6faae35f3fa4caa9ce8658 )
Matt Callaway [Tue, 18 Feb 2014 14:08:19 +0000 (08:08 -0600)]
Update pin_spec test to match quote removal.
(cherry picked from commit
d28dc494aae1f0cd2117183a54684f5095ab50cf )
Matt Callaway [Fri, 31 Jan 2014 21:56:28 +0000 (15:56 -0600)]
Remove the quotes from the origin line. This doesn't matter on Ubuntu Precise with apt 0.8, but for those of us still using Ubuntu Lucid, apt 0.7 silently ignores preferences with the quotes.
(cherry picked from commit
3922a1bdf505947bd2425378035f0edaffc385e6 )
Hunter Haugen [Tue, 25 Feb 2014 17:34:00 +0000 (09:34 -0800)]
Merge pull request #226 from mark0n/master
Update out of date Debian signing key for backports
Hunter Haugen [Tue, 25 Feb 2014 17:32:12 +0000 (09:32 -0800)]
Merge pull request #215 from lotherk/proxy_val_no_boolean
changed proxy_host default value from true to undef. fixes #211
Hunter Haugen [Tue, 25 Feb 2014 17:30:37 +0000 (09:30 -0800)]
Merge pull request #227 from daniellawrence/file_perms_apt_ppa
Force owner and mode on ppa files
Hunter Haugen [Tue, 25 Feb 2014 17:29:15 +0000 (09:29 -0800)]
Merge pull request #216 from genome-vendor/master
Remove the quotes from the "origin" line.
Hunter Haugen [Tue, 25 Feb 2014 17:27:51 +0000 (09:27 -0800)]
Merge pull request #229 from daenney/apt-key-ftp
apt_key: Support fetching keys over FTP.
Hunter Haugen [Tue, 25 Feb 2014 17:27:20 +0000 (09:27 -0800)]
Merge pull request #235 from daenney/readme-license-fixes
README and licensing fixes.
Hunter Haugen [Tue, 25 Feb 2014 17:25:49 +0000 (09:25 -0800)]
Merge pull request #240 from daenney/manage-preferences
apt: Allow managing of preferences file.
Ashley Penney [Mon, 24 Feb 2014 22:31:16 +0000 (22:31 +0000)]
Add lsbdistid facts where appropriate.
(cherry picked from commit
4d188443bc4f7b10581fedf2180573308bb2bf7b )
Hunter Haugen [Tue, 25 Feb 2014 00:14:59 +0000 (16:14 -0800)]
Merge pull request #244 from apenney/fix-tests
Add lsbdistid facts where appropriate.
Ashley Penney [Mon, 24 Feb 2014 22:31:16 +0000 (22:31 +0000)]
Add lsbdistid facts where appropriate.
Hunter Haugen [Mon, 24 Feb 2014 21:56:21 +0000 (13:56 -0800)]
Merge pull request #242 from hunner/add_unsup
Add non Debian os family unsupported test.
Ashley Penney [Mon, 24 Feb 2014 21:53:41 +0000 (16:53 -0500)]
Merge pull request #241 from hunner/add_unsup
Add non Debian os family unsupported test.
Hunter Haugen [Mon, 24 Feb 2014 21:52:13 +0000 (13:52 -0800)]
Add non Debian os family unsupported test.
Hunter Haugen [Mon, 24 Feb 2014 21:36:48 +0000 (13:36 -0800)]
Merge branch '1.4.x'
Daniele Sluijters [Sat, 22 Feb 2014 09:56:50 +0000 (10:56 +0100)]
apt: Allow managing of preferences file.
We already had a feature to manage and purge entries in preferences.d
but not the preferences file in /etc/apt. This commit adds that
capability.
Fixes #199
Hunter Haugen [Fri, 21 Feb 2014 19:55:59 +0000 (11:55 -0800)]
Merge pull request #239 from hunner/fix_builddep
Use smaller build-dep package
Hunter Haugen [Fri, 21 Feb 2014 19:55:16 +0000 (11:55 -0800)]
Use smaller build-dep package
Ashley Penney [Fri, 21 Feb 2014 19:47:52 +0000 (14:47 -0500)]
Merge pull request #238 from hunner/clean_conditional
Using rspec filters works better
Hunter Haugen [Fri, 21 Feb 2014 19:45:21 +0000 (11:45 -0800)]
Using rspec filters works better
And this will make merging back to master cleaner
Hunter Haugen [Fri, 21 Feb 2014 19:32:10 +0000 (11:32 -0800)]
Merge pull request #237 from hunner/change_port
Port 8080 is a bad choice and bumps into puppetdb
Daniele Sluijters [Fri, 21 Feb 2014 17:39:52 +0000 (18:39 +0100)]
README: Fix white space / mixed indents.
Daniele Sluijters [Fri, 21 Feb 2014 17:39:39 +0000 (18:39 +0100)]
README/LICENSE: Fix licensing.
Closes #152
Hunter Haugen [Fri, 21 Feb 2014 17:36:25 +0000 (09:36 -0800)]
Merge pull request #234 from hunner/fix_dash_tests
Missed the - for -y, but also tests were missing lsbdistid
Hunter Haugen [Fri, 21 Feb 2014 17:34:46 +0000 (09:34 -0800)]
Missed the - for -y, but also tests were missing lsbdistid
Daniele Sluijters [Thu, 20 Feb 2014 09:34:22 +0000 (10:34 +0100)]
apt_key: Support fetching keys over FTP.
Hunter Haugen [Fri, 21 Feb 2014 07:14:14 +0000 (23:14 -0800)]
Merge pull request #231 from hunner/fix_ppa_options
Don't pass options to ppa on lucid
Hunter Haugen [Fri, 21 Feb 2014 00:43:48 +0000 (16:43 -0800)]
Don't pass options to ppa on lucid
Lucid (10.04) has `add-apt-repository` but it doesn't accept any
options. The define defaulted to `-y` but this changes that on lucid.
This was made 7 months ago, so apparently no one cares about 10.04 any
more.
Ashley Penney [Wed, 19 Feb 2014 19:52:05 +0000 (19:52 +0000)]
Make sure we handle PE properly.
Ashley Penney [Wed, 19 Feb 2014 19:54:00 +0000 (14:54 -0500)]
Merge pull request #228 from apenney/add-pe
Make sure we handle PE properly.
Ashley Penney [Wed, 19 Feb 2014 19:52:05 +0000 (19:52 +0000)]
Make sure we handle PE properly.
Ashley Penney [Wed, 19 Feb 2014 15:03:57 +0000 (10:03 -0500)]
Merge pull request #212 from daenney/apt-key
apt_key type/provider
Daniel Lawrence [Wed, 19 Feb 2014 00:41:01 +0000 (11:41 +1100)]
Force owner and mode on ppa files
Martin Konrad [Tue, 18 Feb 2014 21:57:01 +0000 (16:57 -0500)]
Update out-of-date Debian signing key in remaining files.
Daniele Sluijters [Sun, 16 Feb 2014 16:14:47 +0000 (17:14 +0100)]
Travis: Remove 3.0, add newer 3.x releases.
3.0 is just broken in tests, something is wrong with the module loading
rendering tests completely useless.
Start testing on Puppet 3.3 and 3.4.
Daniele Sluijters [Fri, 17 Jan 2014 08:11:56 +0000 (09:11 +0100)]
Add a type and provider to manage apt keys.
This commits introduces:
* The apt_key type;
* The apt_key provider;
* Unit tests for the type;
* Beaker/acceptance tests for the type/provider.
The idea behind apt_key is that apt::key will simply become a wrapper
that uses apt_key. Being a native type/provider apt_key is a lot less
error prone than the current exec behaviour of apt::key and adds a few
nice bonuses like inventory capabilities for mcollective users.