review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/log

David Swan [Thu, 10 Jan 2019 15:24:24 +0000 (15:24 +0000)]

Eimhin Laverty [Thu, 3 Jan 2019 17:04:29 +0000 (17:04 +0000)]

Merge pull request #836 from antaflos/fix_auth_conf_owner

(MODULES-8418) Fix /etc/apt/auth.conf owner changing endlessly

commit | commitdiff | tree

Andreas Voegele [Mon, 3 Dec 2018 18:49:47 +0000 (19:49 +0100)]

(MODULES-8418) Add parameter $auth_conf_owner

Starting from Debian 9 and Ubuntu 16.04 the user _apt owns the file
/etc/apt/auth.conf. In previous versions it is owned by root.

Set ownership of /etc/apt/auth.conf correctly based on OS version and
add spec tests to cover managing the file's owner under Ubuntu 14.04,
16.04 and 18.04 as well as Debian 7.0, 8.0 and 9.0.

commit | commitdiff | tree

Eimhin Laverty [Thu, 3 Jan 2019 15:57:20 +0000 (15:57 +0000)]

Merge pull request #837 from puppetlabs/pdksync_pdksync_heads/master-0-g9c815ea

pdksync - pdksync_heads/master-0-g9c815ea

commit | commitdiff | tree

David Swan [Thu, 3 Jan 2019 14:32:14 +0000 (14:32 +0000)]

pdksync_heads/master-0-g9c815ea

commit | commitdiff | tree

Eimhin Laverty [Thu, 20 Dec 2018 10:47:59 +0000 (10:47 +0000)]

Merge pull request #835 from puppetlabs/pdksync_FM-7655

pdksync - (FM-7655) Fix rubygems-update for ruby < 2.3

commit | commitdiff | tree

tphoney [Thu, 20 Dec 2018 10:09:31 +0000 (10:09 +0000)]

(FM-7655) Fix rubygems-update for ruby < 2.3

commit | commitdiff | tree

david22swan [Wed, 19 Dec 2018 14:15:13 +0000 (14:15 +0000)]

Merge pull request #833 from puppetlabs/anchor-tags

(maint) Add HTML anchor tag

commit | commitdiff | tree

Eimhin Laverty [Mon, 17 Dec 2018 12:32:01 +0000 (12:32 +0000)]

Merge pull request #834 from puppetlabs/pdksync_pdksync_heads/master-0-gbf720df

pdksync - pdksync_heads/master-0-gbf720df

commit | commitdiff | tree

Eimhin Laverty [Mon, 17 Dec 2018 11:29:26 +0000 (11:29 +0000)]

pdksync_heads/master-0-gbf720df

commit | commitdiff | tree

clairecadman [Fri, 14 Dec 2018 15:46:36 +0000 (15:46 +0000)]

commit | commitdiff | tree

clairecadman [Fri, 14 Dec 2018 15:45:41 +0000 (15:45 +0000)]

(maint) Add HTML anchor tag

The anchor tag helps fix broken links — If the header text changes (gets localized) the link will brake.

commit | commitdiff | tree

Paula Muir [Thu, 13 Dec 2018 17:40:42 +0000 (17:40 +0000)]

Merge pull request #832 from aboks/apt-task

Add support for dist-upgrade & autoremove action

commit | commitdiff | tree

Arnout Boks [Thu, 13 Dec 2018 11:34:24 +0000 (12:34 +0100)]

Add tests for new apt actions

commit | commitdiff | tree

Arnout Boks [Tue, 11 Dec 2018 19:59:55 +0000 (20:59 +0100)]

Add support for dist-upgrade & autoremove action

commit | commitdiff | tree

Ewoud Kohl van Wijngaarden [Fri, 7 Dec 2018 13:10:40 +0000 (14:10 +0100)]

(maint) Remove duplicated fact declarations (#828)

* (maint) Remove duplicated fact declarations
* (maint) Correct lsbdist facts in tests
* (maint) Remove the puppetversion fact in testing
* (maint) - Remove blank line

commit | commitdiff | tree

TP Honey [Fri, 7 Dec 2018 10:04:13 +0000 (10:04 +0000)]

Merge pull request #831 from eimlav/modules-8321

(MODULES-8321) - Add manage_auth_conf parameter

commit | commitdiff | tree

TP Honey [Fri, 7 Dec 2018 10:03:22 +0000 (10:03 +0000)]

Merge pull request #830 from eimlav/modules-8326

(MODULES-8326) - apt-transport-https not ensured properly

commit | commitdiff | tree

Eimhin Laverty [Thu, 6 Dec 2018 16:31:40 +0000 (16:31 +0000)]

(MODULES-8321) - Add manage_auth_conf parameter

commit | commitdiff | tree

Eimhin Laverty [Thu, 6 Dec 2018 13:41:08 +0000 (13:41 +0000)]

(MODULES-8326) - apt-transport-https not ensured properly

commit | commitdiff | tree

Eimhin Laverty [Thu, 22 Nov 2018 09:14:21 +0000 (09:14 +0000)]

Merge pull request #827 from puppetlabs/release

(maint) - 6.2.1 Release mergeback

commit | commitdiff | tree

Paula Muir [Tue, 20 Nov 2018 13:45:12 +0000 (13:45 +0000)]

Merge pull request #826 from eimlav/release-prep

(MODULES-8275) - Release prep for 6.2.1

commit | commitdiff | tree

Eimhin Laverty [Tue, 20 Nov 2018 12:56:51 +0000 (12:56 +0000)]

(MODULES-8275) - Release prep for 6.2.1

commit | commitdiff | tree

Paula Muir [Tue, 20 Nov 2018 12:44:16 +0000 (12:44 +0000)]

Merge pull request #825 from eimlav/dirmngr-fix

(MODULES-8272) - Revert "Autorequire dirmngr in apt_key types"

commit | commitdiff | tree

Eimhin Laverty [Tue, 20 Nov 2018 09:09:49 +0000 (09:09 +0000)]

(MODULES-8272) - Revert "Autorequire dirmngr in apt_key types"

This reverts commit 53ea6e7a789ebec00d463ba78abf09bfe031efd9.

commit | commitdiff | tree

Eimhin Laverty [Mon, 19 Nov 2018 17:22:43 +0000 (17:22 +0000)]

Merge pull request #824 from puppetlabs/release

(maint) - 6.2.0 Release Mergeback

commit | commitdiff | tree

Eimhin Laverty [Mon, 19 Nov 2018 10:13:40 +0000 (10:13 +0000)]

Merge pull request #823 from david22swan/PreRelease

(MODULES-8226) - 6.2.0 Release Prep

commit | commitdiff | tree

David Swan [Thu, 8 Nov 2018 10:24:46 +0000 (10:24 +0000)]

(MODULES-8226) - 6.2.0 Release Prep

commit | commitdiff | tree

Helen [Fri, 16 Nov 2018 14:35:37 +0000 (14:35 +0000)]

Merge pull request #822 from ekohl/apt-key-fixes

Apt-key fixes to properly work on Debian 9

commit | commitdiff | tree

Ewoud Kohl van Wijngaarden [Wed, 14 Nov 2018 16:15:14 +0000 (17:15 +0100)]

Autorequire dirmngr in apt_key types

commit | commitdiff | tree

Ewoud Kohl van Wijngaarden [Wed, 14 Nov 2018 16:13:48 +0000 (17:13 +0100)]

Pass in --no-tty to apt-key

On modern Debian(-based) distros this is needed for gpg to function when
no TTY is available. Since Puppet often runs from cron or a daemon, this
is often the case.

commit | commitdiff | tree

Eimhin Laverty [Wed, 7 Nov 2018 11:44:55 +0000 (11:44 +0000)]

Merge pull request #820 from puppetlabs/pdksync_pdksync_heads/master-0-gabccfb1

pdksync - pdksync_heads/master-0-gabccfb1

commit | commitdiff | tree

David Swan [Wed, 7 Nov 2018 10:20:58 +0000 (10:20 +0000)]

pdksync_heads/master-0-gabccfb1

commit | commitdiff | tree

david22swan [Fri, 2 Nov 2018 12:22:43 +0000 (12:22 +0000)]

Merge pull request #819 from rodjek/epp-files-lf

(maint) Prefer LF over CRLF line endings for .epp files

commit | commitdiff | tree

david22swan [Wed, 31 Oct 2018 11:59:22 +0000 (11:59 +0000)]

Merge pull request #815 from simondeziel/modules-8081

(MODULES-8081): add support for hkps:// protocol in apt::key

commit | commitdiff | tree

Tim Sharpe [Tue, 23 Oct 2018 09:53:59 +0000 (20:53 +1100)]

(maint) Prefer LF over CRLF line endings for .epp files

commit | commitdiff | tree

TP Honey [Mon, 22 Oct 2018 14:37:03 +0000 (15:37 +0100)]

Merge pull request #818 from eimlav/refresh-changes

(maint) - Minor logic changes related to apt_key refresh param

commit | commitdiff | tree

Eimhin Laverty [Mon, 22 Oct 2018 13:52:31 +0000 (14:52 +0100)]

Test ensure value of key is passed in for apt::source

commit | commitdiff | tree

Eimhin Laverty [Mon, 22 Oct 2018 13:33:47 +0000 (14:33 +0100)]

Added default refresh value to apt::key default unit test

commit | commitdiff | tree

Eimhin Laverty [Mon, 22 Oct 2018 13:33:04 +0000 (14:33 +0100)]

Removed duplicated test

commit | commitdiff | tree

Simon Deziel [Fri, 19 Oct 2018 23:19:21 +0000 (19:19 -0400)]

(MODULES-8081): style improvement to apt_key_provider_spec.rb

commit | commitdiff | tree

Simon Deziel [Fri, 19 Oct 2018 20:36:54 +0000 (16:36 -0400)]

(MODULES-8081): improve variable assignment/condition testing in apt_key_provider_spec.rb

commit | commitdiff | tree

Simon Deziel [Fri, 19 Oct 2018 20:11:08 +0000 (16:11 -0400)]

(MODULES-8081): mention hkps:// protocol in key.pp and s/and/&&/ in apt_key_provider_spec.rb

commit | commitdiff | tree

Eimhin Laverty [Fri, 19 Oct 2018 13:54:30 +0000 (14:54 +0100)]

(maint) - Minor logic changes related to apt_key refresh param

commit | commitdiff | tree

Simon Deziel [Thu, 18 Oct 2018 20:44:17 +0000 (16:44 -0400)]

(MODULES-8081): hkps:// protocol is supported on Ubuntu 18.04 only

commit | commitdiff | tree

Simon Deziel [Wed, 10 Oct 2018 03:52:49 +0000 (23:52 -0400)]

(MODULES-8081): add support for hkps:// protocol in apt::key

Add hkps:// to the list of protocols supported by apt::key
(hkp://, http:// and https://).

commit | commitdiff | tree

Eimhin Laverty [Mon, 8 Oct 2018 16:19:43 +0000 (17:19 +0100)]

Merge pull request #813 from david22swan/Loc_update

(maint) - Localization test updates and Minor syntax refactor

commit | commitdiff | tree

David Swan [Mon, 8 Oct 2018 14:01:25 +0000 (15:01 +0100)]

(maint) - Localization test updates and Minor syntax refactor

commit | commitdiff | tree

Eimhin Laverty [Fri, 5 Oct 2018 15:26:15 +0000 (16:26 +0100)]

Merge pull request #812 from pmcmaw/Update_localization_tests

(maint) - Updating loc tests to include Japanese translations

commit | commitdiff | tree

David Swan [Fri, 5 Oct 2018 10:12:20 +0000 (11:12 +0100)]

(maint) - Update of puppet manifest loc test's

commit | commitdiff | tree

Paula Muir [Fri, 5 Oct 2018 09:02:50 +0000 (10:02 +0100)]

(maint) - Updating loc tests to include Japanese translations

commit | commitdiff | tree

transifex-bot [Thu, 4 Oct 2018 16:07:34 +0000 (09:07 -0700)]

(L10n) Updating translations for readmes/README_ja_JP.md

commit | commitdiff | tree

transifex-bot [Thu, 4 Oct 2018 16:06:20 +0000 (09:06 -0700)]

(L10n) Updating translations for locales/ja/puppetlabs-apt.po

commit | commitdiff | tree

Eimhin Laverty [Tue, 2 Oct 2018 14:17:06 +0000 (15:17 +0100)]

Merge pull request #811 from puppetlabs/pmcmaw-patch-1

(maint) - Update Link to REFERENCE.md

commit | commitdiff | tree

Paula Muir [Tue, 2 Oct 2018 13:40:20 +0000 (14:40 +0100)]

(maint) - Update Link to REFERENCE.md

commit | commitdiff | tree

Paula Muir [Tue, 2 Oct 2018 10:13:37 +0000 (11:13 +0100)]

Merge pull request #810 from puppetlabs/release

Release merge back 6.1.1

commit | commitdiff | tree

Dave Armstrong [Mon, 1 Oct 2018 16:45:51 +0000 (17:45 +0100)]

Merge pull request #809 from pmcmaw/MODULES-8020

(MODULES-8020) - Release Prep 6.1.1

commit | commitdiff | tree

Paula Muir [Mon, 1 Oct 2018 15:59:12 +0000 (16:59 +0100)]

(MODULES-8020) - Release Prep 6.1.1

commit | commitdiff | tree

Eimhin Laverty [Mon, 1 Oct 2018 14:37:43 +0000 (15:37 +0100)]

Merge pull request #807 from puppetlabs/release

(MODULES-7873) - 6.1.0 Merge Back

commit | commitdiff | tree

Paula Muir [Mon, 1 Oct 2018 09:44:46 +0000 (10:44 +0100)]

Merge pull request #808 from puppetlabs/revert-801-modules6408

Revert "(MODULES-6408) - Fix dirmngr install failing"

commit | commitdiff | tree

Eimhin Laverty [Mon, 1 Oct 2018 09:23:46 +0000 (10:23 +0100)]

Revert "(MODULES-6408) - Fix dirmngr install failing"

commit | commitdiff | tree

david22swan [Fri, 28 Sep 2018 15:01:13 +0000 (16:01 +0100)]

Merge pull request #806 from puppetlabs/pdksync_puppet_6_release_prep

Module Release Prep 6.1.0

commit | commitdiff | tree

Paula Muir [Thu, 27 Sep 2018 12:19:04 +0000 (13:19 +0100)]

commit | commitdiff | tree

clairecadman [Fri, 28 Sep 2018 12:53:26 +0000 (13:53 +0100)]

Update README.md

This commit includes a few minor grammatical and localization edits.

commit | commitdiff | tree

Paula Muir [Thu, 27 Sep 2018 09:50:27 +0000 (10:50 +0100)]

Merge pull request #798 from puppetlabs/pdksync_MODULES-6805

pdksync - (MODULES-6805) metadata.json shows support for puppet 6

commit | commitdiff | tree

Paula Muir [Thu, 27 Sep 2018 09:49:56 +0000 (10:49 +0100)]

Merge pull request #802 from eimlav/update-reference

(maint) - Update docs to reflect changes in key.pp

commit | commitdiff | tree

Eimhin Laverty [Thu, 27 Sep 2018 09:22:01 +0000 (10:22 +0100)]

(maint) - Update docs to reflect changes in key.pp

commit | commitdiff | tree

david22swan [Wed, 26 Sep 2018 12:06:10 +0000 (13:06 +0100)]

Merge pull request #801 from eimlav/modules6408

(MODULES-6408) - Fix dirmngr install failing

commit | commitdiff | tree

Eimhin Laverty [Wed, 26 Sep 2018 10:27:56 +0000 (11:27 +0100)]

(MODULES-6408) - Fix dirmngr install failing

commit | commitdiff | tree

david22swan [Tue, 25 Sep 2018 08:23:11 +0000 (09:23 +0100)]

Merge pull request #800 from puppetlabs/pdksync_FM-7392_pdk_update

pdksync - (FM-7392) - Puppet 6 Testing Changes

commit | commitdiff | tree

Paula Muir [Mon, 24 Sep 2018 16:02:25 +0000 (17:02 +0100)]

(FM-7392) - Puppet 6 Testing Changes

commit | commitdiff | tree

Paula Muir [Mon, 24 Sep 2018 14:22:47 +0000 (15:22 +0100)]

Merge pull request #799 from eimlav/string-fix

(maint) - Fix cut off summary for apt_key

commit | commitdiff | tree

Paula Muir [Mon, 24 Sep 2018 13:29:40 +0000 (14:29 +0100)]

Merge pull request #795 from eimlav/modules3307

(MODULES-3307) - Auto update expired keys

commit | commitdiff | tree

Eimhin Laverty [Mon, 24 Sep 2018 13:13:06 +0000 (14:13 +0100)]

(maint) - Fix cut off summary for apt_key

commit | commitdiff | tree

Eimhin Laverty [Tue, 18 Sep 2018 16:55:55 +0000 (17:55 +0100)]

(MODULES-3307) - Auto update expired keys

commit | commitdiff | tree

tphoney [Thu, 20 Sep 2018 15:33:42 +0000 (16:33 +0100)]

(MODULES-6805) metadata.json shows support for puppet 6

commit | commitdiff | tree

Eimhin Laverty [Thu, 20 Sep 2018 12:54:14 +0000 (13:54 +0100)]

Merge pull request #796 from david22swan/MODULES-7827

(MODULES-7827) - Update to i18n test logic to account for puppet 6

commit | commitdiff | tree

David Swan [Thu, 20 Sep 2018 10:48:25 +0000 (11:48 +0100)]

(MODULES-7827) - Update to i18n test logic to account for puppet 6

commit | commitdiff | tree

Eimhin Laverty [Mon, 17 Sep 2018 14:25:25 +0000 (15:25 +0100)]

(maint) - Moved i18n tests to new file (#794)

(maint) - Moved i18n tests to new file

commit | commitdiff | tree

TP Honey [Mon, 10 Sep 2018 13:10:13 +0000 (14:10 +0100)]

Merge pull request #793 from eimlav/os-cleanup

(FM-7348) - OS logic cleanup

commit | commitdiff | tree

Eimhin Laverty [Mon, 10 Sep 2018 10:22:04 +0000 (11:22 +0100)]

(FM-7348) - OS logic cleanup

commit | commitdiff | tree

Helen [Wed, 5 Sep 2018 10:10:57 +0000 (11:10 +0100)]

Merge pull request #792 from eimlav/stringify

(FM-7318) - Added Puppet Strings formatting to documentation

commit | commitdiff | tree

Eimhin Laverty [Tue, 4 Sep 2018 13:38:25 +0000 (14:38 +0100)]

(FM-7318) - Added Puppet Strings formatting to documentation

commit | commitdiff | tree

Helen [Mon, 3 Sep 2018 11:47:03 +0000 (12:47 +0100)]

Merge pull request #789 from david22swan/FM-7316

(FM-7316) - Implementation of the i18n process

commit | commitdiff | tree

Helen [Fri, 31 Aug 2018 15:35:39 +0000 (16:35 +0100)]

Merge pull request #791 from eimlav/puppet4ify

(FM-7320) - Removed assert_type statements

commit | commitdiff | tree

David Swan [Fri, 31 Aug 2018 13:34:15 +0000 (14:34 +0100)]

(FM-7316) - Temporary fix pending the rubocop templates being updated

commit | commitdiff | tree

David Swan [Fri, 31 Aug 2018 13:24:35 +0000 (14:24 +0100)]

(FM-7316) - i18n Implementation Tests Made

commit | commitdiff | tree

David Swan [Thu, 30 Aug 2018 15:14:08 +0000 (16:14 +0100)]

(FM-7316) - i18n Process implemented and .pot file generated

commit | commitdiff | tree

David Swan [Thu, 30 Aug 2018 12:50:28 +0000 (13:50 +0100)]

(FM-7316) - Setup for i18n process

commit | commitdiff | tree

Eimhin Laverty [Fri, 31 Aug 2018 15:01:07 +0000 (16:01 +0100)]

(FM-7320) - Removed assert_type statements

commit | commitdiff | tree

david22swan [Fri, 31 Aug 2018 14:40:48 +0000 (15:40 +0100)]

Merge pull request #790 from puppetlabs/pdksync_pdksync-beaker4

pdksync - (MODULES-7658) use beaker4 in puppet-module-gems

commit | commitdiff | tree

tphoney [Thu, 30 Aug 2018 16:07:42 +0000 (17:07 +0100)]

(MODULES-7658) use beaker4 in puppet-module-gems

commit | commitdiff | tree

TP Honey [Wed, 29 Aug 2018 13:08:57 +0000 (14:08 +0100)]

Merge pull request #788 from david22swan/MODULES-1630

(MODULES-1630) - Expanding source list fix to cover all needed versions

commit | commitdiff | tree

David Swan [Wed, 29 Aug 2018 09:19:30 +0000 (10:19 +0100)]

(MODULES-1630) - Expanding source list fix to cover all needed versions

commit | commitdiff | tree

clairecadman [Wed, 29 Aug 2018 09:42:00 +0000 (02:42 -0700)]

Merge pull request #787 from david22swan/MODULES-4439

(MODULES-4439) - Adding new sources/PPAs README clarification

commit | commitdiff | tree

David Swan [Tue, 28 Aug 2018 10:11:37 +0000 (11:11 +0100)]

(MODULES-4439) - Adding new sources/PPAs README clarification

commit | commitdiff | tree

Helen [Fri, 24 Aug 2018 14:53:23 +0000 (15:53 +0100)]

Merge pull request #773 from ekohl/apt-proxy-type

Introduce an Apt::Proxy type to validate the hash

commit | commitdiff | tree

Paula Muir [Fri, 24 Aug 2018 14:38:46 +0000 (15:38 +0100)]

Merge pull request #785 from puppetlabs/release

Release merge back 6.0.0

commit | commitdiff | tree

david22swan [Fri, 24 Aug 2018 11:37:41 +0000 (12:37 +0100)]

Merge pull request #784 from pmcmaw/release_prep

(MODULES-7711) - Release Prep for 6.0.0

commit | commitdiff | tree

David Swan [Fri, 24 Aug 2018 10:55:45 +0000 (11:55 +0100)]